René's URL Explorer Experiment


Title: Allow both module.exports= and module.exports property assignments by sandersn · Pull Request #23228 · microsoft/TypeScript · GitHub

Open Graph Title: Allow both module.exports= and module.exports property assignments by sandersn · Pull Request #23228 · microsoft/TypeScript

X Title: Allow both module.exports= and module.exports property assignments by sandersn · Pull Request #23228 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Allow both module.exports= and module.exports property assignments by sandersn · Pull Request #23228 · microsoft/TypeScript

Open Graph Description: In Javascript, it's common both to assign to module.exports and to assign properties to module.exports: module.exports = function A() { this.p = 1 } module.exports.util = function() { retur...

X Description: In Javascript, it's common both to assign to module.exports and to assign properties to module.exports: module.exports = function A() { this.p = 1 } module.exports.util = function() { r...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/23228

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c3478eb9-a35f-7fcc-ad93-7886b6beb723
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE2B8:2E7A8:20A595:2B6D26:6B018BB0
html-safe-nonce2b91e8c1072f82104da3e944c0da7a0bc0614688325ce1123cf4307ea1de2721
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkI4OjJFN0E4OjIwQTU5NToyQjZEMjY6NkIwMThCQjAiLCJ2aXNpdG9yX2lkIjoiNjYzMDU3Njk5ODc2MDY4MDM2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca0d499506f75b51bde6b90b5a50800d86fa000f10a46ea9f2515f7bd65c43233
hovercard-subject-tagpull_request:180036296
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/23228/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/46f613092ff2374e6bfc8762e813edace8f2985b3aa8e4965ccc748551545167/microsoft/TypeScript/pull/23228
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/46f613092ff2374e6bfc8762e813edace8f2985b3aa8e4965ccc748551545167/microsoft/TypeScript/pull/23228
og:image:altIn Javascript, it's common both to assign to module.exports and to assign properties to module.exports: module.exports = function A() { this.p = 1 } module.exports.util = function() { retur...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/23228#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F23228
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F23228
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/23228
Reloadhttps://github.com/microsoft/TypeScript/pull/23228
Reloadhttps://github.com/microsoft/TypeScript/pull/23228
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
js/allow-module-exports-with-exports-assignmentshttps://github.com/microsoft/TypeScript/tree/js/allow-module-exports-with-exports-assignments
Conversationhttps://github.com/microsoft/TypeScript/pull/23228
Commits5 (5)https://github.com/microsoft/TypeScript/pull/23228/commits
Checkshttps://github.com/microsoft/TypeScript/pull/23228/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/23228/files
Allow both module.exports= and module.exports property assignmentshttps://github.com/microsoft/TypeScript/pull/23228#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
js/allow-module-exports-with-exports-assignmentshttps://github.com/microsoft/TypeScript/tree/js/allow-module-exports-with-exports-assignments
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Apr 6, 2018https://github.com/microsoft/TypeScript/pull/23228#issue-312093327
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23228
#22461https://github.com/microsoft/TypeScript/issues/22461
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23228
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
April 5, 2018 16:33https://github.com/microsoft/TypeScript/pull/23228#commits-pushed-854c124
https://github.com/sandersn
Combining symbol and removing error done but messyhttps://github.com/microsoft/TypeScript/pull/23228/commits/854c124a10773ef069bc065a0bbd24438c434171
854c124https://github.com/microsoft/TypeScript/pull/23228/commits/854c124a10773ef069bc065a0bbd24438c434171
https://github.com/sandersn
Small fix + add new test baselineshttps://github.com/microsoft/TypeScript/pull/23228/commits/8b67c9b799bb322f4e9cf49654404e0c0a7ee52d
8b67c9bhttps://github.com/microsoft/TypeScript/pull/23228/commits/8b67c9b799bb322f4e9cf49654404e0c0a7ee52d
https://github.com/sandersn
Union conflicting assignment types+better nameshttps://github.com/microsoft/TypeScript/pull/23228/commits/571e9350cbbbb5364f23172f81cf48c73a74a064
571e935https://github.com/microsoft/TypeScript/pull/23228/commits/571e9350cbbbb5364f23172f81cf48c73a74a064
https://github.com/sandersn
Add tests and update baselineshttps://github.com/microsoft/TypeScript/pull/23228/commits/6203ec7ec1223a60f50f28adec6fc3ca8b200e94
6203ec7https://github.com/microsoft/TypeScript/pull/23228/commits/6203ec7ec1223a60f50f28adec6fc3ca8b200e94
https://github.com/sandersn
Check commonjs export= from resolveExternalModuleSymbolhttps://github.com/microsoft/TypeScript/pull/23228/commits/c6a47d97fcc3bc0e6be6b0f17426e37d467524a4
c6a47d9https://github.com/microsoft/TypeScript/pull/23228/commits/c6a47d97fcc3bc0e6be6b0f17426e37d467524a4
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
April 6, 2018 19:38https://github.com/microsoft/TypeScript/pull/23228#event-1561609740
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Apr 6, 2018 https://github.com/microsoft/TypeScript/pull/23228#pullrequestreview-110191245
View reviewed changes https://github.com/microsoft/TypeScript/pull/23228/files/c6a47d97fcc3bc0e6be6b0f17426e37d467524a4
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
a7a01eahttps://github.com/microsoft/TypeScript/commit/a7a01eadba25f15dc353bc38c5c57822745d83ef
Apr 6, 2018https://github.com/microsoft/TypeScript/pull/23228#event-1561653111
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
April 6, 2018 20:04https://github.com/microsoft/TypeScript/pull/23228#event-1561653323
Update user tests with improved lib settings #23238 https://github.com/microsoft/TypeScript/pull/23238
checkJs too strict about module.exports assignment #15647 https://github.com/microsoft/TypeScript/issues/15647
Mohsen Azimi (mohsen1)https://github.com/mohsen1
Apr 11, 2018 https://github.com/microsoft/TypeScript/pull/23228#ref-commit-c2865e9
TS now understands module.exports assignmentshttps://github.com/mohsen1/webpack/commit/c2865e9a9a04fa01f1ce6b6b483ce9d4fa66e2c1
c2865e9https://github.com/mohsen1/webpack/commit/c2865e9a9a04fa01f1ce6b6b483ce9d4fa66e2c1
microsoft/TypeScript#23228https://github.com/microsoft/TypeScript/pull/23228
Tobias Koppers (sokra)https://github.com/sokra
Apr 12, 2018 https://github.com/microsoft/TypeScript/pull/23228#ref-commit-2b66263
https://github.com/sokra
TS now understands module.exports assignmentshttps://github.com/webpack/webpack/commit/2b66263b44f0efe5591bc4e457895b397bb95d7e
2b66263https://github.com/webpack/webpack/commit/2b66263b44f0efe5591bc4e457895b397bb95d7e
microsoft/TypeScript#23228https://github.com/microsoft/TypeScript/pull/23228
Support @typedef importing a CommonJS default exported class as type into another file #23375 https://github.com/microsoft/TypeScript/issues/23375
module.exports = Entity is an alias, just like export = Entity #23570 https://github.com/microsoft/TypeScript/pull/23570
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 25, 2018https://github.com/microsoft/TypeScript/pull/23228#event-1753830594
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F23228
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
https://github.com/microsoft/TypeScript/pull/23228/files/c6a47d97fcc3bc0e6be6b0f17426e37d467524a4
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23228
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23228
https://github.com/sandersn
https://github.com/mhegazy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.