| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c3478eb9-a35f-7fcc-ad93-7886b6beb723 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E2B8:2E7A8:20A595:2B6D26:6B018BB0 |
| html-safe-nonce | 2b91e8c1072f82104da3e944c0da7a0bc0614688325ce1123cf4307ea1de2721 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkI4OjJFN0E4OjIwQTU5NToyQjZEMjY6NkIwMThCQjAiLCJ2aXNpdG9yX2lkIjoiNjYzMDU3Njk5ODc2MDY4MDM2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a0d499506f75b51bde6b90b5a50800d86fa000f10a46ea9f2515f7bd65c43233 |
| hovercard-subject-tag | pull_request:180036296 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/23228/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/46f613092ff2374e6bfc8762e813edace8f2985b3aa8e4965ccc748551545167/microsoft/TypeScript/pull/23228 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/46f613092ff2374e6bfc8762e813edace8f2985b3aa8e4965ccc748551545167/microsoft/TypeScript/pull/23228 |
| og:image:alt | In Javascript, it's common both to assign to module.exports and to assign properties to module.exports:
module.exports = function A() {
this.p = 1
}
module.exports.util = function() {
retur... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sandersn |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/23228#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F23228 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F23228 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/23228 |
| Reload | https://github.com/microsoft/TypeScript/pull/23228 |
| Reload | https://github.com/microsoft/TypeScript/pull/23228 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests312 (312) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| master | https://github.com/microsoft/TypeScript/tree/master |
| js/allow-module-exports-with-exports-assignments | https://github.com/microsoft/TypeScript/tree/js/allow-module-exports-with-exports-assignments |
| Conversation | https://github.com/microsoft/TypeScript/pull/23228 |
| Commits5 (5) | https://github.com/microsoft/TypeScript/pull/23228/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/23228/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/23228/files |
| Allow both module.exports= and module.exports property assignments | https://github.com/microsoft/TypeScript/pull/23228#top |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| master | https://github.com/microsoft/TypeScript/tree/master |
| js/allow-module-exports-with-exports-assignments | https://github.com/microsoft/TypeScript/tree/js/allow-module-exports-with-exports-assignments |
|
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Apr 6, 2018 | https://github.com/microsoft/TypeScript/pull/23228#issue-312093327 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/23228 |
| #22461 | https://github.com/microsoft/TypeScript/issues/22461 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/23228 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| April 5, 2018 16:33 | https://github.com/microsoft/TypeScript/pull/23228#commits-pushed-854c124 |
|
| https://github.com/sandersn |
| Combining symbol and removing error done but messy | https://github.com/microsoft/TypeScript/pull/23228/commits/854c124a10773ef069bc065a0bbd24438c434171 |
| 854c124 | https://github.com/microsoft/TypeScript/pull/23228/commits/854c124a10773ef069bc065a0bbd24438c434171 |
|
| https://github.com/sandersn |
| Small fix + add new test baselines | https://github.com/microsoft/TypeScript/pull/23228/commits/8b67c9b799bb322f4e9cf49654404e0c0a7ee52d |
| 8b67c9b | https://github.com/microsoft/TypeScript/pull/23228/commits/8b67c9b799bb322f4e9cf49654404e0c0a7ee52d |
|
| https://github.com/sandersn |
| Union conflicting assignment types+better names | https://github.com/microsoft/TypeScript/pull/23228/commits/571e9350cbbbb5364f23172f81cf48c73a74a064 |
| 571e935 | https://github.com/microsoft/TypeScript/pull/23228/commits/571e9350cbbbb5364f23172f81cf48c73a74a064 |
|
| https://github.com/sandersn |
| Add tests and update baselines | https://github.com/microsoft/TypeScript/pull/23228/commits/6203ec7ec1223a60f50f28adec6fc3ca8b200e94 |
| 6203ec7 | https://github.com/microsoft/TypeScript/pull/23228/commits/6203ec7ec1223a60f50f28adec6fc3ca8b200e94 |
|
| https://github.com/sandersn |
| Check commonjs export= from resolveExternalModuleSymbol | https://github.com/microsoft/TypeScript/pull/23228/commits/c6a47d97fcc3bc0e6be6b0f17426e37d467524a4 |
| c6a47d9 | https://github.com/microsoft/TypeScript/pull/23228/commits/c6a47d97fcc3bc0e6be6b0f17426e37d467524a4 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
| April 6, 2018 19:38 | https://github.com/microsoft/TypeScript/pull/23228#event-1561609740 |
| https://github.com/mhegazy |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
|
Apr 6, 2018
| https://github.com/microsoft/TypeScript/pull/23228#pullrequestreview-110191245 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/23228/files/c6a47d97fcc3bc0e6be6b0f17426e37d467524a4 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| a7a01ea | https://github.com/microsoft/TypeScript/commit/a7a01eadba25f15dc353bc38c5c57822745d83ef |
| Apr 6, 2018 | https://github.com/microsoft/TypeScript/pull/23228#event-1561653111 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| April 6, 2018 20:04 | https://github.com/microsoft/TypeScript/pull/23228#event-1561653323 |
|
Update user tests with improved lib settings
#23238
| https://github.com/microsoft/TypeScript/pull/23238 |
|
checkJs too strict about module.exports assignment
#15647
| https://github.com/microsoft/TypeScript/issues/15647 |
| Mohsen Azimi (mohsen1) | https://github.com/mohsen1 |
|
Apr 11, 2018
| https://github.com/microsoft/TypeScript/pull/23228#ref-commit-c2865e9 |
| TS now understands module.exports assignments | https://github.com/mohsen1/webpack/commit/c2865e9a9a04fa01f1ce6b6b483ce9d4fa66e2c1 |
| c2865e9 | https://github.com/mohsen1/webpack/commit/c2865e9a9a04fa01f1ce6b6b483ce9d4fa66e2c1 |
| microsoft/TypeScript#23228 | https://github.com/microsoft/TypeScript/pull/23228 |
| Tobias Koppers (sokra) | https://github.com/sokra |
|
Apr 12, 2018
| https://github.com/microsoft/TypeScript/pull/23228#ref-commit-2b66263 |
|
| https://github.com/sokra |
| TS now understands module.exports assignments | https://github.com/webpack/webpack/commit/2b66263b44f0efe5591bc4e457895b397bb95d7e |
| 2b66263 | https://github.com/webpack/webpack/commit/2b66263b44f0efe5591bc4e457895b397bb95d7e |
| microsoft/TypeScript#23228 | https://github.com/microsoft/TypeScript/pull/23228 |
|
Support @typedef importing a CommonJS default exported class as type into another file
#23375
| https://github.com/microsoft/TypeScript/issues/23375 |
|
module.exports = Entity is an alias, just like export = Entity
#23570
| https://github.com/microsoft/TypeScript/pull/23570 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Jul 25, 2018 | https://github.com/microsoft/TypeScript/pull/23228#event-1753830594 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F23228 |
|
| https://github.com/mhegazy |
|
Mohamed Hegazy (mhegazy)
| https://github.com/mhegazy |
|
| https://github.com/microsoft/TypeScript/pull/23228/files/c6a47d97fcc3bc0e6be6b0f17426e37d467524a4 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/23228 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/23228 |
|
| https://github.com/sandersn |
|
| https://github.com/mhegazy |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |