René's URL Explorer Experiment


Title: Bind toplevel this assignments as global declarations by sandersn · Pull Request #22891 · microsoft/TypeScript · GitHub

Open Graph Title: Bind toplevel this assignments as global declarations by sandersn · Pull Request #22891 · microsoft/TypeScript

X Title: Bind toplevel this assignments as global declarations by sandersn · Pull Request #22891 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Bind toplevel this assignments as global declarations by sandersn · Pull Request #22891 · microsoft/TypeScript

Open Graph Description: Previously, this-assignments at the top level of a source file did not bind anything. The source file case was not handled in bindThisPropertyAssignment, however, so when #22643 added an assert tha...

X Description: Previously, this-assignments at the top level of a source file did not bind anything. The source file case was not handled in bindThisPropertyAssignment, however, so when #22643 added an assert tha...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/22891

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:545e0f30-0c2c-d774-4754-17e9371d9db2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id95E2:31E99C:2615063:32D7E64:6B01A66F
html-safe-nonceadb8206a51a326297ab729b11b32ca3c72c647b2b18564371f19fc3a2bd6b7ee
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NUUyOjMxRTk5QzoyNjE1MDYzOjMyRDdFNjQ6NkIwMUE2NkYiLCJ2aXNpdG9yX2lkIjoiMzExMDQxNzMwOTQwMDg1ODcxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf5a8fd11e77bd59f51132639a7a4f479d69b22362c9c7cc581af7d9803696d73
hovercard-subject-tagpull_request:177593151
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/22891/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bf8ace20f8d7c441fdff4c68f1d36b975756ead08f7172c40e7e22bcb31114b5/microsoft/TypeScript/pull/22891
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bf8ace20f8d7c441fdff4c68f1d36b975756ead08f7172c40e7e22bcb31114b5/microsoft/TypeScript/pull/22891
og:image:altPreviously, this-assignments at the top level of a source file did not bind anything. The source file case was not handled in bindThisPropertyAssignment, however, so when #22643 added an assert tha...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/22891#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22891
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22891
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/22891
Reloadhttps://github.com/microsoft/TypeScript/pull/22891
Reloadhttps://github.com/microsoft/TypeScript/pull/22891
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
bind-toplevel-thishttps://github.com/microsoft/TypeScript/tree/bind-toplevel-this
Conversationhttps://github.com/microsoft/TypeScript/pull/22891
Commits5 (5)https://github.com/microsoft/TypeScript/pull/22891/commits
Checkshttps://github.com/microsoft/TypeScript/pull/22891/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/22891/files
Bind toplevel this assignments as global declarationshttps://github.com/microsoft/TypeScript/pull/22891#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
bind-toplevel-thishttps://github.com/microsoft/TypeScript/tree/bind-toplevel-this
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 26, 2018https://github.com/microsoft/TypeScript/pull/22891#issue-308768164
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
#22643https://github.com/microsoft/TypeScript/pull/22643
#22888https://github.com/microsoft/TypeScript/issues/22888
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
https://github.com/sandersn
Bind toplevel this assignments as global declshttps://github.com/microsoft/TypeScript/pull/22891/commits/a0dc55412d7430365bcf954c42f3d1c60567dce3
a0dc554https://github.com/microsoft/TypeScript/pull/22891/commits/a0dc55412d7430365bcf954c42f3d1c60567dce3
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
March 26, 2018 23:18https://github.com/microsoft/TypeScript/pull/22891#event-1542054615
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 26, 2018https://github.com/microsoft/TypeScript/pull/22891#event-1542054816
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Mar 26, 2018 https://github.com/microsoft/TypeScript/pull/22891#pullrequestreview-107110224
View reviewed changes https://github.com/microsoft/TypeScript/pull/22891/files/a0dc55412d7430365bcf954c42f3d1c60567dce3
src/compiler/binder.tshttps://github.com/microsoft/TypeScript/pull/22891/files/a0dc55412d7430365bcf954c42f3d1c60567dce3#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898
Deleted user (ghost)https://github.com/ghost
Mar 26, 2018https://github.com/microsoft/TypeScript/pull/22891#discussion_r177267508
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Mar 26, 2018https://github.com/microsoft/TypeScript/pull/22891#discussion_r177269140
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
Jessica Franco (Jessidhia)https://github.com/Jessidhia
Mar 27, 2018https://github.com/microsoft/TypeScript/pull/22891#discussion_r177281724
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 27, 2018https://github.com/microsoft/TypeScript/pull/22891#discussion_r177461235
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Andy (Andrewkraft) (@Andy-MS)https://github.com/Andy-MS
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
Sheetal Nandi (@sheetalkamat)https://github.com/sheetalkamat
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
March 27, 2018 11:01https://github.com/microsoft/TypeScript/pull/22891#commits-pushed-e58da91
https://github.com/sandersn
Improve toplevel this-assignment testhttps://github.com/microsoft/TypeScript/pull/22891/commits/e58da912acd7188ed7968589fd260e9fa0faff03
e58da91https://github.com/microsoft/TypeScript/pull/22891/commits/e58da912acd7188ed7968589fd260e9fa0faff03
https://github.com/sandersn
Bind+check toplevel this in commonjshttps://github.com/microsoft/TypeScript/pull/22891/commits/5831e807a7262a569295cd75168db2017fd7585a
5831e80https://github.com/microsoft/TypeScript/pull/22891/commits/5831e807a7262a569295cd75168db2017fd7585a
https://github.com/sandersn
Merge branch 'master' into bind-toplevel-thishttps://github.com/microsoft/TypeScript/pull/22891/commits/59e2617ebc267bee62d5dc2547cb2b79fe843d21
59e2617https://github.com/microsoft/TypeScript/pull/22891/commits/59e2617ebc267bee62d5dc2547cb2b79fe843d21
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 27, 2018https://github.com/microsoft/TypeScript/pull/22891#issuecomment-376702527
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Mar 27, 2018 https://github.com/microsoft/TypeScript/pull/22891#pullrequestreview-107503383
View reviewed changes https://github.com/microsoft/TypeScript/pull/22891/files/59e2617ebc267bee62d5dc2547cb2b79fe843d21
src/compiler/binder.tshttps://github.com/microsoft/TypeScript/pull/22891/files/59e2617ebc267bee62d5dc2547cb2b79fe843d21#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/22891/files/59e2617ebc267bee62d5dc2547cb2b79fe843d21#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Deleted user (ghost)https://github.com/ghost
Mar 27, 2018https://github.com/microsoft/TypeScript/pull/22891#discussion_r177603431
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#14052https://github.com/microsoft/TypeScript/issues/14052
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Mar 28, 2018https://github.com/microsoft/TypeScript/pull/22891#discussion_r177615960
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 28, 2018https://github.com/microsoft/TypeScript/pull/22891#discussion_r177835878
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
Andy (Andrewkraft) (@Andy-MS)https://github.com/Andy-MS
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
https://github.com/sandersn
Don't create new types for toplevel every timehttps://github.com/microsoft/TypeScript/pull/22891/commits/2050027a83d1762a7d1ef97458ffd986dfa4c6c2
https://github.com/microsoft/TypeScript/commit/2050027a83d1762a7d1ef97458ffd986dfa4c6c2#comments
2050027https://github.com/microsoft/TypeScript/pull/22891/commits/2050027a83d1762a7d1ef97458ffd986dfa4c6c2
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 29, 2018https://github.com/microsoft/TypeScript/pull/22891#issuecomment-377291841
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 30, 2018https://github.com/microsoft/TypeScript/pull/22891#issuecomment-377616528
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Mar 31, 2018 https://github.com/microsoft/TypeScript/pull/22891#ref-issue-310263623
Design Meeting Notes, 3/31/2018 #23045 https://github.com/microsoft/TypeScript/issues/23045
Add create-react-app and puppeteer user tests #23471 https://github.com/microsoft/TypeScript/pull/23471
Add axios' source to user tests #23490 https://github.com/microsoft/TypeScript/pull/23490
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 25, 2018https://github.com/microsoft/TypeScript/pull/22891#issuecomment-407852207
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 25, 2018https://github.com/microsoft/TypeScript/pull/22891#event-1753308362
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jan 9, 2019 https://github.com/microsoft/TypeScript/pull/22891#ref-pullrequest-397562565
Add globalThis #29332 https://github.com/microsoft/TypeScript/pull/29332
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
November 7, 2022 17:32https://github.com/microsoft/TypeScript/pull/22891#event-7754866724
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/22891#event-20415627908
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22891
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
https://github.com/Jessidhia
Jessica Franco (Jessidhia) https://github.com/Jessidhia
https://github.com/microsoft/TypeScript/pull/22891/files/a0dc55412d7430365bcf954c42f3d1c60567dce3
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22891
https://github.com/sandersn
https://github.com/typescript-bot
https://github.com/Jessidhia
https://github.com/mhegazy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.