René's URL Explorer Experiment


Title: Correctly track thisContainer for this-property-assignments in JS nested containers by sandersn · Pull Request #22779 · microsoft/TypeScript · GitHub

Open Graph Title: Correctly track thisContainer for this-property-assignments in JS nested containers by sandersn · Pull Request #22779 · microsoft/TypeScript

X Title: Correctly track thisContainer for this-property-assignments in JS nested containers by sandersn · Pull Request #22779 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Correctly track thisContainer for this-property-assignments in JS nested containers by sandersn · Pull Request #22779 · microsoft/TypeScript

Open Graph Description: Previously thisContainer (previously called containerContainer) would update on every block, not just those that could bind this. In addition, if the constructor symbol still can't be found, th...

X Description: Previously thisContainer (previously called containerContainer) would update on every block, not just those that could bind this. In addition, if the constructor symbol still can't be found...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/22779

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0eda7230-801a-3867-92b9-2dff2c184401
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8680:1050BD:9FBE89:D39D6D:6B01BA4B
html-safe-nonce78f378d3113fd966ca4ea3e76c1735e25cd2ef9aa814841e55160ca57d424e43
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjgwOjEwNTBCRDo5RkJFODk6RDM5RDZEOjZCMDFCQTRCIiwidmlzaXRvcl9pZCI6IjY4ODUzMTA5ODA4MDU0NzQ4OTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacab6f2a9cc6645be155ad7b9d8c1830600a559e7d10465c1712e1ca499c7d035e
hovercard-subject-tagpull_request:176633330
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/22779/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dd7b4c3bed16fec327b37f474fcc4fd46d713f678e67e962d0003e8bb3d050e8/microsoft/TypeScript/pull/22779
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dd7b4c3bed16fec327b37f474fcc4fd46d713f678e67e962d0003e8bb3d050e8/microsoft/TypeScript/pull/22779
og:image:altPreviously thisContainer (previously called containerContainer) would update on every block, not just those that could bind this. In addition, if the constructor symbol still can't be found, th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/22779#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22779
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22779
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/22779
Reloadhttps://github.com/microsoft/TypeScript/pull/22779
Reloadhttps://github.com/microsoft/TypeScript/pull/22779
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
js/fix-this-assignments-in-nested-containershttps://github.com/microsoft/TypeScript/tree/js/fix-this-assignments-in-nested-containers
Conversationhttps://github.com/microsoft/TypeScript/pull/22779
Commits5 (5)https://github.com/microsoft/TypeScript/pull/22779/commits
Checkshttps://github.com/microsoft/TypeScript/pull/22779/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/22779/files
Correctly track thisContainer for this-property-assignments in JS nested containershttps://github.com/microsoft/TypeScript/pull/22779#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
js/fix-this-assignments-in-nested-containershttps://github.com/microsoft/TypeScript/tree/js/fix-this-assignments-in-nested-containers
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 21, 2018https://github.com/microsoft/TypeScript/pull/22779#issue-307448691
#22774https://github.com/microsoft/TypeScript/issues/22774
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
March 21, 2018 15:59https://github.com/microsoft/TypeScript/pull/22779#commits-pushed-8ab89ad
https://github.com/sandersn
Track thisContainer for this-property-assignments in JShttps://github.com/microsoft/TypeScript/pull/22779/commits/8ab89ad438172942235dfc7ee7500ae7f91e4265
8ab89adhttps://github.com/microsoft/TypeScript/pull/22779/commits/8ab89ad438172942235dfc7ee7500ae7f91e4265
https://github.com/sandersn
Update additional baselineshttps://github.com/microsoft/TypeScript/pull/22779/commits/f9444147098be78f8c5a387d2182e639ca8ec098
f944414https://github.com/microsoft/TypeScript/pull/22779/commits/f9444147098be78f8c5a387d2182e639ca8ec098
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Wesley Wigham (weswigham)https://github.com/weswigham
March 21, 2018 23:04https://github.com/microsoft/TypeScript/pull/22779#event-1534436972
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 21, 2018 https://github.com/microsoft/TypeScript/pull/22779#pullrequestreview-105940944
View reviewed changes https://github.com/microsoft/TypeScript/pull/22779/files/f9444147098be78f8c5a387d2182e639ca8ec098
tests/baselines/reference/typeFromPropertyAssignment21.errors.txthttps://github.com/microsoft/TypeScript/pull/22779/files/f9444147098be78f8c5a387d2182e639ca8ec098#diff-947ad22e71b000f23e0c511c1bce9fc2facdd47e6ce510854c8d15bf42ae8b6d
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 21, 2018https://github.com/microsoft/TypeScript/pull/22779#discussion_r176267846
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
https://github.com/sandersn
Add lib:dom to new testhttps://github.com/microsoft/TypeScript/pull/22779/commits/d00363c154f35489ac88e7e18a4fcb578e994e70
d00363chttps://github.com/microsoft/TypeScript/pull/22779/commits/d00363c154f35489ac88e7e18a4fcb578e994e70
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Mar 22, 2018 https://github.com/microsoft/TypeScript/pull/22779#pullrequestreview-106159610
View reviewed changes https://github.com/microsoft/TypeScript/pull/22779/files/d00363c154f35489ac88e7e18a4fcb578e994e70
Deleted user (ghost)https://github.com/ghost
https://github.com/microsoft/TypeScript/pull/22779#pullrequestreview-106159610
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
src/compiler/binder.tshttps://github.com/microsoft/TypeScript/pull/22779/files/d00363c154f35489ac88e7e18a4fcb578e994e70#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898
Deleted user (ghost)https://github.com/ghost
Mar 22, 2018https://github.com/microsoft/TypeScript/pull/22779#discussion_r176454732
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
tests/cases/conformance/salsa/typeFromPropertyAssignment20.tshttps://github.com/microsoft/TypeScript/pull/22779/files/d00363c154f35489ac88e7e18a4fcb578e994e70#diff-dad71ab11aa002473a031b15720757c612160b9ea8b44563ed2894c73e3a2d7c
Deleted user (ghost)https://github.com/ghost
Mar 22, 2018https://github.com/microsoft/TypeScript/pull/22779#discussion_r176455466
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 22, 2018https://github.com/microsoft/TypeScript/pull/22779#discussion_r176479878
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 22, 2018https://github.com/microsoft/TypeScript/pull/22779#discussion_r176509554
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
tests/cases/conformance/salsa/typeFromPropertyAssignment20.tshttps://github.com/microsoft/TypeScript/pull/22779/files/d00363c154f35489ac88e7e18a4fcb578e994e70#diff-dad71ab11aa002473a031b15720757c612160b9ea8b44563ed2894c73e3a2d7c
Deleted user (ghost)https://github.com/ghost
Mar 22, 2018https://github.com/microsoft/TypeScript/pull/22779#discussion_r176455656
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 22, 2018https://github.com/microsoft/TypeScript/pull/22779#discussion_r176479278
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
tests/cases/conformance/salsa/typeFromPropertyAssignment22.tshttps://github.com/microsoft/TypeScript/pull/22779/files/d00363c154f35489ac88e7e18a4fcb578e994e70#diff-396950ce2a11e4eccd69caf03987722070e23aaab4032cc232476f5fa873f737
Deleted user (ghost)https://github.com/ghost
Mar 22, 2018https://github.com/microsoft/TypeScript/pull/22779#discussion_r176456269
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 22, 2018https://github.com/microsoft/TypeScript/pull/22779#discussion_r176481246
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 22, 2018https://github.com/microsoft/TypeScript/pull/22779#discussion_r176482068
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 22, 2018https://github.com/microsoft/TypeScript/pull/22779#discussion_r176485730
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#22792https://github.com/microsoft/TypeScript/issues/22792
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
tests/cases/conformance/salsa/typeFromPropertyAssignment22.tshttps://github.com/microsoft/TypeScript/pull/22779/files/d00363c154f35489ac88e7e18a4fcb578e994e70#diff-396950ce2a11e4eccd69caf03987722070e23aaab4032cc232476f5fa873f737
Deleted user (ghost)https://github.com/ghost
Mar 22, 2018https://github.com/microsoft/TypeScript/pull/22779#discussion_r176456467
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Mar 22, 2018 https://github.com/microsoft/TypeScript/pull/22779#pullrequestreview-106171171
View reviewed changes https://github.com/microsoft/TypeScript/pull/22779/files/d00363c154f35489ac88e7e18a4fcb578e994e70
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Mar 22, 2018https://github.com/microsoft/TypeScript/pull/22779#issuecomment-375348449
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 22, 2018https://github.com/microsoft/TypeScript/pull/22779#issuecomment-375358839
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
Andy (Andrewkraft) (@Andy-MS)https://github.com/Andy-MS
#22643https://github.com/microsoft/TypeScript/pull/22643
#22643https://github.com/microsoft/TypeScript/pull/22643
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
https://github.com/sandersn
Address PR commentshttps://github.com/microsoft/TypeScript/pull/22779/commits/911ad97a05d5dd507311428c39d3d8d900ef5ded
911ad97https://github.com/microsoft/TypeScript/pull/22779/commits/911ad97a05d5dd507311428c39d3d8d900ef5ded
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Mar 22, 2018 https://github.com/microsoft/TypeScript/pull/22779#pullrequestreview-106200533
View reviewed changes https://github.com/microsoft/TypeScript/pull/22779/files/911ad97a05d5dd507311428c39d3d8d900ef5ded
src/compiler/binder.tshttps://github.com/microsoft/TypeScript/pull/22779/files/d00363c154f35489ac88e7e18a4fcb578e994e70..911ad97a05d5dd507311428c39d3d8d900ef5ded#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898
Deleted user (ghost)https://github.com/ghost
Mar 22, 2018https://github.com/microsoft/TypeScript/pull/22779#discussion_r176487880
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
https://github.com/sandersn
Correct new name for saveThisParentContainerhttps://github.com/microsoft/TypeScript/pull/22779/commits/e2941c8f05053cd0d31ad6a237b1e5badf99e236
e2941c8https://github.com/microsoft/TypeScript/pull/22779/commits/e2941c8f05053cd0d31ad6a237b1e5badf99e236
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Mar 22, 2018https://github.com/microsoft/TypeScript/pull/22779#issuecomment-375375587
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
4462c15https://github.com/microsoft/TypeScript/commit/4462c159b1df956494c9e87fab2b5ddf1d7e4f16
Mar 22, 2018https://github.com/microsoft/TypeScript/pull/22779#event-1536086539
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
March 22, 2018 17:37https://github.com/microsoft/TypeScript/pull/22779#event-1536187169
https://github.com/stereokai
Tom Alon (stereokai)https://github.com/stereokai
Mar 26, 2018 https://github.com/microsoft/TypeScript/pull/22779#ref-issue-308537512
Multiple Issues Related to IntelliSense Opened Since Last Release microsoft/vscode#46546 https://github.com/microsoft/vscode/issues/46546
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 25, 2018https://github.com/microsoft/TypeScript/pull/22779#event-1753424916
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22779
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/22779/files/f9444147098be78f8c5a387d2182e639ca8ec098
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
https://github.com/microsoft/TypeScript/pull/22779/files/d00363c154f35489ac88e7e18a4fcb578e994e70
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22779
https://github.com/sandersn
https://github.com/mhegazy
https://github.com/weswigham
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.