René's URL Explorer Experiment


Title: Fix indexed access in conditional type by ahejlsberg · Pull Request #22707 · microsoft/TypeScript · GitHub

Open Graph Title: Fix indexed access in conditional type by ahejlsberg · Pull Request #22707 · microsoft/TypeScript

X Title: Fix indexed access in conditional type by ahejlsberg · Pull Request #22707 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix indexed access in conditional type by ahejlsberg · Pull Request #22707 · microsoft/TypeScript

Open Graph Description: With this PR, when the checked type in a conditional type is an indexed access type, we now add an implicit constraint to the type in the true branch. Also, this PR fixes an issue where implicit co...

X Description: With this PR, when the checked type in a conditional type is an indexed access type, we now add an implicit constraint to the type in the true branch. Also, this PR fixes an issue where implicit co...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/22707

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4f09771c-57ac-6a61-539e-cec47b9bff80
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8B62:E3C4F:B50B22:E7F479:6B00FAEF
html-safe-nonce7bef9d6bc8d429507eb38d56681463f8f38dd8712de576b196dbfddf4f8876e9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjYyOkUzQzRGOkI1MEIyMjpFN0Y0Nzk6NkIwMEZBRUYiLCJ2aXNpdG9yX2lkIjoiMjA2NTgwNDQ3MDAyMDc5OTIxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacde62e92a5d3da907d69878371a772ba8c94f7449db03edb3e29009bd9486c65d
hovercard-subject-tagpull_request:176054109
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/22707/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e97ef550328ccee0f9b6de9ec5c0aa002a91d96abfad9cb6d8b4d62ff35c0aad/microsoft/TypeScript/pull/22707
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e97ef550328ccee0f9b6de9ec5c0aa002a91d96abfad9cb6d8b4d62ff35c0aad/microsoft/TypeScript/pull/22707
og:image:altWith this PR, when the checked type in a conditional type is an indexed access type, we now add an implicit constraint to the type in the true branch. Also, this PR fixes an issue where implicit co...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameahejlsberg
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/22707#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22707
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22707
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/22707
Reloadhttps://github.com/microsoft/TypeScript/pull/22707
Reloadhttps://github.com/microsoft/TypeScript/pull/22707
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
fixIndexedAccessInConditionalTypehttps://github.com/microsoft/TypeScript/tree/fixIndexedAccessInConditionalType
Conversationhttps://github.com/microsoft/TypeScript/pull/22707
Commits7 (7)https://github.com/microsoft/TypeScript/pull/22707/commits
Checkshttps://github.com/microsoft/TypeScript/pull/22707/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/22707/files
Fix indexed access in conditional typehttps://github.com/microsoft/TypeScript/pull/22707#top
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
fixIndexedAccessInConditionalTypehttps://github.com/microsoft/TypeScript/tree/fixIndexedAccessInConditionalType
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Mar 19, 2018https://github.com/microsoft/TypeScript/pull/22707#issue-306677135
#21729https://github.com/microsoft/TypeScript/issues/21729
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22707
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
March 19, 2018 16:11https://github.com/microsoft/TypeScript/pull/22707#commits-pushed-de1ebb4
https://github.com/ahejlsberg
Add constraints to indexed access types in conditional typeshttps://github.com/microsoft/TypeScript/pull/22707/commits/de1ebb4a84c17610365b72b76682064a51bcdb46
de1ebb4https://github.com/microsoft/TypeScript/pull/22707/commits/de1ebb4a84c17610365b72b76682064a51bcdb46
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/22707/commits/8cb9ac9ab0510393a6e2a840494b2dc4da447347
8cb9ac9https://github.com/microsoft/TypeScript/pull/22707/commits/8cb9ac9ab0510393a6e2a840494b2dc4da447347
https://github.com/ahejlsberg
Add testshttps://github.com/microsoft/TypeScript/pull/22707/commits/16f571b026b829266a90789be46e136dd0b013b8
16f571bhttps://github.com/microsoft/TypeScript/pull/22707/commits/16f571b026b829266a90789be46e136dd0b013b8
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/22707/commits/56710dd5371dff3bf1c47c0857bbe69b1870f374
56710ddhttps://github.com/microsoft/TypeScript/pull/22707/commits/56710dd5371dff3bf1c47c0857bbe69b1870f374
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
March 19, 2018 23:40https://github.com/microsoft/TypeScript/pull/22707#event-1529778192
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Mar 20, 2018 https://github.com/microsoft/TypeScript/pull/22707#pullrequestreview-105453724
View reviewed changes https://github.com/microsoft/TypeScript/pull/22707/files/56710dd5371dff3bf1c47c0857bbe69b1870f374
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
March 20, 2018 14:08https://github.com/microsoft/TypeScript/pull/22707#commits-pushed-420e58c
https://github.com/ahejlsberg
Implicit constraints in non-distributive '[T] extends [U] ? X : Y' typeshttps://github.com/microsoft/TypeScript/pull/22707/commits/420e58c44462a415dab0480779dc574067074a7c
420e58chttps://github.com/microsoft/TypeScript/pull/22707/commits/420e58c44462a415dab0480779dc574067074a7c
https://github.com/ahejlsberg
Add testhttps://github.com/microsoft/TypeScript/pull/22707/commits/c94d28dbc8f28df48295abfc21a2353ff04f6e25
c94d28dhttps://github.com/microsoft/TypeScript/pull/22707/commits/c94d28dbc8f28df48295abfc21a2353ff04f6e25
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/22707/commits/be4f2d9b082160d931abe7877bed2299e3f1fa75
be4f2d9https://github.com/microsoft/TypeScript/pull/22707/commits/be4f2d9b082160d931abe7877bed2299e3f1fa75
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Mar 21, 2018 https://github.com/microsoft/TypeScript/pull/22707#ref-issue-307356785
Incorrect Generics inference with keyof, conditional types #22765 https://github.com/microsoft/TypeScript/issues/22765
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 21, 2018 https://github.com/microsoft/TypeScript/pull/22707#pullrequestreview-105925138
View reviewed changes https://github.com/microsoft/TypeScript/pull/22707/files/be4f2d9b082160d931abe7877bed2299e3f1fa75
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/22707/files/be4f2d9b082160d931abe7877bed2299e3f1fa75#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 21, 2018https://github.com/microsoft/TypeScript/pull/22707#discussion_r176253752
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22707
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 21, 2018https://github.com/microsoft/TypeScript/pull/22707#discussion_r176253902
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22707
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
e5f6ed0https://github.com/microsoft/TypeScript/commit/e5f6ed0b60775bf489b7fa440db307ca3a2ac717
Mar 21, 2018https://github.com/microsoft/TypeScript/pull/22707#event-1534373902
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
March 21, 2018 22:18https://github.com/microsoft/TypeScript/pull/22707#event-1534374044
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 21, 2018 https://github.com/microsoft/TypeScript/pull/22707#ref-pullrequest-307447249
[release 2.8] Fix indexed access in conditional type #22778 https://github.com/microsoft/TypeScript/pull/22778
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 29, 2018 https://github.com/microsoft/TypeScript/pull/22707#ref-issue-309806935
Can't dereference array type in conditional type #22985 https://github.com/microsoft/TypeScript/issues/22985
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 25, 2018https://github.com/microsoft/TypeScript/pull/22707#event-1753424314
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22707
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
https://github.com/microsoft/TypeScript/pull/22707/files/be4f2d9b082160d931abe7877bed2299e3f1fa75
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) https://github.com/RyanCavanaugh
https://github.com/microsoft/TypeScript/pull/22707/files/56710dd5371dff3bf1c47c0857bbe69b1870f374
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22707
Bug: Mapped type does not satisfy the constraint it just matched in conditional type https://github.com/microsoft/TypeScript/issues/21729
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22707
https://github.com/ahejlsberg
https://github.com/DanielRosenwasser
https://github.com/RyanCavanaugh
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.