| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4f09771c-57ac-6a61-539e-cec47b9bff80 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8B62:E3C4F:B50B22:E7F479:6B00FAEF |
| html-safe-nonce | 7bef9d6bc8d429507eb38d56681463f8f38dd8712de576b196dbfddf4f8876e9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjYyOkUzQzRGOkI1MEIyMjpFN0Y0Nzk6NkIwMEZBRUYiLCJ2aXNpdG9yX2lkIjoiMjA2NTgwNDQ3MDAyMDc5OTIxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | de62e92a5d3da907d69878371a772ba8c94f7449db03edb3e29009bd9486c65d |
| hovercard-subject-tag | pull_request:176054109 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/22707/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e97ef550328ccee0f9b6de9ec5c0aa002a91d96abfad9cb6d8b4d62ff35c0aad/microsoft/TypeScript/pull/22707 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e97ef550328ccee0f9b6de9ec5c0aa002a91d96abfad9cb6d8b4d62ff35c0aad/microsoft/TypeScript/pull/22707 |
| og:image:alt | With this PR, when the checked type in a conditional type is an indexed access type, we now add an implicit constraint to the type in the true branch.
Also, this PR fixes an issue where implicit co... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ahejlsberg |
| hostname | github.com |
| expected-hostname | github.com |
| None | e208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187 |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7dafd017fb7809a839c443dba08622af38e63c09 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/22707#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22707 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22707 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/22707 |
| Reload | https://github.com/microsoft/TypeScript/pull/22707 |
| Reload | https://github.com/microsoft/TypeScript/pull/22707 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests309 (309) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| master | https://github.com/microsoft/TypeScript/tree/master |
| fixIndexedAccessInConditionalType | https://github.com/microsoft/TypeScript/tree/fixIndexedAccessInConditionalType |
| Conversation | https://github.com/microsoft/TypeScript/pull/22707 |
| Commits7 (7) | https://github.com/microsoft/TypeScript/pull/22707/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/22707/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/22707/files |
| Fix indexed access in conditional type | https://github.com/microsoft/TypeScript/pull/22707#top |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| master | https://github.com/microsoft/TypeScript/tree/master |
| fixIndexedAccessInConditionalType | https://github.com/microsoft/TypeScript/tree/fixIndexedAccessInConditionalType |
|
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Mar 19, 2018 | https://github.com/microsoft/TypeScript/pull/22707#issue-306677135 |
| #21729 | https://github.com/microsoft/TypeScript/issues/21729 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/22707 |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| March 19, 2018 16:11 | https://github.com/microsoft/TypeScript/pull/22707#commits-pushed-de1ebb4 |
|
| https://github.com/ahejlsberg |
| Add constraints to indexed access types in conditional types | https://github.com/microsoft/TypeScript/pull/22707/commits/de1ebb4a84c17610365b72b76682064a51bcdb46 |
| de1ebb4 | https://github.com/microsoft/TypeScript/pull/22707/commits/de1ebb4a84c17610365b72b76682064a51bcdb46 |
|
| https://github.com/ahejlsberg |
| Accept new baselines | https://github.com/microsoft/TypeScript/pull/22707/commits/8cb9ac9ab0510393a6e2a840494b2dc4da447347 |
| 8cb9ac9 | https://github.com/microsoft/TypeScript/pull/22707/commits/8cb9ac9ab0510393a6e2a840494b2dc4da447347 |
|
| https://github.com/ahejlsberg |
| Add tests | https://github.com/microsoft/TypeScript/pull/22707/commits/16f571b026b829266a90789be46e136dd0b013b8 |
| 16f571b | https://github.com/microsoft/TypeScript/pull/22707/commits/16f571b026b829266a90789be46e136dd0b013b8 |
|
| https://github.com/ahejlsberg |
| Accept new baselines | https://github.com/microsoft/TypeScript/pull/22707/commits/56710dd5371dff3bf1c47c0857bbe69b1870f374 |
| 56710dd | https://github.com/microsoft/TypeScript/pull/22707/commits/56710dd5371dff3bf1c47c0857bbe69b1870f374 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
| March 19, 2018 23:40 | https://github.com/microsoft/TypeScript/pull/22707#event-1529778192 |
| https://github.com/RyanCavanaugh |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
|
Mar 20, 2018
| https://github.com/microsoft/TypeScript/pull/22707#pullrequestreview-105453724 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/22707/files/56710dd5371dff3bf1c47c0857bbe69b1870f374 |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| March 20, 2018 14:08 | https://github.com/microsoft/TypeScript/pull/22707#commits-pushed-420e58c |
|
| https://github.com/ahejlsberg |
| Implicit constraints in non-distributive '[T] extends [U] ? X : Y' types | https://github.com/microsoft/TypeScript/pull/22707/commits/420e58c44462a415dab0480779dc574067074a7c |
| 420e58c | https://github.com/microsoft/TypeScript/pull/22707/commits/420e58c44462a415dab0480779dc574067074a7c |
|
| https://github.com/ahejlsberg |
| Add test | https://github.com/microsoft/TypeScript/pull/22707/commits/c94d28dbc8f28df48295abfc21a2353ff04f6e25 |
| c94d28d | https://github.com/microsoft/TypeScript/pull/22707/commits/c94d28dbc8f28df48295abfc21a2353ff04f6e25 |
|
| https://github.com/ahejlsberg |
| Accept new baselines | https://github.com/microsoft/TypeScript/pull/22707/commits/be4f2d9b082160d931abe7877bed2299e3f1fa75 |
| be4f2d9 | https://github.com/microsoft/TypeScript/pull/22707/commits/be4f2d9b082160d931abe7877bed2299e3f1fa75 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
|
Mar 21, 2018
| https://github.com/microsoft/TypeScript/pull/22707#ref-issue-307356785 |
|
Incorrect Generics inference with keyof, conditional types
#22765
| https://github.com/microsoft/TypeScript/issues/22765 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Mar 21, 2018
| https://github.com/microsoft/TypeScript/pull/22707#pullrequestreview-105925138 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/22707/files/be4f2d9b082160d931abe7877bed2299e3f1fa75 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/22707/files/be4f2d9b082160d931abe7877bed2299e3f1fa75#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Mar 21, 2018 | https://github.com/microsoft/TypeScript/pull/22707#discussion_r176253752 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/22707 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Mar 21, 2018 | https://github.com/microsoft/TypeScript/pull/22707#discussion_r176253902 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/22707 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| e5f6ed0 | https://github.com/microsoft/TypeScript/commit/e5f6ed0b60775bf489b7fa440db307ca3a2ac717 |
| Mar 21, 2018 | https://github.com/microsoft/TypeScript/pull/22707#event-1534373902 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| March 21, 2018 22:18 | https://github.com/microsoft/TypeScript/pull/22707#event-1534374044 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Mar 21, 2018
| https://github.com/microsoft/TypeScript/pull/22707#ref-pullrequest-307447249 |
|
[release 2.8] Fix indexed access in conditional type
#22778
| https://github.com/microsoft/TypeScript/pull/22778 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
|
Mar 29, 2018
| https://github.com/microsoft/TypeScript/pull/22707#ref-issue-309806935 |
|
Can't dereference array type in conditional type
#22985
| https://github.com/microsoft/TypeScript/issues/22985 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Jul 25, 2018 | https://github.com/microsoft/TypeScript/pull/22707#event-1753424314 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22707 |
|
| https://github.com/DanielRosenwasser |
|
Daniel Rosenwasser (DanielRosenwasser)
| https://github.com/DanielRosenwasser |
|
| https://github.com/microsoft/TypeScript/pull/22707/files/be4f2d9b082160d931abe7877bed2299e3f1fa75 |
|
| https://github.com/RyanCavanaugh |
|
Ryan Cavanaugh (RyanCavanaugh)
| https://github.com/RyanCavanaugh |
|
| https://github.com/microsoft/TypeScript/pull/22707/files/56710dd5371dff3bf1c47c0857bbe69b1870f374 |
|
| https://github.com/mhegazy |
|
Mohamed Hegazy (mhegazy)
| https://github.com/mhegazy |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/22707 |
|
Bug: Mapped type does not satisfy the constraint it just matched in conditional type
| https://github.com/microsoft/TypeScript/issues/21729 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/22707 |
|
| https://github.com/ahejlsberg |
|
| https://github.com/DanielRosenwasser |
|
| https://github.com/RyanCavanaugh |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |