René's URL Explorer Experiment


Title: For `f.prototype.m = function() { this.x = 0; }` make `x` a member of `f`, not of the function expression · Pull Request #22643 · microsoft/TypeScript · GitHub

Open Graph Title: For `f.prototype.m = function() { this.x = 0; }` make `x` a member of `f`, not of the function expression · Pull Request #22643 · microsoft/TypeScript

X Title: For `f.prototype.m = function() { this.x = 0; }` make `x` a member of `f`, not of the function expression · Pull Request #22643 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - For `f.prototype.m = function() { this.x = 0; }` make `x` a member of `f`, not of the function expression · Pull Request #22643 · microsoft/TypeScript

Open Graph Description: Fixes #22240

X Description: Fixes #22240

Opengraph URL: https://github.com/microsoft/TypeScript/pull/22643

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4b931495-e990-d06e-53fe-904ab6d5dd50
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id89BC:2463BD:2E6A8B2:3B4CDF5:6B01B312
html-safe-noncef6d2c823718abb43705d2e380930057e7caba7ec5df3efe400980afdefaaa61f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUJDOjI0NjNCRDoyRTZBOEIyOjNCNENERjU6NkIwMUIzMTIiLCJ2aXNpdG9yX2lkIjoiNzIxNDU3Njk3Nzc0MTcyMjM4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca834a1966c34882a6631eb2812ec99b4c22e0043b2af0a5758256901863a08d7
hovercard-subject-tagpull_request:175596546
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/22643/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e2b0d947d9ee9af77cb4d7a3da917c3354944a5eda4018b444bd7ef5baca9bfe/microsoft/TypeScript/pull/22643
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e2b0d947d9ee9af77cb4d7a3da917c3354944a5eda4018b444bd7ef5baca9bfe/microsoft/TypeScript/pull/22643
og:image:altFixes #22240
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/22643#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22643
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22643
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/22643
Reloadhttps://github.com/microsoft/TypeScript/pull/22643
Reloadhttps://github.com/microsoft/TypeScript/pull/22643
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
masterhttps://github.com/microsoft/TypeScript/tree/master
property_assignment_in_prototype_functionhttps://github.com/microsoft/TypeScript/tree/property_assignment_in_prototype_function
Conversationhttps://github.com/microsoft/TypeScript/pull/22643
Commits1 (1)https://github.com/microsoft/TypeScript/pull/22643/commits
Checkshttps://github.com/microsoft/TypeScript/pull/22643/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/22643/files
For f.prototype.m = function() { this.x = 0; } make x a member of f, not of the function expressionhttps://github.com/microsoft/TypeScript/pull/22643#top
masterhttps://github.com/microsoft/TypeScript/tree/master
property_assignment_in_prototype_functionhttps://github.com/microsoft/TypeScript/tree/property_assignment_in_prototype_function
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Mar 16, 2018https://github.com/microsoft/TypeScript/pull/22643#issue-306011573
#22240https://github.com/microsoft/TypeScript/issues/22240
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22643
For f.prototype.m = function() { this.x = 0; } make x a member of…https://github.com/microsoft/TypeScript/pull/22643/commits/7ce39ccb8adda6bc466d1bb1f352b7e1023f06eb
7ce39cchttps://github.com/microsoft/TypeScript/pull/22643/commits/7ce39ccb8adda6bc466d1bb1f352b7e1023f06eb
Ron Buckton (rbuckton)https://github.com/rbuckton
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
March 16, 2018 17:19https://github.com/microsoft/TypeScript/pull/22643#event-1526021344
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 16, 2018 https://github.com/microsoft/TypeScript/pull/22643#pullrequestreview-104665242
View reviewed changes https://github.com/microsoft/TypeScript/pull/22643/files/7ce39ccb8adda6bc466d1bb1f352b7e1023f06eb
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/22643#pullrequestreview-104665242
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22643
src/compiler/binder.tshttps://github.com/microsoft/TypeScript/pull/22643/files/7ce39ccb8adda6bc466d1bb1f352b7e1023f06eb#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 16, 2018https://github.com/microsoft/TypeScript/pull/22643#discussion_r175171387
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22643
b9f6056https://github.com/microsoft/TypeScript/commit/b9f60566d09d11177716c96b83ca9a78809b3b18
Mar 16, 2018https://github.com/microsoft/TypeScript/pull/22643#event-1526166816
March 16, 2018 18:35https://github.com/microsoft/TypeScript/pull/22643#event-1526166893
Mar 16, 2018 https://github.com/microsoft/TypeScript/pull/22643#ref-pullrequest-306040225
Add 'isPrototypeAccess' helper #22648 https://github.com/microsoft/TypeScript/pull/22648
In JS, out-of-order prototype assignments crash in the binder #22725 https://github.com/microsoft/TypeScript/issues/22725
Correctly track thisContainer for this-property-assignments in JS nested containers #22779 https://github.com/microsoft/TypeScript/pull/22779
Debug.fail hit in bindThisPropertyAssignment #22888 https://github.com/microsoft/TypeScript/issues/22888
Bind toplevel this assignments as global declarations #22891 https://github.com/microsoft/TypeScript/pull/22891
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 25, 2018https://github.com/microsoft/TypeScript/pull/22643#event-1753423795
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22643
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22643
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22643
https://github.com/sandersn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.