René's URL Explorer Experiment


Title: Combine keyof T inferences by weswigham · Pull Request #22525 · microsoft/TypeScript · GitHub

Open Graph Title: Combine keyof T inferences by weswigham · Pull Request #22525 · microsoft/TypeScript

X Title: Combine keyof T inferences by weswigham · Pull Request #22525 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Combine keyof T inferences by weswigham · Pull Request #22525 · microsoft/TypeScript

Open Graph Description: Fixes #21553 kinda. The example will now typecheck (instead of error) as expected, but the inferred type for T won't be the default (as it used to be when we made no inference), instead it'...

X Description: Fixes #21553 kinda. The example will now typecheck (instead of error) as expected, but the inferred type for T won't be the default (as it used to be when we made no inference), instead it&...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/22525

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4b8d23a8-fe7d-0b20-e0da-a014d166d672
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC2AE:31E99C:CBA0E9:1115E4A:6B00FD27
html-safe-nonceecca071d06eb0194744574e22b72c14677760cd18c3b413ed986406a61379b98
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkFFOjMxRTk5QzpDQkEwRTk6MTExNUU0QTo2QjAwRkQyNyIsInZpc2l0b3JfaWQiOiI0NzAyMjcwMDkzMTMwNzkyMjMxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac26d5d62dff8e6c95f073500900e110f387d988bea3c32c5597fcc14987fa2a80
hovercard-subject-tagpull_request:174817734
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/22525/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/38d97eb3e007b5a66c090a285b7d3d068b2cc73f5ef7221c688a5e6aaf289391/microsoft/TypeScript/pull/22525
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/38d97eb3e007b5a66c090a285b7d3d068b2cc73f5ef7221c688a5e6aaf289391/microsoft/TypeScript/pull/22525
og:image:altFixes #21553 kinda. The example will now typecheck (instead of error) as expected, but the inferred type for T won't be the default (as it used to be when we made no inference), instead it'...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/22525#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22525
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22525
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/22525
Reloadhttps://github.com/microsoft/TypeScript/pull/22525
Reloadhttps://github.com/microsoft/TypeScript/pull/22525
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:combine-keyof-inferenceshttps://github.com/weswigham/TypeScript/tree/combine-keyof-inferences
Conversationhttps://github.com/microsoft/TypeScript/pull/22525
Commits9 (9)https://github.com/microsoft/TypeScript/pull/22525/commits
Checkshttps://github.com/microsoft/TypeScript/pull/22525/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/22525/files
Combine keyof T inferenceshttps://github.com/microsoft/TypeScript/pull/22525#top
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:combine-keyof-inferenceshttps://github.com/weswigham/TypeScript/tree/combine-keyof-inferences
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 13, 2018https://github.com/microsoft/TypeScript/pull/22525#issue-304971755
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22525
#21553https://github.com/microsoft/TypeScript/issues/21553
#22376https://github.com/microsoft/TypeScript/issues/22376
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22525
https://github.com/weswigham
Combine keyof T inferenceshttps://github.com/microsoft/TypeScript/pull/22525/commits/927fe3eb631d7536a211bec9e3c46efbaac87798
927fe3ehttps://github.com/microsoft/TypeScript/pull/22525/commits/927fe3eb631d7536a211bec9e3c46efbaac87798
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
March 13, 2018 23:30https://github.com/microsoft/TypeScript/pull/22525#event-1519845535
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 14, 2018 https://github.com/microsoft/TypeScript/pull/22525#pullrequestreview-103657632
View reviewed changes https://github.com/microsoft/TypeScript/pull/22525/files/927fe3eb631d7536a211bec9e3c46efbaac87798
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/22525#pullrequestreview-103657632
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22525
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/22525/files/927fe3eb631d7536a211bec9e3c46efbaac87798#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 14, 2018https://github.com/microsoft/TypeScript/pull/22525#discussion_r174322767
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22525
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 14, 2018https://github.com/microsoft/TypeScript/pull/22525#discussion_r174323084
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#22323https://github.com/microsoft/TypeScript/pull/22323
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22525
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 14, 2018https://github.com/microsoft/TypeScript/pull/22525#discussion_r174333988
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22525
https://github.com/weswigham
Extract covariant inference derivation into functionhttps://github.com/microsoft/TypeScript/pull/22525/commits/27c171ecc85c0a0cfede45c50cb8b46f2080194a
27c171ehttps://github.com/microsoft/TypeScript/pull/22525/commits/27c171ecc85c0a0cfede45c50cb8b46f2080194a
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 14, 2018https://github.com/microsoft/TypeScript/pull/22525#issuecomment-373096725
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22525
#22376https://github.com/microsoft/TypeScript/issues/22376
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22525
https://github.com/sandersn
Test:keyof inference lower priority than return inferencehttps://github.com/microsoft/TypeScript/pull/22525/commits/2938bbbee0f7ab434b54fd4f8ddda08905501de3
https://github.com/microsoft/TypeScript/commit/2938bbbee0f7ab434b54fd4f8ddda08905501de3#comments
2938bbbhttps://github.com/microsoft/TypeScript/pull/22525/commits/2938bbbee0f7ab434b54fd4f8ddda08905501de3
microsoft#22376https://github.com/microsoft/TypeScript/issues/22376
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 14, 2018 https://github.com/microsoft/TypeScript/pull/22525#pullrequestreview-103877283
View reviewed changes https://github.com/microsoft/TypeScript/pull/22525/files/27c171ecc85c0a0cfede45c50cb8b46f2080194a
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/22525#pullrequestreview-103877283
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22525
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/22525/files/27c171ecc85c0a0cfede45c50cb8b46f2080194a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 14, 2018https://github.com/microsoft/TypeScript/pull/22525#discussion_r174507660
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22525
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 14, 2018https://github.com/microsoft/TypeScript/pull/22525#issuecomment-373100559
#22376https://github.com/microsoft/TypeScript/issues/22376
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22525
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
March 14, 2018 10:12https://github.com/microsoft/TypeScript/pull/22525#commits-pushed-4fd8bf3
https://github.com/sandersn
Update 'expected' comment in keyofInferenceLowerPriorityThanReturnhttps://github.com/microsoft/TypeScript/pull/22525/commits/4fd8bf3951b27dd302a88736e7fd3af4d6996043
4fd8bf3https://github.com/microsoft/TypeScript/pull/22525/commits/4fd8bf3951b27dd302a88736e7fd3af4d6996043
https://github.com/sandersn
Update comment in test too, not just baselineshttps://github.com/microsoft/TypeScript/pull/22525/commits/c6c41d351be8ea8d614bb7d35ce8f42a8fe36b6b
c6c41d3https://github.com/microsoft/TypeScript/pull/22525/commits/c6c41d351be8ea8d614bb7d35ce8f42a8fe36b6b
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 14, 2018 https://github.com/microsoft/TypeScript/pull/22525#ref-issue-303121079
Regression in Type Inference engine in TypeScript 2.7.1 #22376 https://github.com/microsoft/TypeScript/issues/22376
Wesley Wigham (weswigham)https://github.com/weswigham
March 14, 2018 10:56https://github.com/microsoft/TypeScript/pull/22525#commits-pushed-515439a
https://github.com/weswigham
Fix typohttps://github.com/microsoft/TypeScript/pull/22525/commits/515439a981f16017a19a9ba3a0b55efc65f432c9
515439ahttps://github.com/microsoft/TypeScript/pull/22525/commits/515439a981f16017a19a9ba3a0b55efc65f432c9
https://github.com/weswigham
Merge branch 'combine-keyof-inferences' of github.com:weswigham/TypeS…https://github.com/microsoft/TypeScript/pull/22525/commits/8359aafc0982835951d4fb5334e179e1626a27a8
8359aafhttps://github.com/microsoft/TypeScript/pull/22525/commits/8359aafc0982835951d4fb5334e179e1626a27a8
https://github.com/weswigham
Move testshttps://github.com/microsoft/TypeScript/pull/22525/commits/acde7070573fa37621de6b2f0523694fcc5f7b5d
acde707https://github.com/microsoft/TypeScript/pull/22525/commits/acde7070573fa37621de6b2f0523694fcc5f7b5d
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 14, 2018https://github.com/microsoft/TypeScript/pull/22525#issuecomment-373125008
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22525
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Mar 19, 2018 https://github.com/microsoft/TypeScript/pull/22525#pullrequestreview-105165998
View reviewed changes https://github.com/microsoft/TypeScript/pull/22525/files/acde7070573fa37621de6b2f0523694fcc5f7b5d
https://github.com/weswigham
Merge branch 'master' into combine-keyof-inferenceshttps://github.com/microsoft/TypeScript/pull/22525/commits/f4512c11979bc3cdea2aa13fab19a00ca7c4cd60
f4512c1https://github.com/microsoft/TypeScript/pull/22525/commits/f4512c11979bc3cdea2aa13fab19a00ca7c4cd60
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
eaabf92https://github.com/microsoft/TypeScript/commit/eaabf920eb20c250b3b45b725c2e6ec667ec1bec
Mar 19, 2018https://github.com/microsoft/TypeScript/pull/22525#event-1529795105
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
March 19, 2018 23:56https://github.com/microsoft/TypeScript/pull/22525#event-1529795193
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 20, 2018 https://github.com/microsoft/TypeScript/pull/22525#ref-commit-044cdbc
https://github.com/weswigham
https://github.com/DanielRosenwasser
Combine keyof T inferences (https://github.com/microsoft/TypeScript/commit/044cdbc85f39999dc5d9d136bb679d8a18dbd1d4
#22525https://github.com/microsoft/TypeScript/pull/22525
)https://github.com/microsoft/TypeScript/commit/044cdbc85f39999dc5d9d136bb679d8a18dbd1d4
044cdbchttps://github.com/microsoft/TypeScript/commit/044cdbc85f39999dc5d9d136bb679d8a18dbd1d4
#22376https://github.com/microsoft/TypeScript/issues/22376
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 20, 2018 https://github.com/microsoft/TypeScript/pull/22525#ref-pullrequest-306690853
[release-2.8] Combine keyof T inferences (#22525) #22708 https://github.com/microsoft/TypeScript/pull/22708
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 20, 2018 https://github.com/microsoft/TypeScript/pull/22525#ref-commit-0f024f5
https://github.com/DanielRosenwasser
Merge pull requesthttps://github.com/microsoft/TypeScript/commit/0f024f5e32b7b853ae962a005113c51bb468e418
#22708https://github.com/microsoft/TypeScript/pull/22708
from Microsoft/combineKeyofInferenceRelease…https://github.com/microsoft/TypeScript/commit/0f024f5e32b7b853ae962a005113c51bb468e418
0f024f5https://github.com/microsoft/TypeScript/commit/0f024f5e32b7b853ae962a005113c51bb468e418
#22525https://github.com/microsoft/TypeScript/pull/22525
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 25, 2018https://github.com/microsoft/TypeScript/pull/22525#event-1753422866
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22525
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/22525/files/27c171ecc85c0a0cfede45c50cb8b46f2080194a
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
https://github.com/microsoft/TypeScript/pull/22525/files/acde7070573fa37621de6b2f0523694fcc5f7b5d
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22525
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22525
https://github.com/weswigham
https://github.com/sandersn
https://github.com/ahejlsberg
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.