René's URL Explorer Experiment


Title: convertToEs6Module: Avoid replacing entire function · Pull Request #22507 · microsoft/TypeScript · GitHub

Open Graph Title: convertToEs6Module: Avoid replacing entire function · Pull Request #22507 · microsoft/TypeScript

X Title: convertToEs6Module: Avoid replacing entire function · Pull Request #22507 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - convertToEs6Module: Avoid replacing entire function · Pull Request #22507 · microsoft/TypeScript

Open Graph Description: Fixes #22492 Will rebase once #22361 is in.

X Description: Fixes #22492 Will rebase once #22361 is in.

Opengraph URL: https://github.com/microsoft/TypeScript/pull/22507

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2db206e9-dc0a-45fc-c37d-d8266bc0720e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDE70:14A09E:B82FE:FDDCA:6AFBF9A3
html-safe-noncec3b63bb8ad7cd7560af851899ffcf2e58e8d9501b68c7a98b906960f14994200
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTcwOjE0QTA5RTpCODJGRTpGRERDQTo2QUZCRjlBMyIsInZpc2l0b3JfaWQiOiI0MzA4NTA0MTMyNzY4NzU4MTc5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac78c5a7c329760a11728edd31336fa503d04634839ffed506a98bebdb0edc67db
hovercard-subject-tagpull_request:174717620
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/22507/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f5e74fff8a4385e8c85ea575a94c4115c7bd01fd3904c61ef09bd13fd9d55830/microsoft/TypeScript/pull/22507
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f5e74fff8a4385e8c85ea575a94c4115c7bd01fd3904c61ef09bd13fd9d55830/microsoft/TypeScript/pull/22507
og:image:altFixes #22492 Will rebase once #22361 is in.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonefa74413a1d84dac536fcca0740780bcbd3207bafec0e51873b73ff8e8cca032f
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb3b5633a74535d9c23385512d534c66c8fde1907
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/22507#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22507
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22507
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/22507
Reloadhttps://github.com/microsoft/TypeScript/pull/22507
Reloadhttps://github.com/microsoft/TypeScript/pull/22507
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests335 (335)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/pulse
https://github.com/microsoft/TypeScript
masterhttps://github.com/microsoft/TypeScript/tree/master
convertExportsDotXEqualshttps://github.com/microsoft/TypeScript/tree/convertExportsDotXEquals
Conversationhttps://github.com/microsoft/TypeScript/pull/22507
Commits3 (3)https://github.com/microsoft/TypeScript/pull/22507/commits
Checkshttps://github.com/microsoft/TypeScript/pull/22507/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/22507/files
convertToEs6Module: Avoid replacing entire functionhttps://github.com/microsoft/TypeScript/pull/22507#top
masterhttps://github.com/microsoft/TypeScript/tree/master
convertExportsDotXEqualshttps://github.com/microsoft/TypeScript/tree/convertExportsDotXEquals
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Mar 13, 2018https://github.com/microsoft/TypeScript/pull/22507#issue-304840804
#22492https://github.com/microsoft/TypeScript/issues/22492
#22361https://github.com/microsoft/TypeScript/pull/22361
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
Mar 13, 2018https://github.com/microsoft/TypeScript/pull/22507#event-1519058184
Mar 20, 2018 https://github.com/microsoft/TypeScript/pull/22507#ref-pullrequest-307053392
Fix test for overlapping changes #22741 https://github.com/microsoft/TypeScript/pull/22741
force-pushedhttps://github.com/microsoft/TypeScript/compare/3fde583c1ea154c2b038e4baae854ecff1df4d36..9e99f5d1216354ef69a149b4cfdf6fb759bae85c
3fde583https://github.com/microsoft/TypeScript/commit/3fde583c1ea154c2b038e4baae854ecff1df4d36
9e99f5dhttps://github.com/microsoft/TypeScript/commit/9e99f5d1216354ef69a149b4cfdf6fb759bae85c
Compare https://github.com/microsoft/TypeScript/compare/3fde583c1ea154c2b038e4baae854ecff1df4d36..9e99f5d1216354ef69a149b4cfdf6fb759bae85c
April 6, 2018 22:36https://github.com/microsoft/TypeScript/pull/22507#event-1561877508
Andrew Casey (amcasey)https://github.com/amcasey
April 6, 2018 23:22https://github.com/microsoft/TypeScript/pull/22507#event-1561919599
convertToEs6Module: Avoid replacing entire functionhttps://github.com/microsoft/TypeScript/pull/22507/commits/5c13eaf72e549c0f87f8296905dbb3c7d112d808
5c13eafhttps://github.com/microsoft/TypeScript/pull/22507/commits/5c13eaf72e549c0f87f8296905dbb3c7d112d808
force-pushedhttps://github.com/microsoft/TypeScript/compare/9e99f5d1216354ef69a149b4cfdf6fb759bae85c..5c13eaf72e549c0f87f8296905dbb3c7d112d808
9e99f5dhttps://github.com/microsoft/TypeScript/commit/9e99f5d1216354ef69a149b4cfdf6fb759bae85c
5c13eafhttps://github.com/microsoft/TypeScript/commit/5c13eaf72e549c0f87f8296905dbb3c7d112d808
Compare https://github.com/microsoft/TypeScript/compare/9e99f5d1216354ef69a149b4cfdf6fb759bae85c..5c13eaf72e549c0f87f8296905dbb3c7d112d808
April 6, 2018 23:22https://github.com/microsoft/TypeScript/pull/22507#event-1561919957
https://github.com/amcasey
Andrew Casey (amcasey)https://github.com/amcasey
Apr 12, 2018 https://github.com/microsoft/TypeScript/pull/22507#pullrequestreview-111725743
View reviewed changes https://github.com/microsoft/TypeScript/pull/22507/files/5c13eaf72e549c0f87f8296905dbb3c7d112d808
Andrew Casey (amcasey)https://github.com/amcasey
https://github.com/microsoft/TypeScript/pull/22507#pullrequestreview-111725743
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
tests/cases/fourslash/refactorConvertToEs6Module_export_referenced.tshttps://github.com/microsoft/TypeScript/pull/22507/files/5c13eaf72e549c0f87f8296905dbb3c7d112d808#diff-31c2fea3df5b0f03afe24558ee3f576f5796946b0bc2023f2db59885a7943cf8
Andrew Casey (amcasey)https://github.com/amcasey
Apr 12, 2018https://github.com/microsoft/TypeScript/pull/22507#discussion_r181166612
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
Deleted user (ghost)https://github.com/ghost
Apr 12, 2018https://github.com/microsoft/TypeScript/pull/22507#discussion_r181181359
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
src/services/textChanges.tshttps://github.com/microsoft/TypeScript/pull/22507/files/5c13eaf72e549c0f87f8296905dbb3c7d112d808#diff-386d93db50a938da0c4af7bb293ac679b5da235cebeeee9adbc040fbf8aa222c
Andrew Casey (amcasey)https://github.com/amcasey
Apr 12, 2018https://github.com/microsoft/TypeScript/pull/22507#discussion_r181168984
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
Deleted user (ghost)https://github.com/ghost
Apr 12, 2018https://github.com/microsoft/TypeScript/pull/22507#discussion_r181181374
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#23373https://github.com/microsoft/TypeScript/issues/23373
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
src/services/textChanges.tshttps://github.com/microsoft/TypeScript/pull/22507/files/5c13eaf72e549c0f87f8296905dbb3c7d112d808#diff-386d93db50a938da0c4af7bb293ac679b5da235cebeeee9adbc040fbf8aa222c
Andrew Casey (amcasey)https://github.com/amcasey
Apr 12, 2018https://github.com/microsoft/TypeScript/pull/22507#discussion_r181169233
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
Andrew Casey (amcasey)https://github.com/amcasey
Apr 12, 2018https://github.com/microsoft/TypeScript/pull/22507#discussion_r181169417
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
Deleted user (ghost)https://github.com/ghost
Apr 12, 2018https://github.com/microsoft/TypeScript/pull/22507#discussion_r181181383
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
src/services/textChanges.tshttps://github.com/microsoft/TypeScript/pull/22507/files/5c13eaf72e549c0f87f8296905dbb3c7d112d808#diff-386d93db50a938da0c4af7bb293ac679b5da235cebeeee9adbc040fbf8aa222c
Andrew Casey (amcasey)https://github.com/amcasey
Apr 12, 2018https://github.com/microsoft/TypeScript/pull/22507#discussion_r181170054
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
Deleted user (ghost)https://github.com/ghost
Apr 12, 2018https://github.com/microsoft/TypeScript/pull/22507#discussion_r181181412
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
src/services/textChanges.tshttps://github.com/microsoft/TypeScript/pull/22507/files/5c13eaf72e549c0f87f8296905dbb3c7d112d808#diff-386d93db50a938da0c4af7bb293ac679b5da235cebeeee9adbc040fbf8aa222c
Andrew Casey (amcasey)https://github.com/amcasey
Apr 12, 2018https://github.com/microsoft/TypeScript/pull/22507#discussion_r181170126
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
Deleted user (ghost)https://github.com/ghost
Apr 12, 2018https://github.com/microsoft/TypeScript/pull/22507#discussion_r181181444
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
src/services/textChanges.tshttps://github.com/microsoft/TypeScript/pull/22507/files/5c13eaf72e549c0f87f8296905dbb3c7d112d808#diff-386d93db50a938da0c4af7bb293ac679b5da235cebeeee9adbc040fbf8aa222c
Andrew Casey (amcasey)https://github.com/amcasey
Apr 12, 2018https://github.com/microsoft/TypeScript/pull/22507#discussion_r181170215
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
Deleted user (ghost)https://github.com/ghost
Apr 12, 2018https://github.com/microsoft/TypeScript/pull/22507#discussion_r181181463
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#23373https://github.com/microsoft/TypeScript/issues/23373
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
src/services/codefixes/convertToEs6Module.tshttps://github.com/microsoft/TypeScript/pull/22507/files/5c13eaf72e549c0f87f8296905dbb3c7d112d808#diff-9fae4ac18cb7ef1888c1cec88e6e583215f8c45bb98f6fe9cfc034b25f623a37
Andrew Casey (amcasey)https://github.com/amcasey
Apr 12, 2018https://github.com/microsoft/TypeScript/pull/22507#discussion_r181171250
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
Deleted user (ghost)https://github.com/ghost
Apr 12, 2018https://github.com/microsoft/TypeScript/pull/22507#discussion_r181181486
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
src/services/codefixes/convertToEs6Module.tshttps://github.com/microsoft/TypeScript/pull/22507/files/5c13eaf72e549c0f87f8296905dbb3c7d112d808#diff-9fae4ac18cb7ef1888c1cec88e6e583215f8c45bb98f6fe9cfc034b25f623a37
Andrew Casey (amcasey)https://github.com/amcasey
Apr 12, 2018https://github.com/microsoft/TypeScript/pull/22507#discussion_r181172112
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
Deleted user (ghost)https://github.com/ghost
Apr 12, 2018https://github.com/microsoft/TypeScript/pull/22507#discussion_r181181510
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#23373https://github.com/microsoft/TypeScript/issues/23373
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
src/services/codefixes/convertToEs6Module.tshttps://github.com/microsoft/TypeScript/pull/22507/files/5c13eaf72e549c0f87f8296905dbb3c7d112d808#diff-9fae4ac18cb7ef1888c1cec88e6e583215f8c45bb98f6fe9cfc034b25f623a37
Andrew Casey (amcasey)https://github.com/amcasey
Apr 12, 2018https://github.com/microsoft/TypeScript/pull/22507#discussion_r181172226
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
Deleted user (ghost)https://github.com/ghost
Apr 12, 2018https://github.com/microsoft/TypeScript/pull/22507#discussion_r181181519
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#23373https://github.com/microsoft/TypeScript/issues/23373
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
Code reviewhttps://github.com/microsoft/TypeScript/pull/22507/commits/a78a41c84aca33b4ec672f927df0416865134c65
a78a41chttps://github.com/microsoft/TypeScript/pull/22507/commits/a78a41c84aca33b4ec672f927df0416865134c65
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Apr 13, 2018 https://github.com/microsoft/TypeScript/pull/22507#pullrequestreview-111844951
View reviewed changes https://github.com/microsoft/TypeScript/pull/22507/files/a78a41c84aca33b4ec672f927df0416865134c65
Fix typohttps://github.com/microsoft/TypeScript/pull/22507/commits/2415f2f97dea0579820b6b7b0b0e63c67cb9d1ac
2415f2fhttps://github.com/microsoft/TypeScript/pull/22507/commits/2415f2f97dea0579820b6b7b0b0e63c67cb9d1ac
aac9ef5https://github.com/microsoft/TypeScript/commit/aac9ef5e513d35c34d513c22fa63510101f0953a
Apr 16, 2018https://github.com/microsoft/TypeScript/pull/22507#event-1577201145
April 16, 2018 20:16https://github.com/microsoft/TypeScript/pull/22507#event-1577201247
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 26, 2018https://github.com/microsoft/TypeScript/pull/22507#event-1753855274
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22507
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22507
https://github.com/mhegazy
https://github.com/amcasey
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.