René's URL Explorer Experiment


Title: Fix ignore message indentation by mhegazy · Pull Request #22340 · microsoft/TypeScript · GitHub

Open Graph Title: Fix ignore message indentation by mhegazy · Pull Request #22340 · microsoft/TypeScript

X Title: Fix ignore message indentation by mhegazy · Pull Request #22340 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix ignore message indentation by mhegazy · Pull Request #22340 · microsoft/TypeScript

Open Graph Description: Use change tracker instead of direct text edits to add // @ts-check above statements. Fixes #21355

X Description: Use change tracker instead of direct text edits to add // @ts-check above statements. Fixes #21355

Opengraph URL: https://github.com/microsoft/TypeScript/pull/22340

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f5c7f9af-48c4-f6d1-7e48-998a762be482
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id99C8:CDD83:28327:37BD9:6AFBF46C
html-safe-nonced7bd743b9ec425ed9fe5ca1a854c83216c7da3b6a8fa4e93a949fd906c104672
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUM4OkNERDgzOjI4MzI3OjM3QkQ5OjZBRkJGNDZDIiwidmlzaXRvcl9pZCI6IjYzMjgxMDEzMzcwNzQyMzQ0NzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac60870e16601cb6cac117fa8df090d7c9bf1a760adb1ef7d8535faefa0be2be5d
hovercard-subject-tagpull_request:172974421
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/22340/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d9a80ab80eaaf07e35a7191e8d5253414bc8bfde27e583b9b8a77a72de8b97b8/microsoft/TypeScript/pull/22340
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d9a80ab80eaaf07e35a7191e8d5253414bc8bfde27e583b9b8a77a72de8b97b8/microsoft/TypeScript/pull/22340
og:image:altUse change tracker instead of direct text edits to add // @ts-check above statements. Fixes #21355
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemhegazy
hostnamegithub.com
expected-hostnamegithub.com
Nonefa74413a1d84dac536fcca0740780bcbd3207bafec0e51873b73ff8e8cca032f
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb3b5633a74535d9c23385512d534c66c8fde1907
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/22340#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22340
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22340
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/22340
Reloadhttps://github.com/microsoft/TypeScript/pull/22340
Reloadhttps://github.com/microsoft/TypeScript/pull/22340
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests335 (335)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/pulse
https://github.com/microsoft/TypeScript
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
masterhttps://github.com/microsoft/TypeScript/tree/master
fixIgnoreMessageIndentationhttps://github.com/microsoft/TypeScript/tree/fixIgnoreMessageIndentation
Conversationhttps://github.com/microsoft/TypeScript/pull/22340
Commits9 (9)https://github.com/microsoft/TypeScript/pull/22340/commits
Checkshttps://github.com/microsoft/TypeScript/pull/22340/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/22340/files
Fix ignore message indentationhttps://github.com/microsoft/TypeScript/pull/22340#top
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
masterhttps://github.com/microsoft/TypeScript/tree/master
fixIgnoreMessageIndentationhttps://github.com/microsoft/TypeScript/tree/fixIgnoreMessageIndentation
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Mar 5, 2018https://github.com/microsoft/TypeScript/pull/22340#issue-302445508
#21355https://github.com/microsoft/TypeScript/issues/21355
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22340
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
March 1, 2018 14:33https://github.com/microsoft/TypeScript/pull/22340#commits-pushed-e51d0a7
https://github.com/mhegazy
Update baselines for user testshttps://github.com/microsoft/TypeScript/pull/22340/commits/e51d0a7ed8224dce073cc9fbbaf4507e9a9fc446
e51d0a7https://github.com/microsoft/TypeScript/pull/22340/commits/e51d0a7ed8224dce073cc9fbbaf4507e9a9fc446
https://github.com/mhegazy
Merge branch 'master' ofhttps://github.com/microsoft/TypeScript/pull/22340/commits/b032bb359b9a9e62901dc9ec4136d5fcef688771
https://github.com/Microsoft/TypeScripthttps://github.com/Microsoft/TypeScript
b032bb3https://github.com/microsoft/TypeScript/pull/22340/commits/b032bb359b9a9e62901dc9ec4136d5fcef688771
https://github.com/mhegazy
Merge branch 'master' ofhttps://github.com/microsoft/TypeScript/pull/22340/commits/ffc9c89746bf93f24c4d02c8f66e8fdb12c5316d
https://github.com/Microsoft/TypeScripthttps://github.com/Microsoft/TypeScript
ffc9c89https://github.com/microsoft/TypeScript/pull/22340/commits/ffc9c89746bf93f24c4d02c8f66e8fdb12c5316d
https://github.com/mhegazy
Add explicit indentationhttps://github.com/microsoft/TypeScript/pull/22340/commits/1b5629bfa84c974fe892959f0d4f427a0fd1247f
1b5629bhttps://github.com/microsoft/TypeScript/pull/22340/commits/1b5629bfa84c974fe892959f0d4f427a0fd1247f
https://github.com/mhegazy
Fixhttps://github.com/microsoft/TypeScript/pull/22340/commits/2e5bf3694bd4b834bd3e064c4aa0e151ae722d98
#21355https://github.com/microsoft/TypeScript/issues/21355
: Formathttps://github.com/microsoft/TypeScript/pull/22340/commits/2e5bf3694bd4b834bd3e064c4aa0e151ae722d98
// @ts-ignorehttps://github.com/microsoft/TypeScript/pull/22340/commits/2e5bf3694bd4b834bd3e064c4aa0e151ae722d98
added by quick fixhttps://github.com/microsoft/TypeScript/pull/22340/commits/2e5bf3694bd4b834bd3e064c4aa0e151ae722d98
2e5bf36https://github.com/microsoft/TypeScript/pull/22340/commits/2e5bf3694bd4b834bd3e064c4aa0e151ae722d98
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
March 5, 2018 20:19https://github.com/microsoft/TypeScript/pull/22340#event-1505016870
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Mar 5, 2018 https://github.com/microsoft/TypeScript/pull/22340#pullrequestreview-101336255
View reviewed changes https://github.com/microsoft/TypeScript/pull/22340/files/2e5bf3694bd4b834bd3e064c4aa0e151ae722d98
src/services/codefixes/disableJsDiagnostics.tshttps://github.com/microsoft/TypeScript/pull/22340/files/2e5bf3694bd4b834bd3e064c4aa0e151ae722d98#diff-a6a2ecf796a8d04af838d924028f1bcf00ed0e1c9a549719ec0b379f0f8716be
Deleted user (ghost)https://github.com/ghost
Mar 5, 2018https://github.com/microsoft/TypeScript/pull/22340#discussion_r172335959
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22340
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Mar 5, 2018https://github.com/microsoft/TypeScript/pull/22340#discussion_r172349846
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22340
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Mar 5, 2018https://github.com/microsoft/TypeScript/pull/22340#discussion_r172352180
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22340
src/services/codefixes/disableJsDiagnostics.tshttps://github.com/microsoft/TypeScript/pull/22340/files/2e5bf3694bd4b834bd3e064c4aa0e151ae722d98#diff-a6a2ecf796a8d04af838d924028f1bcf00ed0e1c9a549719ec0b379f0f8716be
Deleted user (ghost)https://github.com/ghost
Mar 5, 2018https://github.com/microsoft/TypeScript/pull/22340#discussion_r172336212
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22340
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Mar 5, 2018https://github.com/microsoft/TypeScript/pull/22340#discussion_r172349276
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22340
Deleted user (ghost)https://github.com/ghost
Mar 5, 2018https://github.com/microsoft/TypeScript/pull/22340#discussion_r172352821
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22340
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Mar 5, 2018https://github.com/microsoft/TypeScript/pull/22340#discussion_r172364583
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22340
src/services/codefixes/disableJsDiagnostics.tshttps://github.com/microsoft/TypeScript/pull/22340/files/2e5bf3694bd4b834bd3e064c4aa0e151ae722d98#diff-a6a2ecf796a8d04af838d924028f1bcf00ed0e1c9a549719ec0b379f0f8716be
Deleted user (ghost)https://github.com/ghost
Mar 5, 2018https://github.com/microsoft/TypeScript/pull/22340#discussion_r172336767
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#20574https://github.com/microsoft/TypeScript/pull/20574
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22340
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Mar 5, 2018https://github.com/microsoft/TypeScript/pull/22340#discussion_r172351839
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22340
Deleted user (ghost)https://github.com/ghost
Mar 5, 2018https://github.com/microsoft/TypeScript/pull/22340#discussion_r172353019
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22340
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22340
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
March 5, 2018 14:32https://github.com/microsoft/TypeScript/pull/22340#commits-pushed-9a8705b
https://github.com/mhegazy
Extract check to a separate functionhttps://github.com/microsoft/TypeScript/pull/22340/commits/9a8705b9bfe27f33fcb48f288555f00b49123619
9a8705bhttps://github.com/microsoft/TypeScript/pull/22340/commits/9a8705b9bfe27f33fcb48f288555f00b49123619
https://github.com/mhegazy
Consolidate checking for valid insert locationhttps://github.com/microsoft/TypeScript/pull/22340/commits/81e6b84e8fbc83f30bc69804d4b37326dd43d264
81e6b84https://github.com/microsoft/TypeScript/pull/22340/commits/81e6b84e8fbc83f30bc69804d4b37326dd43d264
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 6, 2018 https://github.com/microsoft/TypeScript/pull/22340#pullrequestreview-101456125
View reviewed changes https://github.com/microsoft/TypeScript/pull/22340/files/81e6b84e8fbc83f30bc69804d4b37326dd43d264
src/services/textChanges.tshttps://github.com/microsoft/TypeScript/pull/22340/files/81e6b84e8fbc83f30bc69804d4b37326dd43d264#diff-386d93db50a938da0c4af7bb293ac679b5da235cebeeee9adbc040fbf8aa222c
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 6, 2018https://github.com/microsoft/TypeScript/pull/22340#discussion_r172442420
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22340
https://github.com/mhegazy
Code review commentshttps://github.com/microsoft/TypeScript/pull/22340/commits/f4902275447758b12bfd4280872eda4850d471f2
f490227https://github.com/microsoft/TypeScript/pull/22340/commits/f4902275447758b12bfd4280872eda4850d471f2
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Mar 6, 2018 https://github.com/microsoft/TypeScript/pull/22340#pullrequestreview-101672705
View reviewed changes https://github.com/microsoft/TypeScript/pull/22340/files/f4902275447758b12bfd4280872eda4850d471f2
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Mar 6, 2018 https://github.com/microsoft/TypeScript/pull/22340#pullrequestreview-101672888
View reviewed changes https://github.com/microsoft/TypeScript/pull/22340/files/f4902275447758b12bfd4280872eda4850d471f2
src/services/codefixes/disableJsDiagnostics.tshttps://github.com/microsoft/TypeScript/pull/22340/files/f4902275447758b12bfd4280872eda4850d471f2#diff-a6a2ecf796a8d04af838d924028f1bcf00ed0e1c9a549719ec0b379f0f8716be
Deleted user (ghost)https://github.com/ghost
Mar 6, 2018https://github.com/microsoft/TypeScript/pull/22340#discussion_r172623698
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22340
https://github.com/mhegazy
Do not return makeChangehttps://github.com/microsoft/TypeScript/pull/22340/commits/acc0783a40c5a02d3d3d5363790fad8156440482
acc0783https://github.com/microsoft/TypeScript/pull/22340/commits/acc0783a40c5a02d3d3d5363790fad8156440482
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
b2dd610https://github.com/microsoft/TypeScript/commit/b2dd610e92ca9f68f24f589f727459b586fc5d43
Mar 6, 2018https://github.com/microsoft/TypeScript/pull/22340#event-1507413372
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
March 6, 2018 20:19https://github.com/microsoft/TypeScript/pull/22340#event-1507413532
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Mar 9, 2018 https://github.com/microsoft/TypeScript/pull/22340#ref-pullrequest-303912375
Merge master into release-2.8 #22442 https://github.com/microsoft/TypeScript/pull/22442
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 25, 2018https://github.com/microsoft/TypeScript/pull/22340#event-1753421448
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F22340
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
https://github.com/microsoft/TypeScript/pull/22340/files/81e6b84e8fbc83f30bc69804d4b37326dd43d264
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22340
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/22340
https://github.com/mhegazy
https://github.com/DanielRosenwasser
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.