| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:de358978-2fc0-f525-c972-7787e128ecf0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8C40:10D9F8:1C6C88E:2550FB4:6B015130 |
| html-safe-nonce | 0e13e71ee4a43d73b48a31552924626e89da33f9e57e8bf3853a1df465d4b770 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzQwOjEwRDlGODoxQzZDODhFOjI1NTBGQjQ6NkIwMTUxMzAiLCJ2aXNpdG9yX2lkIjoiODU5NzIwMTM4MjEwNzMzNzAwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 03c25674ef7105c15baa36d9f4e352aa30a4a50f6700edf376cc881fc6944324 |
| hovercard-subject-tag | pull_request:30614224 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/2218/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6a1e902bc47b72dea0881a3a99a53d029a70e3c8e16e5438325a8a0beb57ccf5/microsoft/TypeScript/pull/2218 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6a1e902bc47b72dea0881a3a99a53d029a70e3c8e16e5438325a8a0beb57ccf5/microsoft/TypeScript/pull/2218 |
| og:image:alt | Conservative fix for a crash in the navbar and adding instrumentation for a better fix.
TypeError: Unable to get property 'localeCompare' of undefined or null reference
at Anonymous functio... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | paulvanbrenk |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/2218#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F2218 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F2218 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/2218 |
| Reload | https://github.com/microsoft/TypeScript/pull/2218 |
| Reload | https://github.com/microsoft/TypeScript/pull/2218 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests312 (312) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Paul van Brenk (paulvanbrenk) | https://github.com/paulvanbrenk |
| master | https://github.com/microsoft/TypeScript/tree/master |
| sortNodesNavBarFix | https://github.com/microsoft/TypeScript/tree/sortNodesNavBarFix |
| Conversation | https://github.com/microsoft/TypeScript/pull/2218 |
| Commits2 (2) | https://github.com/microsoft/TypeScript/pull/2218/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/2218/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/2218/files |
| Add assert for unexpected syntaxkind and a conservative temporary fix. | https://github.com/microsoft/TypeScript/pull/2218#top |
| Paul van Brenk (paulvanbrenk) | https://github.com/paulvanbrenk |
| master | https://github.com/microsoft/TypeScript/tree/master |
| sortNodesNavBarFix | https://github.com/microsoft/TypeScript/tree/sortNodesNavBarFix |
|
| https://github.com/paulvanbrenk |
| Paul van Brenk (paulvanbrenk) | https://github.com/paulvanbrenk |
| Mar 6, 2015 | https://github.com/microsoft/TypeScript/pull/2218#issue-60046420 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/2218 |
| Add assert for unexpected syntaxkind and a conservative temporary fix. | https://github.com/microsoft/TypeScript/pull/2218/commits/b5d9fa5dd6d6f35b95bd4d7440f5aca169b13f0b |
| b5d9fa5 | https://github.com/microsoft/TypeScript/pull/2218/commits/b5d9fa5dd6d6f35b95bd4d7440f5aca169b13f0b |
| https://github.com/msftclas |
| Microsoft Contribution License Agreements (msftclas) | https://github.com/msftclas |
|
cla-not-required
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required |
| Mar 6, 2015 | https://github.com/microsoft/TypeScript/pull/2218#event-247241636 |
| Add checks so we don't crash on undefined in the asserts. | https://github.com/microsoft/TypeScript/pull/2218/commits/839d92f766020477a9a67dbfca74fdef17c7e1ba |
| 839d92f | https://github.com/microsoft/TypeScript/pull/2218/commits/839d92f766020477a9a67dbfca74fdef17c7e1ba |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Mar 6, 2015 | https://github.com/microsoft/TypeScript/pull/2218#issuecomment-77510583 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/2218 |
| https://github.com/vladima |
| Vladimir Matveev (vladima) | https://github.com/vladima |
| Mar 6, 2015 | https://github.com/microsoft/TypeScript/pull/2218#issuecomment-77512230 |
| 11f589f | https://github.com/microsoft/TypeScript/commit/11f589f03b87d8e52371fc9cca1e680eb16de17e |
| f4ca318 | https://github.com/microsoft/TypeScript/commit/f4ca318c39ca4181fb331c2b03980524359c0572 |
| b05f2bf | https://github.com/microsoft/TypeScript/commit/b05f2bf1a3ebbd0a1967c63d5cd6852d396f4bad |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/2218 |
| https://github.com/paulvanbrenk |
| Paul van Brenk (paulvanbrenk) | https://github.com/paulvanbrenk |
| Mar 6, 2015 | https://github.com/microsoft/TypeScript/pull/2218#issuecomment-77625721 |
| Daniel Rosenwasser (@DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Vladimir Matveev (@vladima) | https://github.com/vladima |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/2218 |
| https://github.com/paulvanbrenk |
| Paul van Brenk (paulvanbrenk) | https://github.com/paulvanbrenk |
| Mar 6, 2015 | https://github.com/microsoft/TypeScript/pull/2218#event-247749785 |
| https://github.com/paulvanbrenk |
| Paul van Brenk (paulvanbrenk) | https://github.com/paulvanbrenk |
| April 29, 2015 01:49 | https://github.com/microsoft/TypeScript/pull/2218#event-292605938 |
|
Salsa doesn't show any outline for this source code
#6644
| https://github.com/microsoft/TypeScript/issues/6644 |
|
Salsa is weird around assigning twice to the same member
#6645
| https://github.com/microsoft/TypeScript/issues/6645 |
|
JSDoc does not appear to work for ES6 class ctors
#6646
| https://github.com/microsoft/TypeScript/issues/6646 |
|
Salsa cross TS-JS find all references does not work
#6647
| https://github.com/microsoft/TypeScript/issues/6647 |
|
Salsa: renaming in TypeScript does not rename in JavaScript
#6648
| https://github.com/microsoft/TypeScript/issues/6648 |
|
Should not suggest "caller" in strict mode as it causes TypeError
#6649
| https://github.com/microsoft/TypeScript/issues/6649 |
|
Salsa duplicate literal properties cause should be flagged only when in strict mode
#6650
| https://github.com/microsoft/TypeScript/issues/6650 |
|
Salsa does not flag ReferenceErrors in strict mode
#6652
| https://github.com/microsoft/TypeScript/issues/6652 |
|
Should not place errors on comments
#6653
| https://github.com/microsoft/TypeScript/issues/6653 |
|
Salsa: "Implicit globals" leak into member completions but not global completions?
#6654
| https://github.com/microsoft/TypeScript/issues/6654 |
|
Salsa does not warn or help when passing in wrong argument type
#6658
| https://github.com/microsoft/TypeScript/issues/6658 |
|
Salsa does not use JSDoc all the way in type inference
#6659
| https://github.com/microsoft/TypeScript/issues/6659 |
|
Salsa does not use JSDoc all the way in type inference
#6660
| https://github.com/microsoft/TypeScript/issues/6660 |
|
Salsa does not understand parameters with properties JSDoc
#6661
| https://github.com/microsoft/TypeScript/issues/6661 |
|
Salsa does not show doc comment when I have "@returns" in it?
#6662
| https://github.com/microsoft/TypeScript/issues/6662 |
|
Salsa type inference should find or types
#6663
| https://github.com/microsoft/TypeScript/issues/6663 |
|
Salsa does not highlight object properties across methods
#6664
| https://github.com/microsoft/TypeScript/issues/6664 |
|
Salsa unreachable code detected is not so smart
#6665
| https://github.com/microsoft/TypeScript/issues/6665 |
|
Salsa formatting gives overlapping edits in this case
#6666
| https://github.com/microsoft/TypeScript/issues/6666 |
|
Formatting honours tab vs spaces setting only sometimes?
#6667
| https://github.com/microsoft/TypeScript/issues/6667 |
|
Salsa type inference could pass through argument types
#6668
| https://github.com/microsoft/TypeScript/issues/6668 |
|
Salsa could show warning messages on require statements if it is not configured with a module system
#6669
| https://github.com/microsoft/TypeScript/issues/6669 |
|
[Salsa] load .js files from node packages
#6670
| https://github.com/microsoft/TypeScript/issues/6670 |
|
[0.10.7-insider] Salsa does not honor JSDoc for object methods
#6825
| https://github.com/microsoft/TypeScript/issues/6825 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Jun 18, 2018 | https://github.com/microsoft/TypeScript/pull/2218#event-1686924084 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F2218 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/2218 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/2218 |
|
| https://github.com/paulvanbrenk |
|
| https://github.com/DanielRosenwasser |
|
| https://github.com/vladima |
|
| https://github.com/msftclas |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |