René's URL Explorer Experiment


Title: Just map type variables to constraints at certain positions for narrowing so that we do not map primitives by weswigham · Pull Request #21384 · microsoft/TypeScript · GitHub

Open Graph Title: Just map type variables to constraints at certain positions for narrowing so that we do not map primitives by weswigham · Pull Request #21384 · microsoft/TypeScript

X Title: Just map type variables to constraints at certain positions for narrowing so that we do not map primitives by weswigham · Pull Request #21384 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Just map type variables to constraints at certain positions for narrowing so that we do not map primitives by weswigham · Pull Request #21384 · microsoft/TypeScript

Open Graph Description: Fixes #21360 getApparentTypeForLocation (which is how we enabled this, similarly to how we've made guards on this.foo.bar work when this.foo is an indexed access type) uses getAparrentType. Th...

X Description: Fixes #21360 getApparentTypeForLocation (which is how we enabled this, similarly to how we've made guards on this.foo.bar work when this.foo is an indexed access type) uses getAparrentType...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/21384

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c5fcbbf7-f4f9-ee53-fb6f-fc85f54bbd74
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDAC0:3F8A67:E83227:136EA16:6B010BBD
html-safe-nonce1e97900be0f2f43028407f450726d5eb87733aaa285fa14df5e271a9e387ac79
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUMwOjNGOEE2NzpFODMyMjc6MTM2RUExNjo2QjAxMEJCRCIsInZpc2l0b3JfaWQiOiI3NjYwODA0ODY0MTEyMzk3MjQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac06380aa0e9629bca55a47f1451b9029171cd6390683905b204b1a77731ebdf7b
hovercard-subject-tagpull_request:164747887
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/21384/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/381b20d8e0d3fe7af0df711d954ada0dfbeaf3efc055a1806d1a6ad08673e33e/microsoft/TypeScript/pull/21384
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/381b20d8e0d3fe7af0df711d954ada0dfbeaf3efc055a1806d1a6ad08673e33e/microsoft/TypeScript/pull/21384
og:image:altFixes #21360 getApparentTypeForLocation (which is how we enabled this, similarly to how we've made guards on this.foo.bar work when this.foo is an indexed access type) uses getAparrentType. Th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/21384#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F21384
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F21384
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/21384
Reloadhttps://github.com/microsoft/TypeScript/pull/21384
Reloadhttps://github.com/microsoft/TypeScript/pull/21384
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests310 (310)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:use-trimmed-apparent-logichttps://github.com/weswigham/TypeScript/tree/use-trimmed-apparent-logic
Conversationhttps://github.com/microsoft/TypeScript/pull/21384
Commits4 (4)https://github.com/microsoft/TypeScript/pull/21384/commits
Checkshttps://github.com/microsoft/TypeScript/pull/21384/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/21384/files
Just map type variables to constraints at certain positions for narrowing so that we do not map primitiveshttps://github.com/microsoft/TypeScript/pull/21384#top
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:use-trimmed-apparent-logichttps://github.com/weswigham/TypeScript/tree/use-trimmed-apparent-logic
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 24, 2018https://github.com/microsoft/TypeScript/pull/21384#issue-291071948
#21360https://github.com/microsoft/TypeScript/issues/21360
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21384
https://github.com/weswigham
Use a limited version of getApparentType that doesnt map primitiveshttps://github.com/microsoft/TypeScript/pull/21384/commits/34e2ae6498d902fe9ffd86ceacdae65e000acf2e
34e2ae6https://github.com/microsoft/TypeScript/pull/21384/commits/34e2ae6498d902fe9ffd86ceacdae65e000acf2e
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
January 24, 2018 03:23https://github.com/microsoft/TypeScript/pull/21384#event-1438702255
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jan 24, 2018 https://github.com/microsoft/TypeScript/pull/21384#pullrequestreview-91233693
View reviewed changes https://github.com/microsoft/TypeScript/pull/21384/files/34e2ae6498d902fe9ffd86ceacdae65e000acf2e
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/21384#pullrequestreview-91233693
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21384
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/21384/files/34e2ae6498d902fe9ffd86ceacdae65e000acf2e#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jan 24, 2018https://github.com/microsoft/TypeScript/pull/21384#discussion_r163595927
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21384
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 24, 2018https://github.com/microsoft/TypeScript/pull/21384#discussion_r163606434
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21384
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 24, 2018https://github.com/microsoft/TypeScript/pull/21384#discussion_r163670452
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21384
https://github.com/weswigham
Reuse [most of] getBaseConstraintOfType, since it does the needed beh…https://github.com/microsoft/TypeScript/pull/21384/commits/70cfc5d265e9c81871069e8d2c9051655d125a38
70cfc5dhttps://github.com/microsoft/TypeScript/pull/21384/commits/70cfc5d265e9c81871069e8d2c9051655d125a38
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jan 24, 2018 https://github.com/microsoft/TypeScript/pull/21384#pullrequestreview-91323691
View reviewed changes https://github.com/microsoft/TypeScript/pull/21384/files/70cfc5d265e9c81871069e8d2c9051655d125a38
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/21384/files/70cfc5d265e9c81871069e8d2c9051655d125a38#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jan 24, 2018https://github.com/microsoft/TypeScript/pull/21384#discussion_r163672451
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21384
https://github.com/weswigham
Move new function next to the very similar functionhttps://github.com/microsoft/TypeScript/pull/21384/commits/27dc9853e681f8cf40d069880e56d9efa7222dff
27dc985https://github.com/microsoft/TypeScript/pull/21384/commits/27dc9853e681f8cf40d069880e56d9efa7222dff
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 24, 2018https://github.com/microsoft/TypeScript/pull/21384#event-1440404539
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
force-pushedhttps://github.com/microsoft/TypeScript/compare/a0cb0a316ff0bdc27ec7c5f0a2ca77bd97fd7dd2..e3a3b9a917a29ca324628ad67ab5512885d0d228
a0cb0a3https://github.com/microsoft/TypeScript/commit/a0cb0a316ff0bdc27ec7c5f0a2ca77bd97fd7dd2
e3a3b9ahttps://github.com/microsoft/TypeScript/commit/e3a3b9a917a29ca324628ad67ab5512885d0d228
Compare https://github.com/microsoft/TypeScript/compare/a0cb0a316ff0bdc27ec7c5f0a2ca77bd97fd7dd2..e3a3b9a917a29ca324628ad67ab5512885d0d228
February 8, 2018 00:56https://github.com/microsoft/TypeScript/pull/21384#event-1463619387
https://github.com/weswigham
Merge branch 'master' into use-trimmed-apparent-logichttps://github.com/microsoft/TypeScript/pull/21384/commits/68e594a32ad96b2c2cb4d36d46fd90be234363aa
68e594ahttps://github.com/microsoft/TypeScript/pull/21384/commits/68e594a32ad96b2c2cb4d36d46fd90be234363aa
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
force-pushedhttps://github.com/microsoft/TypeScript/compare/e3a3b9a917a29ca324628ad67ab5512885d0d228..68e594a32ad96b2c2cb4d36d46fd90be234363aa
e3a3b9ahttps://github.com/microsoft/TypeScript/commit/e3a3b9a917a29ca324628ad67ab5512885d0d228
68e594ahttps://github.com/microsoft/TypeScript/commit/68e594a32ad96b2c2cb4d36d46fd90be234363aa
Compare https://github.com/microsoft/TypeScript/compare/e3a3b9a917a29ca324628ad67ab5512885d0d228..68e594a32ad96b2c2cb4d36d46fd90be234363aa
February 8, 2018 01:33https://github.com/microsoft/TypeScript/pull/21384#event-1463657893
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
66fa9f6https://github.com/microsoft/TypeScript/commit/66fa9f6cd793f7df210799b7d665d05bdfa9ade1
Feb 21, 2018https://github.com/microsoft/TypeScript/pull/21384#event-1485600265
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
February 21, 2018 20:51https://github.com/microsoft/TypeScript/pull/21384#event-1485600406
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 3, 2018https://github.com/microsoft/TypeScript/pull/21384#event-1712806619
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F21384
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/21384/files/70cfc5d265e9c81871069e8d2c9051655d125a38
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21384
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21384
https://github.com/weswigham
https://github.com/sandersn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.