| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3d40768c-5503-1d0c-5713-2e5524bbef90 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9572:A7C8F:B497C3:E93A85:6B00E77C |
| html-safe-nonce | 9cf863537eebe50426481d84f42a70e717755acc6d8f89ffe5a9f9d6dab7448d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTcyOkE3QzhGOkI0OTdDMzpFOTNBODU6NkIwMEU3N0MiLCJ2aXNpdG9yX2lkIjoiNjIzNjYwOTYxMzAyMjY4NTA1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 25918c00097395969f4405d33dea02c6b42c071287d921f6a0348c7cc992b571 |
| hovercard-subject-tag | pull_request:164013611 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/21298/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8ed330e8ea6fd186750cb0e77f5f69c14338eeb950d0024014919231f031e524/microsoft/TypeScript/pull/21298 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8ed330e8ea6fd186750cb0e77f5f69c14338eeb950d0024014919231f031e524/microsoft/TypeScript/pull/21298 |
| og:image:alt | Fixes #21288
Discovered #21297
This will not fix the issue if it is written like:
interface ResultA { kind: "success", code: number }
interface ResultB { kind: "failure", messag... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14 |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 624179fb8b88d26ba5bba08894eb60a1c5a1d93d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/21298#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F21298 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F21298 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/21298 |
| Reload | https://github.com/microsoft/TypeScript/pull/21298 |
| Reload | https://github.com/microsoft/TypeScript/pull/21298 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests308 (308) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| master | https://github.com/microsoft/TypeScript/tree/master |
| findAllRefsUnionProperty | https://github.com/microsoft/TypeScript/tree/findAllRefsUnionProperty |
| Conversation | https://github.com/microsoft/TypeScript/pull/21298 |
| Commits2 (2) | https://github.com/microsoft/TypeScript/pull/21298/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/21298/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/21298/files |
| For { type: "a" } | { type: "b" }, find references for the union property | https://github.com/microsoft/TypeScript/pull/21298#top |
| master | https://github.com/microsoft/TypeScript/tree/master |
| findAllRefsUnionProperty | https://github.com/microsoft/TypeScript/tree/findAllRefsUnionProperty |
|
| https://github.com/ghost |
| Deleted user (ghost) | https://github.com/ghost |
| Jan 19, 2018 | https://github.com/microsoft/TypeScript/pull/21298#issue-290034402 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/21298 |
| #21288 | https://github.com/microsoft/TypeScript/issues/21288 |
| #21297 | https://github.com/microsoft/TypeScript/issues/21297 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/21298 |
| For { type: "a" } | { type: "b" }, find references for the union pr… | https://github.com/microsoft/TypeScript/pull/21298/commits/257a9b035a2fee1e07eeed4b793aa76924c027ad |
| 257a9b0 | https://github.com/microsoft/TypeScript/pull/21298/commits/257a9b035a2fee1e07eeed4b793aa76924c027ad |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| Armando Aguirre (armanio123) | https://github.com/armanio123 |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| January 19, 2018 16:34 | https://github.com/microsoft/TypeScript/pull/21298#event-1432795044 |
| https://github.com/sheetalkamat |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
|
Jan 19, 2018
| https://github.com/microsoft/TypeScript/pull/21298#pullrequestreview-90201118 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/21298/files/257a9b035a2fee1e07eeed4b793aa76924c027ad |
| src/services/findAllReferences.ts | https://github.com/microsoft/TypeScript/pull/21298/files/257a9b035a2fee1e07eeed4b793aa76924c027ad#diff-4f7d18dd83dde2a81734d434c3453bdc53c60e4209a5f8b78f5b03e4a9e7c556 |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| Jan 19, 2018 | https://github.com/microsoft/TypeScript/pull/21298#discussion_r162695956 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/21298 |
| Deleted user (ghost) | https://github.com/ghost |
| Jan 19, 2018 | https://github.com/microsoft/TypeScript/pull/21298#discussion_r162698615 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/21298 |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| Jan 19, 2018 | https://github.com/microsoft/TypeScript/pull/21298#discussion_r162732152 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/21298 |
| Deleted user (ghost) | https://github.com/ghost |
| Jan 19, 2018 | https://github.com/microsoft/TypeScript/pull/21298#discussion_r162743861 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/21298 |
| https://github.com/RyanCavanaugh |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
|
Jan 19, 2018
| https://github.com/microsoft/TypeScript/pull/21298#pullrequestreview-90201612 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/21298/files/257a9b035a2fee1e07eeed4b793aa76924c027ad |
| https://github.com/ghost |
| Deleted user (ghost) | https://github.com/ghost |
| Jan 19, 2018 | https://github.com/microsoft/TypeScript/pull/21298#issuecomment-359051981 |
| Sheetal Nandi (@sheetalkamat) | https://github.com/sheetalkamat |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/21298 |
| Merge branch 'master' into findAllRefsUnionProperty | https://github.com/microsoft/TypeScript/pull/21298/commits/f33290172b990d0c98c12976a04a57e22ddd4ff5 |
| f332901 | https://github.com/microsoft/TypeScript/pull/21298/commits/f33290172b990d0c98c12976a04a57e22ddd4ff5 |
| https://github.com/sheetalkamat |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
|
Jan 19, 2018
| https://github.com/microsoft/TypeScript/pull/21298#pullrequestreview-90271317 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/21298/files/f33290172b990d0c98c12976a04a57e22ddd4ff5 |
| 6224d51 | https://github.com/microsoft/TypeScript/commit/6224d51f84cc2daf07e2ba69ed3392dfa8b96fec |
| Jan 20, 2018 | https://github.com/microsoft/TypeScript/pull/21298#event-1433457679 |
| January 20, 2018 00:04 | https://github.com/microsoft/TypeScript/pull/21298#event-1433457710 |
| Albert Siddhartha Slawinski (errendir) | https://github.com/errendir |
|
Jan 20, 2018
| https://github.com/microsoft/TypeScript/pull/21298#ref-commit-bff2f37 |
|
| https://github.com/errendir |
| Merge remote-tracking branch 'origin/master' into faster-interface-check | https://github.com/errendir/TypeScript/commit/bff2f37b3ddc6235de53da9a493f80a24dd6ca7b |
| bff2f37 | https://github.com/errendir/TypeScript/commit/bff2f37b3ddc6235de53da9a493f80a24dd6ca7b |
| microsoft#20875 | https://github.com/microsoft/TypeScript/issues/20875 |
| microsoft#20884 | https://github.com/microsoft/TypeScript/pull/20884 |
| microsoft#21257 | https://github.com/microsoft/TypeScript/pull/21257 |
| microsoft#20995 | https://github.com/microsoft/TypeScript/pull/20995 |
| microsoft#21298 | https://github.com/microsoft/TypeScript/pull/21298 |
| microsoft#21304 | https://github.com/microsoft/TypeScript/pull/21304 |
| microsoft#21302 | https://github.com/microsoft/TypeScript/pull/21302 |
| microsoft#21300 | https://github.com/microsoft/TypeScript/pull/21300 |
| microsoft#21291 | https://github.com/microsoft/TypeScript/pull/21291 |
| microsoft#21286 | https://github.com/microsoft/TypeScript/pull/21286 |
| microsoft#21276 | https://github.com/microsoft/TypeScript/pull/21276 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Jul 3, 2018 | https://github.com/microsoft/TypeScript/pull/21298#event-1712806307 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F21298 |
|
| https://github.com/armanio123 |
|
Armando Aguirre (armanio123)
| https://github.com/armanio123 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/21298 |
|
Renaming the discrimnant of a union should always rename all occurrences
| https://github.com/microsoft/TypeScript/issues/21288 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/21298 |
|
| https://github.com/RyanCavanaugh |
|
| https://github.com/sheetalkamat |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |