René's URL Explorer Experiment


Title: Fix indexed access relation by sandersn · Pull Request #21242 · microsoft/TypeScript · GitHub

Open Graph Title: Fix indexed access relation by sandersn · Pull Request #21242 · microsoft/TypeScript

X Title: Fix indexed access relation by sandersn · Pull Request #21242 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix indexed access relation by sandersn · Pull Request #21242 · microsoft/TypeScript

Open Graph Description: Fixes #21185 Previously, structuredTypeRelatedTo only checked the object types of an index access type, and only if the index types were identical. Now both checks call isRelatedTo recursively. Bef...

X Description: Fixes #21185 Previously, structuredTypeRelatedTo only checked the object types of an index access type, and only if the index types were identical. Now both checks call isRelatedTo recursively. Bef...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/21242

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:da23ccd6-5742-ed38-2980-f8b55221c66e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8024:EA09B:A88A5F:E12B9D:6B00EE65
html-safe-nonce5d914d5964b502e7a7884c17bdcfe6ed024765750ea11b209753af49bb73af70
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDI0OkVBMDlCOkE4OEE1RjpFMTJCOUQ6NkIwMEVFNjUiLCJ2aXNpdG9yX2lkIjoiMjM3MDk2OTg1OTI3MDk2Mjc4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1675d286167467bdc1112d7a65a74392c195b844a81af15774f5db0746b71e38
hovercard-subject-tagpull_request:163557438
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/21242/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2423b3ed358ec82cfc8c064d509e194ee13564c725a2d9a081a7e84fa14d178d/microsoft/TypeScript/pull/21242
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2423b3ed358ec82cfc8c064d509e194ee13564c725a2d9a081a7e84fa14d178d/microsoft/TypeScript/pull/21242
og:image:altFixes #21185 Previously, structuredTypeRelatedTo only checked the object types of an index access type, and only if the index types were identical. Now both checks call isRelatedTo recursively. Bef...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/21242#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F21242
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F21242
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/21242
Reloadhttps://github.com/microsoft/TypeScript/pull/21242
Reloadhttps://github.com/microsoft/TypeScript/pull/21242
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
fix-indexed-access-relationhttps://github.com/microsoft/TypeScript/tree/fix-indexed-access-relation
Conversationhttps://github.com/microsoft/TypeScript/pull/21242
Commits2 (2)https://github.com/microsoft/TypeScript/pull/21242/commits
Checkshttps://github.com/microsoft/TypeScript/pull/21242/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/21242/files
Fix indexed access relationhttps://github.com/microsoft/TypeScript/pull/21242#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
fix-indexed-access-relationhttps://github.com/microsoft/TypeScript/tree/fix-indexed-access-relation
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jan 17, 2018https://github.com/microsoft/TypeScript/pull/21242#issue-289420121
#21185https://github.com/microsoft/TypeScript/issues/21185
#17912https://github.com/microsoft/TypeScript/pull/17912
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21242
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
January 17, 2018 13:21https://github.com/microsoft/TypeScript/pull/21242#commits-pushed-5c88929
https://github.com/sandersn
Indexed access relation check object+index typeshttps://github.com/microsoft/TypeScript/pull/21242/commits/5c889299f4ddb4ba53b704a423da01e2d21275b9
5c88929https://github.com/microsoft/TypeScript/pull/21242/commits/5c889299f4ddb4ba53b704a423da01e2d21275b9
https://github.com/sandersn
Test assignability of indexed access typeshttps://github.com/microsoft/TypeScript/pull/21242/commits/485ec34e8ed7d3240acc567c2287dd822ca2aea8
485ec34https://github.com/microsoft/TypeScript/pull/21242/commits/485ec34e8ed7d3240acc567c2287dd822ca2aea8
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Wesley Wigham (weswigham)https://github.com/weswigham
January 17, 2018 21:29https://github.com/microsoft/TypeScript/pull/21242#event-1429196506
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jan 17, 2018 https://github.com/microsoft/TypeScript/pull/21242#ref-issue-288478398
Spurious "A type predicate's type must be assignable to its parameter's type" #21185 https://github.com/microsoft/TypeScript/issues/21185
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jan 18, 2018https://github.com/microsoft/TypeScript/pull/21242#issuecomment-358502316
#17912https://github.com/microsoft/TypeScript/pull/17912
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21242
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 18, 2018 https://github.com/microsoft/TypeScript/pull/21242#pullrequestreview-89657590
View reviewed changes https://github.com/microsoft/TypeScript/pull/21242/files/485ec34e8ed7d3240acc567c2287dd822ca2aea8
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 18, 2018https://github.com/microsoft/TypeScript/pull/21242#issuecomment-358518895
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21242
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jan 18, 2018https://github.com/microsoft/TypeScript/pull/21242#issuecomment-358694268
Wesley Wigham (@weswigham)https://github.com/weswigham
#17912https://github.com/microsoft/TypeScript/pull/17912
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21242
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jan 18, 2018https://github.com/microsoft/TypeScript/pull/21242#issuecomment-358747360
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21242
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Jan 19, 2018 https://github.com/microsoft/TypeScript/pull/21242#pullrequestreview-90245548
View reviewed changes https://github.com/microsoft/TypeScript/pull/21242/files/485ec34e8ed7d3240acc567c2287dd822ca2aea8
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
4632ed6https://github.com/microsoft/TypeScript/commit/4632ed6dda7dbf3b4cfb48b968946a5554acbf10
Jan 19, 2018https://github.com/microsoft/TypeScript/pull/21242#event-1433253031
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
January 19, 2018 21:13https://github.com/microsoft/TypeScript/pull/21242#event-1433253098
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 3, 2018https://github.com/microsoft/TypeScript/pull/21242#event-1712806110
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F21242
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/21242/files/485ec34e8ed7d3240acc567c2287dd822ca2aea8
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
https://github.com/microsoft/TypeScript/pull/21242/files/485ec34e8ed7d3240acc567c2287dd822ca2aea8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21242
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21242
https://github.com/sandersn
https://github.com/weswigham
https://github.com/ahejlsberg
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.