René's URL Explorer Experiment


Title: Fixes var declaration shadowing in async functions by rbuckton · Pull Request #21215 · microsoft/TypeScript · GitHub

Open Graph Title: Fixes var declaration shadowing in async functions by rbuckton · Pull Request #21215 · microsoft/TypeScript

X Title: Fixes var declaration shadowing in async functions by rbuckton · Pull Request #21215 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fixes var declaration shadowing in async functions by rbuckton · Pull Request #21215 · microsoft/TypeScript

Open Graph Description: This fixes an issue where the downlevel emit for async functions to ES2015 can result in incorrect runtime semantics when the async function body contains a var declaration that shadows a parameter...

X Description: This fixes an issue where the downlevel emit for async functions to ES2015 can result in incorrect runtime semantics when the async function body contains a var declaration that shadows a parameter...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/21215

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:31790fac-9684-5c95-851a-c0ef67819773
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC58:2BE220:2A838F3:38C1E0B:6B01C538
html-safe-noncefd9d456a79b7546ed28b377e3cd79a273cfb3d7be71c59c67b0159ec21180cab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzU4OjJCRTIyMDoyQTgzOEYzOjM4QzFFMEI6NkIwMUM1MzgiLCJ2aXNpdG9yX2lkIjoiMjY3NzUyNzEzMTQ1NzcwMTE3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9b92c39e2c6bd7c366a6e4adeeed258580481b905c21b086eb6127428da32395
hovercard-subject-tagpull_request:163310498
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/21215/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/90aaae7c81404f6af9f0b680c15f7eab58f7fc301bbe6517db5586317be6e76d/microsoft/TypeScript/pull/21215
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/90aaae7c81404f6af9f0b680c15f7eab58f7fc301bbe6517db5586317be6e76d/microsoft/TypeScript/pull/21215
og:image:altThis fixes an issue where the downlevel emit for async functions to ES2015 can result in incorrect runtime semantics when the async function body contains a var declaration that shadows a parameter...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerbuckton
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/21215#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F21215
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F21215
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/21215
Reloadhttps://github.com/microsoft/TypeScript/pull/21215
Reloadhttps://github.com/microsoft/TypeScript/pull/21215
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Ron Buckton (rbuckton)https://github.com/rbuckton
masterhttps://github.com/microsoft/TypeScript/tree/master
fix20461https://github.com/microsoft/TypeScript/tree/fix20461
Conversationhttps://github.com/microsoft/TypeScript/pull/21215
Commits6 (6)https://github.com/microsoft/TypeScript/pull/21215/commits
Checkshttps://github.com/microsoft/TypeScript/pull/21215/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/21215/files
Fixes var declaration shadowing in async functionshttps://github.com/microsoft/TypeScript/pull/21215#top
Ron Buckton (rbuckton)https://github.com/rbuckton
masterhttps://github.com/microsoft/TypeScript/tree/master
fix20461https://github.com/microsoft/TypeScript/tree/fix20461
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Jan 16, 2018https://github.com/microsoft/TypeScript/pull/21215#issue-289086744
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21215
#20461https://github.com/microsoft/TypeScript/issues/20461
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21215
https://github.com/rbuckton
Fixes var declaration shadowing in async functionshttps://github.com/microsoft/TypeScript/pull/21215/commits/136c4d0dda5a381957f14b6c63456d2766053108
136c4d0https://github.com/microsoft/TypeScript/pull/21215/commits/136c4d0dda5a381957f14b6c63456d2766053108
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Wesley Wigham (weswigham)https://github.com/weswigham
January 16, 2018 23:04https://github.com/microsoft/TypeScript/pull/21215#event-1427230555
https://github.com/rbuckton
Remove duplicate implementationshttps://github.com/microsoft/TypeScript/pull/21215/commits/c4fddba0a9459c3ff0582ae787004368b9f063ef
c4fddbahttps://github.com/microsoft/TypeScript/pull/21215/commits/c4fddba0a9459c3ff0582ae787004368b9f063ef
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 17, 2018 https://github.com/microsoft/TypeScript/pull/21215#pullrequestreview-89347769
View reviewed changes https://github.com/microsoft/TypeScript/pull/21215/files/c4fddba0a9459c3ff0582ae787004368b9f063ef
src/compiler/transformers/es2017.tshttps://github.com/microsoft/TypeScript/pull/21215/files/c4fddba0a9459c3ff0582ae787004368b9f063ef#diff-6b17ef3d8b015bd4fedd243c73729c84b448a8376cd725743e65fb2a92b04874
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 17, 2018https://github.com/microsoft/TypeScript/pull/21215#discussion_r161972973
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21215
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
the statement and declaration listhttps://tc39.github.io/ecma262/#sec-ecmascript-language-statements-and-declarations
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21215
Ron Buckton (rbuckton)https://github.com/rbuckton
Jan 17, 2018https://github.com/microsoft/TypeScript/pull/21215#discussion_r162149204
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21215
Ron Buckton (rbuckton)https://github.com/rbuckton
Jan 17, 2018https://github.com/microsoft/TypeScript/pull/21215#discussion_r162154517
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
2ba29d8https://github.com/microsoft/TypeScript/commit/2ba29d8d9d923d99b828a999b99c47db9cd1184f
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21215
https://github.com/ajafff
Klaus Meinhardt (ajafff)https://github.com/ajafff
Jan 17, 2018 https://github.com/microsoft/TypeScript/pull/21215#pullrequestreview-89389975
View reviewed changes https://github.com/microsoft/TypeScript/pull/21215/files/c4fddba0a9459c3ff0582ae787004368b9f063ef
src/compiler/transformers/es2017.tshttps://github.com/microsoft/TypeScript/pull/21215/files/c4fddba0a9459c3ff0582ae787004368b9f063ef#diff-6b17ef3d8b015bd4fedd243c73729c84b448a8376cd725743e65fb2a92b04874
Klaus Meinhardt (ajafff)https://github.com/ajafff
Jan 17, 2018https://github.com/microsoft/TypeScript/pull/21215#discussion_r162008973
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21215
Ron Buckton (rbuckton)https://github.com/rbuckton
Jan 17, 2018https://github.com/microsoft/TypeScript/pull/21215#discussion_r162150294
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21215
Ron Buckton (rbuckton)https://github.com/rbuckton
Jan 17, 2018https://github.com/microsoft/TypeScript/pull/21215#discussion_r162153961
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
e655446https://github.com/microsoft/TypeScript/commit/e655446318dbbdcf2dab1a232d607d5f1f89351c
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21215
Ron Buckton (rbuckton)https://github.com/rbuckton
January 17, 2018 11:24https://github.com/microsoft/TypeScript/pull/21215#commits-pushed-2ba29d8
https://github.com/rbuckton
Support labeled statementhttps://github.com/microsoft/TypeScript/pull/21215/commits/2ba29d8d9d923d99b828a999b99c47db9cd1184f
2ba29d8https://github.com/microsoft/TypeScript/pull/21215/commits/2ba29d8d9d923d99b828a999b99c47db9cd1184f
https://github.com/rbuckton
Add test for catch block without variablehttps://github.com/microsoft/TypeScript/pull/21215/commits/e655446318dbbdcf2dab1a232d607d5f1f89351c
e655446https://github.com/microsoft/TypeScript/pull/21215/commits/e655446318dbbdcf2dab1a232d607d5f1f89351c
https://github.com/rbuckton
Namespaces do not have the same 'var' scopehttps://github.com/microsoft/TypeScript/pull/21215/commits/afaa13947576c828b418d89fa67301df039d500d
afaa139https://github.com/microsoft/TypeScript/pull/21215/commits/afaa13947576c828b418d89fa67301df039d500d
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 17, 2018 https://github.com/microsoft/TypeScript/pull/21215#pullrequestreview-89564542
View reviewed changes https://github.com/microsoft/TypeScript/pull/21215/files/e655446318dbbdcf2dab1a232d607d5f1f89351c
Wesley Wigham (weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21215
https://github.com/microsoft/TypeScript/pull/21215#pullrequestreview-89564542
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21215
src/compiler/transformers/es2017.tshttps://github.com/microsoft/TypeScript/pull/21215/files/e655446318dbbdcf2dab1a232d607d5f1f89351c#diff-6b17ef3d8b015bd4fedd243c73729c84b448a8376cd725743e65fb2a92b04874
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 17, 2018https://github.com/microsoft/TypeScript/pull/21215#discussion_r162156331
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21215
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21215
https://github.com/rbuckton
PR Feedbackhttps://github.com/microsoft/TypeScript/pull/21215/commits/5b45db790729508553016572a5cddb8e806bc214
5b45db7https://github.com/microsoft/TypeScript/pull/21215/commits/5b45db790729508553016572a5cddb8e806bc214
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
3c988e8https://github.com/microsoft/TypeScript/commit/3c988e8f5ab4ee3aa8cd8bfb350dd3915b96662f
Jan 17, 2018https://github.com/microsoft/TypeScript/pull/21215#event-1429160202
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
January 17, 2018 21:08https://github.com/microsoft/TypeScript/pull/21215#event-1429160410
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 3, 2018https://github.com/microsoft/TypeScript/pull/21215#event-1712806025
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F21215
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/21215/files/e655446318dbbdcf2dab1a232d607d5f1f89351c
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
https://github.com/ajafff
Klaus Meinhardt (ajafff) https://github.com/ajafff
https://github.com/microsoft/TypeScript/pull/21215/files/c4fddba0a9459c3ff0582ae787004368b9f063ef
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21215
Async function __awaiter allows var declarations to clobber function parameters https://github.com/microsoft/TypeScript/issues/20461
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21215
https://github.com/rbuckton
https://github.com/weswigham
https://github.com/ajafff
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.