René's URL Explorer Experiment


Title: Fix recursive mapped type infinite recursion by sandersn · Pull Request #21134 · microsoft/TypeScript · GitHub

Open Graph Title: Fix recursive mapped type infinite recursion by sandersn · Pull Request #21134 · microsoft/TypeScript

X Title: Fix recursive mapped type infinite recursion by sandersn · Pull Request #21134 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix recursive mapped type infinite recursion by sandersn · Pull Request #21134 · microsoft/TypeScript

Open Graph Description: Fixes #17847 isGenericMappedType indirectly calls getResolvedBaseConstraint, but is called indirectly from inside getResolvedBaseConstraint. This avoids the circularity check in getResolvedBaseCons...

X Description: Fixes #17847 isGenericMappedType indirectly calls getResolvedBaseConstraint, but is called indirectly from inside getResolvedBaseConstraint. This avoids the circularity check in getResolvedBaseCons...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/21134

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:38a7cfaf-1b2c-1ff6-d46b-c2a8a8304748
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9560:11EACE:1E5AFDC:287C6EE:6B017194
html-safe-nonce56e2f4fa8db7a9cfb79cf7c40c48bd705ebbf2d9b2dda3ad5d35c36b2278d635
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTYwOjExRUFDRToxRTVBRkRDOjI4N0M2RUU6NkIwMTcxOTQiLCJ2aXNpdG9yX2lkIjoiNTg0MDU5NDU5NzMzMTQzMTgyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac31f6c8dfc6bb0d3c3f7906903c8443e08c7b8a87acdeb8409760f869813da8c2
hovercard-subject-tagpull_request:162260441
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/21134/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0a8826d08f994c069c503b135dfd84e0481e047d0bc6a14d11264b43722b9fcd/microsoft/TypeScript/pull/21134
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0a8826d08f994c069c503b135dfd84e0481e047d0bc6a14d11264b43722b9fcd/microsoft/TypeScript/pull/21134
og:image:altFixes #17847 isGenericMappedType indirectly calls getResolvedBaseConstraint, but is called indirectly from inside getResolvedBaseConstraint. This avoids the circularity check in getResolvedBaseCons...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/21134#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F21134
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F21134
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/21134
Reloadhttps://github.com/microsoft/TypeScript/pull/21134
Reloadhttps://github.com/microsoft/TypeScript/pull/21134
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
fix-recursive-mapped-type-infinite-recursionhttps://github.com/microsoft/TypeScript/tree/fix-recursive-mapped-type-infinite-recursion
Conversationhttps://github.com/microsoft/TypeScript/pull/21134
Commits5 (5)https://github.com/microsoft/TypeScript/pull/21134/commits
Checkshttps://github.com/microsoft/TypeScript/pull/21134/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/21134/files
Fix recursive mapped type infinite recursionhttps://github.com/microsoft/TypeScript/pull/21134#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
fix-recursive-mapped-type-infinite-recursionhttps://github.com/microsoft/TypeScript/tree/fix-recursive-mapped-type-infinite-recursion
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jan 10, 2018https://github.com/microsoft/TypeScript/pull/21134#issue-287617680
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21134
#17847https://github.com/microsoft/TypeScript/issues/17847
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21134
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
January 10, 2018 15:40https://github.com/microsoft/TypeScript/pull/21134#commits-pushed-f0ef9a0
https://github.com/sandersn
getConstraintOfTypeParameter:check circularity in base constrainthttps://github.com/microsoft/TypeScript/pull/21134/commits/f0ef9a08d86ae92815559e66c8ceb63a6c953830
f0ef9a0https://github.com/microsoft/TypeScript/pull/21134/commits/f0ef9a08d86ae92815559e66c8ceb63a6c953830
https://github.com/sandersn
Test:incorrect mapped type doesn't infinitely recurhttps://github.com/microsoft/TypeScript/pull/21134/commits/c0dd832e468aa60f18a538cd2d9fe8d8e7ec4bc7
c0dd832https://github.com/microsoft/TypeScript/pull/21134/commits/c0dd832e468aa60f18a538cd2d9fe8d8e7ec4bc7
https://github.com/sandersn
Merge branch 'master' into fix-recursive-mapped-type-infinite-recursionhttps://github.com/microsoft/TypeScript/pull/21134/commits/7f8ec15edd8ec99b9fdba3c1a3935d33e54b6d39
7f8ec15https://github.com/microsoft/TypeScript/pull/21134/commits/7f8ec15edd8ec99b9fdba3c1a3935d33e54b6d39
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Wesley Wigham (weswigham)https://github.com/weswigham
January 10, 2018 23:50https://github.com/microsoft/TypeScript/pull/21134#event-1418786649
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
January 11, 2018 10:07https://github.com/microsoft/TypeScript/pull/21134#commits-pushed-16a8003
https://github.com/sandersn
push/popTypeResolution for circular base constraintshttps://github.com/microsoft/TypeScript/pull/21134/commits/16a80030117e00f4ab046db5a2d1ff009ddebccb
16a8003https://github.com/microsoft/TypeScript/pull/21134/commits/16a80030117e00f4ab046db5a2d1ff009ddebccb
https://github.com/sandersn
Update baselineshttps://github.com/microsoft/TypeScript/pull/21134/commits/2b630e9ea5002b5a5bf7219d32e71e26e4e56a82
2b630e9https://github.com/microsoft/TypeScript/pull/21134/commits/2b630e9ea5002b5a5bf7219d32e71e26e4e56a82
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jan 11, 2018https://github.com/microsoft/TypeScript/pull/21134#issuecomment-357013388
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21134
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 11, 2018 https://github.com/microsoft/TypeScript/pull/21134#pullrequestreview-88258504
View reviewed changes https://github.com/microsoft/TypeScript/pull/21134/files/2b630e9ea5002b5a5bf7219d32e71e26e4e56a82
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
658de7fhttps://github.com/microsoft/TypeScript/commit/658de7f80eb96f5b59eb7eea3bd678ba84d9c078
Jan 11, 2018https://github.com/microsoft/TypeScript/pull/21134#event-1420330214
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
January 11, 2018 18:24https://github.com/microsoft/TypeScript/pull/21134#event-1420330318
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 3, 2018https://github.com/microsoft/TypeScript/pull/21134#event-1712805682
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F21134
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/21134/files/2b630e9ea5002b5a5bf7219d32e71e26e4e56a82
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21134
Stack overflow with incorrect mapped type as constraint of type parameter https://github.com/microsoft/TypeScript/issues/17847
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/21134
https://github.com/sandersn
https://github.com/weswigham
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.