René's URL Explorer Experiment


Title: Fix isTypeOfExpression in compiler API (#20875). by tehwalris · Pull Request #20884 · microsoft/TypeScript · GitHub

Open Graph Title: Fix isTypeOfExpression in compiler API (#20875). by tehwalris · Pull Request #20884 · microsoft/TypeScript

X Title: Fix isTypeOfExpression in compiler API (#20875). by tehwalris · Pull Request #20884 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix isTypeOfExpression in compiler API (#20875). by tehwalris · Pull Request #20884 · microsoft/TypeScript

Open Graph Description: Fixes #20875. Does it make sense to write a test for this sort of change? If yes, could someone point me towards a similar trivial test against the public API?

X Description: Fixes #20875. Does it make sense to write a test for this sort of change? If yes, could someone point me towards a similar trivial test against the public API?

Opengraph URL: https://github.com/microsoft/TypeScript/pull/20884

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:13850c02-d9ad-c728-b63c-a800b3aad39b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9568:76F02:A7A356:D94EB0:6B00E77C
html-safe-nonce4414f76382ad95d662e1077b6fc928eda2405cccdad31e35d42668ff1ede3117
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTY4Ojc2RjAyOkE3QTM1NjpEOTRFQjA6NkIwMEU3N0MiLCJ2aXNpdG9yX2lkIjoiMTI3ODUzNTA5MjA1ODI1MzE4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb8437c5dce52404983100ab21e9c83a5308412ee2df8273ead25a37c0a5db751
hovercard-subject-tagpull_request:159994457
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/20884/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/529aa0682a613b5192cce5d1c234943f41d22cb1ee0f1556607569a93d33a167/microsoft/TypeScript/pull/20884
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/529aa0682a613b5192cce5d1c234943f41d22cb1ee0f1556607569a93d33a167/microsoft/TypeScript/pull/20884
og:image:altFixes #20875. Does it make sense to write a test for this sort of change? If yes, could someone point me towards a similar trivial test against the public API?
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametehwalris
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/20884#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F20884
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F20884
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/20884
Reloadhttps://github.com/microsoft/TypeScript/pull/20884
Reloadhttps://github.com/microsoft/TypeScript/pull/20884
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
tehwalris:masterhttps://github.com/tehwalris/TypeScript/tree/master
Conversationhttps://github.com/microsoft/TypeScript/pull/20884
Commits1 (1)https://github.com/microsoft/TypeScript/pull/20884/commits
Checkshttps://github.com/microsoft/TypeScript/pull/20884/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/20884/files
Fix isTypeOfExpression in compiler API (#20875).https://github.com/microsoft/TypeScript/pull/20884#top
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
tehwalris:masterhttps://github.com/tehwalris/TypeScript/tree/master
https://github.com/tehwalris
Philippe Voinov (tehwalris)https://github.com/tehwalris
Dec 24, 2017https://github.com/microsoft/TypeScript/pull/20884#issue-284353729
#20875https://github.com/microsoft/TypeScript/issues/20875
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20884
https://github.com/tehwalris
Fix isTypeOfExpression in compiler API (https://github.com/microsoft/TypeScript/pull/20884/commits/a16e87f17240892163ad8878c6d1f973ad7a072b
microsoft#20875https://github.com/microsoft/TypeScript/issues/20875
).https://github.com/microsoft/TypeScript/pull/20884/commits/a16e87f17240892163ad8878c6d1f973ad7a072b
a16e87fhttps://github.com/microsoft/TypeScript/pull/20884/commits/a16e87f17240892163ad8878c6d1f973ad7a072b
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Dec 26, 2017https://github.com/microsoft/TypeScript/pull/20884#issuecomment-354013830
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20884
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20884
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Jan 20, 2018https://github.com/microsoft/TypeScript/pull/20884#event-1433513885
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Jan 20, 2018https://github.com/microsoft/TypeScript/pull/20884#event-1433513908
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
a7c53c7https://github.com/microsoft/TypeScript/commit/a7c53c70d2d74520483a892eb3e9ca55daf655cf
Jan 20, 2018https://github.com/microsoft/TypeScript/pull/20884#event-1433514357
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Jan 20, 2018https://github.com/microsoft/TypeScript/pull/20884#issuecomment-359133939
Philippe Voinov (@tehwalris)https://github.com/tehwalris
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20884
Albert Siddhartha Slawinski (errendir)https://github.com/errendir
Jan 20, 2018 https://github.com/microsoft/TypeScript/pull/20884#ref-commit-bff2f37
https://github.com/errendir
Merge remote-tracking branch 'origin/master' into faster-interface-checkhttps://github.com/errendir/TypeScript/commit/bff2f37b3ddc6235de53da9a493f80a24dd6ca7b
bff2f37https://github.com/errendir/TypeScript/commit/bff2f37b3ddc6235de53da9a493f80a24dd6ca7b
microsoft#20875https://github.com/microsoft/TypeScript/issues/20875
microsoft#20884https://github.com/microsoft/TypeScript/pull/20884
microsoft#21257https://github.com/microsoft/TypeScript/pull/21257
microsoft#20995https://github.com/microsoft/TypeScript/pull/20995
microsoft#21298https://github.com/microsoft/TypeScript/pull/21298
microsoft#21304https://github.com/microsoft/TypeScript/pull/21304
microsoft#21302https://github.com/microsoft/TypeScript/pull/21302
microsoft#21300https://github.com/microsoft/TypeScript/pull/21300
microsoft#21291https://github.com/microsoft/TypeScript/pull/21291
microsoft#21286https://github.com/microsoft/TypeScript/pull/21286
microsoft#21276https://github.com/microsoft/TypeScript/pull/21276
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 3, 2018https://github.com/microsoft/TypeScript/pull/20884#event-1712804774
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F20884
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20884
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20884
https://github.com/tehwalris
https://github.com/DanielRosenwasser
https://github.com/mhegazy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.