René's URL Explorer Experiment


Title: Make ChangeTracker#newLineCharacter public, to avoid having to pass newLineCharacter around as a parameter · Pull Request #20574 · microsoft/TypeScript · GitHub

Open Graph Title: Make ChangeTracker#newLineCharacter public, to avoid having to pass newLineCharacter around as a parameter · Pull Request #20574 · microsoft/TypeScript

X Title: Make ChangeTracker#newLineCharacter public, to avoid having to pass newLineCharacter around as a parameter · Pull Request #20574 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Make ChangeTracker#newLineCharacter public, to avoid having to pass newLineCharacter around as a parameter · Pull Request #20574 · microsoft/TypeScript

Open Graph Description: Noticed in many code fixes that we have functions with both a ChangeTracker and newLineCharacter as parameters. ChangeTracker already stores newLineCharacter as a property, so we can just make that...

X Description: Noticed in many code fixes that we have functions with both a ChangeTracker and newLineCharacter as parameters. ChangeTracker already stores newLineCharacter as a property, so we can just make that...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/20574

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b2b3c350-a9a8-1c94-76f2-79bf05eed55f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD9C:2F15DD:10B1E:16D86:6AFBF65F
html-safe-noncebf8c61a2b3dbce15c148783e4c93631002cfda30dee12fc227eac87e46a2602a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDlDOjJGMTVERDoxMEIxRToxNkQ4Njo2QUZCRjY1RiIsInZpc2l0b3JfaWQiOiIxNjUxOTQxMjMyMzk5MzQ5MzQzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5db0a92ee6ee1f1f6ec10eb94e11a98c1d325ee8596fac80b828b322b294854a
hovercard-subject-tagpull_request:157263716
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/20574/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/896e6fcbb4a57466818a633ac20117dd9b1640ed4bfa52b4af07e6a608bc1588/microsoft/TypeScript/pull/20574
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/896e6fcbb4a57466818a633ac20117dd9b1640ed4bfa52b4af07e6a608bc1588/microsoft/TypeScript/pull/20574
og:image:altNoticed in many code fixes that we have functions with both a ChangeTracker and newLineCharacter as parameters. ChangeTracker already stores newLineCharacter as a property, so we can just make that...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonefa74413a1d84dac536fcca0740780bcbd3207bafec0e51873b73ff8e8cca032f
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb3b5633a74535d9c23385512d534c66c8fde1907
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/20574#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F20574
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F20574
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/20574
Reloadhttps://github.com/microsoft/TypeScript/pull/20574
Reloadhttps://github.com/microsoft/TypeScript/pull/20574
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests335 (335)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/pulse
https://github.com/microsoft/TypeScript
masterhttps://github.com/microsoft/TypeScript/tree/master
changeTracker_newLineCharacterhttps://github.com/microsoft/TypeScript/tree/changeTracker_newLineCharacter
Conversationhttps://github.com/microsoft/TypeScript/pull/20574
Commits2 (2)https://github.com/microsoft/TypeScript/pull/20574/commits
Checkshttps://github.com/microsoft/TypeScript/pull/20574/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/20574/files
Make ChangeTracker#newLineCharacter public, to avoid having to pass newLineCharacter around as a parameterhttps://github.com/microsoft/TypeScript/pull/20574#top
masterhttps://github.com/microsoft/TypeScript/tree/master
changeTracker_newLineCharacterhttps://github.com/microsoft/TypeScript/tree/changeTracker_newLineCharacter
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Dec 8, 2017https://github.com/microsoft/TypeScript/pull/20574#issue-280518851
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20574
Make ChangeTracker#newLineCharacter public, to avoid having to pass n…https://github.com/microsoft/TypeScript/pull/20574/commits/c3bdd2a963101d0d79f489b25decae2b1b5f8130
c3bdd2ahttps://github.com/microsoft/TypeScript/pull/20574/commits/c3bdd2a963101d0d79f489b25decae2b1b5f8130
Andrew Casey (amcasey)https://github.com/amcasey
December 8, 2017 15:09https://github.com/microsoft/TypeScript/pull/20574#event-1378986187
https://github.com/amcasey
Andrew Casey (amcasey)https://github.com/amcasey
Dec 8, 2017https://github.com/microsoft/TypeScript/pull/20574#issuecomment-350373747
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20574
Don't require newLineCharacter as input to ChangeTracker methods, and…https://github.com/microsoft/TypeScript/pull/20574/commits/9b769ccc61b7916281755df6db67d794a11697f1
9b769cchttps://github.com/microsoft/TypeScript/pull/20574/commits/9b769ccc61b7916281755df6db67d794a11697f1
force-pushedhttps://github.com/microsoft/TypeScript/compare/1b86c76e9f8c82a8e29f567b23ba1b752d1ca56c..9b769ccc61b7916281755df6db67d794a11697f1
1b86c76https://github.com/microsoft/TypeScript/commit/1b86c76e9f8c82a8e29f567b23ba1b752d1ca56c
9b769cchttps://github.com/microsoft/TypeScript/commit/9b769ccc61b7916281755df6db67d794a11697f1
Compare https://github.com/microsoft/TypeScript/compare/1b86c76e9f8c82a8e29f567b23ba1b752d1ca56c..9b769ccc61b7916281755df6db67d794a11697f1
December 11, 2017 22:50https://github.com/microsoft/TypeScript/pull/20574#event-1382479362
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Dec 11, 2017https://github.com/microsoft/TypeScript/pull/20574#issuecomment-350885327
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20574
https://github.com/amcasey
Andrew Casey (amcasey)https://github.com/amcasey
Dec 12, 2017 https://github.com/microsoft/TypeScript/pull/20574#pullrequestreview-82944973
View reviewed changes https://github.com/microsoft/TypeScript/pull/20574/files/9b769ccc61b7916281755df6db67d794a11697f1
Andrew Casey (amcasey)https://github.com/amcasey
https://github.com/microsoft/TypeScript/pull/20574#pullrequestreview-82944973
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20574
8ad4aeehttps://github.com/microsoft/TypeScript/commit/8ad4aeece15477e1b869b45bbedbf217a219ba5c
Dec 12, 2017https://github.com/microsoft/TypeScript/pull/20574#event-1384355638
December 12, 2017 20:23https://github.com/microsoft/TypeScript/pull/20574#event-1384355728
Mar 5, 2018 https://github.com/microsoft/TypeScript/pull/20574#ref-pullrequest-302445508
Fix ignore message indentation #22340 https://github.com/microsoft/TypeScript/pull/22340
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 14, 2018https://github.com/microsoft/TypeScript/pull/20574#event-1682109245
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F20574
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20574
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20574
https://github.com/amcasey
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.