René's URL Explorer Experiment


Title: Limit recursive structured type resolution by sandersn · Pull Request #20400 · microsoft/TypeScript · GitHub

Open Graph Title: Limit recursive structured type resolution by sandersn · Pull Request #20400 · microsoft/TypeScript

X Title: Limit recursive structured type resolution by sandersn · Pull Request #20400 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Limit recursive structured type resolution by sandersn · Pull Request #20400 · microsoft/TypeScript

Open Graph Description: Fixes #20330 Fixes #20772 It sets empty structured type members immediately so that recursive calls to resolveStructuredTypeMembers will never proceed. Edit: This change now mimics the behaviour of...

X Description: Fixes #20330 Fixes #20772 It sets empty structured type members immediately so that recursive calls to resolveStructuredTypeMembers will never proceed. Edit: This change now mimics the behaviour of...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/20400

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5b9105c3-8d6b-e118-7194-c2aa3b665646
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8634:785A9:A6DA2E:D4D388:6B00F3CF
html-safe-noncee43f94b923fcc340f25f34d2e1b4a2d883a86ea20060dd31ae85307d2a96d77c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjM0Ojc4NUE5OkE2REEyRTpENEQzODg6NkIwMEYzQ0YiLCJ2aXNpdG9yX2lkIjoiNDk3OTE3NDk4ODQxNTMwMDU1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac23ee9bf35963c6eb9ce6ec0ee81643e31e26fcbb86a21926306b158aa398c903
hovercard-subject-tagpull_request:155978260
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/20400/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/99b76d79b7906a0306de312958b135235a1bd4c35b6d1f369d72902de59d251d/microsoft/TypeScript/pull/20400
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/99b76d79b7906a0306de312958b135235a1bd4c35b6d1f369d72902de59d251d/microsoft/TypeScript/pull/20400
og:image:altFixes #20330 Fixes #20772 It sets empty structured type members immediately so that recursive calls to resolveStructuredTypeMembers will never proceed. Edit: This change now mimics the behaviour of...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/20400#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F20400
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F20400
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/20400
Reloadhttps://github.com/microsoft/TypeScript/pull/20400
Reloadhttps://github.com/microsoft/TypeScript/pull/20400
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
limit-recursive-structured-type-resolutionhttps://github.com/microsoft/TypeScript/tree/limit-recursive-structured-type-resolution
Conversationhttps://github.com/microsoft/TypeScript/pull/20400
Commits5 (5)https://github.com/microsoft/TypeScript/pull/20400/commits
Checkshttps://github.com/microsoft/TypeScript/pull/20400/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/20400/files
Limit recursive structured type resolutionhttps://github.com/microsoft/TypeScript/pull/20400#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
limit-recursive-structured-type-resolutionhttps://github.com/microsoft/TypeScript/tree/limit-recursive-structured-type-resolution
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Dec 1, 2017https://github.com/microsoft/TypeScript/pull/20400#issue-278624172
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20400
#20330https://github.com/microsoft/TypeScript/issues/20330
#20772https://github.com/microsoft/TypeScript/issues/20772
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20400
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
December 1, 2017 15:00https://github.com/microsoft/TypeScript/pull/20400#commits-pushed-dc24f77
https://github.com/sandersn
Limit recursive structured type resolutionhttps://github.com/microsoft/TypeScript/pull/20400/commits/dc24f77741c5be2c48b69f8b816eff75ffcb04d2
dc24f77https://github.com/microsoft/TypeScript/pull/20400/commits/dc24f77741c5be2c48b69f8b816eff75ffcb04d2
https://github.com/sandersn
Test:Mutually recursive types do not recur infinitelyhttps://github.com/microsoft/TypeScript/pull/20400/commits/7cfe6a4cdbed168fc670945a16b24cc3ae51ed93
7cfe6a4https://github.com/microsoft/TypeScript/pull/20400/commits/7cfe6a4cdbed168fc670945a16b24cc3ae51ed93
https://github.com/sandersn
Fill "empty" structured type marker with early symbolshttps://github.com/microsoft/TypeScript/pull/20400/commits/988f9ac641128cc3b201c0399332ca24fffa4bae
988f9achttps://github.com/microsoft/TypeScript/pull/20400/commits/988f9ac641128cc3b201c0399332ca24fffa4bae
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Dec 4, 2017https://github.com/microsoft/TypeScript/pull/20400#issuecomment-349114606
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20400
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Ron Buckton (rbuckton)https://github.com/rbuckton
December 4, 2017 21:39https://github.com/microsoft/TypeScript/pull/20400#event-1371435577
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
December 21, 2017 18:34https://github.com/microsoft/TypeScript/pull/20400#event-1398482604
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Dec 21, 2017 https://github.com/microsoft/TypeScript/pull/20400#ref-issue-283073759
Stack overflow in recursive type #20772 https://github.com/microsoft/TypeScript/issues/20772
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 22, 2017 https://github.com/microsoft/TypeScript/pull/20400#pullrequestreview-85383067
View reviewed changes https://github.com/microsoft/TypeScript/pull/20400/files/988f9ac641128cc3b201c0399332ca24fffa4bae
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/20400/files/988f9ac641128cc3b201c0399332ca24fffa4bae#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 22, 2017https://github.com/microsoft/TypeScript/pull/20400#discussion_r158547439
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20400
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 22, 2017https://github.com/microsoft/TypeScript/pull/20400#discussion_r158548096
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20400
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20400
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Dec 22, 2017https://github.com/microsoft/TypeScript/pull/20400#discussion_r158566546
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20400
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
December 22, 2017 14:39https://github.com/microsoft/TypeScript/pull/20400#commits-pushed-fb3042c
https://github.com/sandersn
Move recursion limiter to individual resolve* functionshttps://github.com/microsoft/TypeScript/pull/20400/commits/fb3042c3f7a26cd62f6d3c0fa9dda1729e9212c1
fb3042chttps://github.com/microsoft/TypeScript/pull/20400/commits/fb3042c3f7a26cd62f6d3c0fa9dda1729e9212c1
https://github.com/sandersn
Merge branch 'master' into limit-recursive-structured-type-resolutionhttps://github.com/microsoft/TypeScript/pull/20400/commits/2df7a89e617823314516f1201367deb78ce285ef
2df7a89https://github.com/microsoft/TypeScript/pull/20400/commits/2df7a89e617823314516f1201367deb78ce285ef
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 22, 2017 https://github.com/microsoft/TypeScript/pull/20400#pullrequestreview-85405895
View reviewed changes https://github.com/microsoft/TypeScript/pull/20400/files/2df7a89e617823314516f1201367deb78ce285ef
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
fd4ac10https://github.com/microsoft/TypeScript/commit/fd4ac106778a86bd58918a9da4877d72387845ef
Dec 22, 2017https://github.com/microsoft/TypeScript/pull/20400#event-1400211631
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
December 22, 2017 23:12https://github.com/microsoft/TypeScript/pull/20400#event-1400211660
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 21, 2018https://github.com/microsoft/TypeScript/pull/20400#event-1694517817
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F20400
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/20400/files/2df7a89e617823314516f1201367deb78ce285ef
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20400
Stack overflow in recursive type https://github.com/microsoft/TypeScript/issues/20772
Maximum call stack size exceeded https://github.com/microsoft/TypeScript/issues/20330
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/20400
https://github.com/sandersn
https://github.com/weswigham
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.