René's URL Explorer Experiment


Title: Apply isLiteralContextualType recursively for unions and intersections. by kpdonn · Pull Request #19684 · microsoft/TypeScript · GitHub

Open Graph Title: Apply isLiteralContextualType recursively for unions and intersections. by kpdonn · Pull Request #19684 · microsoft/TypeScript

X Title: Apply isLiteralContextualType recursively for unions and intersections. by kpdonn · Pull Request #19684 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Apply isLiteralContextualType recursively for unions and intersections. by kpdonn · Pull Request #19684 · microsoft/TypeScript

Open Graph Description: Fixes #19632. The issue was isLiteralContextualType was only checking for type parameters that extended a literal base type at the top level. It was already recursively checking the constituents of...

X Description: Fixes #19632. The issue was isLiteralContextualType was only checking for type parameters that extended a literal base type at the top level. It was already recursively checking the constituents of...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/19684

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:871f4ad0-e764-5406-74f3-bc6758c53b34
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8878:E5741:30A5C9:4153CA:6AFBE676
html-safe-nonce8dae075b7667cbfb6b78358530ef9690ccba7f78b9924f3a2cecb6a736921b0b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODc4OkU1NzQxOjMwQTVDOTo0MTUzQ0E6NkFGQkU2NzYiLCJ2aXNpdG9yX2lkIjoiMjg2NzcyMzY1MDcxNzE4MTU1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac603a15b50e9cf8f17dfd65c484ccadca08d7cab21b81c275c35d394018ed1814
hovercard-subject-tagpull_request:150354858
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/19684/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/849be0f2412a8e385a119806d4d8af8f252c233756e94f3259ded653adbfcd33/microsoft/TypeScript/pull/19684
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/849be0f2412a8e385a119806d4d8af8f252c233756e94f3259ded653adbfcd33/microsoft/TypeScript/pull/19684
og:image:altFixes #19632. The issue was isLiteralContextualType was only checking for type parameters that extended a literal base type at the top level. It was already recursively checking the constituents of...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekpdonn
hostnamegithub.com
expected-hostnamegithub.com
None744d4381b1c4dbd6d8736c7d7e5bbe7dc11217584e457a3555020c631764e8ec
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedf859c48a4c8b4c0009c19bb4e82101aacb4b998
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/19684#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19684
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19684
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/19684
Reloadhttps://github.com/microsoft/TypeScript/pull/19684
Reloadhttps://github.com/microsoft/TypeScript/pull/19684
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests334 (334)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/pulse
https://github.com/microsoft/TypeScript
Kevin Donnelly (kpdonn)https://github.com/kpdonn
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
kpdonn:masterhttps://github.com/kpdonn/TypeScript/tree/master
Conversationhttps://github.com/microsoft/TypeScript/pull/19684
Commits3 (3)https://github.com/microsoft/TypeScript/pull/19684/commits
Checkshttps://github.com/microsoft/TypeScript/pull/19684/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/19684/files
Apply isLiteralContextualType recursively for unions and intersections.https://github.com/microsoft/TypeScript/pull/19684#top
Kevin Donnelly (kpdonn)https://github.com/kpdonn
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
kpdonn:masterhttps://github.com/kpdonn/TypeScript/tree/master
https://github.com/kpdonn
Kevin Donnelly (kpdonn)https://github.com/kpdonn
Nov 2, 2017https://github.com/microsoft/TypeScript/pull/19684#issue-270739369
#19632https://github.com/microsoft/TypeScript/issues/19632
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19684
https://github.com/kpdonn
Apply isLiteralContextualType recursively for unions and intersections.https://github.com/microsoft/TypeScript/pull/19684/commits/2b85a29859392d6eb6edb4f5a7a6cf94392771e7
2b85a29https://github.com/microsoft/TypeScript/pull/19684/commits/2b85a29859392d6eb6edb4f5a7a6cf94392771e7
microsoft#19632https://github.com/microsoft/TypeScript/issues/19632
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
Nov 2, 2017https://github.com/microsoft/TypeScript/pull/19684#issuecomment-341497209
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19684
https://cla.opensource.microsoft.com/Microsoft/TypeScript?pullRequest=19684
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19684
https://github.com/kpdonn
Kevin Donnelly (kpdonn)https://github.com/kpdonn
Nov 2, 2017 https://github.com/microsoft/TypeScript/pull/19684#ref-issue-270168561
String literal generic not always inferred when part of union in nested object #19632 https://github.com/microsoft/TypeScript/issues/19632
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Nov 3, 2017 https://github.com/microsoft/TypeScript/pull/19684#pullrequestreview-73977597
View reviewed changes https://github.com/microsoft/TypeScript/pull/19684/files/2b85a29859392d6eb6edb4f5a7a6cf94392771e7
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/19684/files/2b85a29859392d6eb6edb4f5a7a6cf94392771e7#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Nov 3, 2017https://github.com/microsoft/TypeScript/pull/19684#discussion_r148692643
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19684
Kevin Donnelly (kpdonn)https://github.com/kpdonn
Nov 3, 2017https://github.com/microsoft/TypeScript/pull/19684#discussion_r148908849
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
#19632https://github.com/microsoft/TypeScript/issues/19632
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19684
Kevin Donnelly (kpdonn)https://github.com/kpdonn
November 3, 2017 17:31https://github.com/microsoft/TypeScript/pull/19684#commits-pushed-13bf0f5
https://github.com/kpdonn
Refactor to more closely match coding guidelines.https://github.com/microsoft/TypeScript/pull/19684/commits/13bf0f56086bc5b5c910d8a2c60e112fe4f74102
13bf0f5https://github.com/microsoft/TypeScript/pull/19684/commits/13bf0f56086bc5b5c910d8a2c60e112fe4f74102
https://github.com/kpdonn
Add additional test cases for nested union literal inference.https://github.com/microsoft/TypeScript/pull/19684/commits/b5d57a74a9c44fb49e1f74db1f4db8b741404fc2
b5d57a7https://github.com/microsoft/TypeScript/pull/19684/commits/b5d57a74a9c44fb49e1f74db1f4db8b741404fc2
https://github.com/kpdonn
Kevin Donnelly (kpdonn)https://github.com/kpdonn
Mar 1, 2018https://github.com/microsoft/TypeScript/pull/19684#issuecomment-369476793
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19684
https://github.com/kpdonn
Kevin Donnelly (kpdonn)https://github.com/kpdonn
Mar 1, 2018https://github.com/microsoft/TypeScript/pull/19684#event-1498255929
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 3, 2018https://github.com/microsoft/TypeScript/pull/19684#event-1712803230
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19684
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
https://github.com/microsoft/TypeScript/pull/19684/files/2b85a29859392d6eb6edb4f5a7a6cf94392771e7
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19684
String literal generic not always inferred when part of union in nested object https://github.com/microsoft/TypeScript/issues/19632
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19684
https://github.com/kpdonn
https://github.com/msftclas
https://github.com/mhegazy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.