René's URL Explorer Experiment


Title: Improved handling of structurally identical classes by ahejlsberg · Pull Request #19671 · microsoft/TypeScript · GitHub

Open Graph Title: Improved handling of structurally identical classes by ahejlsberg · Pull Request #19671 · microsoft/TypeScript

X Title: Improved handling of structurally identical classes by ahejlsberg · Pull Request #19671 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Improved handling of structurally identical classes by ahejlsberg · Pull Request #19671 · microsoft/TypeScript

Open Graph Description: With this PR we improve the handling of structurally identical classes in union types and instanceof expressions: Structurally identical, but distinct, class types are now preserved in union types...

X Description: With this PR we improve the handling of structurally identical classes in union types and instanceof expressions: Structurally identical, but distinct, class types are now preserved in union types...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/19671

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2b50fced-26b8-1560-1039-80fb4f6bf264
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA578:216F0D:3F40C:4E20A:6B00F17D
html-safe-nonce5cbf9860cdea4a82a44830e16bf370fb7e625b0c81b00bb827aa1243209975be
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTc4OjIxNkYwRDozRjQwQzo0RTIwQTo2QjAwRjE3RCIsInZpc2l0b3JfaWQiOiI4MDE0MTk1MTcyNjU5MjI5MDUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5dd1996673324429c10c7c3e254736f0cecedc44b9256a40bef310b65d3f4cde
hovercard-subject-tagpull_request:150164295
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/19671/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a07d31c011196695c640fcb6b9259fb8b93dd69157da65844cd2d7dbd505cd95/microsoft/TypeScript/pull/19671
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a07d31c011196695c640fcb6b9259fb8b93dd69157da65844cd2d7dbd505cd95/microsoft/TypeScript/pull/19671
og:image:altWith this PR we improve the handling of structurally identical classes in union types and instanceof expressions: Structurally identical, but distinct, class types are now preserved in union types...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameahejlsberg
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/19671#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19671
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19671
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/19671
Reloadhttps://github.com/microsoft/TypeScript/pull/19671
Reloadhttps://github.com/microsoft/TypeScript/pull/19671
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
nominalInstanceofhttps://github.com/microsoft/TypeScript/tree/nominalInstanceof
Conversationhttps://github.com/microsoft/TypeScript/pull/19671
Commits9 (9)https://github.com/microsoft/TypeScript/pull/19671/commits
Checkshttps://github.com/microsoft/TypeScript/pull/19671/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/19671/files
Improved handling of structurally identical classeshttps://github.com/microsoft/TypeScript/pull/19671#top
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
nominalInstanceofhttps://github.com/microsoft/TypeScript/tree/nominalInstanceof
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 1, 2017https://github.com/microsoft/TypeScript/pull/19671#issue-270476392
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19671
#10934https://github.com/microsoft/TypeScript/issues/10934
#11965https://github.com/microsoft/TypeScript/issues/11965
#14426https://github.com/microsoft/TypeScript/issues/14426
#15585https://github.com/microsoft/TypeScript/issues/15585
#15615https://github.com/microsoft/TypeScript/issues/15615
#17612https://github.com/microsoft/TypeScript/issues/17612
#18276https://github.com/microsoft/TypeScript/issues/18276
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19671
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
October 30, 2017 12:36https://github.com/microsoft/TypeScript/pull/19671#commits-pushed-a01df0f
https://github.com/ahejlsberg
Use nominal check in isTypeInstanceOfhttps://github.com/microsoft/TypeScript/pull/19671/commits/a01df0f20beef355f0902eb54019e7018fde5576
a01df0fhttps://github.com/microsoft/TypeScript/pull/19671/commits/a01df0f20beef355f0902eb54019e7018fde5576
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/19671/commits/d6697714629b3c204fdbadca1452480b436bd09c
d669771https://github.com/microsoft/TypeScript/pull/19671/commits/d6697714629b3c204fdbadca1452480b436bd09c
https://github.com/ahejlsberg
Use nominal checks in union type subtype reductionhttps://github.com/microsoft/TypeScript/pull/19671/commits/3d89837cfa01a25bcf432f1d7f0077932bb9ec11
3d89837https://github.com/microsoft/TypeScript/pull/19671/commits/3d89837cfa01a25bcf432f1d7f0077932bb9ec11
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/19671/commits/923e7a0614dc4dae6116508e8a86c9a7df0458fb
923e7a0https://github.com/microsoft/TypeScript/pull/19671/commits/923e7a0614dc4dae6116508e8a86c9a7df0458fb
https://github.com/ahejlsberg
Nix getBestChoiceType, [] subtyping, nominal union reduction for classeshttps://github.com/microsoft/TypeScript/pull/19671/commits/25af351014236059030ed4bc6b1c8aec2eee8978
25af351https://github.com/microsoft/TypeScript/pull/19671/commits/25af351014236059030ed4bc6b1c8aec2eee8978
https://github.com/ahejlsberg
Add type annotationhttps://github.com/microsoft/TypeScript/pull/19671/commits/7f35c8fd07c10b7e964e82b4536b5fdc85be4e73
7f35c8fhttps://github.com/microsoft/TypeScript/pull/19671/commits/7f35c8fd07c10b7e964e82b4536b5fdc85be4e73
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/19671/commits/412f3735bc03a149dce28da1173ee2b5f8fa70cf
412f373https://github.com/microsoft/TypeScript/pull/19671/commits/412f3735bc03a149dce28da1173ee2b5f8fa70cf
https://github.com/ahejlsberg
Merge branch 'master' into nominalInstanceofhttps://github.com/microsoft/TypeScript/pull/19671/commits/2a30aaff2fda4f57014a5a113daad056364df1a9
2a30aafhttps://github.com/microsoft/TypeScript/pull/19671/commits/2a30aaff2fda4f57014a5a113daad056364df1a9
https://github.com/ahejlsberg
Properly handle Object and Function typeshttps://github.com/microsoft/TypeScript/pull/19671/commits/81326ac90178a5a481412dab32fc458cb45be4e5
81326achttps://github.com/microsoft/TypeScript/pull/19671/commits/81326ac90178a5a481412dab32fc458cb45be4e5
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
November 1, 2017 22:51https://github.com/microsoft/TypeScript/pull/19671#event-1321995868
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Nov 2, 2017 https://github.com/microsoft/TypeScript/pull/19671#pullrequestreview-73969657
View reviewed changes https://github.com/microsoft/TypeScript/pull/19671/files/81326ac90178a5a481412dab32fc458cb45be4e5
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Breaking Change https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22
Nov 2, 2017https://github.com/microsoft/TypeScript/pull/19671#event-1324105256
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
TypeScript 2.7https://github.com/microsoft/TypeScript/milestone/56
Nov 2, 2017https://github.com/microsoft/TypeScript/pull/19671#event-1324105284
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
add8b49https://github.com/microsoft/TypeScript/commit/add8b492c104e0e1ef571a3e5af8654937ef87df
Nov 3, 2017https://github.com/microsoft/TypeScript/pull/19671#event-1324158390
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
November 3, 2017 00:37https://github.com/microsoft/TypeScript/pull/19671#event-1324158476
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Nov 3, 2017 https://github.com/microsoft/TypeScript/pull/19671#ref-issue-271108607
Design Meeting Notes, 11/3/2017 #19722 https://github.com/microsoft/TypeScript/issues/19722
https://github.com/drewnoakes
Drew Noakes (drewnoakes)https://github.com/drewnoakes
Nov 17, 2017 https://github.com/microsoft/TypeScript/pull/19671#ref-issue-136845222
instanceof typeguard fails if classes have similar structure #7271 https://github.com/microsoft/TypeScript/issues/7271
https://github.com/akarzazi
Adel KARZAZI (akarzazi)https://github.com/akarzazi
Nov 17, 2017https://github.com/microsoft/TypeScript/pull/19671#issuecomment-345353249
#11664https://github.com/microsoft/TypeScript/issues/11664
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19671
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Nov 17, 2017 https://github.com/microsoft/TypeScript/pull/19671#ref-issue-183233946
Wrong type narrowing when types are compatibles #11664 https://github.com/microsoft/TypeScript/issues/11664
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 19, 2017 https://github.com/microsoft/TypeScript/pull/19671#ref-issue-275156249
instanceof type guard missing deduction #20138 https://github.com/microsoft/TypeScript/issues/20138
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 29, 2017 https://github.com/microsoft/TypeScript/pull/19671#ref-issue-284291747
Destructuring assignment makes any types when it skips some elements (regression) #20872 https://github.com/microsoft/TypeScript/issues/20872
https://github.com/HerringtonDarkholme
Herrington Darkholme (HerringtonDarkholme)https://github.com/HerringtonDarkholme
Jan 2, 2018 https://github.com/microsoft/TypeScript/pull/19671#ref-issue-285273734
Incorrect 'never' type inference in TypeScript 2.6 #20952 https://github.com/microsoft/TypeScript/issues/20952
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Jan 31, 2018 https://github.com/microsoft/TypeScript/pull/19671#ref-issue-293318069
regression with private class members and loosing visibility #21516 https://github.com/microsoft/TypeScript/issues/21516
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 14, 2018https://github.com/microsoft/TypeScript/pull/19671#event-1682116209
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19671
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) https://github.com/RyanCavanaugh
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
https://github.com/microsoft/TypeScript/pull/19671/files/81326ac90178a5a481412dab32fc458cb45be4e5
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19671
Breaking Change https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22
TypeScript 2.7 https://github.com/microsoft/TypeScript/milestone/56
this subclass inference problem https://github.com/microsoft/TypeScript/issues/15615
instanceof / structural typing issue https://github.com/microsoft/TypeScript/issues/15585
'instanceof' narrowing works awkwardly with empty object types & primitives https://github.com/microsoft/TypeScript/issues/14426
instanceof type inference broken in an "if -> else if -> else if" chain https://github.com/microsoft/TypeScript/issues/11965
never incorrectly inferred with type guard https://github.com/microsoft/TypeScript/issues/10934
instanceof typeguard fails with derived classes that have unsound overrides https://github.com/microsoft/TypeScript/issues/17612
Strange warning with 'instanceof' https://github.com/microsoft/TypeScript/issues/18276
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19671
https://github.com/ahejlsberg
https://github.com/akarzazi
https://github.com/mhegazy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.