René's URL Explorer Experiment


Title: Fix assertion -- an import may come from a require() call · Pull Request #19667 · microsoft/TypeScript · GitHub

Open Graph Title: Fix assertion -- an import may come from a require() call · Pull Request #19667 · microsoft/TypeScript

X Title: Fix assertion -- an import may come from a require() call · Pull Request #19667 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix assertion -- an import may come from a require() call · Pull Request #19667 · microsoft/TypeScript

Open Graph Description: Fixes #19629

X Description: Fixes #19629

Opengraph URL: https://github.com/microsoft/TypeScript/pull/19667

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:08e4c1df-cae4-3b38-e4e1-7d8e213c6e3a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE968:92094:E6C069:13E61C2:6AFBF470
html-safe-noncefcb3b97c62800ba1fa86f1d82ff4908dacd2e69db009d3bc5b11cc9f4c55bb4e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTY4OjkyMDk0OkU2QzA2OToxM0U2MUMyOjZBRkJGNDcwIiwidmlzaXRvcl9pZCI6Ijg1MTU3OTQ2NjIxNzI5MTQ4MDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8f23d0bc96a3a9e7f8168e875571c666f430ff41798c6a3fe450e4f4cdf284bd
hovercard-subject-tagpull_request:150138388
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/19667/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4c1a02b83e87daab734088564d7b388f2020953fc62736d1da7cffc00b893c39/microsoft/TypeScript/pull/19667
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4c1a02b83e87daab734088564d7b388f2020953fc62736d1da7cffc00b893c39/microsoft/TypeScript/pull/19667
og:image:altFixes #19629
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonefa74413a1d84dac536fcca0740780bcbd3207bafec0e51873b73ff8e8cca032f
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb3b5633a74535d9c23385512d534c66c8fde1907
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/19667#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19667
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19667
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/19667
Reloadhttps://github.com/microsoft/TypeScript/pull/19667
Reloadhttps://github.com/microsoft/TypeScript/pull/19667
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests335 (335)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/pulse
https://github.com/microsoft/TypeScript
masterhttps://github.com/microsoft/TypeScript/tree/master
completionsimport_requirehttps://github.com/microsoft/TypeScript/tree/completionsimport_require
Conversationhttps://github.com/microsoft/TypeScript/pull/19667
Commits3 (3)https://github.com/microsoft/TypeScript/pull/19667/commits
Checkshttps://github.com/microsoft/TypeScript/pull/19667/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/19667/files
Fix assertion -- an import may come from a require() callhttps://github.com/microsoft/TypeScript/pull/19667#top
masterhttps://github.com/microsoft/TypeScript/tree/master
completionsimport_requirehttps://github.com/microsoft/TypeScript/tree/completionsimport_require
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Nov 1, 2017https://github.com/microsoft/TypeScript/pull/19667#issue-270442154
#19629https://github.com/microsoft/TypeScript/issues/19629
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19667
Fix assertion -- an import may come from a require() callhttps://github.com/microsoft/TypeScript/pull/19667/commits/e49f094b7ed7b650f0d9b29e707704a9ec79315a
e49f094https://github.com/microsoft/TypeScript/pull/19667/commits/e49f094b7ed7b650f0d9b29e707704a9ec79315a
Armando Aguirre (armanio123)https://github.com/armanio123
November 1, 2017 20:31https://github.com/microsoft/TypeScript/pull/19667#event-1321784243
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Nov 1, 2017 https://github.com/microsoft/TypeScript/pull/19667#pullrequestreview-73627815
View reviewed changes https://github.com/microsoft/TypeScript/pull/19667/files/e49f094b7ed7b650f0d9b29e707704a9ec79315a
tests/cases/fourslash/completionsImport_require.tshttps://github.com/microsoft/TypeScript/pull/19667/files/e49f094b7ed7b650f0d9b29e707704a9ec79315a#diff-2536b2d9b708d20e058b8d4c1bb459d235864998aed578687db1cd52acabe997
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Nov 1, 2017https://github.com/microsoft/TypeScript/pull/19667#discussion_r148392076
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19667
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Nov 1, 2017 https://github.com/microsoft/TypeScript/pull/19667#pullrequestreview-73628106
View reviewed changes https://github.com/microsoft/TypeScript/pull/19667/files/e49f094b7ed7b650f0d9b29e707704a9ec79315a
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Nov 1, 2017https://github.com/microsoft/TypeScript/pull/19667#issuecomment-341251363
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19667
Add test for import("./a")https://github.com/microsoft/TypeScript/pull/19667/commits/e23ddc63376e33c33e2a7d665ec82bb6ed00bdfe
e23ddc6https://github.com/microsoft/TypeScript/pull/19667/commits/e23ddc63376e33c33e2a7d665ec82bb6ed00bdfe
force-pushedhttps://github.com/microsoft/TypeScript/compare/2308d787a7c5eaafb461cf449a3b5503883632a8..e23ddc63376e33c33e2a7d665ec82bb6ed00bdfe
2308d78https://github.com/microsoft/TypeScript/commit/2308d787a7c5eaafb461cf449a3b5503883632a8
e23ddc6https://github.com/microsoft/TypeScript/commit/e23ddc63376e33c33e2a7d665ec82bb6ed00bdfe
Compare https://github.com/microsoft/TypeScript/compare/2308d787a7c5eaafb461cf449a3b5503883632a8..e23ddc63376e33c33e2a7d665ec82bb6ed00bdfe
November 7, 2017 03:17https://github.com/microsoft/TypeScript/pull/19667#event-1328906653
Nov 7, 2017 https://github.com/microsoft/TypeScript/pull/19667#ref-pullrequest-269620574
fix inconsistencies in import UMD code fixes adapting to module format #19572 https://github.com/microsoft/TypeScript/pull/19572
Merge branch 'master' into completionsimport_requirehttps://github.com/microsoft/TypeScript/pull/19667/commits/c4cc9757846721d4a0ff55ada370b19c31b2418a
c4cc975https://github.com/microsoft/TypeScript/pull/19667/commits/c4cc9757846721d4a0ff55ada370b19c31b2418a
2fcf8b7https://github.com/microsoft/TypeScript/commit/2fcf8b7068b5cf2ef1bd5c1929b1fb9a241f9a1f
Nov 7, 2017https://github.com/microsoft/TypeScript/pull/19667#event-1329959707
November 7, 2017 15:41https://github.com/microsoft/TypeScript/pull/19667#event-1329959851
Nov 7, 2017 https://github.com/microsoft/TypeScript/pull/19667#ref-commit-5420879
Fix assertion -- an import may come from a require() call (https://github.com/microsoft/TypeScript/commit/54208793a29f8f20992abfbf2965dabb8c451746
#19667https://github.com/microsoft/TypeScript/pull/19667
)https://github.com/microsoft/TypeScript/commit/54208793a29f8f20992abfbf2965dabb8c451746
https://github.com/microsoft/TypeScript/commit/54208793a29f8f20992abfbf2965dabb8c451746#comments
5420879https://github.com/microsoft/TypeScript/commit/54208793a29f8f20992abfbf2965dabb8c451746
Nov 7, 2017 https://github.com/microsoft/TypeScript/pull/19667#ref-pullrequest-271878632
Fix assertion -- an import may come from a require() call (#19667) #19810 https://github.com/microsoft/TypeScript/pull/19810
Aluan Haddad (aluanhaddad)https://github.com/aluanhaddad
Nov 7, 2017 https://github.com/microsoft/TypeScript/pull/19667#ref-commit-ec865b7
https://github.com/aluanhaddad
Fix assertion -- an import may come from a require() call (https://github.com/aluanhaddad/TypeScript/commit/ec865b74b150392476b77256f152221d0864db2b
microsoft#…https://github.com/microsoft/TypeScript/pull/19667
ec865b7https://github.com/aluanhaddad/TypeScript/commit/ec865b74b150392476b77256f152221d0864db2b
…19667https://github.com/microsoft/TypeScript/pull/19667
Nov 7, 2017 https://github.com/microsoft/TypeScript/pull/19667#ref-commit-45594d1
Fix assertion -- an import may come from a require() call (https://github.com/microsoft/TypeScript/commit/45594d11db14b45580cf240d4f78c335366c1dcb
#19667https://github.com/microsoft/TypeScript/pull/19667
) (https://github.com/microsoft/TypeScript/commit/45594d11db14b45580cf240d4f78c335366c1dcb
#…https://github.com/microsoft/TypeScript/pull/19810
45594d1https://github.com/microsoft/TypeScript/commit/45594d11db14b45580cf240d4f78c335366c1dcb
…19810https://github.com/microsoft/TypeScript/pull/19810
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 14, 2018https://github.com/microsoft/TypeScript/pull/19667#event-1682116251
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19667
https://github.com/armanio123
Armando Aguirre (armanio123) https://github.com/armanio123
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19667
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19667
https://github.com/mhegazy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.