René's URL Explorer Experiment


Title: In services, when overload resolution fails, create a union signature · Pull Request #19620 · microsoft/TypeScript · GitHub

Open Graph Title: In services, when overload resolution fails, create a union signature · Pull Request #19620 · microsoft/TypeScript

X Title: In services, when overload resolution fails, create a union signature · Pull Request #19620 · microsoft/TypeScript

Description: Fixes #19474 Edit: Fixes #19854 too (getUnionSignatures seems like it would be useful but it returns a Signature[] and I just want a Signature.)

Open Graph Description: Fixes #19474 Edit: Fixes #19854 too (getUnionSignatures seems like it would be useful but it returns a Signature[] and I just want a Signature.)

X Description: Fixes #19474 Edit: Fixes #19854 too (getUnionSignatures seems like it would be useful but it returns a Signature[] and I just want a Signature.)

Opengraph URL: https://github.com/microsoft/TypeScript/pull/19620

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9b192f6c-926d-e420-2e14-8c865c2fae3a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEAD4:17FB7:1B7186F:22C1409:6B018D4E
html-safe-nonce6f25bebe6f82f5d72fa14218d161769c58cfee65539f4b0b281936e59abf4a7b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUQ0OjE3RkI3OjFCNzE4NkY6MjJDMTQwOTo2QjAxOEQ0RSIsInZpc2l0b3JfaWQiOiIzOTI0Mjg3OTk3ODMwMzM1ODIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac411f0f72f9e6e352380618b66b86ccf21856db9cdb398029cfd92e3739b25c6f
hovercard-subject-tagpull_request:149910670
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/microsoft/TypeScript/pull/19620/files
twitter:imagehttps://avatars.githubusercontent.com/u/10137?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10137?s=400&v=4
og:image:altFixes #19474 Edit: Fixes #19854 too (getUnionSignatures seems like it would be useful but it returns a Signature[] and I just want a Signature.)
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/19620/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19620%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19620%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/19620/files
Reloadhttps://github.com/microsoft/TypeScript/pull/19620/files
Reloadhttps://github.com/microsoft/TypeScript/pull/19620/files
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
Deleted user (ghost)https://github.com/ghost
masterhttps://github.com/microsoft/TypeScript/tree/master
completionsCombineOverloadshttps://github.com/microsoft/TypeScript/tree/completionsCombineOverloads
Conversation 10 https://github.com/microsoft/TypeScript/pull/19620
Commits 8 https://github.com/microsoft/TypeScript/pull/19620/commits
Checks 0 https://github.com/microsoft/TypeScript/pull/19620/checks
Files changed https://github.com/microsoft/TypeScript/pull/19620/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19620/files
In services, when overload resolution fails, create a union signature https://github.com/microsoft/TypeScript/pull/19620/files#top
Show all changes 8 commits https://github.com/microsoft/TypeScript/pull/19620/files
8463d9e In services, when overload resolution fails, create a union signature Oct 31, 2017 https://github.com/microsoft/TypeScript/pull/19620/commits/8463d9e961905ab99efaca970888865477743c55
96c2085 Code review Dec 6, 2017 https://github.com/microsoft/TypeScript/pull/19620/commits/96c20857c0090ce2cf2f01b42c0d1e2165b218ad
2dec11c Merge branch 'master' into completionsCombineOverloads Dec 6, 2017 https://github.com/microsoft/TypeScript/pull/19620/commits/2dec11c6b762c81398ba45d08386d0093e7e17b5
c8f70c4 Make a bit neater Dec 6, 2017 https://github.com/microsoft/TypeScript/pull/19620/commits/c8f70c4a3ef98ab50a3f208c280a5f550ed8555f
b1d6817 Use intersection of return types Dec 6, 2017 https://github.com/microsoft/TypeScript/pull/19620/commits/b1d6817e8505d0eb66b6ffab878093790bb0755d
e91568c Always fill in type arguments in pickLongestCandidateSignature (Fixes… Dec 6, 2017 https://github.com/microsoft/TypeScript/pull/19620/commits/e91568c4d3e6fd9d486238e150aa7cb74f4adbad
e87fc88 Merge branch 'master' into completionsCombineOverloads Dec 14, 2017 https://github.com/microsoft/TypeScript/pull/19620/commits/e87fc884eee1a723ab078b8a7127a6aac65baa54
c1dd868 Disable GH#19854 fix because it has impacts many test cases Dec 18, 2017 https://github.com/microsoft/TypeScript/pull/19620/commits/c1dd868305c9c235afe0b2052406106abe01c341
Clear filters https://github.com/microsoft/TypeScript/pull/19620/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19620/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19620/files
checker.ts https://github.com/microsoft/TypeScript/pull/19620/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
core.ts https://github.com/microsoft/TypeScript/pull/19620/files#diff-8eee8edc4cdf82aaa3b0c0ba3c8c74fa80ac6d5214540a460c49fb2ee1031b25
completionsCombineOverloads.ts https://github.com/microsoft/TypeScript/pull/19620/files#diff-df859b87646d0936f675779a16b20d77957c82c808ab55243b3f147b93b99320
completionsCombineOverloads_restParameter.ts https://github.com/microsoft/TypeScript/pull/19620/files#diff-b36f3169026e438788a6e2098744b70200166446a33f1c1a7a8486a6bfef0df7
completionsCombineOverloads_returnType.ts https://github.com/microsoft/TypeScript/pull/19620/files#diff-32ae1b9337da663696fe40ab5d018bf3fb9f1e502f7da964a8310f4558113afa
quickInfo_errorSignatureFillsInTypeParameter.ts https://github.com/microsoft/TypeScript/pull/19620/files#diff-f2853c8349de5e9ce3df41446ab3a58d11d248ed50d04ce511734603a594a422
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/19620/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
View file https://github.com/microsoft/TypeScript/blob/c1dd868305c9c235afe0b2052406106abe01c341/src/compiler/checker.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/19620/{{ revealButtonHref }}
https://github.com/microsoft/TypeScript/pull/19620/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com/microsoft/TypeScript/pull/19620/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com/microsoft/TypeScript/pull/19620/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com/microsoft/TypeScript/pull/19620/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com/microsoft/TypeScript/pull/19620/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com/microsoft/TypeScript/pull/19620/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com/microsoft/TypeScript/pull/19620/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com/microsoft/TypeScript/pull/19620/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com/microsoft/TypeScript/pull/19620/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com/microsoft/TypeScript/pull/19620/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com/microsoft/TypeScript/pull/19620/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com/microsoft/TypeScript/pull/19620/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com/microsoft/TypeScript/pull/19620/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com/microsoft/TypeScript/pull/19620/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com/microsoft/TypeScript/pull/19620/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com/microsoft/TypeScript/pull/19620/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
src/compiler/core.tshttps://github.com/microsoft/TypeScript/pull/19620/files#diff-8eee8edc4cdf82aaa3b0c0ba3c8c74fa80ac6d5214540a460c49fb2ee1031b25
View file https://github.com/microsoft/TypeScript/blob/c1dd868305c9c235afe0b2052406106abe01c341/src/compiler/core.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/19620/{{ revealButtonHref }}
https://github.com/microsoft/TypeScript/pull/19620/files#diff-8eee8edc4cdf82aaa3b0c0ba3c8c74fa80ac6d5214540a460c49fb2ee1031b25
https://github.com/microsoft/TypeScript/pull/19620/files#diff-8eee8edc4cdf82aaa3b0c0ba3c8c74fa80ac6d5214540a460c49fb2ee1031b25
tests/cases/fourslash/completionsCombineOverloads.tshttps://github.com/microsoft/TypeScript/pull/19620/files#diff-df859b87646d0936f675779a16b20d77957c82c808ab55243b3f147b93b99320
View file https://github.com/microsoft/TypeScript/blob/c1dd868305c9c235afe0b2052406106abe01c341/tests/cases/fourslash/completionsCombineOverloads.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/19620/{{ revealButtonHref }}
tests/cases/fourslash/completionsCombineOverloads_restParameter.tshttps://github.com/microsoft/TypeScript/pull/19620/files#diff-b36f3169026e438788a6e2098744b70200166446a33f1c1a7a8486a6bfef0df7
View file https://github.com/microsoft/TypeScript/blob/c1dd868305c9c235afe0b2052406106abe01c341/tests/cases/fourslash/completionsCombineOverloads_restParameter.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/19620/{{ revealButtonHref }}
tests/cases/fourslash/completionsCombineOverloads_returnType.tshttps://github.com/microsoft/TypeScript/pull/19620/files#diff-32ae1b9337da663696fe40ab5d018bf3fb9f1e502f7da964a8310f4558113afa
View file https://github.com/microsoft/TypeScript/blob/c1dd868305c9c235afe0b2052406106abe01c341/tests/cases/fourslash/completionsCombineOverloads_returnType.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/19620/{{ revealButtonHref }}
tests/cases/fourslash/quickInfo_errorSignatureFillsInTypeParameter.tshttps://github.com/microsoft/TypeScript/pull/19620/files#diff-f2853c8349de5e9ce3df41446ab3a58d11d248ed50d04ce511734603a594a422
View file https://github.com/microsoft/TypeScript/blob/c1dd868305c9c235afe0b2052406106abe01c341/tests/cases/fourslash/quickInfo_errorSignatureFillsInTypeParameter.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/19620/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.