René's URL Explorer Experiment


Title: In services, when overload resolution fails, create a union signature · Pull Request #19620 · microsoft/TypeScript · GitHub

Open Graph Title: In services, when overload resolution fails, create a union signature · Pull Request #19620 · microsoft/TypeScript

X Title: In services, when overload resolution fails, create a union signature · Pull Request #19620 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - In services, when overload resolution fails, create a union signature · Pull Request #19620 · microsoft/TypeScript

Open Graph Description: Fixes #19474 Edit: Fixes #19854 too (getUnionSignatures seems like it would be useful but it returns a Signature[] and I just want a Signature.)

X Description: Fixes #19474 Edit: Fixes #19854 too (getUnionSignatures seems like it would be useful but it returns a Signature[] and I just want a Signature.)

Opengraph URL: https://github.com/microsoft/TypeScript/pull/19620

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e9ff9f27-b815-f934-6572-7030a9160314
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC7FA:1201C:219D2BC:2C9DB4D:6B018052
html-safe-nonce4b4d6595ad7462ee1e70f56eb63ad5f2d26268fa525a99c045e511fd7ebbed07
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDN0ZBOjEyMDFDOjIxOUQyQkM6MkM5REI0RDo2QjAxODA1MiIsInZpc2l0b3JfaWQiOiIxMjQ4NDUwNTM0MDcxOTU5NjM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac107ba6932cedb24396b8f099feb833e833240ba27bdc8ab53cb554fc7b1c7ae2
hovercard-subject-tagpull_request:149910670
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/19620/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/00c564924535676a820f85531b061775231e628bbe278fae3972e792de7fecf3/microsoft/TypeScript/pull/19620
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/00c564924535676a820f85531b061775231e628bbe278fae3972e792de7fecf3/microsoft/TypeScript/pull/19620
og:image:altFixes #19474 Edit: Fixes #19854 too (getUnionSignatures seems like it would be useful but it returns a Signature[] and I just want a Signature.)
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/19620#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19620
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19620
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/19620
Reloadhttps://github.com/microsoft/TypeScript/pull/19620
Reloadhttps://github.com/microsoft/TypeScript/pull/19620
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Deleted user (ghost)https://github.com/ghost
masterhttps://github.com/microsoft/TypeScript/tree/master
completionsCombineOverloadshttps://github.com/microsoft/TypeScript/tree/completionsCombineOverloads
Conversationhttps://github.com/microsoft/TypeScript/pull/19620
Commits8 (8)https://github.com/microsoft/TypeScript/pull/19620/commits
Checkshttps://github.com/microsoft/TypeScript/pull/19620/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/19620/files
In services, when overload resolution fails, create a union signaturehttps://github.com/microsoft/TypeScript/pull/19620#top
Deleted user (ghost)https://github.com/ghost
masterhttps://github.com/microsoft/TypeScript/tree/master
completionsCombineOverloadshttps://github.com/microsoft/TypeScript/tree/completionsCombineOverloads
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Oct 31, 2017https://github.com/microsoft/TypeScript/pull/19620#issue-270122459
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19620
#19474https://github.com/microsoft/TypeScript/issues/19474
#19854https://github.com/microsoft/TypeScript/issues/19854
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19620
In services, when overload resolution fails, create a union signaturehttps://github.com/microsoft/TypeScript/pull/19620/commits/8463d9e961905ab99efaca970888865477743c55
8463d9ehttps://github.com/microsoft/TypeScript/pull/19620/commits/8463d9e961905ab99efaca970888865477743c55
force-pushedhttps://github.com/microsoft/TypeScript/compare/04c7c910cc1a6e78e750404924e2b541de620271..8463d9e961905ab99efaca970888865477743c55
04c7c91https://github.com/microsoft/TypeScript/commit/04c7c910cc1a6e78e750404924e2b541de620271
8463d9ehttps://github.com/microsoft/TypeScript/commit/8463d9e961905ab99efaca970888865477743c55
Compare https://github.com/microsoft/TypeScript/compare/04c7c910cc1a6e78e750404924e2b541de620271..8463d9e961905ab99efaca970888865477743c55
November 1, 2017 17:25https://github.com/microsoft/TypeScript/pull/19620#event-1321447108
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
November 1, 2017 17:25https://github.com/microsoft/TypeScript/pull/19620#event-1321447446
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Nov 4, 2017https://github.com/microsoft/TypeScript/pull/19620#issuecomment-341859373
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19620
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
#19686https://github.com/microsoft/TypeScript/issues/19686
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19620
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Nov 6, 2017 https://github.com/microsoft/TypeScript/pull/19620#pullrequestreview-74522321
View reviewed changes https://github.com/microsoft/TypeScript/pull/19620/files/8463d9e961905ab99efaca970888865477743c55
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/19620#pullrequestreview-74522321
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Wesley Wigham (@weswigham)https://github.com/weswigham
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19620
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Nov 6, 2017 https://github.com/microsoft/TypeScript/pull/19620#pullrequestreview-74524052
View reviewed changes https://github.com/microsoft/TypeScript/pull/19620/files/8463d9e961905ab99efaca970888865477743c55
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/19620/files/8463d9e961905ab99efaca970888865477743c55#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Nov 6, 2017https://github.com/microsoft/TypeScript/pull/19620#discussion_r149171237
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19620
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Nov 6, 2017 https://github.com/microsoft/TypeScript/pull/19620#pullrequestreview-74527978
View reviewed changes https://github.com/microsoft/TypeScript/pull/19620/files/8463d9e961905ab99efaca970888865477743c55
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/19620#pullrequestreview-74527978
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19620
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/19620/files/8463d9e961905ab99efaca970888865477743c55#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Nov 6, 2017https://github.com/microsoft/TypeScript/pull/19620#discussion_r149174603
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19620
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/19620/files/8463d9e961905ab99efaca970888865477743c55#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Nov 6, 2017https://github.com/microsoft/TypeScript/pull/19620#discussion_r149174780
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19620
Deleted user (ghost)https://github.com/ghost
Dec 6, 2017https://github.com/microsoft/TypeScript/pull/19620#discussion_r155298536
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19620
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Nov 6, 2017https://github.com/microsoft/TypeScript/pull/19620#issuecomment-342288416
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19620
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
#17819https://github.com/microsoft/TypeScript/pull/17819
Andy (Andrewkraft) (@Andy-MS)https://github.com/Andy-MS
#17819https://github.com/microsoft/TypeScript/pull/17819
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19620
December 6, 2017 09:06https://github.com/microsoft/TypeScript/pull/19620#commits-pushed-96c2085
Code reviewhttps://github.com/microsoft/TypeScript/pull/19620/commits/96c20857c0090ce2cf2f01b42c0d1e2165b218ad
96c2085https://github.com/microsoft/TypeScript/pull/19620/commits/96c20857c0090ce2cf2f01b42c0d1e2165b218ad
Merge branch 'master' into completionsCombineOverloadshttps://github.com/microsoft/TypeScript/pull/19620/commits/2dec11c6b762c81398ba45d08386d0093e7e17b5
2dec11chttps://github.com/microsoft/TypeScript/pull/19620/commits/2dec11c6b762c81398ba45d08386d0093e7e17b5
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Dec 6, 2017https://github.com/microsoft/TypeScript/pull/19620#issuecomment-349713819
Wesley Wigham (@weswigham)https://github.com/weswigham
#17819https://github.com/microsoft/TypeScript/pull/17819
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19620
force-pushedhttps://github.com/microsoft/TypeScript/compare/811ae82a02469dfe83fb8d6b05cfdf0bbdac0495..808b18bf1c4c2c6063dba25ca821cbea7305a647
811ae82https://github.com/microsoft/TypeScript/commit/811ae82a02469dfe83fb8d6b05cfdf0bbdac0495
808b18bhttps://github.com/microsoft/TypeScript/commit/808b18bf1c4c2c6063dba25ca821cbea7305a647
Compare https://github.com/microsoft/TypeScript/compare/811ae82a02469dfe83fb8d6b05cfdf0bbdac0495..808b18bf1c4c2c6063dba25ca821cbea7305a647
December 6, 2017 17:35https://github.com/microsoft/TypeScript/pull/19620#event-1375286487
Make a bit neaterhttps://github.com/microsoft/TypeScript/pull/19620/commits/c8f70c4a3ef98ab50a3f208c280a5f550ed8555f
c8f70c4https://github.com/microsoft/TypeScript/pull/19620/commits/c8f70c4a3ef98ab50a3f208c280a5f550ed8555f
force-pushedhttps://github.com/microsoft/TypeScript/compare/808b18bf1c4c2c6063dba25ca821cbea7305a647..c8f70c4a3ef98ab50a3f208c280a5f550ed8555f
808b18bhttps://github.com/microsoft/TypeScript/commit/808b18bf1c4c2c6063dba25ca821cbea7305a647
c8f70c4https://github.com/microsoft/TypeScript/commit/c8f70c4a3ef98ab50a3f208c280a5f550ed8555f
Compare https://github.com/microsoft/TypeScript/compare/808b18bf1c4c2c6063dba25ca821cbea7305a647..c8f70c4a3ef98ab50a3f208c280a5f550ed8555f
December 6, 2017 17:35https://github.com/microsoft/TypeScript/pull/19620#event-1375287309
December 6, 2017 09:37https://github.com/microsoft/TypeScript/pull/19620#commits-pushed-b1d6817
Use intersection of return typeshttps://github.com/microsoft/TypeScript/pull/19620/commits/b1d6817e8505d0eb66b6ffab878093790bb0755d
b1d6817https://github.com/microsoft/TypeScript/pull/19620/commits/b1d6817e8505d0eb66b6ffab878093790bb0755d
Always fill in type arguments in pickLongestCandidateSignature (https://github.com/microsoft/TypeScript/pull/19620/commits/e91568c4d3e6fd9d486238e150aa7cb74f4adbad
Fixeshttps://github.com/microsoft/TypeScript/pull/19620/commits/e91568c4d3e6fd9d486238e150aa7cb74f4adbad
#…https://github.com/microsoft/TypeScript/issues/19854
e91568chttps://github.com/microsoft/TypeScript/pull/19620/commits/e91568c4d3e6fd9d486238e150aa7cb74f4adbad
…19854https://github.com/microsoft/TypeScript/issues/19854
Dec 6, 2017 https://github.com/microsoft/TypeScript/pull/19620#ref-issue-272408042
Type parameter leaks #19854 https://github.com/microsoft/TypeScript/issues/19854
Merge branch 'master' into completionsCombineOverloadshttps://github.com/microsoft/TypeScript/pull/19620/commits/e87fc884eee1a723ab078b8a7127a6aac65baa54
e87fc88https://github.com/microsoft/TypeScript/pull/19620/commits/e87fc884eee1a723ab078b8a7127a6aac65baa54
force-pushedhttps://github.com/microsoft/TypeScript/compare/43e67b996ed46ce5e014e0f56a13c005f5eedabd..e87fc884eee1a723ab078b8a7127a6aac65baa54
43e67b9https://github.com/microsoft/TypeScript/commit/43e67b996ed46ce5e014e0f56a13c005f5eedabd
e87fc88https://github.com/microsoft/TypeScript/commit/e87fc884eee1a723ab078b8a7127a6aac65baa54
Compare https://github.com/microsoft/TypeScript/compare/43e67b996ed46ce5e014e0f56a13c005f5eedabd..e87fc884eee1a723ab078b8a7127a6aac65baa54
December 14, 2017 22:35https://github.com/microsoft/TypeScript/pull/19620#event-1388656390
Disable GH#19854 fix because it has impacts many test caseshttps://github.com/microsoft/TypeScript/pull/19620/commits/c1dd868305c9c235afe0b2052406106abe01c341
c1dd868https://github.com/microsoft/TypeScript/pull/19620/commits/c1dd868305c9c235afe0b2052406106abe01c341
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 13, 2018https://github.com/microsoft/TypeScript/pull/19620#issuecomment-396780195
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19620
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 13, 2018https://github.com/microsoft/TypeScript/pull/19620#event-1677611256
Jun 20, 2018 https://github.com/microsoft/TypeScript/pull/19620#ref-pullrequest-334207101
In services, when overload resolution fails, create a union signature (2) #25100 https://github.com/microsoft/TypeScript/pull/25100
June 20, 2018 18:55https://github.com/microsoft/TypeScript/pull/19620#event-1691966655
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/19620#event-20415534487
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19620
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19620
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19620
https://github.com/weswigham
https://github.com/typescript-bot
https://github.com/sandersn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.