| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e9ff9f27-b815-f934-6572-7030a9160314 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C7FA:1201C:219D2BC:2C9DB4D:6B018052 |
| html-safe-nonce | 4b4d6595ad7462ee1e70f56eb63ad5f2d26268fa525a99c045e511fd7ebbed07 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDN0ZBOjEyMDFDOjIxOUQyQkM6MkM5REI0RDo2QjAxODA1MiIsInZpc2l0b3JfaWQiOiIxMjQ4NDUwNTM0MDcxOTU5NjM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 107ba6932cedb24396b8f099feb833e833240ba27bdc8ab53cb554fc7b1c7ae2 |
| hovercard-subject-tag | pull_request:149910670 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/19620/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/00c564924535676a820f85531b061775231e628bbe278fae3972e792de7fecf3/microsoft/TypeScript/pull/19620 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/00c564924535676a820f85531b061775231e628bbe278fae3972e792de7fecf3/microsoft/TypeScript/pull/19620 |
| og:image:alt | Fixes #19474
Edit: Fixes #19854 too
(getUnionSignatures seems like it would be useful but it returns a Signature[] and I just want a Signature.) |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/19620#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19620 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19620 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/19620 |
| Reload | https://github.com/microsoft/TypeScript/pull/19620 |
| Reload | https://github.com/microsoft/TypeScript/pull/19620 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests312 (312) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Deleted user (ghost) | https://github.com/ghost |
| master | https://github.com/microsoft/TypeScript/tree/master |
| completionsCombineOverloads | https://github.com/microsoft/TypeScript/tree/completionsCombineOverloads |
| Conversation | https://github.com/microsoft/TypeScript/pull/19620 |
| Commits8 (8) | https://github.com/microsoft/TypeScript/pull/19620/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/19620/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/19620/files |
| In services, when overload resolution fails, create a union signature | https://github.com/microsoft/TypeScript/pull/19620#top |
| Deleted user (ghost) | https://github.com/ghost |
| master | https://github.com/microsoft/TypeScript/tree/master |
| completionsCombineOverloads | https://github.com/microsoft/TypeScript/tree/completionsCombineOverloads |
|
| https://github.com/ghost |
| Deleted user (ghost) | https://github.com/ghost |
| Oct 31, 2017 | https://github.com/microsoft/TypeScript/pull/19620#issue-270122459 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/19620 |
| #19474 | https://github.com/microsoft/TypeScript/issues/19474 |
| #19854 | https://github.com/microsoft/TypeScript/issues/19854 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/19620 |
| In services, when overload resolution fails, create a union signature | https://github.com/microsoft/TypeScript/pull/19620/commits/8463d9e961905ab99efaca970888865477743c55 |
| 8463d9e | https://github.com/microsoft/TypeScript/pull/19620/commits/8463d9e961905ab99efaca970888865477743c55 |
| force-pushed | https://github.com/microsoft/TypeScript/compare/04c7c910cc1a6e78e750404924e2b541de620271..8463d9e961905ab99efaca970888865477743c55 |
| 04c7c91 | https://github.com/microsoft/TypeScript/commit/04c7c910cc1a6e78e750404924e2b541de620271 |
| 8463d9e | https://github.com/microsoft/TypeScript/commit/8463d9e961905ab99efaca970888865477743c55 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/04c7c910cc1a6e78e750404924e2b541de620271..8463d9e961905ab99efaca970888865477743c55 |
| November 1, 2017 17:25 | https://github.com/microsoft/TypeScript/pull/19620#event-1321447108 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| November 1, 2017 17:25 | https://github.com/microsoft/TypeScript/pull/19620#event-1321447446 |
| https://github.com/ghost |
| Deleted user (ghost) | https://github.com/ghost |
| Nov 4, 2017 | https://github.com/microsoft/TypeScript/pull/19620#issuecomment-341859373 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/19620 |
| Nathan Shively-Sanders (@sandersn) | https://github.com/sandersn |
| #19686 | https://github.com/microsoft/TypeScript/issues/19686 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/19620 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Nov 6, 2017
| https://github.com/microsoft/TypeScript/pull/19620#pullrequestreview-74522321 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/19620/files/8463d9e961905ab99efaca970888865477743c55 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| https://github.com/microsoft/TypeScript/pull/19620#pullrequestreview-74522321 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Wesley Wigham (@weswigham) | https://github.com/weswigham |
| Wesley Wigham (@weswigham) | https://github.com/weswigham |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/19620 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Nov 6, 2017
| https://github.com/microsoft/TypeScript/pull/19620#pullrequestreview-74524052 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/19620/files/8463d9e961905ab99efaca970888865477743c55 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/19620/files/8463d9e961905ab99efaca970888865477743c55#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Nov 6, 2017 | https://github.com/microsoft/TypeScript/pull/19620#discussion_r149171237 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/19620 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Nov 6, 2017
| https://github.com/microsoft/TypeScript/pull/19620#pullrequestreview-74527978 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/19620/files/8463d9e961905ab99efaca970888865477743c55 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| https://github.com/microsoft/TypeScript/pull/19620#pullrequestreview-74527978 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Wesley Wigham (@weswigham) | https://github.com/weswigham |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/19620 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/19620/files/8463d9e961905ab99efaca970888865477743c55#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Nov 6, 2017 | https://github.com/microsoft/TypeScript/pull/19620#discussion_r149174603 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/19620 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/19620/files/8463d9e961905ab99efaca970888865477743c55#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Nov 6, 2017 | https://github.com/microsoft/TypeScript/pull/19620#discussion_r149174780 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/19620 |
| Deleted user (ghost) | https://github.com/ghost |
| Dec 6, 2017 | https://github.com/microsoft/TypeScript/pull/19620#discussion_r155298536 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/19620 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Nov 6, 2017 | https://github.com/microsoft/TypeScript/pull/19620#issuecomment-342288416 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/19620 |
| Nathan Shively-Sanders (@sandersn) | https://github.com/sandersn |
| #17819 | https://github.com/microsoft/TypeScript/pull/17819 |
| Andy (Andrewkraft) (@Andy-MS) | https://github.com/Andy-MS |
| #17819 | https://github.com/microsoft/TypeScript/pull/17819 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/19620 |
| December 6, 2017 09:06 | https://github.com/microsoft/TypeScript/pull/19620#commits-pushed-96c2085 |
| Code review | https://github.com/microsoft/TypeScript/pull/19620/commits/96c20857c0090ce2cf2f01b42c0d1e2165b218ad |
| 96c2085 | https://github.com/microsoft/TypeScript/pull/19620/commits/96c20857c0090ce2cf2f01b42c0d1e2165b218ad |
| Merge branch 'master' into completionsCombineOverloads | https://github.com/microsoft/TypeScript/pull/19620/commits/2dec11c6b762c81398ba45d08386d0093e7e17b5 |
| 2dec11c | https://github.com/microsoft/TypeScript/pull/19620/commits/2dec11c6b762c81398ba45d08386d0093e7e17b5 |
| https://github.com/ghost |
| Deleted user (ghost) | https://github.com/ghost |
| Dec 6, 2017 | https://github.com/microsoft/TypeScript/pull/19620#issuecomment-349713819 |
| Wesley Wigham (@weswigham) | https://github.com/weswigham |
| #17819 | https://github.com/microsoft/TypeScript/pull/17819 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/19620 |
| force-pushed | https://github.com/microsoft/TypeScript/compare/811ae82a02469dfe83fb8d6b05cfdf0bbdac0495..808b18bf1c4c2c6063dba25ca821cbea7305a647 |
| 811ae82 | https://github.com/microsoft/TypeScript/commit/811ae82a02469dfe83fb8d6b05cfdf0bbdac0495 |
| 808b18b | https://github.com/microsoft/TypeScript/commit/808b18bf1c4c2c6063dba25ca821cbea7305a647 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/811ae82a02469dfe83fb8d6b05cfdf0bbdac0495..808b18bf1c4c2c6063dba25ca821cbea7305a647 |
| December 6, 2017 17:35 | https://github.com/microsoft/TypeScript/pull/19620#event-1375286487 |
| Make a bit neater | https://github.com/microsoft/TypeScript/pull/19620/commits/c8f70c4a3ef98ab50a3f208c280a5f550ed8555f |
| c8f70c4 | https://github.com/microsoft/TypeScript/pull/19620/commits/c8f70c4a3ef98ab50a3f208c280a5f550ed8555f |
| force-pushed | https://github.com/microsoft/TypeScript/compare/808b18bf1c4c2c6063dba25ca821cbea7305a647..c8f70c4a3ef98ab50a3f208c280a5f550ed8555f |
| 808b18b | https://github.com/microsoft/TypeScript/commit/808b18bf1c4c2c6063dba25ca821cbea7305a647 |
| c8f70c4 | https://github.com/microsoft/TypeScript/commit/c8f70c4a3ef98ab50a3f208c280a5f550ed8555f |
|
Compare
| https://github.com/microsoft/TypeScript/compare/808b18bf1c4c2c6063dba25ca821cbea7305a647..c8f70c4a3ef98ab50a3f208c280a5f550ed8555f |
| December 6, 2017 17:35 | https://github.com/microsoft/TypeScript/pull/19620#event-1375287309 |
| December 6, 2017 09:37 | https://github.com/microsoft/TypeScript/pull/19620#commits-pushed-b1d6817 |
| Use intersection of return types | https://github.com/microsoft/TypeScript/pull/19620/commits/b1d6817e8505d0eb66b6ffab878093790bb0755d |
| b1d6817 | https://github.com/microsoft/TypeScript/pull/19620/commits/b1d6817e8505d0eb66b6ffab878093790bb0755d |
| Always fill in type arguments in pickLongestCandidateSignature ( | https://github.com/microsoft/TypeScript/pull/19620/commits/e91568c4d3e6fd9d486238e150aa7cb74f4adbad |
| Fixes | https://github.com/microsoft/TypeScript/pull/19620/commits/e91568c4d3e6fd9d486238e150aa7cb74f4adbad |
| #… | https://github.com/microsoft/TypeScript/issues/19854 |
| e91568c | https://github.com/microsoft/TypeScript/pull/19620/commits/e91568c4d3e6fd9d486238e150aa7cb74f4adbad |
| …19854 | https://github.com/microsoft/TypeScript/issues/19854 |
|
Dec 6, 2017
| https://github.com/microsoft/TypeScript/pull/19620#ref-issue-272408042 |
|
Type parameter leaks
#19854
| https://github.com/microsoft/TypeScript/issues/19854 |
| Merge branch 'master' into completionsCombineOverloads | https://github.com/microsoft/TypeScript/pull/19620/commits/e87fc884eee1a723ab078b8a7127a6aac65baa54 |
| e87fc88 | https://github.com/microsoft/TypeScript/pull/19620/commits/e87fc884eee1a723ab078b8a7127a6aac65baa54 |
| force-pushed | https://github.com/microsoft/TypeScript/compare/43e67b996ed46ce5e014e0f56a13c005f5eedabd..e87fc884eee1a723ab078b8a7127a6aac65baa54 |
| 43e67b9 | https://github.com/microsoft/TypeScript/commit/43e67b996ed46ce5e014e0f56a13c005f5eedabd |
| e87fc88 | https://github.com/microsoft/TypeScript/commit/e87fc884eee1a723ab078b8a7127a6aac65baa54 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/43e67b996ed46ce5e014e0f56a13c005f5eedabd..e87fc884eee1a723ab078b8a7127a6aac65baa54 |
| December 14, 2017 22:35 | https://github.com/microsoft/TypeScript/pull/19620#event-1388656390 |
| Disable GH#19854 fix because it has impacts many test cases | https://github.com/microsoft/TypeScript/pull/19620/commits/c1dd868305c9c235afe0b2052406106abe01c341 |
| c1dd868 | https://github.com/microsoft/TypeScript/pull/19620/commits/c1dd868305c9c235afe0b2052406106abe01c341 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Jun 13, 2018 | https://github.com/microsoft/TypeScript/pull/19620#issuecomment-396780195 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/19620 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Jun 13, 2018 | https://github.com/microsoft/TypeScript/pull/19620#event-1677611256 |
|
Jun 20, 2018
| https://github.com/microsoft/TypeScript/pull/19620#ref-pullrequest-334207101 |
|
In services, when overload resolution fails, create a union signature (2)
#25100
| https://github.com/microsoft/TypeScript/pull/25100 |
| June 20, 2018 18:55 | https://github.com/microsoft/TypeScript/pull/19620#event-1691966655 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/19620#event-20415534487 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19620 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/19620 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/19620 |
|
| https://github.com/weswigham |
|
| https://github.com/typescript-bot |
|
| https://github.com/sandersn |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |