René's URL Explorer Experiment


Title: fix inconsistencies in import UMD code fixes adapting to module format by aluanhaddad · Pull Request #19572 · microsoft/TypeScript · GitHub

Open Graph Title: fix inconsistencies in import UMD code fixes adapting to module format by aluanhaddad · Pull Request #19572 · microsoft/TypeScript

X Title: fix inconsistencies in import UMD code fixes adapting to module format by aluanhaddad · Pull Request #19572 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - fix inconsistencies in import UMD code fixes adapting to module format by aluanhaddad · Pull Request #19572 · microsoft/TypeScript

Open Graph Description: As described in #17860, the import code fix for UMD modules has been updated such that it uses import m from "specifier"; import under --allowSyntheticDefaultImports uses import m = requ...

X Description: As described in #17860, the import code fix for UMD modules has been updated such that it uses import m from "specifier"; import under --allowSyntheticDefaultImports uses import ...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/19572

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5b2460a8-cdd3-5632-7e06-145db1d57cd2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE6C2:2DC2F1:403960:56B296:6AFBEC00
html-safe-nonce217680c9aaf5df757dda56add91c53daf15bc70951e2bb6738997ba71247aa06
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkMyOjJEQzJGMTo0MDM5NjA6NTZCMjk2OjZBRkJFQzAwIiwidmlzaXRvcl9pZCI6IjMwODc0NTE3NDY2MjkwNTM0NDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac147dcec14621f6ebf0f0523257540ca50c9c72a27b0856f6054de839b4820275
hovercard-subject-tagpull_request:149537884
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/19572/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/350c2932d876b890d54a249cc20b4c2e0e8cba63eaa7f4ed4771a1b48a8915b2/microsoft/TypeScript/pull/19572
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/350c2932d876b890d54a249cc20b4c2e0e8cba63eaa7f4ed4771a1b48a8915b2/microsoft/TypeScript/pull/19572
og:image:altAs described in #17860, the import code fix for UMD modules has been updated such that it uses import m from "specifier"; import under --allowSyntheticDefaultImports uses import m = requ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealuanhaddad
hostnamegithub.com
expected-hostnamegithub.com
None744d4381b1c4dbd6d8736c7d7e5bbe7dc11217584e457a3555020c631764e8ec
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedf859c48a4c8b4c0009c19bb4e82101aacb4b998
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/19572#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19572
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19572
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/19572
Reloadhttps://github.com/microsoft/TypeScript/pull/19572
Reloadhttps://github.com/microsoft/TypeScript/pull/19572
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests335 (335)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/pulse
https://github.com/microsoft/TypeScript
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
aluanhaddad:module-format-aware-import-fixeshttps://github.com/aluanhaddad/TypeScript/tree/module-format-aware-import-fixes
Conversationhttps://github.com/microsoft/TypeScript/pull/19572
Commits6 (6)https://github.com/microsoft/TypeScript/pull/19572/commits
Checkshttps://github.com/microsoft/TypeScript/pull/19572/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/19572/files
fix inconsistencies in import UMD code fixes adapting to module formathttps://github.com/microsoft/TypeScript/pull/19572#top
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
aluanhaddad:module-format-aware-import-fixeshttps://github.com/aluanhaddad/TypeScript/tree/module-format-aware-import-fixes
https://github.com/aluanhaddad
Aluan Haddad (aluanhaddad)https://github.com/aluanhaddad
Oct 30, 2017https://github.com/microsoft/TypeScript/pull/19572#issue-269620574
#17860https://github.com/microsoft/TypeScript/issues/17860
#17860https://github.com/microsoft/TypeScript/issues/17860
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19572
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Oct 30, 2017 https://github.com/microsoft/TypeScript/pull/19572#pullrequestreview-73007341
View reviewed changes https://github.com/microsoft/TypeScript/pull/19572/files
src/services/codefixes/importFixes.tshttps://github.com/microsoft/TypeScript/pull/19572/files#diff-5028f517f8a294750ab440acf45a4845b9ae4e0e2f58293808d15adc469bbe23
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Oct 30, 2017https://github.com/microsoft/TypeScript/pull/19572#discussion_r147852413
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19572
src/services/codefixes/importFixes.tshttps://github.com/microsoft/TypeScript/pull/19572/files#diff-5028f517f8a294750ab440acf45a4845b9ae4e0e2f58293808d15adc469bbe23
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Oct 30, 2017https://github.com/microsoft/TypeScript/pull/19572#discussion_r147852500
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19572
src/services/codefixes/importFixes.tshttps://github.com/microsoft/TypeScript/pull/19572/files#diff-5028f517f8a294750ab440acf45a4845b9ae4e0e2f58293808d15adc469bbe23
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Oct 30, 2017https://github.com/microsoft/TypeScript/pull/19572#discussion_r147852626
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19572
Aluan Haddad (aluanhaddad)https://github.com/aluanhaddad
Nov 1, 2017https://github.com/microsoft/TypeScript/pull/19572#discussion_r148299655
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19572
Aluan Haddad (aluanhaddad)https://github.com/aluanhaddad
Nov 2, 2017https://github.com/microsoft/TypeScript/pull/19572#discussion_r148628550
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19572
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Oct 30, 2017https://github.com/microsoft/TypeScript/pull/19572#issuecomment-340606076
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19572
https://github.com/aluanhaddad
Aluan Haddad (aluanhaddad)https://github.com/aluanhaddad
force-pushedhttps://github.com/microsoft/TypeScript/compare/266ea5f2cf92bb7cd1f232b9ee11e67f73234167..af6b43a2a721c5f431d0cdae03a23ac8343e44c8
266ea5fhttps://github.com/microsoft/TypeScript/commit/266ea5f2cf92bb7cd1f232b9ee11e67f73234167
af6b43ahttps://github.com/microsoft/TypeScript/commit/af6b43a2a721c5f431d0cdae03a23ac8343e44c8
Compare https://github.com/microsoft/TypeScript/compare/266ea5f2cf92bb7cd1f232b9ee11e67f73234167..af6b43a2a721c5f431d0cdae03a23ac8343e44c8
November 1, 2017 16:52https://github.com/microsoft/TypeScript/pull/19572#event-1321385753
Aluan Haddad (aluanhaddad)https://github.com/aluanhaddad
November 4, 2017 16:29https://github.com/microsoft/TypeScript/pull/19572#commits-pushed-dcbadcb
https://github.com/aluanhaddad
improve import code fixes for UMD moduleshttps://github.com/microsoft/TypeScript/pull/19572/commits/dcbadcb05a3924218bfd7eaa32e324f83cd79b36
dcbadcbhttps://github.com/microsoft/TypeScript/pull/19572/commits/dcbadcb05a3924218bfd7eaa32e324f83cd79b36
https://github.com/aluanhaddad
Address PR feedback:https://github.com/microsoft/TypeScript/pull/19572/commits/3041e10080587902592e1c11ec453df8effdd40b
3041e10https://github.com/microsoft/TypeScript/pull/19572/commits/3041e10080587902592e1c11ec453df8effdd40b
https://github.com/aluanhaddad
add testshttps://github.com/microsoft/TypeScript/pull/19572/commits/1be8b2131eb71d9aa3a46716e00c399a1985b9bc
1be8b21https://github.com/microsoft/TypeScript/pull/19572/commits/1be8b2131eb71d9aa3a46716e00c399a1985b9bc
https://github.com/aluanhaddad
Aluan Haddad (aluanhaddad)https://github.com/aluanhaddad
force-pushedhttps://github.com/microsoft/TypeScript/compare/06cd3c33740c8e3f900e46dd20d77b264714b0f9..1be8b2131eb71d9aa3a46716e00c399a1985b9bc
06cd3c3https://github.com/microsoft/TypeScript/commit/06cd3c33740c8e3f900e46dd20d77b264714b0f9
1be8b21https://github.com/microsoft/TypeScript/commit/1be8b2131eb71d9aa3a46716e00c399a1985b9bc
Compare https://github.com/microsoft/TypeScript/compare/06cd3c33740c8e3f900e46dd20d77b264714b0f9..1be8b2131eb71d9aa3a46716e00c399a1985b9bc
November 4, 2017 20:30https://github.com/microsoft/TypeScript/pull/19572#event-1326199935
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Nov 6, 2017 https://github.com/microsoft/TypeScript/pull/19572#pullrequestreview-74549499
View reviewed changes https://github.com/microsoft/TypeScript/pull/19572/files/1be8b2131eb71d9aa3a46716e00c399a1985b9bc
src/services/codefixes/importFixes.tshttps://github.com/microsoft/TypeScript/pull/19572/files/1be8b2131eb71d9aa3a46716e00c399a1985b9bc#diff-5028f517f8a294750ab440acf45a4845b9ae4e0e2f58293808d15adc469bbe23
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Nov 6, 2017https://github.com/microsoft/TypeScript/pull/19572#discussion_r149192820
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Wesley Wigham (@weswigham)https://github.com/weswigham
#19675https://github.com/microsoft/TypeScript/pull/19675
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19572
Aluan Haddad (aluanhaddad)https://github.com/aluanhaddad
Nov 6, 2017https://github.com/microsoft/TypeScript/pull/19572#discussion_r149236528
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19572
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Nov 6, 2017https://github.com/microsoft/TypeScript/pull/19572#issuecomment-342281780
Aluan Haddad (@aluanhaddad)https://github.com/aluanhaddad
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19572
Aluan Haddad (aluanhaddad)https://github.com/aluanhaddad
November 6, 2017 18:56https://github.com/microsoft/TypeScript/pull/19572#commits-pushed-f27148d
https://github.com/aluanhaddad
remove import = quick fix and supporting code.https://github.com/microsoft/TypeScript/pull/19572/commits/f27148d7968be9f37507b4509f98040414ef141c
f27148dhttps://github.com/microsoft/TypeScript/pull/19572/commits/f27148d7968be9f37507b4509f98040414ef141c
https://github.com/aluanhaddad
update feature testshttps://github.com/microsoft/TypeScript/pull/19572/commits/78ee07fcb7be599251d9dbcb7c413b42f80c75dc
78ee07fhttps://github.com/microsoft/TypeScript/pull/19572/commits/78ee07fcb7be599251d9dbcb7c413b42f80c75dc
https://github.com/aluanhaddad
remove errant whitespacehttps://github.com/microsoft/TypeScript/pull/19572/commits/3800b46350de91cf9b51405218ef9e05c1e0b97a
3800b46https://github.com/microsoft/TypeScript/pull/19572/commits/3800b46350de91cf9b51405218ef9e05c1e0b97a
https://github.com/aluanhaddad
Aluan Haddad (aluanhaddad)https://github.com/aluanhaddad
Nov 7, 2017https://github.com/microsoft/TypeScript/pull/19572#issuecomment-342337959
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19572
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
70cabddhttps://github.com/microsoft/TypeScript/commit/70cabdda419748c0ce10d0cd15e025cbb5bc0fae
Nov 7, 2017https://github.com/microsoft/TypeScript/pull/19572#event-1329080452
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Nov 7, 2017https://github.com/microsoft/TypeScript/pull/19572#issuecomment-342392486
Aluan Haddad (@aluanhaddad)https://github.com/aluanhaddad
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19572
https://github.com/aluanhaddad
Aluan Haddad (aluanhaddad)https://github.com/aluanhaddad
Nov 7, 2017https://github.com/microsoft/TypeScript/pull/19572#issuecomment-342395870
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19572
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Nov 7, 2017https://github.com/microsoft/TypeScript/pull/19572#issuecomment-342397637
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19572
https://github.com/aluanhaddad
Aluan Haddad (aluanhaddad)https://github.com/aluanhaddad
November 7, 2017 08:33https://github.com/microsoft/TypeScript/pull/19572#event-1329197309
https://github.com/aluanhaddad
Aluan Haddad (aluanhaddad)https://github.com/aluanhaddad
Nov 7, 2017 https://github.com/microsoft/TypeScript/pull/19572#ref-pullrequest-271763810
Import fix add import require support #19802 https://github.com/microsoft/TypeScript/pull/19802
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Nov 7, 2017 https://github.com/microsoft/TypeScript/pull/19572#pullrequestreview-74779507
View reviewed changes https://github.com/microsoft/TypeScript/pull/19572/files/3800b46350de91cf9b51405218ef9e05c1e0b97a
src/services/codefixes/importFixes.tshttps://github.com/microsoft/TypeScript/pull/19572/files/3800b46350de91cf9b51405218ef9e05c1e0b97a#diff-5028f517f8a294750ab440acf45a4845b9ae4e0e2f58293808d15adc469bbe23
Deleted user (ghost)https://github.com/ghost
Nov 7, 2017https://github.com/microsoft/TypeScript/pull/19572#discussion_r149394442
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#19667https://github.com/microsoft/TypeScript/pull/19667
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19572
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 14, 2018https://github.com/microsoft/TypeScript/pull/19572#event-1682117021
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19572
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
https://github.com/microsoft/TypeScript/pull/19572/files/1be8b2131eb71d9aa3a46716e00c399a1985b9bc
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19572
Quick Fix info inconsistent when offering to import a UMD declaration. https://github.com/microsoft/TypeScript/issues/17860
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19572
https://github.com/aluanhaddad
https://github.com/mhegazy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.