René's URL Explorer Experiment


Title: Fix checking of recursive callback types by ahejlsberg · Pull Request #19107 · microsoft/TypeScript · GitHub

Open Graph Title: Fix checking of recursive callback types by ahejlsberg · Pull Request #19107 · microsoft/TypeScript

X Title: Fix checking of recursive callback types by ahejlsberg · Pull Request #19107 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix checking of recursive callback types by ahejlsberg · Pull Request #19107 · microsoft/TypeScript

Open Graph Description: This PR fixes the logic introduced in #15104 to only check for callback parameters when we aren't in a recursive call to compareSignaturesRelated that resulted from an outer callback check. Fix...

X Description: This PR fixes the logic introduced in #15104 to only check for callback parameters when we aren't in a recursive call to compareSignaturesRelated that resulted from an outer callback check....

Opengraph URL: https://github.com/microsoft/TypeScript/pull/19107

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3e591cfc-1821-f374-0f1b-6c8337dc838a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8974:19AA62:9E2BFE:CA8760:6B00F149
html-safe-noncef05816c311f7c17e507965ba0aabb26c1ee57220f843d1ad414b17ccf43efb36
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTc0OjE5QUE2Mjo5RTJCRkU6Q0E4NzYwOjZCMDBGMTQ5IiwidmlzaXRvcl9pZCI6IjI1MzMyMTM5NzU0NTQyMTY1MjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace3e4325837418faab5d626e4818c1ca8653546a59459978c6985fa4d8f9dee37
hovercard-subject-tagpull_request:146035524
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/19107/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d8473209eb0e4ca9f29688c8e2819f2d25545377cd793e4d8a4c4797cfb31984/microsoft/TypeScript/pull/19107
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d8473209eb0e4ca9f29688c8e2819f2d25545377cd793e4d8a4c4797cfb31984/microsoft/TypeScript/pull/19107
og:image:altThis PR fixes the logic introduced in #15104 to only check for callback parameters when we aren't in a recursive call to compareSignaturesRelated that resulted from an outer callback check. Fix...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameahejlsberg
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/19107#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19107
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19107
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/19107
Reloadhttps://github.com/microsoft/TypeScript/pull/19107
Reloadhttps://github.com/microsoft/TypeScript/pull/19107
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
fixRecursiveCallbackshttps://github.com/microsoft/TypeScript/tree/fixRecursiveCallbacks
Conversationhttps://github.com/microsoft/TypeScript/pull/19107
Commits3 (3)https://github.com/microsoft/TypeScript/pull/19107/commits
Checkshttps://github.com/microsoft/TypeScript/pull/19107/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/19107/files
Fix checking of recursive callback typeshttps://github.com/microsoft/TypeScript/pull/19107#top
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
fixRecursiveCallbackshttps://github.com/microsoft/TypeScript/tree/fixRecursiveCallbacks
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Oct 11, 2017https://github.com/microsoft/TypeScript/pull/19107#issue-264700941
#15104https://github.com/microsoft/TypeScript/pull/15104
#18277https://github.com/microsoft/TypeScript/issues/18277
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19107
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
October 11, 2017 12:01https://github.com/microsoft/TypeScript/pull/19107#commits-pushed-81fc2a1
https://github.com/ahejlsberg
Don't check for callbacks in recursive call that resulted from callbackshttps://github.com/microsoft/TypeScript/pull/19107/commits/81fc2a14d19ae763286f75a6fba61e05e777edd3
81fc2a1https://github.com/microsoft/TypeScript/pull/19107/commits/81fc2a14d19ae763286f75a6fba61e05e777edd3
https://github.com/ahejlsberg
Add regression testhttps://github.com/microsoft/TypeScript/pull/19107/commits/07e4819b8bb5db64c2d00c91b7ce184de1eb4723
07e4819https://github.com/microsoft/TypeScript/pull/19107/commits/07e4819b8bb5db64c2d00c91b7ce184de1eb4723
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/19107/commits/38cec121902d505de3cf71711f7c4c847563e9d6
38cec12https://github.com/microsoft/TypeScript/pull/19107/commits/38cec121902d505de3cf71711f7c4c847563e9d6
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Oct 11, 2017 https://github.com/microsoft/TypeScript/pull/19107#ref-pullrequest-264374400
Track recursive callback-covariance calls to compareSignaturesRelated #19078 https://github.com/microsoft/TypeScript/pull/19078
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Oct 11, 2017https://github.com/microsoft/TypeScript/pull/19107#issuecomment-335916920
#19078https://github.com/microsoft/TypeScript/pull/19078
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19107
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
October 11, 2017 19:11https://github.com/microsoft/TypeScript/pull/19107#event-1288874941
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 11, 2017 https://github.com/microsoft/TypeScript/pull/19107#pullrequestreview-68720092
View reviewed changes https://github.com/microsoft/TypeScript/pull/19107/files/38cec121902d505de3cf71711f7c4c847563e9d6
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Oct 11, 2017 https://github.com/microsoft/TypeScript/pull/19107#pullrequestreview-68752630
View reviewed changes https://github.com/microsoft/TypeScript/pull/19107/files/38cec121902d505de3cf71711f7c4c847563e9d6
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
6cf41aehttps://github.com/microsoft/TypeScript/commit/6cf41ae8827f14d501129ca4b6f2ba16cc6ca5c0
Oct 11, 2017https://github.com/microsoft/TypeScript/pull/19107#event-1289253587
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
October 11, 2017 23:28https://github.com/microsoft/TypeScript/pull/19107#event-1289253713
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 14, 2018https://github.com/microsoft/TypeScript/pull/19107#event-1682122172
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19107
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/19107/files/38cec121902d505de3cf71711f7c4c847563e9d6
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
https://github.com/microsoft/TypeScript/pull/19107/files/38cec121902d505de3cf71711f7c4c847563e9d6
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19107
Stack overflow while type checking generic, mutually-defined function interfaces https://github.com/microsoft/TypeScript/issues/18277
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19107
https://github.com/ahejlsberg
https://github.com/sandersn
https://github.com/mhegazy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.