René's URL Explorer Experiment


Title: Recreate old decorator metadata behavior by weswigham · Pull Request #19089 · microsoft/TypeScript · GitHub

Open Graph Title: Recreate old decorator metadata behavior by weswigham · Pull Request #19089 · microsoft/TypeScript

X Title: Recreate old decorator metadata behavior by weswigham · Pull Request #19089 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Recreate old decorator metadata behavior by weswigham · Pull Request #19089 · microsoft/TypeScript

Open Graph Description: Fixes #18509. With strictNullChecks off, now we intentionally elide undefined and null from the list of type nodes we look at when attempting to find a metadata type for a union type node (and alwa...

X Description: Fixes #18509. With strictNullChecks off, now we intentionally elide undefined and null from the list of type nodes we look at when attempting to find a metadata type for a union type node (and alwa...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/19089

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:84c8b581-6fbf-c803-ccdb-1f555b7735bd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8BBE:BEE52:354AC:4712F:6B00B7A9
html-safe-nonce50242fa5aaf09a3050d2e4affcb610f380d0d65df41b8929afa1587dda7576ce
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkJFOkJFRTUyOjM1NEFDOjQ3MTJGOjZCMDBCN0E5IiwidmlzaXRvcl9pZCI6IjM5OTAwNjE4MzEzNzU4NjE2NzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacca1fad80d049cfb346af5f45b6f7b636259e7d774a9cad2a11e1c4093fc96256
hovercard-subject-tagpull_request:145832803
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/19089/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/67b412cec661aae6ac5b16f691ce46029547c9545fabb55df8252e941bb71559/microsoft/TypeScript/pull/19089
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/67b412cec661aae6ac5b16f691ce46029547c9545fabb55df8252e941bb71559/microsoft/TypeScript/pull/19089
og:image:altFixes #18509. With strictNullChecks off, now we intentionally elide undefined and null from the list of type nodes we look at when attempting to find a metadata type for a union type node (and alwa...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
None1d07c25977adfc5ff6acb0a962a9bc168c07afbda6fef765f9761c350c2ae4a2
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5429cbfc6aca8c7b9a086a3c8f47400346f38cc9
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/19089#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19089
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19089
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/19089
Reloadhttps://github.com/microsoft/TypeScript/pull/19089
Reloadhttps://github.com/microsoft/TypeScript/pull/19089
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests307 (307)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:recreate-old-decorator-metadata-behaviorhttps://github.com/weswigham/TypeScript/tree/recreate-old-decorator-metadata-behavior
Conversationhttps://github.com/microsoft/TypeScript/pull/19089
Commits5 (5)https://github.com/microsoft/TypeScript/pull/19089/commits
Checkshttps://github.com/microsoft/TypeScript/pull/19089/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/19089/files
Recreate old decorator metadata behaviorhttps://github.com/microsoft/TypeScript/pull/19089#top
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:recreate-old-decorator-metadata-behaviorhttps://github.com/weswigham/TypeScript/tree/recreate-old-decorator-metadata-behavior
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Oct 11, 2017https://github.com/microsoft/TypeScript/pull/19089#issue-264421951
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19089
#18509https://github.com/microsoft/TypeScript/issues/18509
0eaa8ebhttps://github.com/microsoft/TypeScript/commit/0eaa8eb3ab9ad1db8cf95c51d8e02c9d65ee40cf
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19089
Wesley Wigham (weswigham)https://github.com/weswigham
October 10, 2017 17:21https://github.com/microsoft/TypeScript/pull/19089#commits-pushed-96d18b1
https://github.com/weswigham
Emulate pre 2.4 metadata behavior of eliding null and undefined from …https://github.com/microsoft/TypeScript/pull/19089/commits/96d18b159eb8cb57a35403b0644e3585678bb902
96d18b1https://github.com/microsoft/TypeScript/pull/19089/commits/96d18b159eb8cb57a35403b0644e3585678bb902
https://github.com/weswigham
Accept baselinehttps://github.com/microsoft/TypeScript/pull/19089/commits/0daa4240718c9dba562efc0aba5bcde49b9f4ee3
0daa424https://github.com/microsoft/TypeScript/pull/19089/commits/0daa4240718c9dba562efc0aba5bcde49b9f4ee3
https://github.com/weswigham
Update commenthttps://github.com/microsoft/TypeScript/pull/19089/commits/92ddbbe5a7c0266c3d8529e45aa30ebd941c5bb0
92ddbbehttps://github.com/microsoft/TypeScript/pull/19089/commits/92ddbbe5a7c0266c3d8529e45aa30ebd941c5bb0
https://github.com/weswigham
Update for second old baselinehttps://github.com/microsoft/TypeScript/pull/19089/commits/15ee1ad4870bcbcd9064a75a65c346afabf60713
15ee1adhttps://github.com/microsoft/TypeScript/pull/19089/commits/15ee1ad4870bcbcd9064a75a65c346afabf60713
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Ron Buckton (rbuckton)https://github.com/rbuckton
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
October 11, 2017 00:39https://github.com/microsoft/TypeScript/pull/19089#event-1287191716
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
Oct 11, 2017https://github.com/microsoft/TypeScript/pull/19089#issuecomment-335896037
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
#13540 (comment)https://github.com/microsoft/TypeScript/pull/13540#discussion_r97186053
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19089
https://github.com/weswigham
Respect stricthttps://github.com/microsoft/TypeScript/pull/19089/commits/c66b1870e7d0b3d59fd9612c3cf42ae44bc79f02
c66b187https://github.com/microsoft/TypeScript/pull/19089/commits/c66b1870e7d0b3d59fd9612c3cf42ae44bc79f02
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Oct 12, 2017 https://github.com/microsoft/TypeScript/pull/19089#pullrequestreview-69067465
View reviewed changes https://github.com/microsoft/TypeScript/pull/19089/files/c66b1870e7d0b3d59fd9612c3cf42ae44bc79f02
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
de0e475https://github.com/microsoft/TypeScript/commit/de0e475c64a5dbba72d22c0edf6ce5552a5a0ebe
Oct 12, 2017https://github.com/microsoft/TypeScript/pull/19089#event-1291229233
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
October 12, 2017 22:05https://github.com/microsoft/TypeScript/pull/19089#event-1291229307
https://github.com/typeofweb
Michał Miszczyszyn (typeofweb)https://github.com/typeofweb
Oct 18, 2017https://github.com/microsoft/TypeScript/pull/19089#issuecomment-337641080
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19089
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Oct 18, 2017https://github.com/microsoft/TypeScript/pull/19089#issuecomment-337714892
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19089
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Apr 27, 2018 https://github.com/microsoft/TypeScript/pull/19089#ref-issue-258115818
Decorator metadata breaking change between TS 2.3.4 -> 2.4.0 #18509 https://github.com/microsoft/TypeScript/issues/18509
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 31, 2018https://github.com/microsoft/TypeScript/pull/19089#event-1763316361
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F19089
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat) https://github.com/sheetalkamat
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
https://github.com/microsoft/TypeScript/pull/19089/files/c66b1870e7d0b3d59fd9612c3cf42ae44bc79f02
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19089
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/19089
https://github.com/weswigham
https://github.com/sheetalkamat
https://github.com/typeofweb
https://github.com/mhegazy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.