René's URL Explorer Experiment


Title: Strictly check callback parameters by ahejlsberg · Pull Request #18976 · microsoft/TypeScript · GitHub

Open Graph Title: Strictly check callback parameters by ahejlsberg · Pull Request #18976 · microsoft/TypeScript

X Title: Strictly check callback parameters by ahejlsberg · Pull Request #18976 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Strictly check callback parameters by ahejlsberg · Pull Request #18976 · microsoft/TypeScript

Open Graph Description: With this PR we fix checking of the return position of callback parameters in --strictFunctionTypes mode. Previously we'd never check this position strictly (because of #15104) but now we check...

X Description: With this PR we fix checking of the return position of callback parameters in --strictFunctionTypes mode. Previously we'd never check this position strictly (because of #15104) but now we c...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/18976

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ac0bf5a6-1170-b1ed-9e75-8ec4a702038a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA72:16AB79:97F464:C28028:6B00EFBC
html-safe-nonceceaca5c2faa7752882a782b99065d07ab764dc8bb75f001fcac7775bcfe2288b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTcyOjE2QUI3OTo5N0Y0NjQ6QzI4MDI4OjZCMDBFRkJDIiwidmlzaXRvcl9pZCI6IjYwMDIwOTg5NDQwNTI2MjEyNDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac906ac93eb1ce1f792a6aa63f349b4b0a25812aa797df1d59bfc229225eca08c6
hovercard-subject-tagpull_request:145019324
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/18976/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2d5f38f113280145cf39b7901ed3778ad3be56cf0b21c39480f8e6ca6c80455e/microsoft/TypeScript/pull/18976
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2d5f38f113280145cf39b7901ed3778ad3be56cf0b21c39480f8e6ca6c80455e/microsoft/TypeScript/pull/18976
og:image:altWith this PR we fix checking of the return position of callback parameters in --strictFunctionTypes mode. Previously we'd never check this position strictly (because of #15104) but now we check...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameahejlsberg
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/18976#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18976
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18976
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/18976
Reloadhttps://github.com/microsoft/TypeScript/pull/18976
Reloadhttps://github.com/microsoft/TypeScript/pull/18976
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
strictCallbackParametershttps://github.com/microsoft/TypeScript/tree/strictCallbackParameters
Conversationhttps://github.com/microsoft/TypeScript/pull/18976
Commits6 (6)https://github.com/microsoft/TypeScript/pull/18976/commits
Checkshttps://github.com/microsoft/TypeScript/pull/18976/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/18976/files
Strictly check callback parametershttps://github.com/microsoft/TypeScript/pull/18976#top
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
strictCallbackParametershttps://github.com/microsoft/TypeScript/tree/strictCallbackParameters
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Oct 5, 2017https://github.com/microsoft/TypeScript/pull/18976#issue-263264083
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18976
#15104https://github.com/microsoft/TypeScript/pull/15104
#15104https://github.com/microsoft/TypeScript/pull/15104
#18963https://github.com/microsoft/TypeScript/issues/18963
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18976
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
October 5, 2017 13:18https://github.com/microsoft/TypeScript/pull/18976#commits-pushed-c3d1b02
https://github.com/ahejlsberg
Don't use callback parameter code path when strictly checking functionshttps://github.com/microsoft/TypeScript/pull/18976/commits/c3d1b027dcf27520a2a2e64a0e95aa64ea62505f
c3d1b02https://github.com/microsoft/TypeScript/pull/18976/commits/c3d1b027dcf27520a2a2e64a0e95aa64ea62505f
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/18976/commits/0dc1c77f231762079ba106ea7fd828355c2a8852
0dc1c77https://github.com/microsoft/TypeScript/pull/18976/commits/0dc1c77f231762079ba106ea7fd828355c2a8852
https://github.com/ahejlsberg
Add testhttps://github.com/microsoft/TypeScript/pull/18976/commits/aae7572c4869dd5a62acd4311e8f7fdefd1f05f6
aae7572https://github.com/microsoft/TypeScript/pull/18976/commits/aae7572c4869dd5a62acd4311e8f7fdefd1f05f6
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
October 5, 2017 21:03https://github.com/microsoft/TypeScript/pull/18976#event-1280738337
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Oct 5, 2017 https://github.com/microsoft/TypeScript/pull/18976#pullrequestreview-67515352
View reviewed changes https://github.com/microsoft/TypeScript/pull/18976/files/aae7572c4869dd5a62acd4311e8f7fdefd1f05f6
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Oct 5, 2017https://github.com/microsoft/TypeScript/pull/18976#issuecomment-334593893
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18976
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Oct 5, 2017https://github.com/microsoft/TypeScript/pull/18976#issuecomment-334599918
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18976
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 5, 2017 https://github.com/microsoft/TypeScript/pull/18976#pullrequestreview-67523531
View reviewed changes https://github.com/microsoft/TypeScript/pull/18976/files/aae7572c4869dd5a62acd4311e8f7fdefd1f05f6
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Oct 5, 2017https://github.com/microsoft/TypeScript/pull/18976#issuecomment-334623422
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18976
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Oct 6, 2017https://github.com/microsoft/TypeScript/pull/18976#issuecomment-334623949
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18976
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Oct 6, 2017https://github.com/microsoft/TypeScript/pull/18976#issuecomment-334626929
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18976
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
October 6, 2017 09:16https://github.com/microsoft/TypeScript/pull/18976#commits-pushed-70e259a
https://github.com/ahejlsberg
Always use callback parameter code path, but stricter if necessaryhttps://github.com/microsoft/TypeScript/pull/18976/commits/70e259aba368349f075ebe389e2f5c16dfec41db
70e259ahttps://github.com/microsoft/TypeScript/pull/18976/commits/70e259aba368349f075ebe389e2f5c16dfec41db
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/18976/commits/c8d52609142cd61c50b9593ee42ba8a4f649d885
c8d5260https://github.com/microsoft/TypeScript/pull/18976/commits/c8d52609142cd61c50b9593ee42ba8a4f649d885
https://github.com/ahejlsberg
Add testshttps://github.com/microsoft/TypeScript/pull/18976/commits/7fcf51960ddc753754876c9905c84726ff0ff97e
7fcf519https://github.com/microsoft/TypeScript/pull/18976/commits/7fcf51960ddc753754876c9905c84726ff0ff97e
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Oct 6, 2017https://github.com/microsoft/TypeScript/pull/18976#issuecomment-334804444
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18976
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
b7e744ahttps://github.com/microsoft/TypeScript/commit/b7e744a0e59ba3e75ba3c059bb191c4098950c3e
Oct 6, 2017https://github.com/microsoft/TypeScript/pull/18976#event-1282469096
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
October 6, 2017 20:36https://github.com/microsoft/TypeScript/pull/18976#event-1282469145
https://github.com/SlurpTheo
SlurpTheohttps://github.com/SlurpTheo
Oct 9, 2017 https://github.com/microsoft/TypeScript/pull/18976#pullrequestreview-68018509
View reviewed changes https://github.com/microsoft/TypeScript/pull/18976/files/7fcf51960ddc753754876c9905c84726ff0ff97e
SlurpTheohttps://github.com/SlurpTheo
https://github.com/microsoft/TypeScript/pull/18976#pullrequestreview-68018509
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18976
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 14, 2018https://github.com/microsoft/TypeScript/pull/18976#event-1682123406
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18976
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/18976/files/aae7572c4869dd5a62acd4311e8f7fdefd1f05f6
https://github.com/SlurpTheo
SlurpTheo https://github.com/SlurpTheo
https://github.com/microsoft/TypeScript/pull/18976/files/7fcf51960ddc753754876c9905c84726ff0ff97e
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
https://github.com/microsoft/TypeScript/pull/18976/files/aae7572c4869dd5a62acd4311e8f7fdefd1f05f6
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18976
strictFunctionTypes has different behavior with parameter types and return types https://github.com/microsoft/TypeScript/issues/18963
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18976
https://github.com/ahejlsberg
https://github.com/mhegazy
https://github.com/DanielRosenwasser
https://github.com/sandersn
https://github.com/SlurpTheo
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.