René's URL Explorer Experiment


Title: Fully deprecate the symbol display builder, reimplement in terms of node builder by weswigham · Pull Request #18860 · microsoft/TypeScript · GitHub

Open Graph Title: Fully deprecate the symbol display builder, reimplement in terms of node builder by weswigham · Pull Request #18860 · microsoft/TypeScript

X Title: Fully deprecate the symbol display builder, reimplement in terms of node builder by weswigham · Pull Request #18860 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fully deprecate the symbol display builder, reimplement in terms of node builder by weswigham · Pull Request #18860 · microsoft/TypeScript

Open Graph Description: While working on the new declaration emitter, I recognized that there were certain parts of the current declaration emitter which relied on the symbol display builder. For the most part, we had hea...

X Description: While working on the new declaration emitter, I recognized that there were certain parts of the current declaration emitter which relied on the symbol display builder. For the most part, we had hea...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/18860

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0c315966-615a-d39c-443a-467256c53167
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id84D2:19E4BB:2C5062C:38886B3:6B01B812
html-safe-nonce9b1ed616f75889bd93784303ddee5f35a67b06c5f3e5dbb8c0a2f93cec510409
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEQyOjE5RTRCQjoyQzUwNjJDOjM4ODg2QjM6NkIwMUI4MTIiLCJ2aXNpdG9yX2lkIjoiMzEwMjA0NzU0NDQ0NDgyNzY2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace84ea1aaa0213067f4789f8177b2e408cbe5c762391b2ad85df534f1da57da1b
hovercard-subject-tagpull_request:143993173
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/18860/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0383ef3ca1fc1f5b8c02f1aeedb217f7122bee221a7a147bb617d32e79232c23/microsoft/TypeScript/pull/18860
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0383ef3ca1fc1f5b8c02f1aeedb217f7122bee221a7a147bb617d32e79232c23/microsoft/TypeScript/pull/18860
og:image:altWhile working on the new declaration emitter, I recognized that there were certain parts of the current declaration emitter which relied on the symbol display builder. For the most part, we had hea...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/18860#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18860
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18860
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/18860
Reloadhttps://github.com/microsoft/TypeScript/pull/18860
Reloadhttps://github.com/microsoft/TypeScript/pull/18860
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:couple-node-builder-with-symbol-trackerhttps://github.com/weswigham/TypeScript/tree/couple-node-builder-with-symbol-tracker
Conversationhttps://github.com/microsoft/TypeScript/pull/18860
Commits83 (83)https://github.com/microsoft/TypeScript/pull/18860/commits
Checkshttps://github.com/microsoft/TypeScript/pull/18860/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/18860/files
Fully deprecate the symbol display builder, reimplement in terms of node builderhttps://github.com/microsoft/TypeScript/pull/18860#top
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:couple-node-builder-with-symbol-trackerhttps://github.com/weswigham/TypeScript/tree/couple-node-builder-with-symbol-tracker
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Sep 29, 2017https://github.com/microsoft/TypeScript/pull/18860#issue-261788325
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18860
Wesley Wigham (weswigham)https://github.com/weswigham
September 27, 2017 11:54https://github.com/microsoft/TypeScript/pull/18860#commits-pushed-bc8a27c
https://github.com/weswigham
Remove SymbolWriter, give methods to EmitTextWriterhttps://github.com/microsoft/TypeScript/pull/18860/commits/bc8a27c335ca17aa44e19b55d7d3d66940ec5edf
bc8a27chttps://github.com/microsoft/TypeScript/pull/18860/commits/bc8a27c335ca17aa44e19b55d7d3d66940ec5edf
https://github.com/weswigham
Unification of writers is done-ishhttps://github.com/microsoft/TypeScript/pull/18860/commits/1dff6496e9fa4b9753930857e7000edf7f13c69e
1dff649https://github.com/microsoft/TypeScript/pull/18860/commits/1dff6496e9fa4b9753930857e7000edf7f13c69e
https://github.com/weswigham
Make node builder support more flagshttps://github.com/microsoft/TypeScript/pull/18860/commits/7fa4ec9bd84ad02abfb0154cebd44d4eff5fe030
7fa4ec9https://github.com/microsoft/TypeScript/pull/18860/commits/7fa4ec9bd84ad02abfb0154cebd44d4eff5fe030
https://github.com/weswigham
Write out mixins like we used tohttps://github.com/microsoft/TypeScript/pull/18860/commits/fc0ae76f9d9de8b3b641a680911001825f5050e7
fc0ae76https://github.com/microsoft/TypeScript/pull/18860/commits/fc0ae76f9d9de8b3b641a680911001825f5050e7
https://github.com/weswigham
Accept prototype-free baselineshttps://github.com/microsoft/TypeScript/pull/18860/commits/72d413afe43c1a9d5aa61a8dc5a4722cdc2ed011
72d413ahttps://github.com/microsoft/TypeScript/pull/18860/commits/72d413afe43c1a9d5aa61a8dc5a4722cdc2ed011
https://github.com/weswigham
Use instantiated constraint when building mapped type nodeshttps://github.com/microsoft/TypeScript/pull/18860/commits/e68c11166fc6c62e2aba603e2b39024556c1389e
e68c111https://github.com/microsoft/TypeScript/pull/18860/commits/e68c11166fc6c62e2aba603e2b39024556c1389e
https://github.com/weswigham
Accept better mapped type baselineshttps://github.com/microsoft/TypeScript/pull/18860/commits/56450964fc73a6dfbea2a644d29f7c6c3a7fd45c
5645096https://github.com/microsoft/TypeScript/pull/18860/commits/56450964fc73a6dfbea2a644d29f7c6c3a7fd45c
https://github.com/weswigham
Report inaccessible this in node builderhttps://github.com/microsoft/TypeScript/pull/18860/commits/9501e62279100ae72e5f1d68964a48eb9e301a42
9501e62https://github.com/microsoft/TypeScript/pull/18860/commits/9501e62279100ae72e5f1d68964a48eb9e301a42
https://github.com/weswigham
Turns out there was a bug in our codefix, toohttps://github.com/microsoft/TypeScript/pull/18860/commits/1f5972a44d3369b9b9ccacce80e4338bd9ce31f5
1f5972ahttps://github.com/microsoft/TypeScript/pull/18860/commits/1f5972a44d3369b9b9ccacce80e4338bd9ce31f5
https://github.com/weswigham
Symbol display builder usage fallinghttps://github.com/microsoft/TypeScript/pull/18860/commits/266f553541ddac8a792ca3ce324e155602f8e6ce
266f553https://github.com/microsoft/TypeScript/pull/18860/commits/266f553541ddac8a792ca3ce324e155602f8e6ce
https://github.com/weswigham
Replace signatureToString with a nodeBuilder solutionhttps://github.com/microsoft/TypeScript/pull/18860/commits/b1435169e87aa5fb311ac0740856f3d99e5f6f8c
b143516https://github.com/microsoft/TypeScript/pull/18860/commits/b1435169e87aa5fb311ac0740856f3d99e5f6f8c
https://github.com/weswigham
Replace the last internal usages of the symbol writerhttps://github.com/microsoft/TypeScript/pull/18860/commits/6c227b4390d0a5502d270bb7e5c3fafdf05cc7f2
6c227b4https://github.com/microsoft/TypeScript/pull/18860/commits/6c227b4390d0a5502d270bb7e5c3fafdf05cc7f2
https://github.com/weswigham
Accept semicolon additionshttps://github.com/microsoft/TypeScript/pull/18860/commits/0e58719ecf00e7d2ffa944cb74244218adacf7ab
0e58719https://github.com/microsoft/TypeScript/pull/18860/commits/0e58719ecf00e7d2ffa944cb74244218adacf7ab
https://github.com/weswigham
Accept updated symbol baseline outputhttps://github.com/microsoft/TypeScript/pull/18860/commits/a926577ed287b93f6ee8e2870b4d93e12aeb88ba
a926577https://github.com/microsoft/TypeScript/pull/18860/commits/a926577ed287b93f6ee8e2870b4d93e12aeb88ba
https://github.com/weswigham
Start using node builder for some LS operationshttps://github.com/microsoft/TypeScript/pull/18860/commits/d8dfe84af82fdb3b51adee066b3e5d943eb928f5
d8dfe84https://github.com/microsoft/TypeScript/pull/18860/commits/d8dfe84af82fdb3b51adee066b3e5d943eb928f5
https://github.com/weswigham
Remove those pesky trailing semicolons on signatureshttps://github.com/microsoft/TypeScript/pull/18860/commits/d76ddef1892850b23b5a74234af4d625fa31cb86
d76ddefhttps://github.com/microsoft/TypeScript/pull/18860/commits/d76ddef1892850b23b5a74234af4d625fa31cb86
https://github.com/weswigham
Get signature printing much closer to old outputhttps://github.com/microsoft/TypeScript/pull/18860/commits/50cf103439fb9fadcb0383026d94ca598d3a66ff
50cf103https://github.com/microsoft/TypeScript/pull/18860/commits/50cf103439fb9fadcb0383026d94ca598d3a66ff
https://github.com/weswigham
Parameter lists should not be indented by default, especially when si…https://github.com/microsoft/TypeScript/pull/18860/commits/a4725a870be3a03a71f9f0b3aa6fe058c61bab28
a4725a8https://github.com/microsoft/TypeScript/pull/18860/commits/a4725a870be3a03a71f9f0b3aa6fe058c61bab28
https://github.com/weswigham
Signatures up to snuffhttps://github.com/microsoft/TypeScript/pull/18860/commits/ab99ee272117930b21aad25e46df5d45b85a5fd4
ab99ee2https://github.com/microsoft/TypeScript/pull/18860/commits/ab99ee272117930b21aad25e46df5d45b85a5fd4
https://github.com/weswigham
Type quickinfo emit is up to snuffhttps://github.com/microsoft/TypeScript/pull/18860/commits/e28202a8d24a5447cce4396b4242f33904400e1b
e28202ahttps://github.com/microsoft/TypeScript/pull/18860/commits/e28202a8d24a5447cce4396b4242f33904400e1b
https://github.com/weswigham
Start of symbol writer replacement, needs a bit more for full compathttps://github.com/microsoft/TypeScript/pull/18860/commits/358c5c2f2bdc3f5a0d7d824404bf8642d73990f5
358c5c2https://github.com/microsoft/TypeScript/pull/18860/commits/358c5c2f2bdc3f5a0d7d824404bf8642d73990f5
https://github.com/weswigham
Slightly mor accurate to old behaviorhttps://github.com/microsoft/TypeScript/pull/18860/commits/4963b0fe590ffc9e7a09df11198ba1035a515c68
4963b0fhttps://github.com/microsoft/TypeScript/pull/18860/commits/4963b0fe590ffc9e7a09df11198ba1035a515c68
https://github.com/weswigham
Replicate qualified name type argument output correctlyhttps://github.com/microsoft/TypeScript/pull/18860/commits/581cf56c6575c1df6084252946b20198ff1893b0
581cf56https://github.com/microsoft/TypeScript/pull/18860/commits/581cf56c6575c1df6084252946b20198ff1893b0
https://github.com/weswigham
Bring back the old symbol baselineshttps://github.com/microsoft/TypeScript/pull/18860/commits/5b90321d0bd95d1c31463e7e1f8171390fba8cd7
5b90321https://github.com/microsoft/TypeScript/pull/18860/commits/5b90321d0bd95d1c31463e7e1f8171390fba8cd7
https://github.com/weswigham
Mostly identical to old symbol emit nowhttps://github.com/microsoft/TypeScript/pull/18860/commits/83bea8103d31fe371a77b1596f4495b716f6c7f8
83bea81https://github.com/microsoft/TypeScript/pull/18860/commits/83bea8103d31fe371a77b1596f4495b716f6c7f8
https://github.com/weswigham
Perfectly matches old behavior thus farhttps://github.com/microsoft/TypeScript/pull/18860/commits/8bb7230729f43f1c134f895a535e73c4cd58af3e
8bb7230https://github.com/microsoft/TypeScript/pull/18860/commits/8bb7230729f43f1c134f895a535e73c4cd58af3e
https://github.com/weswigham
Replace another usage of the symbol builderhttps://github.com/microsoft/TypeScript/pull/18860/commits/cf6458f9be1af37485df4055cda837f5ac3e4eea
cf6458fhttps://github.com/microsoft/TypeScript/pull/18860/commits/cf6458f9be1af37485df4055cda837f5ac3e4eea
https://github.com/weswigham
Another usage removedhttps://github.com/microsoft/TypeScript/pull/18860/commits/8a773ab0134ccf47ba5bdddf1253f8d4c87246a6
8a773abhttps://github.com/microsoft/TypeScript/pull/18860/commits/8a773ab0134ccf47ba5bdddf1253f8d4c87246a6
https://github.com/weswigham
Another usage removedhttps://github.com/microsoft/TypeScript/pull/18860/commits/1f5aec286b6f2e5c39eb86abdefe28293a916ba1
1f5aec2https://github.com/microsoft/TypeScript/pull/18860/commits/1f5aec286b6f2e5c39eb86abdefe28293a916ba1
https://github.com/weswigham
Remove final uses of symbol display builderhttps://github.com/microsoft/TypeScript/pull/18860/commits/65a7a4b6b3689a4ab85557699c4b09f8166a3555
65a7a4bhttps://github.com/microsoft/TypeScript/pull/18860/commits/65a7a4b6b3689a4ab85557699c4b09f8166a3555
Wesley Wigham (weswigham)https://github.com/weswigham
November 10, 2017 16:52https://github.com/microsoft/TypeScript/pull/18860#commits-pushed-adc43f0
https://github.com/weswigham
Mimic default name declaration emit fixhttps://github.com/microsoft/TypeScript/pull/18860/commits/adc43f0610e2410a1e3e9673553f2e65ecd84882
adc43f0https://github.com/microsoft/TypeScript/pull/18860/commits/adc43f0610e2410a1e3e9673553f2e65ecd84882
https://github.com/weswigham
Merge branch 'master' into couple-node-builder-with-symbol-trackerhttps://github.com/microsoft/TypeScript/pull/18860/commits/f5c79d53a6be5dd7856c6857b83e12b3b9dd7b41
f5c79d5https://github.com/microsoft/TypeScript/pull/18860/commits/f5c79d53a6be5dd7856c6857b83e12b3b9dd7b41
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
force-pushedhttps://github.com/microsoft/TypeScript/compare/ec3f036f25871a6293dd8edc9b21be6f3514ccc4..f5c79d53a6be5dd7856c6857b83e12b3b9dd7b41
ec3f036https://github.com/microsoft/TypeScript/commit/ec3f036f25871a6293dd8edc9b21be6f3514ccc4
f5c79d5https://github.com/microsoft/TypeScript/commit/f5c79d53a6be5dd7856c6857b83e12b3b9dd7b41
Compare https://github.com/microsoft/TypeScript/compare/ec3f036f25871a6293dd8edc9b21be6f3514ccc4..f5c79d53a6be5dd7856c6857b83e12b3b9dd7b41
November 11, 2017 01:25https://github.com/microsoft/TypeScript/pull/18860#event-1337044071
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Nov 11, 2017 https://github.com/microsoft/TypeScript/pull/18860#pullrequestreview-75915364
View reviewed changes https://github.com/microsoft/TypeScript/pull/18860/files/052f8fb8a1b044b399fbb5eb29c85b2d9d842482
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/18860/files/052f8fb8a1b044b399fbb5eb29c85b2d9d842482#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Ron Buckton (rbuckton)https://github.com/rbuckton
Nov 11, 2017https://github.com/microsoft/TypeScript/pull/18860#discussion_r150367007
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18860
src/compiler/emitter.tshttps://github.com/microsoft/TypeScript/pull/18860/files/052f8fb8a1b044b399fbb5eb29c85b2d9d842482#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8
Ron Buckton (rbuckton)https://github.com/rbuckton
Nov 11, 2017https://github.com/microsoft/TypeScript/pull/18860#discussion_r150369784
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18860
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 3, 2018https://github.com/microsoft/TypeScript/pull/18860#discussion_r159542157
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18860
src/compiler/emitter.tshttps://github.com/microsoft/TypeScript/pull/18860/files/052f8fb8a1b044b399fbb5eb29c85b2d9d842482#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8
Ron Buckton (rbuckton)https://github.com/rbuckton
Nov 11, 2017https://github.com/microsoft/TypeScript/pull/18860#discussion_r150369921
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18860
src/compiler/emitter.tshttps://github.com/microsoft/TypeScript/pull/18860/files/052f8fb8a1b044b399fbb5eb29c85b2d9d842482#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8
Ron Buckton (rbuckton)https://github.com/rbuckton
Nov 11, 2017https://github.com/microsoft/TypeScript/pull/18860#discussion_r150370048
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18860
src/compiler/emitter.tshttps://github.com/microsoft/TypeScript/pull/18860/files/052f8fb8a1b044b399fbb5eb29c85b2d9d842482#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8
Ron Buckton (rbuckton)https://github.com/rbuckton
Nov 11, 2017https://github.com/microsoft/TypeScript/pull/18860#discussion_r150370150
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18860
src/services/signatureHelp.tshttps://github.com/microsoft/TypeScript/pull/18860/files/052f8fb8a1b044b399fbb5eb29c85b2d9d842482#diff-e6b935a93dfc24e2f9cde64996712b597a94c19ce2df86a53e4e3b2161ddf155
Ron Buckton (rbuckton)https://github.com/rbuckton
Nov 11, 2017https://github.com/microsoft/TypeScript/pull/18860#discussion_r150371164
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18860
src/services/signatureHelp.tshttps://github.com/microsoft/TypeScript/pull/18860/files/052f8fb8a1b044b399fbb5eb29c85b2d9d842482#diff-e6b935a93dfc24e2f9cde64996712b597a94c19ce2df86a53e4e3b2161ddf155
Ron Buckton (rbuckton)https://github.com/rbuckton
Nov 11, 2017https://github.com/microsoft/TypeScript/pull/18860#discussion_r150371201
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18860
src/services/utilities.tshttps://github.com/microsoft/TypeScript/pull/18860/files/052f8fb8a1b044b399fbb5eb29c85b2d9d842482#diff-e7a6c6ac3d7aec62fd1afbb66b41e8d35663c7c9555b0668d1e14f0221f51459
Ron Buckton (rbuckton)https://github.com/rbuckton
Nov 11, 2017https://github.com/microsoft/TypeScript/pull/18860#discussion_r150371242
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18860
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 3, 2018https://github.com/microsoft/TypeScript/pull/18860#discussion_r159540307
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18860
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/18860/files/052f8fb8a1b044b399fbb5eb29c85b2d9d842482#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Ron Buckton (rbuckton)https://github.com/rbuckton
Nov 11, 2017https://github.com/microsoft/TypeScript/pull/18860#discussion_r150371330
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18860
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/18860/files/052f8fb8a1b044b399fbb5eb29c85b2d9d842482#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Ron Buckton (rbuckton)https://github.com/rbuckton
Nov 11, 2017https://github.com/microsoft/TypeScript/pull/18860#discussion_r150371381
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18860
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 3, 2018https://github.com/microsoft/TypeScript/pull/18860#discussion_r159540418
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18860
https://github.com/weswigham
Merge branch 'master' into couple-node-builder-with-symbol-trackerhttps://github.com/microsoft/TypeScript/pull/18860/commits/03ddb06640426225b7705d8037ad07c1cd10c8a9
03ddb06https://github.com/microsoft/TypeScript/pull/18860/commits/03ddb06640426225b7705d8037ad07c1cd10c8a9
https://github.com/aozgaa
Arthur Ozga (aozgaa)https://github.com/aozgaa
Dec 7, 2017 https://github.com/microsoft/TypeScript/pull/18860#ref-pullrequest-280272841
Omnibus fixes for telemetry-sourced crashes #20545 https://github.com/microsoft/TypeScript/pull/20545
Wesley Wigham (weswigham)https://github.com/weswigham
January 3, 2018 12:19https://github.com/microsoft/TypeScript/pull/18860#commits-pushed-fb9fd83
https://github.com/weswigham
Merge branch 'master' into couple-node-builder-with-symbol-trackerhttps://github.com/microsoft/TypeScript/pull/18860/commits/fb9fd83baa55cbbf19245e24575643700992369e
fb9fd83https://github.com/microsoft/TypeScript/pull/18860/commits/fb9fd83baa55cbbf19245e24575643700992369e
https://github.com/weswigham
Fix tests broken by mergehttps://github.com/microsoft/TypeScript/pull/18860/commits/7a8db7139ff71de24f1e8f6128953d8597535814
7a8db71https://github.com/microsoft/TypeScript/pull/18860/commits/7a8db7139ff71de24f1e8f6128953d8597535814
https://github.com/weswigham
use isFunctionLikehttps://github.com/microsoft/TypeScript/pull/18860/commits/450100a861a4befa4f104a023b6e852f942c1201
450100ahttps://github.com/microsoft/TypeScript/pull/18860/commits/450100a861a4befa4f104a023b6e852f942c1201
https://github.com/weswigham
Cleanup, sync TypeFormat and NodeBuilder flagshttps://github.com/microsoft/TypeScript/pull/18860/commits/7fd36558476965e4a39113d0d1aa4e55d799807c
7fd3655https://github.com/microsoft/TypeScript/pull/18860/commits/7fd36558476965e4a39113d0d1aa4e55d799807c
https://github.com/weswigham
Reorder Node initialization so pos and end are first, so a TextRange …https://github.com/microsoft/TypeScript/pull/18860/commits/3943e4ca53a7f8e75cf8010a8d4670cd5d10821b
3943e4chttps://github.com/microsoft/TypeScript/pull/18860/commits/3943e4ca53a7f8e75cf8010a8d4670cd5d10821b
https://github.com/weswigham
Use variable instead of ternaryhttps://github.com/microsoft/TypeScript/pull/18860/commits/bbffdd78b8130b2fb6b183b5ca0be570bc233e59
bbffdd7https://github.com/microsoft/TypeScript/pull/18860/commits/bbffdd78b8130b2fb6b183b5ca0be570bc233e59
https://github.com/weswigham
Write helper for emitNodeWithWriterhttps://github.com/microsoft/TypeScript/pull/18860/commits/ad102a6df8002ecb43fef79c9a0d3ca4fc104e3c
ad102a6https://github.com/microsoft/TypeScript/pull/18860/commits/ad102a6df8002ecb43fef79c9a0d3ca4fc104e3c
https://github.com/weswigham
Emitter cleanuphttps://github.com/microsoft/TypeScript/pull/18860/commits/5ac170b4559f2ea402b057f126b93d7d68807d87
5ac170bhttps://github.com/microsoft/TypeScript/pull/18860/commits/5ac170b4559f2ea402b057f126b93d7d68807d87
https://github.com/weswigham
Cleanup whitespace, commenthttps://github.com/microsoft/TypeScript/pull/18860/commits/3e881448cd76f9077e07e7ed7db6022e6e157e7a
3e88144https://github.com/microsoft/TypeScript/pull/18860/commits/3e881448cd76f9077e07e7ed7db6022e6e157e7a
https://github.com/weswigham
Reuse printerhttps://github.com/microsoft/TypeScript/pull/18860/commits/0abba6d6350e81ba0ddc51f954906de46ec696a1
0abba6dhttps://github.com/microsoft/TypeScript/pull/18860/commits/0abba6d6350e81ba0ddc51f954906de46ec696a1
https://github.com/weswigham
Raise error if display parts writer uses rawWritehttps://github.com/microsoft/TypeScript/pull/18860/commits/3e181786fbd244a2be59f8e0dcfaef6924e68292
3e18178https://github.com/microsoft/TypeScript/pull/18860/commits/3e181786fbd244a2be59f8e0dcfaef6924e68292
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
force-pushedhttps://github.com/microsoft/TypeScript/compare/6862e50592614ca326af2930a65a26f75d68e2c0..3e181786fbd244a2be59f8e0dcfaef6924e68292
6862e50https://github.com/microsoft/TypeScript/commit/6862e50592614ca326af2930a65a26f75d68e2c0
3e18178https://github.com/microsoft/TypeScript/commit/3e181786fbd244a2be59f8e0dcfaef6924e68292
Compare https://github.com/microsoft/TypeScript/compare/6862e50592614ca326af2930a65a26f75d68e2c0..3e181786fbd244a2be59f8e0dcfaef6924e68292
January 3, 2018 22:07https://github.com/microsoft/TypeScript/pull/18860#event-1408623052
Wesley Wigham (weswigham)https://github.com/weswigham
January 3, 2018 14:18https://github.com/microsoft/TypeScript/pull/18860#commits-pushed-4cec0ca
https://github.com/weswigham
Hide writer parameter through different function instead of overload,…https://github.com/microsoft/TypeScript/pull/18860/commits/4cec0cacdaec5aaaf4c723e1e208578cbf2827d0
4cec0cahttps://github.com/microsoft/TypeScript/pull/18860/commits/4cec0cacdaec5aaaf4c723e1e208578cbf2827d0
https://github.com/weswigham
Make less printerhttps://github.com/microsoft/TypeScript/pull/18860/commits/232d45933efc958a5bd4fc614058889aee12a4a9
232d459https://github.com/microsoft/TypeScript/pull/18860/commits/232d45933efc958a5bd4fc614058889aee12a4a9
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 3, 2018https://github.com/microsoft/TypeScript/pull/18860#issuecomment-355148018
Ron Buckton (@rbuckton)https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18860
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Jan 8, 2018https://github.com/microsoft/TypeScript/pull/18860#issuecomment-356089644
Wesley Wigham (@weswigham)https://github.com/weswigham
Ron Buckton (@rbuckton)https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18860
Wesley Wigham (weswigham)https://github.com/weswigham
January 9, 2018 14:19https://github.com/microsoft/TypeScript/pull/18860#commits-pushed-aa27a6a
https://github.com/weswigham
Merge branch 'master' into couple-node-builder-with-symbol-trackerhttps://github.com/microsoft/TypeScript/pull/18860/commits/aa27a6a63aa461f4fb03889a3f74c95e41f329a6
aa27a6ahttps://github.com/microsoft/TypeScript/pull/18860/commits/aa27a6a63aa461f4fb03889a3f74c95e41f329a6
https://github.com/weswigham
fix linthttps://github.com/microsoft/TypeScript/pull/18860/commits/a481f7f01dbaea6177d7897c584355e5e7e605c2
a481f7fhttps://github.com/microsoft/TypeScript/pull/18860/commits/a481f7f01dbaea6177d7897c584355e5e7e605c2
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Jan 16, 2018 https://github.com/microsoft/TypeScript/pull/18860#pullrequestreview-89186097
View reviewed changes https://github.com/microsoft/TypeScript/pull/18860/files/a481f7f01dbaea6177d7897c584355e5e7e605c2
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
76d9524https://github.com/microsoft/TypeScript/commit/76d95248660d1c7bc7f7a64d5113383f4a015712
Jan 16, 2018https://github.com/microsoft/TypeScript/pull/18860#event-1426693772
Accept corrected baseline #21201 https://github.com/microsoft/TypeScript/pull/21201
Allow functions to be printed structurally in declaration emit even when they have symbols #21203 https://github.com/microsoft/TypeScript/pull/21203
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
February 26, 2018 23:55https://github.com/microsoft/TypeScript/pull/18860#event-1493266527
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 3, 2018https://github.com/microsoft/TypeScript/pull/18860#event-1712802768
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18860
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/18860/files/10718da13ac0cc6bec3ea1bd1d970d5fc4d379eb
https://github.com/aozgaa
Arthur Ozga (aozgaa) https://github.com/aozgaa
https://github.com/microsoft/TypeScript/pull/18860/files/6a1c51ec69242a3fe6fc2f451cf39bf0142289d6
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
https://github.com/microsoft/TypeScript/pull/18860/files/a481f7f01dbaea6177d7897c584355e5e7e605c2
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
https://github.com/microsoft/TypeScript/pull/18860/files/052f8fb8a1b044b399fbb5eb29c85b2d9d842482
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18860
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18860
https://github.com/weswigham
https://github.com/DanielRosenwasser
https://github.com/mhegazy
https://github.com/sandersn
https://github.com/aozgaa
https://github.com/rbuckton
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.