René's URL Explorer Experiment


Title: Narrow contextual type of object literals by sandersn · Pull Request #18488 · microsoft/TypeScript · GitHub

Open Graph Title: Narrow contextual type of object literals by sandersn · Pull Request #18488 · microsoft/TypeScript

X Title: Narrow contextual type of object literals by sandersn · Pull Request #18488 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Narrow contextual type of object literals by sandersn · Pull Request #18488 · microsoft/TypeScript

Open Graph Description: Fixes #16457 (first half). This allows the following example to get the correct contextual type of Y for the object literal with type: 'y'. interface X { type: 'x'; value: 1...

X Description: Fixes #16457 (first half). This allows the following example to get the correct contextual type of Y for the object literal with type: 'y'. interface X { type: 'x&#3...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/18488

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:45ca3bc4-c895-82ed-1588-9e38142d1a98
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB75A:3E16:805A8E:B5A6A5:6AFBDE73
html-safe-noncea89235ed616ceed462b9ec57854c2fc60d6eea84b0313cc2498e20ee46da4dcd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzVBOjNFMTY6ODA1QThFOkI1QTZBNTo2QUZCREU3MyIsInZpc2l0b3JfaWQiOiIyMTI1ODQzMzExMDQ1MTA3MzE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd0d99bf61019301d54ecee705c700fe2ed34d001eb4de82289af4ddb6eb34c7e
hovercard-subject-tagpull_request:141185577
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/18488/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b444a47763fce1cca2aaa861947a35ebee67df100e9afedba55e8925b9baffc6/microsoft/TypeScript/pull/18488
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b444a47763fce1cca2aaa861947a35ebee67df100e9afedba55e8925b9baffc6/microsoft/TypeScript/pull/18488
og:image:altFixes #16457 (first half). This allows the following example to get the correct contextual type of Y for the object literal with type: 'y'. interface X { type: 'x'; value: 1...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
None744d4381b1c4dbd6d8736c7d7e5bbe7dc11217584e457a3555020c631764e8ec
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedf859c48a4c8b4c0009c19bb4e82101aacb4b998
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/18488#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18488
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18488
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/18488
Reloadhttps://github.com/microsoft/TypeScript/pull/18488
Reloadhttps://github.com/microsoft/TypeScript/pull/18488
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests334 (334)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/pulse
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
narrow-contextual-type-of-object-literalshttps://github.com/microsoft/TypeScript/tree/narrow-contextual-type-of-object-literals
Conversationhttps://github.com/microsoft/TypeScript/pull/18488
Commits4 (4)https://github.com/microsoft/TypeScript/pull/18488/commits
Checkshttps://github.com/microsoft/TypeScript/pull/18488/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/18488/files
Narrow contextual type of object literalshttps://github.com/microsoft/TypeScript/pull/18488#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
narrow-contextual-type-of-object-literalshttps://github.com/microsoft/TypeScript/tree/narrow-contextual-type-of-object-literals
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 14, 2017https://github.com/microsoft/TypeScript/pull/18488#issue-257867477
#16457https://github.com/microsoft/TypeScript/issues/16457
#16457https://github.com/microsoft/TypeScript/issues/16457
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18488
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
September 14, 2017 14:39https://github.com/microsoft/TypeScript/pull/18488#commits-pushed-f217fc0
https://github.com/sandersn
Narrow contextual type:prop assignments in obj literalshttps://github.com/microsoft/TypeScript/pull/18488/commits/f217fc09acd030ff667bb4bea4f8a21b45ad7646
f217fc0https://github.com/microsoft/TypeScript/pull/18488/commits/f217fc09acd030ff667bb4bea4f8a21b45ad7646
https://github.com/sandersn
Test:Obj literal assignable to discriminated unionhttps://github.com/microsoft/TypeScript/pull/18488/commits/895c9145f0177578a177ad52bbd2222998a47950
895c914https://github.com/microsoft/TypeScript/pull/18488/commits/895c9145f0177578a177ad52bbd2222998a47950
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Sep 14, 2017https://github.com/microsoft/TypeScript/pull/18488#event-1250089282
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
September 15, 2017 10:46https://github.com/microsoft/TypeScript/pull/18488#commits-pushed-702b50b
https://github.com/sandersn
Merge branch 'master' into narrow-contextual-type-of-object-literalshttps://github.com/microsoft/TypeScript/pull/18488/commits/702b50bbdf69c4d34b44439daa7add9571cd79aa
702b50bhttps://github.com/microsoft/TypeScript/pull/18488/commits/702b50bbdf69c4d34b44439daa7add9571cd79aa
https://github.com/sandersn
Improve style of calling addMemberForKeyTypehttps://github.com/microsoft/TypeScript/pull/18488/commits/84b5a1e728d409754bda2a453ffe6c62026781cd
84b5a1ehttps://github.com/microsoft/TypeScript/pull/18488/commits/84b5a1e728d409754bda2a453ffe6c62026781cd
https://github.com/msftgits
Microsoft GitHub User (msftgits)https://github.com/msftgits
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Sep 26, 2017https://github.com/microsoft/TypeScript/pull/18488#event-1265655695
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Oct 19, 2017 https://github.com/microsoft/TypeScript/pull/18488#ref-pullrequest-266706827
Retain literal types in some contextual unions #19322 https://github.com/microsoft/TypeScript/pull/19322
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Nov 13, 2017https://github.com/microsoft/TypeScript/pull/18488#issuecomment-344059335
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18488
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Nov 13, 2017https://github.com/microsoft/TypeScript/pull/18488#event-1339608411
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
November 14, 2017 20:02https://github.com/microsoft/TypeScript/pull/18488#event-1341656268
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 14, 2018https://github.com/microsoft/TypeScript/pull/18488#event-1682128268
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18488
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18488
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18488
https://github.com/sandersn
https://github.com/msftclas
https://github.com/msftgits
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.