| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d57a3a5f-091a-794c-c2a3-0ea66b17cd64 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C8DA:37820D:13B2E22:1A30051:6B01187D |
| html-safe-nonce | 3f3d71642be062f4f115bc81aad959725f4915efd5d5db1dee5af6d8889fafba |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOERBOjM3ODIwRDoxM0IyRTIyOjFBMzAwNTE6NkIwMTE4N0QiLCJ2aXNpdG9yX2lkIjoiMTY0MzQyMTg1MTIzNTQ1NzE0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f9d7714fe02f35f2496fef644d0b28b1a97b4e596c4627726101fe3519bfec24 |
| hovercard-subject-tag | pull_request:139877512 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/18317/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6fc663362ceeb1c0cae0c6b9d4710851d0a6d2e2d2cd05922eec8191ea218e36/microsoft/TypeScript/pull/18317 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6fc663362ceeb1c0cae0c6b9d4710851d0a6d2e2d2cd05922eec8191ea218e36/microsoft/TypeScript/pull/18317 |
| og:image:alt | This is a late-stage name replacement in checkObjectLiteral, so it's a special-case of Ron's upcoming dynamic names change.
Fixes #16687 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sandersn |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/18317#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18317 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18317 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/18317 |
| Reload | https://github.com/microsoft/TypeScript/pull/18317 |
| Reload | https://github.com/microsoft/TypeScript/pull/18317 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests310 (310) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| master | https://github.com/microsoft/TypeScript/tree/master |
| object-literal-enum-property-names | https://github.com/microsoft/TypeScript/tree/object-literal-enum-property-names |
| Conversation | https://github.com/microsoft/TypeScript/pull/18317 |
| Commits2 (2) | https://github.com/microsoft/TypeScript/pull/18317/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/18317/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/18317/files |
| Object literals computed property names allow literal-typed expressions | https://github.com/microsoft/TypeScript/pull/18317#top |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| master | https://github.com/microsoft/TypeScript/tree/master |
| object-literal-enum-property-names | https://github.com/microsoft/TypeScript/tree/object-literal-enum-property-names |
|
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18317#issue-256033256 |
| #16687 | https://github.com/microsoft/TypeScript/issues/16687 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18317 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| September 7, 2017 11:30 | https://github.com/microsoft/TypeScript/pull/18317#commits-pushed-ac58751 |
|
| https://github.com/sandersn |
| Object literals computed property names allow literal-typed expressions | https://github.com/microsoft/TypeScript/pull/18317/commits/ac58751b6239aeb2c4a980644c4db48ee4bf3c27 |
| ac58751 | https://github.com/microsoft/TypeScript/pull/18317/commits/ac58751b6239aeb2c4a980644c4db48ee4bf3c27 |
|
| https://github.com/sandersn |
| Test Literal-typed computed property names in obj literals | https://github.com/microsoft/TypeScript/pull/18317/commits/3c5b2a5e9d43c3f8b0f92e61208775ad9ffb5c05 |
| 3c5b2a5 | https://github.com/microsoft/TypeScript/pull/18317/commits/3c5b2a5e9d43c3f8b0f92e61208775ad9ffb5c05 |
| https://github.com/msftclas |
| Microsoft Contribution License Agreements (msftclas) | https://github.com/msftclas |
|
cla-not-required
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18317#event-1239369520 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| September 7, 2017 18:43 | https://github.com/microsoft/TypeScript/pull/18317#event-1239369668 |
| https://github.com/mhegazy |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
|
Sep 7, 2017
| https://github.com/microsoft/TypeScript/pull/18317#pullrequestreview-61321913 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/18317/files/3c5b2a5e9d43c3f8b0f92e61208775ad9ffb5c05 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| 397ff84 | https://github.com/microsoft/TypeScript/commit/397ff84f1a466017a6adb8ea0a2a88023663c5e0 |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18317#event-1239586936 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| September 7, 2017 20:56 | https://github.com/microsoft/TypeScript/pull/18317#event-1239587399 |
| https://github.com/simonbuchan |
| Simon Buchan (simonbuchan) | https://github.com/simonbuchan |
|
Sep 10, 2017
| https://github.com/microsoft/TypeScript/pull/18317#ref-issue-237707886 |
|
Using const string enum as object key produces an indexed type
#16687
| https://github.com/microsoft/TypeScript/issues/16687 |
| https://github.com/mhegazy |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
|
Sep 12, 2017
| https://github.com/microsoft/TypeScript/pull/18317#ref-issue-257067035 |
|
Better support for enumerating properties in generics using string enums
#18409
| https://github.com/microsoft/TypeScript/issues/18409 |
|
Sep 20, 2017
| https://github.com/microsoft/TypeScript/pull/18317#ref-issue-259171627 |
|
Computed properties do not type check when they could
#18596
| https://github.com/microsoft/TypeScript/issues/18596 |
|
Type checker doesn't understand string literal type in computed property key
#15534
| https://github.com/microsoft/TypeScript/issues/15534 |
|
Computed property key names should not be widened
#13948
| https://github.com/microsoft/TypeScript/issues/13948 |
| https://github.com/mthurlin |
| Markus Thurlin (mthurlin) | https://github.com/mthurlin |
| Nov 11, 2017 | https://github.com/microsoft/TypeScript/pull/18317#issuecomment-343661086 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18317 |
| https://github.com/mhegazy |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
| Nov 13, 2017 | https://github.com/microsoft/TypeScript/pull/18317#issuecomment-344020457 |
| Markus Thurlin (@mthurlin) | https://github.com/mthurlin |
| #13948 | https://github.com/microsoft/TypeScript/issues/13948 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18317 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Dec 22, 2017
| https://github.com/microsoft/TypeScript/pull/18317#ref-issue-284074801 |
|
Can't infer param type of method assigned to computed property name using string enum value
#20856
| https://github.com/microsoft/TypeScript/issues/20856 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Jun 14, 2018 | https://github.com/microsoft/TypeScript/pull/18317#event-1682129938 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18317 |
|
| https://github.com/rbuckton |
|
Ron Buckton (rbuckton)
| https://github.com/rbuckton |
|
| https://github.com/mhegazy |
|
Mohamed Hegazy (mhegazy)
| https://github.com/mhegazy |
|
| https://github.com/microsoft/TypeScript/pull/18317/files/3c5b2a5e9d43c3f8b0f92e61208775ad9ffb5c05 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18317 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18317 |
|
| https://github.com/sandersn |
|
| https://github.com/mthurlin |
|
| https://github.com/mhegazy |
|
| https://github.com/msftclas |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |