René's URL Explorer Experiment


Title: Correctly cache tagged template objects in modules by DanielRosenwasser · Pull Request #18300 · microsoft/TypeScript · GitHub

Open Graph Title: Correctly cache tagged template objects in modules by DanielRosenwasser · Pull Request #18300 · microsoft/TypeScript

X Title: Correctly cache tagged template objects in modules by DanielRosenwasser · Pull Request #18300 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Correctly cache tagged template objects in modules by DanielRosenwasser · Pull Request #18300 · microsoft/TypeScript

Open Graph Description: This PR is a work in progress at the moment Remaining things to work on: Bikeshed on helper name. Bikeshed on helper semantics Bikeshed on template object initialization location Add helper fo...

X Description: This PR is a work in progress at the moment Remaining things to work on: Bikeshed on helper name. Bikeshed on helper semantics Bikeshed on template object initialization location Add helper fo...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/18300

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:857f66a6-dc79-4dd6-fa3b-0c9e46316dd2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D1E:26ECEB:2ABE6E5:36550DB:6B019700
html-safe-noncede1a468e06ceffb2ff85cce96788d357ac9a23ca876067ffb86a90e1ed2b0e7c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDFFOjI2RUNFQjoyQUJFNkU1OjM2NTUwREI6NkIwMTk3MDAiLCJ2aXNpdG9yX2lkIjoiNDY1ODI0MDE0MTQwNjYwNzEwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5a820cba3a1a0d41aba639db5499be5e410e14f64031c2c67695bd02b2973cc9
hovercard-subject-tagpull_request:139708946
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/18300/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3d4928e51f52b230d93dd8539faf801aa56b591607f20eb9282386e6158ee274/microsoft/TypeScript/pull/18300
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3d4928e51f52b230d93dd8539faf801aa56b591607f20eb9282386e6158ee274/microsoft/TypeScript/pull/18300
og:image:altThis PR is a work in progress at the moment Remaining things to work on: Bikeshed on helper name. Bikeshed on helper semantics Bikeshed on template object initialization location Add helper fo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDanielRosenwasser
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/18300#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18300
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18300
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/18300
Reloadhttps://github.com/microsoft/TypeScript/pull/18300
Reloadhttps://github.com/microsoft/TypeScript/pull/18300
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
masterhttps://github.com/microsoft/TypeScript/tree/master
correctlyCacheTaggedTemplateshttps://github.com/microsoft/TypeScript/tree/correctlyCacheTaggedTemplates
Conversationhttps://github.com/microsoft/TypeScript/pull/18300
Commits29 (29)https://github.com/microsoft/TypeScript/pull/18300/commits
Checkshttps://github.com/microsoft/TypeScript/pull/18300/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/18300/files
Correctly cache tagged template objects in moduleshttps://github.com/microsoft/TypeScript/pull/18300#top
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
masterhttps://github.com/microsoft/TypeScript/tree/master
correctlyCacheTaggedTemplateshttps://github.com/microsoft/TypeScript/tree/correctlyCacheTaggedTemplates
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Sep 7, 2017https://github.com/microsoft/TypeScript/pull/18300#issue-255803771
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
#17956https://github.com/microsoft/TypeScript/issues/17956
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Sep 7, 2017https://github.com/microsoft/TypeScript/pull/18300#event-1238020081
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Sep 7, 2017 https://github.com/microsoft/TypeScript/pull/18300#pullrequestreview-61105431
View reviewed changes https://github.com/microsoft/TypeScript/pull/18300/files
tests/baselines/reference/taggedTemplateStringsWithManyCallAndMemberExpressions.jshttps://github.com/microsoft/TypeScript/pull/18300/files#diff-eb4e105a0fd9897118ea4e0f0859d571b06ad290c6c7677c05c78a9b64672545
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Sep 7, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r137439176
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Ron Buckton (@rbuckton)https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Ron Buckton (rbuckton)https://github.com/rbuckton
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Wesley Wigham (weswigham)https://github.com/weswigham
September 7, 2017 03:28https://github.com/microsoft/TypeScript/pull/18300#event-1238021377
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Sep 7, 2017 https://github.com/microsoft/TypeScript/pull/18300#ref-issue-251797379
Tagged template literals compiled incorrectly, TemplateStringsArray not cached #17956 https://github.com/microsoft/TypeScript/issues/17956
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
September 6, 2017 20:39https://github.com/microsoft/TypeScript/pull/18300#commits-pushed-c4b1a9d
https://github.com/DanielRosenwasser
Update emit for tagged templates to use a per-site cached template ob…https://github.com/microsoft/TypeScript/pull/18300/commits/c4b1a9d94fa8006c4c41eb76d768500b2322432d
c4b1a9dhttps://github.com/microsoft/TypeScript/pull/18300/commits/c4b1a9d94fa8006c4c41eb76d768500b2322432d
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/18300/commits/166af8caf21c8d423cfb1f244d558e438ffac83b
166af8chttps://github.com/microsoft/TypeScript/pull/18300/commits/166af8caf21c8d423cfb1f244d558e438ffac83b
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
force-pushedhttps://github.com/microsoft/TypeScript/compare/587c8a8aaa327e6ae6a22a63da49505601b8a304..166af8caf21c8d423cfb1f244d558e438ffac83b
587c8a8https://github.com/microsoft/TypeScript/commit/587c8a8aaa327e6ae6a22a63da49505601b8a304
166af8chttps://github.com/microsoft/TypeScript/commit/166af8caf21c8d423cfb1f244d558e438ffac83b
Compare https://github.com/microsoft/TypeScript/compare/587c8a8aaa327e6ae6a22a63da49505601b8a304..166af8caf21c8d423cfb1f244d558e438ffac83b
September 7, 2017 03:40https://github.com/microsoft/TypeScript/pull/18300#event-1238029885
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Sep 8, 2017 https://github.com/microsoft/TypeScript/pull/18300#ref-issue-256356481
Design Meeting Notes, 9/8/2017 #18339 https://github.com/microsoft/TypeScript/issues/18339
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
September 14, 2017 14:00https://github.com/microsoft/TypeScript/pull/18300#commits-pushed-aa634ba
https://github.com/DanielRosenwasser
Added printer test for 'new (f().x)'.https://github.com/microsoft/TypeScript/pull/18300/commits/aa634ba7c0309b0ee5ae42c475f70a510ac68aae
aa634bahttps://github.com/microsoft/TypeScript/pull/18300/commits/aa634ba7c0309b0ee5ae42c475f70a510ac68aae
https://github.com/DanielRosenwasser
Accepted (incorrect) baselines.https://github.com/microsoft/TypeScript/pull/18300/commits/4beb9b09645c4a8c152632c0668cea18b0882d8e
4beb9b0https://github.com/microsoft/TypeScript/pull/18300/commits/4beb9b09645c4a8c152632c0668cea18b0882d8e
https://github.com/DanielRosenwasser
Parenthesize new'd expressions based on the leftmost node (or the fir…https://github.com/microsoft/TypeScript/pull/18300/commits/6a9fa839e6342e4ead060e1f898114a732b5a5c9
6a9fa83https://github.com/microsoft/TypeScript/pull/18300/commits/6a9fa839e6342e4ead060e1f898114a732b5a5c9
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/18300/commits/c966059de144e342b3726cfc3b4cc14fc892fe5f
c966059https://github.com/microsoft/TypeScript/pull/18300/commits/c966059de144e342b3726cfc3b4cc14fc892fe5f
https://github.com/DanielRosenwasser
Add a test case for conditional expressions just in case.https://github.com/microsoft/TypeScript/pull/18300/commits/8fbb30453f695a35f6f4a48e2a75a4b5ff220751
8fbb304https://github.com/microsoft/TypeScript/pull/18300/commits/8fbb30453f695a35f6f4a48e2a75a4b5ff220751
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/18300/commits/7871e08502ea45a4864669d76585134be00e8995
7871e08https://github.com/microsoft/TypeScript/pull/18300/commits/7871e08502ea45a4864669d76585134be00e8995
https://github.com/DanielRosenwasser
Explicit fall-through.https://github.com/microsoft/TypeScript/pull/18300/commits/9f669d007409b00026e39ac5e8b64e4d417a5ca2
9f669d0https://github.com/microsoft/TypeScript/pull/18300/commits/9f669d007409b00026e39ac5e8b64e4d417a5ca2
https://github.com/DanielRosenwasser
Remove freezing behavior from tagged template helper.https://github.com/microsoft/TypeScript/pull/18300/commits/e9c6dfe7b5ef086e6ed2f4fc41091806486321f6
e9c6dfehttps://github.com/microsoft/TypeScript/pull/18300/commits/e9c6dfe7b5ef086e6ed2f4fc41091806486321f6
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/18300/commits/16567907492985dddc021ae8f14ebb9679dcc699
1656790https://github.com/microsoft/TypeScript/pull/18300/commits/16567907492985dddc021ae8f14ebb9679dcc699
https://github.com/DanielRosenwasser
%s/getTemplateObject/makeTemplateObjecthttps://github.com/microsoft/TypeScript/pull/18300/commits/b137f24eb71b97be20feee7d77b465e23bb864e9
b137f24https://github.com/microsoft/TypeScript/pull/18300/commits/b137f24eb71b97be20feee7d77b465e23bb864e9
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/18300/commits/55657093d3509d8711234b32b95ec2d733c8296b
5565709https://github.com/microsoft/TypeScript/pull/18300/commits/55657093d3509d8711234b32b95ec2d733c8296b
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Sep 18, 2017 https://github.com/microsoft/TypeScript/pull/18300#ref-pullrequest-258631476
Add the '__makeTemplateObject' helper. microsoft/tslib#39 https://github.com/microsoft/tslib/pull/39
https://github.com/DanielRosenwasser
Merge branch 'master' into correctlyCacheTaggedTemplateshttps://github.com/microsoft/TypeScript/pull/18300/commits/9907453e5fb0dfa3103a23240135336d8ebf6e17
9907453https://github.com/microsoft/TypeScript/pull/18300/commits/9907453e5fb0dfa3103a23240135336d8ebf6e17
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Sep 21, 2017 https://github.com/microsoft/TypeScript/pull/18300#ref-issue-259642803
Incorrect emit for IIFE with assertion in property access in call expression #18668 https://github.com/microsoft/TypeScript/issues/18668
https://github.com/DanielRosenwasser
Merge branch 'master' into correctlyCacheTaggedTemplateshttps://github.com/microsoft/TypeScript/pull/18300/commits/1cb5eb968543c284456f756efbb3e093295ef8f4
1cb5eb9https://github.com/microsoft/TypeScript/pull/18300/commits/1cb5eb968543c284456f756efbb3e093295ef8f4
https://github.com/msftgits
Microsoft GitHub User (msftgits)https://github.com/msftgits
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Sep 26, 2017https://github.com/microsoft/TypeScript/pull/18300#event-1265655690
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
September 27, 2017 17:07https://github.com/microsoft/TypeScript/pull/18300#commits-pushed-886a29b
https://github.com/DanielRosenwasser
Added tests for import helpers with & without a declared template obj…https://github.com/microsoft/TypeScript/pull/18300/commits/886a29b5126518d9bb131313d2ff78b01645d639
886a29bhttps://github.com/microsoft/TypeScript/pull/18300/commits/886a29b5126518d9bb131313d2ff78b01645d639
https://github.com/DanielRosenwasser
Ensure that the import helper is checked for tagged templates, and up…https://github.com/microsoft/TypeScript/pull/18300/commits/1841afeaa2254ee32d50ac49d2f27e6ad8e3ccb8
1841afehttps://github.com/microsoft/TypeScript/pull/18300/commits/1841afeaa2254ee32d50ac49d2f27e6ad8e3ccb8
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/18300/commits/0b7538d04daf2d3015d23eafa4605a2866be23a0
0b7538dhttps://github.com/microsoft/TypeScript/pull/18300/commits/0b7538d04daf2d3015d23eafa4605a2866be23a0
https://github.com/DanielRosenwasser
git Merge branch 'master' into correctlyCacheTaggedTemplateshttps://github.com/microsoft/TypeScript/pull/18300/commits/b406d5453e421192fcfe856102347bba4de2e0b8
b406d54https://github.com/microsoft/TypeScript/pull/18300/commits/b406d5453e421192fcfe856102347bba4de2e0b8
https://github.com/DanielRosenwasser
Fall back to old behavior for tagged template emit in global files.https://github.com/microsoft/TypeScript/pull/18300/commits/4ec1643ecc56dcf95c7dcc11d7a35c5ebc861dea
4ec1643https://github.com/microsoft/TypeScript/pull/18300/commits/4ec1643ecc56dcf95c7dcc11d7a35c5ebc861dea
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Sep 29, 2017 https://github.com/microsoft/TypeScript/pull/18300#pullrequestreview-66260420
View reviewed changes https://github.com/microsoft/TypeScript/pull/18300/files
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/18300/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Deleted user (ghost)https://github.com/ghost
Sep 29, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r141958632
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Sep 30, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r141998680
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/18300/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Deleted user (ghost)https://github.com/ghost
Sep 29, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r141959156
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Sep 30, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r141990145
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#18863https://github.com/microsoft/TypeScript/issues/18863
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
src/compiler/transformers/es2015.tshttps://github.com/microsoft/TypeScript/pull/18300/files#diff-dcd4349c3d05901caf249656675e87a417abb13c0c678026b823e8a259442c34
Deleted user (ghost)https://github.com/ghost
Sep 29, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r141959664
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
src/compiler/transformers/es2015.tshttps://github.com/microsoft/TypeScript/pull/18300/files#diff-dcd4349c3d05901caf249656675e87a417abb13c0c678026b823e8a259442c34
Deleted user (ghost)https://github.com/ghost
Sep 29, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r141960322
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
src/compiler/transformers/es2015.tshttps://github.com/microsoft/TypeScript/pull/18300/files#diff-dcd4349c3d05901caf249656675e87a417abb13c0c678026b823e8a259442c34
Deleted user (ghost)https://github.com/ghost
Sep 29, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r141961285
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
Wesley Wigham (weswigham)https://github.com/weswigham
Sep 29, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r141983191
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Sep 30, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r141990230
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/18300/files#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Deleted user (ghost)https://github.com/ghost
Sep 29, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r141961621
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
Ron Buckton (rbuckton)https://github.com/rbuckton
Oct 2, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r142054853
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 29, 2017 https://github.com/microsoft/TypeScript/pull/18300#pullrequestreview-61273851
View reviewed changes https://github.com/microsoft/TypeScript/pull/18300/files/166af8caf21c8d423cfb1f244d558e438ffac83b
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/18300#pullrequestreview-61273851
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/18300/files/166af8caf21c8d423cfb1f244d558e438ffac83b#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 7, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r137585657
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Sep 30, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r141990258
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
src/compiler/factory.tshttps://github.com/microsoft/TypeScript/pull/18300/files/9f3db7f8e98dbc6f956b200460eb5acb7a2676ab#diff-aa7be70e4da2f4c99dd3bdfeda6e99ea1e8270cf51643ab462aa8a640d8c5c3a
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 28, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r141738814
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
src/compiler/transformers/es2015.tshttps://github.com/microsoft/TypeScript/pull/18300/files/9f3db7f8e98dbc6f956b200460eb5acb7a2676ab#diff-dcd4349c3d05901caf249656675e87a417abb13c0c678026b823e8a259442c34
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 29, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r141979231
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 29, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r141979265
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Sep 29, 2017 https://github.com/microsoft/TypeScript/pull/18300#pullrequestreview-66290394
View reviewed changes https://github.com/microsoft/TypeScript/pull/18300/files
Wesley Wigham (weswigham)https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/18300#pullrequestreview-66290394
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
...s/baselines/reference/printerApi/printsNodeCorrectly.newExpressionOnConditionalExpression.jshttps://github.com/microsoft/TypeScript/pull/18300/files#diff-e6436cc211fd04c900f0995dfd093011d8ccf794bbf5368824d6eb2b9f5a4f0b
Wesley Wigham (weswigham)https://github.com/weswigham
Sep 29, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r141984959
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
Wesley Wigham (weswigham)https://github.com/weswigham
Sep 29, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r141985271
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/18300/commits/d039942d9ac76678f23b0aea29be38f505e5576b
d039942https://github.com/microsoft/TypeScript/pull/18300/commits/d039942d9ac76678f23b0aea29be38f505e5576b
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
force-pushedhttps://github.com/microsoft/TypeScript/compare/9f3db7f8e98dbc6f956b200460eb5acb7a2676ab..f22a1fea050d0fcd464ff3e46ea96e3382d14e57
9f3db7fhttps://github.com/microsoft/TypeScript/commit/9f3db7f8e98dbc6f956b200460eb5acb7a2676ab
f22a1fehttps://github.com/microsoft/TypeScript/commit/f22a1fea050d0fcd464ff3e46ea96e3382d14e57
Compare https://github.com/microsoft/TypeScript/compare/9f3db7f8e98dbc6f956b200460eb5acb7a2676ab..f22a1fea050d0fcd464ff3e46ea96e3382d14e57
September 30, 2017 00:14https://github.com/microsoft/TypeScript/pull/18300#event-1272556066
https://github.com/DanielRosenwasser
Addressed code review feedback.https://github.com/microsoft/TypeScript/pull/18300/commits/5da45fb6de74b0776c8dc19118607a213807fbc5
5da45fbhttps://github.com/microsoft/TypeScript/pull/18300/commits/5da45fb6de74b0776c8dc19118607a213807fbc5
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
force-pushedhttps://github.com/microsoft/TypeScript/compare/f22a1fea050d0fcd464ff3e46ea96e3382d14e57..5da45fb6de74b0776c8dc19118607a213807fbc5
f22a1fehttps://github.com/microsoft/TypeScript/commit/f22a1fea050d0fcd464ff3e46ea96e3382d14e57
5da45fbhttps://github.com/microsoft/TypeScript/commit/5da45fb6de74b0776c8dc19118607a213807fbc5
Compare https://github.com/microsoft/TypeScript/compare/f22a1fea050d0fcd464ff3e46ea96e3382d14e57..5da45fb6de74b0776c8dc19118607a213807fbc5
September 30, 2017 00:17https://github.com/microsoft/TypeScript/pull/18300#event-1272557834
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
September 29, 2017 23:01https://github.com/microsoft/TypeScript/pull/18300#commits-pushed-f94bded
https://github.com/DanielRosenwasser
Added test for module & global examples.https://github.com/microsoft/TypeScript/pull/18300/commits/f94bdedc79a0aa386c28c8b5eac26b52b826cec1
f94bdedhttps://github.com/microsoft/TypeScript/pull/18300/commits/f94bdedc79a0aa386c28c8b5eac26b52b826cec1
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/18300/commits/81b3e85592cb0191bb80af8f4a62970cc0ea2873
81b3e85https://github.com/microsoft/TypeScript/pull/18300/commits/81b3e85592cb0191bb80af8f4a62970cc0ea2873
https://github.com/DanielRosenwasser
Updated helper for marginally better minification.https://github.com/microsoft/TypeScript/pull/18300/commits/a23d1bf3ea14a42aa8bac5268881b57fddaf8c8f
a23d1bfhttps://github.com/microsoft/TypeScript/pull/18300/commits/a23d1bf3ea14a42aa8bac5268881b57fddaf8c8f
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/18300/commits/e2c6aac414fba54380c9f43ce3cdf56238417df2
e2c6aachttps://github.com/microsoft/TypeScript/pull/18300/commits/e2c6aac414fba54380c9f43ce3cdf56238417df2
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Oct 1, 2017https://github.com/microsoft/TypeScript/pull/18300#issuecomment-333407232
template literal cache lifetimehttps://github.com/tc39/ecma262/pull/890
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Oct 2, 2017https://github.com/microsoft/TypeScript/pull/18300#issuecomment-333434357
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
Ron Buckton (@rbuckton)https://github.com/rbuckton
Brandon CS Sanders (@sanders)https://github.com/sanders
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Oct 2, 2017 https://github.com/microsoft/TypeScript/pull/18300#pullrequestreview-61107604
View reviewed changes https://github.com/microsoft/TypeScript/pull/18300/files/166af8caf21c8d423cfb1f244d558e438ffac83b
src/compiler/transformers/es2015.tshttps://github.com/microsoft/TypeScript/pull/18300/files/166af8caf21c8d423cfb1f244d558e438ffac83b#diff-dcd4349c3d05901caf249656675e87a417abb13c0c678026b823e8a259442c34
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 7, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r137441002
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/18300/files#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Ron Buckton (rbuckton)https://github.com/rbuckton
Oct 2, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r142054853
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
src/compiler/transformers/es2015.tshttps://github.com/microsoft/TypeScript/pull/18300/files/e2c6aac414fba54380c9f43ce3cdf56238417df2#diff-dcd4349c3d05901caf249656675e87a417abb13c0c678026b823e8a259442c34
Ron Buckton (rbuckton)https://github.com/rbuckton
Oct 2, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r142055096
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Oct 2, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r142069885
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
Wesley Wigham (weswigham)https://github.com/weswigham
Oct 2, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r142070379
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/18300/files/e2c6aac414fba54380c9f43ce3cdf56238417df2#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Ron Buckton (rbuckton)https://github.com/rbuckton
Oct 2, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r142055257
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Oct 2, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r142069800
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Ron Buckton (@rbuckton)https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
Wesley Wigham (weswigham)https://github.com/weswigham
Oct 2, 2017https://github.com/microsoft/TypeScript/pull/18300#discussion_r142071172
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
October 2, 2017 13:23https://github.com/microsoft/TypeScript/pull/18300#commits-pushed-b80b2ee
https://github.com/DanielRosenwasser
Move first/last shortcuts closer to the end of the helper flags.https://github.com/microsoft/TypeScript/pull/18300/commits/b80b2eeaa3500fc63ce478e68a79e5051a6c3df2
b80b2eehttps://github.com/microsoft/TypeScript/pull/18300/commits/b80b2eeaa3500fc63ce478e68a79e5051a6c3df2
https://github.com/DanielRosenwasser
Flatten the '__makeTemplateObject' helper to use less vertical screen…https://github.com/microsoft/TypeScript/pull/18300/commits/babe3cb9311ee423f4b8421b06f30380ca22c922
babe3cbhttps://github.com/microsoft/TypeScript/pull/18300/commits/babe3cb9311ee423f4b8421b06f30380ca22c922
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/18300/commits/8fd638c7a8449e0d15f0f32e2557f08f26c95c9e
8fd638chttps://github.com/microsoft/TypeScript/pull/18300/commits/8fd638c7a8449e0d15f0f32e2557f08f26c95c9e
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Oct 3, 2017https://github.com/microsoft/TypeScript/pull/18300#event-1276629947
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
301c90chttps://github.com/microsoft/TypeScript/commit/301c90ccff03e2980cd5871c470c9e864209560e
Oct 3, 2017https://github.com/microsoft/TypeScript/pull/18300#event-1276630522
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
October 3, 2017 19:07https://github.com/microsoft/TypeScript/pull/18300#event-1276630956
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 14, 2018https://github.com/microsoft/TypeScript/pull/18300#event-1682130117
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18300
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/18300/files/e2c6aac414fba54380c9f43ce3cdf56238417df2
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/18300/files/166af8caf21c8d423cfb1f244d558e438ffac83b
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
https://github.com/microsoft/TypeScript/pull/18300/files/166af8caf21c8d423cfb1f244d558e438ffac83b
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18300
https://github.com/DanielRosenwasser
https://github.com/rbuckton
https://github.com/sandersn
https://github.com/weswigham
https://github.com/msftclas
https://github.com/msftgits
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.