| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:857f66a6-dc79-4dd6-fa3b-0c9e46316dd2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8D1E:26ECEB:2ABE6E5:36550DB:6B019700 |
| html-safe-nonce | de1a468e06ceffb2ff85cce96788d357ac9a23ca876067ffb86a90e1ed2b0e7c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDFFOjI2RUNFQjoyQUJFNkU1OjM2NTUwREI6NkIwMTk3MDAiLCJ2aXNpdG9yX2lkIjoiNDY1ODI0MDE0MTQwNjYwNzEwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5a820cba3a1a0d41aba639db5499be5e410e14f64031c2c67695bd02b2973cc9 |
| hovercard-subject-tag | pull_request:139708946 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/18300/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3d4928e51f52b230d93dd8539faf801aa56b591607f20eb9282386e6158ee274/microsoft/TypeScript/pull/18300 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3d4928e51f52b230d93dd8539faf801aa56b591607f20eb9282386e6158ee274/microsoft/TypeScript/pull/18300 |
| og:image:alt | This PR is a work in progress at the moment
Remaining things to work on:
Bikeshed on helper name.
Bikeshed on helper semantics
Bikeshed on template object initialization location
Add helper fo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DanielRosenwasser |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/18300#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18300 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18300 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/18300 |
| Reload | https://github.com/microsoft/TypeScript/pull/18300 |
| Reload | https://github.com/microsoft/TypeScript/pull/18300 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests312 (312) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| master | https://github.com/microsoft/TypeScript/tree/master |
| correctlyCacheTaggedTemplates | https://github.com/microsoft/TypeScript/tree/correctlyCacheTaggedTemplates |
| Conversation | https://github.com/microsoft/TypeScript/pull/18300 |
| Commits29 (29) | https://github.com/microsoft/TypeScript/pull/18300/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/18300/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/18300/files |
| Correctly cache tagged template objects in modules | https://github.com/microsoft/TypeScript/pull/18300#top |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| master | https://github.com/microsoft/TypeScript/tree/master |
| correctlyCacheTaggedTemplates | https://github.com/microsoft/TypeScript/tree/correctlyCacheTaggedTemplates |
|
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18300#issue-255803771 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| #17956 | https://github.com/microsoft/TypeScript/issues/17956 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| https://github.com/msftclas |
| Microsoft Contribution License Agreements (msftclas) | https://github.com/msftclas |
|
cla-not-required
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18300#event-1238020081 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Sep 7, 2017
| https://github.com/microsoft/TypeScript/pull/18300#pullrequestreview-61105431 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/18300/files |
| tests/baselines/reference/taggedTemplateStringsWithManyCallAndMemberExpressions.js | https://github.com/microsoft/TypeScript/pull/18300/files#diff-eb4e105a0fd9897118ea4e0f0859d571b06ad290c6c7677c05c78a9b64672545 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r137439176 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Ron Buckton (@rbuckton) | https://github.com/rbuckton |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| September 7, 2017 03:28 | https://github.com/microsoft/TypeScript/pull/18300#event-1238021377 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Sep 7, 2017
| https://github.com/microsoft/TypeScript/pull/18300#ref-issue-251797379 |
|
Tagged template literals compiled incorrectly, TemplateStringsArray not cached
#17956
| https://github.com/microsoft/TypeScript/issues/17956 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| September 6, 2017 20:39 | https://github.com/microsoft/TypeScript/pull/18300#commits-pushed-c4b1a9d |
|
| https://github.com/DanielRosenwasser |
| Update emit for tagged templates to use a per-site cached template ob… | https://github.com/microsoft/TypeScript/pull/18300/commits/c4b1a9d94fa8006c4c41eb76d768500b2322432d |
| c4b1a9d | https://github.com/microsoft/TypeScript/pull/18300/commits/c4b1a9d94fa8006c4c41eb76d768500b2322432d |
|
| https://github.com/DanielRosenwasser |
| Accepted baselines. | https://github.com/microsoft/TypeScript/pull/18300/commits/166af8caf21c8d423cfb1f244d558e438ffac83b |
| 166af8c | https://github.com/microsoft/TypeScript/pull/18300/commits/166af8caf21c8d423cfb1f244d558e438ffac83b |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| force-pushed | https://github.com/microsoft/TypeScript/compare/587c8a8aaa327e6ae6a22a63da49505601b8a304..166af8caf21c8d423cfb1f244d558e438ffac83b |
| 587c8a8 | https://github.com/microsoft/TypeScript/commit/587c8a8aaa327e6ae6a22a63da49505601b8a304 |
| 166af8c | https://github.com/microsoft/TypeScript/commit/166af8caf21c8d423cfb1f244d558e438ffac83b |
|
Compare
| https://github.com/microsoft/TypeScript/compare/587c8a8aaa327e6ae6a22a63da49505601b8a304..166af8caf21c8d423cfb1f244d558e438ffac83b |
| September 7, 2017 03:40 | https://github.com/microsoft/TypeScript/pull/18300#event-1238029885 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Sep 8, 2017
| https://github.com/microsoft/TypeScript/pull/18300#ref-issue-256356481 |
|
Design Meeting Notes, 9/8/2017
#18339
| https://github.com/microsoft/TypeScript/issues/18339 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| September 14, 2017 14:00 | https://github.com/microsoft/TypeScript/pull/18300#commits-pushed-aa634ba |
|
| https://github.com/DanielRosenwasser |
| Added printer test for 'new (f().x)'. | https://github.com/microsoft/TypeScript/pull/18300/commits/aa634ba7c0309b0ee5ae42c475f70a510ac68aae |
| aa634ba | https://github.com/microsoft/TypeScript/pull/18300/commits/aa634ba7c0309b0ee5ae42c475f70a510ac68aae |
|
| https://github.com/DanielRosenwasser |
| Accepted (incorrect) baselines. | https://github.com/microsoft/TypeScript/pull/18300/commits/4beb9b09645c4a8c152632c0668cea18b0882d8e |
| 4beb9b0 | https://github.com/microsoft/TypeScript/pull/18300/commits/4beb9b09645c4a8c152632c0668cea18b0882d8e |
|
| https://github.com/DanielRosenwasser |
| Parenthesize new'd expressions based on the leftmost node (or the fir… | https://github.com/microsoft/TypeScript/pull/18300/commits/6a9fa839e6342e4ead060e1f898114a732b5a5c9 |
| 6a9fa83 | https://github.com/microsoft/TypeScript/pull/18300/commits/6a9fa839e6342e4ead060e1f898114a732b5a5c9 |
|
| https://github.com/DanielRosenwasser |
| Accepted baselines. | https://github.com/microsoft/TypeScript/pull/18300/commits/c966059de144e342b3726cfc3b4cc14fc892fe5f |
| c966059 | https://github.com/microsoft/TypeScript/pull/18300/commits/c966059de144e342b3726cfc3b4cc14fc892fe5f |
|
| https://github.com/DanielRosenwasser |
| Add a test case for conditional expressions just in case. | https://github.com/microsoft/TypeScript/pull/18300/commits/8fbb30453f695a35f6f4a48e2a75a4b5ff220751 |
| 8fbb304 | https://github.com/microsoft/TypeScript/pull/18300/commits/8fbb30453f695a35f6f4a48e2a75a4b5ff220751 |
|
| https://github.com/DanielRosenwasser |
| Accepted baselines. | https://github.com/microsoft/TypeScript/pull/18300/commits/7871e08502ea45a4864669d76585134be00e8995 |
| 7871e08 | https://github.com/microsoft/TypeScript/pull/18300/commits/7871e08502ea45a4864669d76585134be00e8995 |
|
| https://github.com/DanielRosenwasser |
| Explicit fall-through. | https://github.com/microsoft/TypeScript/pull/18300/commits/9f669d007409b00026e39ac5e8b64e4d417a5ca2 |
| 9f669d0 | https://github.com/microsoft/TypeScript/pull/18300/commits/9f669d007409b00026e39ac5e8b64e4d417a5ca2 |
|
| https://github.com/DanielRosenwasser |
| Remove freezing behavior from tagged template helper. | https://github.com/microsoft/TypeScript/pull/18300/commits/e9c6dfe7b5ef086e6ed2f4fc41091806486321f6 |
| e9c6dfe | https://github.com/microsoft/TypeScript/pull/18300/commits/e9c6dfe7b5ef086e6ed2f4fc41091806486321f6 |
|
| https://github.com/DanielRosenwasser |
| Accepted baselines. | https://github.com/microsoft/TypeScript/pull/18300/commits/16567907492985dddc021ae8f14ebb9679dcc699 |
| 1656790 | https://github.com/microsoft/TypeScript/pull/18300/commits/16567907492985dddc021ae8f14ebb9679dcc699 |
|
| https://github.com/DanielRosenwasser |
| %s/getTemplateObject/makeTemplateObject | https://github.com/microsoft/TypeScript/pull/18300/commits/b137f24eb71b97be20feee7d77b465e23bb864e9 |
| b137f24 | https://github.com/microsoft/TypeScript/pull/18300/commits/b137f24eb71b97be20feee7d77b465e23bb864e9 |
|
| https://github.com/DanielRosenwasser |
| Accepted baselines. | https://github.com/microsoft/TypeScript/pull/18300/commits/55657093d3509d8711234b32b95ec2d733c8296b |
| 5565709 | https://github.com/microsoft/TypeScript/pull/18300/commits/55657093d3509d8711234b32b95ec2d733c8296b |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Sep 18, 2017
| https://github.com/microsoft/TypeScript/pull/18300#ref-pullrequest-258631476 |
|
Add the '__makeTemplateObject' helper.
microsoft/tslib#39
| https://github.com/microsoft/tslib/pull/39 |
|
| https://github.com/DanielRosenwasser |
| Merge branch 'master' into correctlyCacheTaggedTemplates | https://github.com/microsoft/TypeScript/pull/18300/commits/9907453e5fb0dfa3103a23240135336d8ebf6e17 |
| 9907453 | https://github.com/microsoft/TypeScript/pull/18300/commits/9907453e5fb0dfa3103a23240135336d8ebf6e17 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Sep 21, 2017
| https://github.com/microsoft/TypeScript/pull/18300#ref-issue-259642803 |
|
Incorrect emit for IIFE with assertion in property access in call expression
#18668
| https://github.com/microsoft/TypeScript/issues/18668 |
|
| https://github.com/DanielRosenwasser |
| Merge branch 'master' into correctlyCacheTaggedTemplates | https://github.com/microsoft/TypeScript/pull/18300/commits/1cb5eb968543c284456f756efbb3e093295ef8f4 |
| 1cb5eb9 | https://github.com/microsoft/TypeScript/pull/18300/commits/1cb5eb968543c284456f756efbb3e093295ef8f4 |
| https://github.com/msftgits |
| Microsoft GitHub User (msftgits) | https://github.com/msftgits |
|
cla-not-required
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required |
| Sep 26, 2017 | https://github.com/microsoft/TypeScript/pull/18300#event-1265655690 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| September 27, 2017 17:07 | https://github.com/microsoft/TypeScript/pull/18300#commits-pushed-886a29b |
|
| https://github.com/DanielRosenwasser |
| Added tests for import helpers with & without a declared template obj… | https://github.com/microsoft/TypeScript/pull/18300/commits/886a29b5126518d9bb131313d2ff78b01645d639 |
| 886a29b | https://github.com/microsoft/TypeScript/pull/18300/commits/886a29b5126518d9bb131313d2ff78b01645d639 |
|
| https://github.com/DanielRosenwasser |
| Ensure that the import helper is checked for tagged templates, and up… | https://github.com/microsoft/TypeScript/pull/18300/commits/1841afeaa2254ee32d50ac49d2f27e6ad8e3ccb8 |
| 1841afe | https://github.com/microsoft/TypeScript/pull/18300/commits/1841afeaa2254ee32d50ac49d2f27e6ad8e3ccb8 |
|
| https://github.com/DanielRosenwasser |
| Accepted baselines. | https://github.com/microsoft/TypeScript/pull/18300/commits/0b7538d04daf2d3015d23eafa4605a2866be23a0 |
| 0b7538d | https://github.com/microsoft/TypeScript/pull/18300/commits/0b7538d04daf2d3015d23eafa4605a2866be23a0 |
|
| https://github.com/DanielRosenwasser |
| git Merge branch 'master' into correctlyCacheTaggedTemplates | https://github.com/microsoft/TypeScript/pull/18300/commits/b406d5453e421192fcfe856102347bba4de2e0b8 |
| b406d54 | https://github.com/microsoft/TypeScript/pull/18300/commits/b406d5453e421192fcfe856102347bba4de2e0b8 |
|
| https://github.com/DanielRosenwasser |
| Fall back to old behavior for tagged template emit in global files. | https://github.com/microsoft/TypeScript/pull/18300/commits/4ec1643ecc56dcf95c7dcc11d7a35c5ebc861dea |
| 4ec1643 | https://github.com/microsoft/TypeScript/pull/18300/commits/4ec1643ecc56dcf95c7dcc11d7a35c5ebc861dea |
| https://github.com/ghost |
| Deleted user (ghost) | https://github.com/ghost |
|
Sep 29, 2017
| https://github.com/microsoft/TypeScript/pull/18300#pullrequestreview-66260420 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/18300/files |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/18300/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Deleted user (ghost) | https://github.com/ghost |
| Sep 29, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r141958632 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Sep 30, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r141998680 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/18300/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Deleted user (ghost) | https://github.com/ghost |
| Sep 29, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r141959156 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Sep 30, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r141990145 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #18863 | https://github.com/microsoft/TypeScript/issues/18863 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| src/compiler/transformers/es2015.ts | https://github.com/microsoft/TypeScript/pull/18300/files#diff-dcd4349c3d05901caf249656675e87a417abb13c0c678026b823e8a259442c34 |
| Deleted user (ghost) | https://github.com/ghost |
| Sep 29, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r141959664 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| src/compiler/transformers/es2015.ts | https://github.com/microsoft/TypeScript/pull/18300/files#diff-dcd4349c3d05901caf249656675e87a417abb13c0c678026b823e8a259442c34 |
| Deleted user (ghost) | https://github.com/ghost |
| Sep 29, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r141960322 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| src/compiler/transformers/es2015.ts | https://github.com/microsoft/TypeScript/pull/18300/files#diff-dcd4349c3d05901caf249656675e87a417abb13c0c678026b823e8a259442c34 |
| Deleted user (ghost) | https://github.com/ghost |
| Sep 29, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r141961285 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Sep 29, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r141983191 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Sep 30, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r141990230 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| src/compiler/types.ts | https://github.com/microsoft/TypeScript/pull/18300/files#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560 |
| Deleted user (ghost) | https://github.com/ghost |
| Sep 29, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r141961621 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Oct 2, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r142054853 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Sep 29, 2017
| https://github.com/microsoft/TypeScript/pull/18300#pullrequestreview-61273851 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/18300/files/166af8caf21c8d423cfb1f244d558e438ffac83b |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| https://github.com/microsoft/TypeScript/pull/18300#pullrequestreview-61273851 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| src/compiler/types.ts | https://github.com/microsoft/TypeScript/pull/18300/files/166af8caf21c8d423cfb1f244d558e438ffac83b#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r137585657 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Sep 30, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r141990258 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| src/compiler/factory.ts | https://github.com/microsoft/TypeScript/pull/18300/files/9f3db7f8e98dbc6f956b200460eb5acb7a2676ab#diff-aa7be70e4da2f4c99dd3bdfeda6e99ea1e8270cf51643ab462aa8a640d8c5c3a |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Sep 28, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r141738814 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| src/compiler/transformers/es2015.ts | https://github.com/microsoft/TypeScript/pull/18300/files/9f3db7f8e98dbc6f956b200460eb5acb7a2676ab#diff-dcd4349c3d05901caf249656675e87a417abb13c0c678026b823e8a259442c34 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Sep 29, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r141979231 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Sep 29, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r141979265 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
|
Sep 29, 2017
| https://github.com/microsoft/TypeScript/pull/18300#pullrequestreview-66290394 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/18300/files |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| https://github.com/microsoft/TypeScript/pull/18300#pullrequestreview-66290394 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| ...s/baselines/reference/printerApi/printsNodeCorrectly.newExpressionOnConditionalExpression.js | https://github.com/microsoft/TypeScript/pull/18300/files#diff-e6436cc211fd04c900f0995dfd093011d8ccf794bbf5368824d6eb2b9f5a4f0b |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Sep 29, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r141984959 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Sep 29, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r141985271 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
|
| https://github.com/DanielRosenwasser |
| Accepted baselines. | https://github.com/microsoft/TypeScript/pull/18300/commits/d039942d9ac76678f23b0aea29be38f505e5576b |
| d039942 | https://github.com/microsoft/TypeScript/pull/18300/commits/d039942d9ac76678f23b0aea29be38f505e5576b |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| force-pushed | https://github.com/microsoft/TypeScript/compare/9f3db7f8e98dbc6f956b200460eb5acb7a2676ab..f22a1fea050d0fcd464ff3e46ea96e3382d14e57 |
| 9f3db7f | https://github.com/microsoft/TypeScript/commit/9f3db7f8e98dbc6f956b200460eb5acb7a2676ab |
| f22a1fe | https://github.com/microsoft/TypeScript/commit/f22a1fea050d0fcd464ff3e46ea96e3382d14e57 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/9f3db7f8e98dbc6f956b200460eb5acb7a2676ab..f22a1fea050d0fcd464ff3e46ea96e3382d14e57 |
| September 30, 2017 00:14 | https://github.com/microsoft/TypeScript/pull/18300#event-1272556066 |
|
| https://github.com/DanielRosenwasser |
| Addressed code review feedback. | https://github.com/microsoft/TypeScript/pull/18300/commits/5da45fb6de74b0776c8dc19118607a213807fbc5 |
| 5da45fb | https://github.com/microsoft/TypeScript/pull/18300/commits/5da45fb6de74b0776c8dc19118607a213807fbc5 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| force-pushed | https://github.com/microsoft/TypeScript/compare/f22a1fea050d0fcd464ff3e46ea96e3382d14e57..5da45fb6de74b0776c8dc19118607a213807fbc5 |
| f22a1fe | https://github.com/microsoft/TypeScript/commit/f22a1fea050d0fcd464ff3e46ea96e3382d14e57 |
| 5da45fb | https://github.com/microsoft/TypeScript/commit/5da45fb6de74b0776c8dc19118607a213807fbc5 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/f22a1fea050d0fcd464ff3e46ea96e3382d14e57..5da45fb6de74b0776c8dc19118607a213807fbc5 |
| September 30, 2017 00:17 | https://github.com/microsoft/TypeScript/pull/18300#event-1272557834 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| September 29, 2017 23:01 | https://github.com/microsoft/TypeScript/pull/18300#commits-pushed-f94bded |
|
| https://github.com/DanielRosenwasser |
| Added test for module & global examples. | https://github.com/microsoft/TypeScript/pull/18300/commits/f94bdedc79a0aa386c28c8b5eac26b52b826cec1 |
| f94bded | https://github.com/microsoft/TypeScript/pull/18300/commits/f94bdedc79a0aa386c28c8b5eac26b52b826cec1 |
|
| https://github.com/DanielRosenwasser |
| Accepted baselines. | https://github.com/microsoft/TypeScript/pull/18300/commits/81b3e85592cb0191bb80af8f4a62970cc0ea2873 |
| 81b3e85 | https://github.com/microsoft/TypeScript/pull/18300/commits/81b3e85592cb0191bb80af8f4a62970cc0ea2873 |
|
| https://github.com/DanielRosenwasser |
| Updated helper for marginally better minification. | https://github.com/microsoft/TypeScript/pull/18300/commits/a23d1bf3ea14a42aa8bac5268881b57fddaf8c8f |
| a23d1bf | https://github.com/microsoft/TypeScript/pull/18300/commits/a23d1bf3ea14a42aa8bac5268881b57fddaf8c8f |
|
| https://github.com/DanielRosenwasser |
| Accepted baselines. | https://github.com/microsoft/TypeScript/pull/18300/commits/e2c6aac414fba54380c9f43ce3cdf56238417df2 |
| e2c6aac | https://github.com/microsoft/TypeScript/pull/18300/commits/e2c6aac414fba54380c9f43ce3cdf56238417df2 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Oct 1, 2017 | https://github.com/microsoft/TypeScript/pull/18300#issuecomment-333407232 |
| template literal cache lifetime | https://github.com/tc39/ecma262/pull/890 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Oct 2, 2017 | https://github.com/microsoft/TypeScript/pull/18300#issuecomment-333434357 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| Ron Buckton (@rbuckton) | https://github.com/rbuckton |
| Brandon CS Sanders (@sanders) | https://github.com/sanders |
| Wesley Wigham (@weswigham) | https://github.com/weswigham |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
|
Oct 2, 2017
| https://github.com/microsoft/TypeScript/pull/18300#pullrequestreview-61107604 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/18300/files/166af8caf21c8d423cfb1f244d558e438ffac83b |
| src/compiler/transformers/es2015.ts | https://github.com/microsoft/TypeScript/pull/18300/files/166af8caf21c8d423cfb1f244d558e438ffac83b#diff-dcd4349c3d05901caf249656675e87a417abb13c0c678026b823e8a259442c34 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r137441002 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| src/compiler/types.ts | https://github.com/microsoft/TypeScript/pull/18300/files#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Oct 2, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r142054853 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| src/compiler/transformers/es2015.ts | https://github.com/microsoft/TypeScript/pull/18300/files/e2c6aac414fba54380c9f43ce3cdf56238417df2#diff-dcd4349c3d05901caf249656675e87a417abb13c0c678026b823e8a259442c34 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Oct 2, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r142055096 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Oct 2, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r142069885 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Oct 2, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r142070379 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/18300/files/e2c6aac414fba54380c9f43ce3cdf56238417df2#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Oct 2, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r142055257 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Oct 2, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r142069800 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Ron Buckton (@rbuckton) | https://github.com/rbuckton |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Oct 2, 2017 | https://github.com/microsoft/TypeScript/pull/18300#discussion_r142071172 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| October 2, 2017 13:23 | https://github.com/microsoft/TypeScript/pull/18300#commits-pushed-b80b2ee |
|
| https://github.com/DanielRosenwasser |
| Move first/last shortcuts closer to the end of the helper flags. | https://github.com/microsoft/TypeScript/pull/18300/commits/b80b2eeaa3500fc63ce478e68a79e5051a6c3df2 |
| b80b2ee | https://github.com/microsoft/TypeScript/pull/18300/commits/b80b2eeaa3500fc63ce478e68a79e5051a6c3df2 |
|
| https://github.com/DanielRosenwasser |
| Flatten the '__makeTemplateObject' helper to use less vertical screen… | https://github.com/microsoft/TypeScript/pull/18300/commits/babe3cb9311ee423f4b8421b06f30380ca22c922 |
| babe3cb | https://github.com/microsoft/TypeScript/pull/18300/commits/babe3cb9311ee423f4b8421b06f30380ca22c922 |
|
| https://github.com/DanielRosenwasser |
| Accepted baselines. | https://github.com/microsoft/TypeScript/pull/18300/commits/8fd638c7a8449e0d15f0f32e2557f08f26c95c9e |
| 8fd638c | https://github.com/microsoft/TypeScript/pull/18300/commits/8fd638c7a8449e0d15f0f32e2557f08f26c95c9e |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Oct 3, 2017 | https://github.com/microsoft/TypeScript/pull/18300#event-1276629947 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| 301c90c | https://github.com/microsoft/TypeScript/commit/301c90ccff03e2980cd5871c470c9e864209560e |
| Oct 3, 2017 | https://github.com/microsoft/TypeScript/pull/18300#event-1276630522 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| October 3, 2017 19:07 | https://github.com/microsoft/TypeScript/pull/18300#event-1276630956 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Jun 14, 2018 | https://github.com/microsoft/TypeScript/pull/18300#event-1682130117 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18300 |
|
| https://github.com/weswigham |
|
Wesley Wigham (weswigham)
| https://github.com/weswigham |
|
| https://github.com/microsoft/TypeScript/pull/18300/files/e2c6aac414fba54380c9f43ce3cdf56238417df2 |
|
| https://github.com/sandersn |
|
Nathan Shively-Sanders (sandersn)
| https://github.com/sandersn |
|
| https://github.com/microsoft/TypeScript/pull/18300/files/166af8caf21c8d423cfb1f244d558e438ffac83b |
|
| https://github.com/rbuckton |
|
Ron Buckton (rbuckton)
| https://github.com/rbuckton |
|
| https://github.com/microsoft/TypeScript/pull/18300/files/166af8caf21c8d423cfb1f244d558e438ffac83b |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18300 |
|
| https://github.com/DanielRosenwasser |
|
| https://github.com/rbuckton |
|
| https://github.com/sandersn |
|
| https://github.com/weswigham |
|
| https://github.com/msftclas |
|
| https://github.com/msftgits |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |