René's URL Explorer Experiment


Title: Ensure that emitter calls callbacks · Pull Request #18284 · microsoft/TypeScript · GitHub

Open Graph Title: Ensure that emitter calls callbacks · Pull Request #18284 · microsoft/TypeScript

X Title: Ensure that emitter calls callbacks · Pull Request #18284 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Ensure that emitter calls callbacks · Pull Request #18284 · microsoft/TypeScript

Open Graph Description: Fixes #18091 The bug was happening because in formatting.ts, in processChildNodes, we continue scanning until getting to nodes.pos. Since this is a dynamically typed language, nodes.pos may be unde...

X Description: Fixes #18091 The bug was happening because in formatting.ts, in processChildNodes, we continue scanning until getting to nodes.pos. Since this is a dynamically typed language, nodes.pos may be unde...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/18284

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:28aca416-ca2a-25b6-629f-c6925f08e853
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C32:2F9718:7E19C9:AA9E4F:6B00E2CE
html-safe-noncefddb3d7c3fed146f92990d9661387fb02e78f2bc27024a8ef8ad02df037da761
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzMyOjJGOTcxODo3RTE5Qzk6QUE5RTRGOjZCMDBFMkNFIiwidmlzaXRvcl9pZCI6IjM3NzU0NDYyNzk4NDk1NjY5MjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace74f4d4eff1e5159d8683f2155137fb3a6de0b79c11ab7f03d9c4f8eaddc763b
hovercard-subject-tagpull_request:139656707
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/18284/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ce93c6bab203b8b704e87da557e4504ba4be68a5e4e4ac4fcd06e33f8600152a/microsoft/TypeScript/pull/18284
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ce93c6bab203b8b704e87da557e4504ba4be68a5e4e4ac4fcd06e33f8600152a/microsoft/TypeScript/pull/18284
og:image:altFixes #18091 The bug was happening because in formatting.ts, in processChildNodes, we continue scanning until getting to nodes.pos. Since this is a dynamically typed language, nodes.pos may be unde...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/18284#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18284
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18284
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/18284
Reloadhttps://github.com/microsoft/TypeScript/pull/18284
Reloadhttps://github.com/microsoft/TypeScript/pull/18284
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
masterhttps://github.com/microsoft/TypeScript/tree/master
extract-method-formathttps://github.com/microsoft/TypeScript/tree/extract-method-format
Conversationhttps://github.com/microsoft/TypeScript/pull/18284
Commits9 (9)https://github.com/microsoft/TypeScript/pull/18284/commits
Checkshttps://github.com/microsoft/TypeScript/pull/18284/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/18284/files
Ensure that emitter calls callbackshttps://github.com/microsoft/TypeScript/pull/18284#top
masterhttps://github.com/microsoft/TypeScript/tree/master
extract-method-formathttps://github.com/microsoft/TypeScript/tree/extract-method-format
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Sep 6, 2017https://github.com/microsoft/TypeScript/pull/18284#issue-255731541
#18091https://github.com/microsoft/TypeScript/issues/18091
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
Ensure that emitter calls calbackshttps://github.com/microsoft/TypeScript/pull/18284/commits/98153599f76cf58beef4df916acfcaf9a9ab1527
9815359https://github.com/microsoft/TypeScript/pull/18284/commits/98153599f76cf58beef4df916acfcaf9a9ab1527
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Sep 6, 2017https://github.com/microsoft/TypeScript/pull/18284#event-1237597934
Ron Buckton (rbuckton)https://github.com/rbuckton
September 6, 2017 20:26https://github.com/microsoft/TypeScript/pull/18284#event-1237598174
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Sep 6, 2017 https://github.com/microsoft/TypeScript/pull/18284#pullrequestreview-61040649
View reviewed changes https://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527
src/compiler/factory.tshttps://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527#diff-aa7be70e4da2f4c99dd3bdfeda6e99ea1e8270cf51643ab462aa8a640d8c5c3a
Deleted user (ghost)https://github.com/ghost
Sep 6, 2017https://github.com/microsoft/TypeScript/pull/18284#discussion_r137380730
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Sep 6, 2017https://github.com/microsoft/TypeScript/pull/18284#discussion_r137396224
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 7, 2017https://github.com/microsoft/TypeScript/pull/18284#discussion_r137631063
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
Sep 6, 2017https://github.com/microsoft/TypeScript/pull/18284#event-1237660680
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 6, 2017https://github.com/microsoft/TypeScript/pull/18284#issuecomment-327619541
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
#18091https://github.com/microsoft/TypeScript/issues/18091
#18091https://github.com/microsoft/TypeScript/issues/18091
#18091https://github.com/microsoft/TypeScript/issues/18091
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 6, 2017 https://github.com/microsoft/TypeScript/pull/18284#pullrequestreview-61060444
View reviewed changes https://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527
src/compiler/emitter.tshttps://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 6, 2017https://github.com/microsoft/TypeScript/pull/18284#discussion_r137398685
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
src/compiler/emitter.tshttps://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 6, 2017https://github.com/microsoft/TypeScript/pull/18284#discussion_r137399052
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
src/compiler/emitter.tshttps://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 6, 2017https://github.com/microsoft/TypeScript/pull/18284#discussion_r137399547
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
src/compiler/emitter.tshttps://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 6, 2017https://github.com/microsoft/TypeScript/pull/18284#discussion_r137399630
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
Deleted user (ghost)https://github.com/ghost
Sep 7, 2017https://github.com/microsoft/TypeScript/pull/18284#discussion_r137611034
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
src/compiler/emitter.tshttps://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 6, 2017https://github.com/microsoft/TypeScript/pull/18284#discussion_r137400181
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
src/compiler/emitter.tshttps://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 6, 2017https://github.com/microsoft/TypeScript/pull/18284#discussion_r137401466
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
src/compiler/utilities.tshttps://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527#diff-1516c8349f7a625a2e4a2aa60f6bbe84e4b1a499128e8705d3087d893e01d367
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 6, 2017https://github.com/microsoft/TypeScript/pull/18284#discussion_r137402398
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
Move new parameter to end of parametershttps://github.com/microsoft/TypeScript/pull/18284/commits/7d931bb1cde111aa0e13228189eb488cd9bedca1
7d931bbhttps://github.com/microsoft/TypeScript/pull/18284/commits/7d931bb1cde111aa0e13228189eb488cd9bedca1
force-pushedhttps://github.com/microsoft/TypeScript/compare/495f1a252da8cc952aab9c9e6a8afdbcad8bff10..7d931bb1cde111aa0e13228189eb488cd9bedca1
495f1a2https://github.com/microsoft/TypeScript/commit/495f1a252da8cc952aab9c9e6a8afdbcad8bff10
7d931bbhttps://github.com/microsoft/TypeScript/commit/7d931bb1cde111aa0e13228189eb488cd9bedca1
Compare https://github.com/microsoft/TypeScript/compare/495f1a252da8cc952aab9c9e6a8afdbcad8bff10..7d931bb1cde111aa0e13228189eb488cd9bedca1
September 7, 2017 18:14https://github.com/microsoft/TypeScript/pull/18284#event-1239321647
September 7, 2017 11:14https://github.com/microsoft/TypeScript/pull/18284#commits-pushed-7d56deb
Merge branch 'master' into extract-method-formathttps://github.com/microsoft/TypeScript/pull/18284/commits/7d56deb12ea959860997e6face7ae6dfd198d9cc
7d56debhttps://github.com/microsoft/TypeScript/pull/18284/commits/7d56deb12ea959860997e6face7ae6dfd198d9cc
Fix for ConditionalExpressionhttps://github.com/microsoft/TypeScript/pull/18284/commits/5b44de1f1502216dd4901069e15bd8490d2ca221
5b44de1https://github.com/microsoft/TypeScript/pull/18284/commits/5b44de1f1502216dd4901069e15bd8490d2ca221
force-pushedhttps://github.com/microsoft/TypeScript/compare/49e21b1ad64f998f4063be5e4633b1381da02506..5b44de1f1502216dd4901069e15bd8490d2ca221
49e21b1https://github.com/microsoft/TypeScript/commit/49e21b1ad64f998f4063be5e4633b1381da02506
5b44de1https://github.com/microsoft/TypeScript/commit/5b44de1f1502216dd4901069e15bd8490d2ca221
Compare https://github.com/microsoft/TypeScript/compare/49e21b1ad64f998f4063be5e4633b1381da02506..5b44de1f1502216dd4901069e15bd8490d2ca221
September 7, 2017 18:44https://github.com/microsoft/TypeScript/pull/18284#event-1239370825
Make suggested changes to emitterhttps://github.com/microsoft/TypeScript/pull/18284/commits/aae877d6fb5881a5977d8a00002bd529e02bc8b3
aae877dhttps://github.com/microsoft/TypeScript/pull/18284/commits/aae877d6fb5881a5977d8a00002bd529e02bc8b3
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 7, 2017 https://github.com/microsoft/TypeScript/pull/18284#pullrequestreview-61323851
View reviewed changes https://github.com/microsoft/TypeScript/pull/18284/files/aae877d6fb5881a5977d8a00002bd529e02bc8b3
src/compiler/factory.tshttps://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527..aae877d6fb5881a5977d8a00002bd529e02bc8b3#diff-aa7be70e4da2f4c99dd3bdfeda6e99ea1e8270cf51643ab462aa8a640d8c5c3a
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 7, 2017https://github.com/microsoft/TypeScript/pull/18284#discussion_r137630915
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
src/compiler/factory.tshttps://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527#diff-aa7be70e4da2f4c99dd3bdfeda6e99ea1e8270cf51643ab462aa8a640d8c5c3a
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 7, 2017https://github.com/microsoft/TypeScript/pull/18284#discussion_r137631063
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 7, 2017 https://github.com/microsoft/TypeScript/pull/18284#pullrequestreview-61324253
View reviewed changes https://github.com/microsoft/TypeScript/pull/18284/files/aae877d6fb5881a5977d8a00002bd529e02bc8b3
src/compiler/factory.tshttps://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527..aae877d6fb5881a5977d8a00002bd529e02bc8b3#diff-aa7be70e4da2f4c99dd3bdfeda6e99ea1e8270cf51643ab462aa8a640d8c5c3a
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 7, 2017https://github.com/microsoft/TypeScript/pull/18284#discussion_r137631235
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527..aae877d6fb5881a5977d8a00002bd529e02bc8b3#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 7, 2017https://github.com/microsoft/TypeScript/pull/18284#discussion_r137631439
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
src/compiler/visitor.tshttps://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527..aae877d6fb5881a5977d8a00002bd529e02bc8b3#diff-64a8e8375642131c99e3999316e14d2ad3839d25972934d69aa87b51d5076386
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 7, 2017https://github.com/microsoft/TypeScript/pull/18284#discussion_r137631856
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
src/compiler/visitor.tshttps://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527..aae877d6fb5881a5977d8a00002bd529e02bc8b3#diff-64a8e8375642131c99e3999316e14d2ad3839d25972934d69aa87b51d5076386
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 7, 2017https://github.com/microsoft/TypeScript/pull/18284#discussion_r137631882
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
src/compiler/visitor.tshttps://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527..aae877d6fb5881a5977d8a00002bd529e02bc8b3#diff-64a8e8375642131c99e3999316e14d2ad3839d25972934d69aa87b51d5076386
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 7, 2017https://github.com/microsoft/TypeScript/pull/18284#discussion_r137631912
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
September 7, 2017 12:57https://github.com/microsoft/TypeScript/pull/18284#commits-pushed-8f775dc
Fix parameter orderinghttps://github.com/microsoft/TypeScript/pull/18284/commits/8f775dc117645461ff26ccc2d726c1ad535aebc4
8f775dchttps://github.com/microsoft/TypeScript/pull/18284/commits/8f775dc117645461ff26ccc2d726c1ad535aebc4
Respond to minor commentshttps://github.com/microsoft/TypeScript/pull/18284/commits/bca3b097004a784aa2bafff1d280aa55b2ade602
bca3b09https://github.com/microsoft/TypeScript/pull/18284/commits/bca3b097004a784aa2bafff1d280aa55b2ade602
Remove potentially expensive assertionhttps://github.com/microsoft/TypeScript/pull/18284/commits/15e26635e93fa5d6bdf0ac16223cbed15d2705ec
15e2663https://github.com/microsoft/TypeScript/pull/18284/commits/15e26635e93fa5d6bdf0ac16223cbed15d2705ec
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Sep 7, 2017https://github.com/microsoft/TypeScript/pull/18284#issuecomment-327926843
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 7, 2017 https://github.com/microsoft/TypeScript/pull/18284#pullrequestreview-61352218
View reviewed changes https://github.com/microsoft/TypeScript/pull/18284/files/15e26635e93fa5d6bdf0ac16223cbed15d2705ec
Ron Buckton (rbuckton)https://github.com/rbuckton
https://github.com/microsoft/TypeScript/pull/18284#pullrequestreview-61352218
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
src/compiler/emitter.tshttps://github.com/microsoft/TypeScript/pull/18284/files/15e26635e93fa5d6bdf0ac16223cbed15d2705ec#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8
Ron Buckton (rbuckton)https://github.com/rbuckton
Sep 7, 2017https://github.com/microsoft/TypeScript/pull/18284#discussion_r137655328
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
More emitter cleanuphttps://github.com/microsoft/TypeScript/pull/18284/commits/b33dbecfd60b6665e744b0e3219012a73eda2222
b33dbechttps://github.com/microsoft/TypeScript/pull/18284/commits/b33dbecfd60b6665e744b0e3219012a73eda2222
ed4e2e6https://github.com/microsoft/TypeScript/commit/ed4e2e6e3b66e43ce3e4807be342f3b235e0bb73
Sep 7, 2017https://github.com/microsoft/TypeScript/pull/18284#event-1239783230
September 7, 2017 21:30https://github.com/microsoft/TypeScript/pull/18284#event-1239783342
Sep 7, 2017 https://github.com/microsoft/TypeScript/pull/18284#ref-commit-80166c5
Ensure that emitter calls callbacks (https://github.com/microsoft/TypeScript/commit/80166c5f047f7dad5a505b1f7efaa1e2adb64319
#18284https://github.com/microsoft/TypeScript/pull/18284
)https://github.com/microsoft/TypeScript/commit/80166c5f047f7dad5a505b1f7efaa1e2adb64319
80166c5https://github.com/microsoft/TypeScript/commit/80166c5f047f7dad5a505b1f7efaa1e2adb64319
Sep 7, 2017 https://github.com/microsoft/TypeScript/pull/18284#ref-pullrequest-256079809
Ensure that emitter calls callbacks () #18325 https://github.com/microsoft/TypeScript/pull/18325
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Sep 7, 2017https://github.com/microsoft/TypeScript/pull/18284#issuecomment-327941643
Andy (Andrewkraft) (@Andy-MS)https://github.com/Andy-MS
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Sep 7, 2017 https://github.com/microsoft/TypeScript/pull/18284#ref-commit-f5b9e30
https://github.com/mhegazy
Ensure that emitter calls callbacks (https://github.com/microsoft/TypeScript/commit/f5b9e30986d2195b286c6a9b71a1de6ce89d8e9c
#18284https://github.com/microsoft/TypeScript/pull/18284
) (https://github.com/microsoft/TypeScript/commit/f5b9e30986d2195b286c6a9b71a1de6ce89d8e9c
#18325https://github.com/microsoft/TypeScript/pull/18325
)https://github.com/microsoft/TypeScript/commit/f5b9e30986d2195b286c6a9b71a1de6ce89d8e9c
f5b9e30https://github.com/microsoft/TypeScript/commit/f5b9e30986d2195b286c6a9b71a1de6ce89d8e9c
Fixes to emit / format for codeFix #18484 https://github.com/microsoft/TypeScript/pull/18484
Ensure that emitter calls callbacks for empty blocks #18547 https://github.com/microsoft/TypeScript/pull/18547
Sep 22, 2017 https://github.com/microsoft/TypeScript/pull/18284#ref-issue-259654067
getEditsForRefactor debug failure in js file #18671 https://github.com/microsoft/TypeScript/issues/18671
Should this just be emit? imdone/TypeScript#90 https://github.com/imdone/TypeScript/issues/90
Should this just be emit? imdone/TypeScript#127 https://github.com/imdone/TypeScript/issues/127
Should this just be emit? imdone/TypeScript#192 https://github.com/imdone/TypeScript/issues/192
Should this just be emit? imdone/TypeScript#714 https://github.com/imdone/TypeScript/issues/714
Feb 8, 2018 https://github.com/microsoft/TypeScript/pull/18284#ref-pullrequest-295692725
Fix bug: Don't skip emitting JSX attributes #21777 https://github.com/microsoft/TypeScript/pull/21777
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 14, 2018https://github.com/microsoft/TypeScript/pull/18284#event-1682130242
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18284
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18284
https://github.com/rbuckton
https://github.com/mhegazy
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.