| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:28aca416-ca2a-25b6-629f-c6925f08e853 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8C32:2F9718:7E19C9:AA9E4F:6B00E2CE |
| html-safe-nonce | fddb3d7c3fed146f92990d9661387fb02e78f2bc27024a8ef8ad02df037da761 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzMyOjJGOTcxODo3RTE5Qzk6QUE5RTRGOjZCMDBFMkNFIiwidmlzaXRvcl9pZCI6IjM3NzU0NDYyNzk4NDk1NjY5MjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e74f4d4eff1e5159d8683f2155137fb3a6de0b79c11ab7f03d9c4f8eaddc763b |
| hovercard-subject-tag | pull_request:139656707 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/18284/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ce93c6bab203b8b704e87da557e4504ba4be68a5e4e4ac4fcd06e33f8600152a/microsoft/TypeScript/pull/18284 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ce93c6bab203b8b704e87da557e4504ba4be68a5e4e4ac4fcd06e33f8600152a/microsoft/TypeScript/pull/18284 |
| og:image:alt | Fixes #18091
The bug was happening because in formatting.ts, in processChildNodes, we continue scanning until getting to nodes.pos. Since this is a dynamically typed language, nodes.pos may be unde... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14 |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 624179fb8b88d26ba5bba08894eb60a1c5a1d93d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/18284#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18284 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18284 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/18284 |
| Reload | https://github.com/microsoft/TypeScript/pull/18284 |
| Reload | https://github.com/microsoft/TypeScript/pull/18284 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests309 (309) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| master | https://github.com/microsoft/TypeScript/tree/master |
| extract-method-format | https://github.com/microsoft/TypeScript/tree/extract-method-format |
| Conversation | https://github.com/microsoft/TypeScript/pull/18284 |
| Commits9 (9) | https://github.com/microsoft/TypeScript/pull/18284/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/18284/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/18284/files |
| Ensure that emitter calls callbacks | https://github.com/microsoft/TypeScript/pull/18284#top |
| master | https://github.com/microsoft/TypeScript/tree/master |
| extract-method-format | https://github.com/microsoft/TypeScript/tree/extract-method-format |
|
| https://github.com/ghost |
| Deleted user (ghost) | https://github.com/ghost |
| Sep 6, 2017 | https://github.com/microsoft/TypeScript/pull/18284#issue-255731541 |
| #18091 | https://github.com/microsoft/TypeScript/issues/18091 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| Ensure that emitter calls calbacks | https://github.com/microsoft/TypeScript/pull/18284/commits/98153599f76cf58beef4df916acfcaf9a9ab1527 |
| 9815359 | https://github.com/microsoft/TypeScript/pull/18284/commits/98153599f76cf58beef4df916acfcaf9a9ab1527 |
| https://github.com/msftclas |
| Microsoft Contribution License Agreements (msftclas) | https://github.com/msftclas |
|
cla-not-required
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required |
| Sep 6, 2017 | https://github.com/microsoft/TypeScript/pull/18284#event-1237597934 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| September 6, 2017 20:26 | https://github.com/microsoft/TypeScript/pull/18284#event-1237598174 |
| https://github.com/ghost |
| Deleted user (ghost) | https://github.com/ghost |
|
Sep 6, 2017
| https://github.com/microsoft/TypeScript/pull/18284#pullrequestreview-61040649 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527 |
| src/compiler/factory.ts | https://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527#diff-aa7be70e4da2f4c99dd3bdfeda6e99ea1e8270cf51643ab462aa8a640d8c5c3a |
| Deleted user (ghost) | https://github.com/ghost |
| Sep 6, 2017 | https://github.com/microsoft/TypeScript/pull/18284#discussion_r137380730 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
| Sep 6, 2017 | https://github.com/microsoft/TypeScript/pull/18284#discussion_r137396224 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18284#discussion_r137631063 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| Sep 6, 2017 | https://github.com/microsoft/TypeScript/pull/18284#event-1237660680 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 6, 2017 | https://github.com/microsoft/TypeScript/pull/18284#issuecomment-327619541 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| #18091 | https://github.com/microsoft/TypeScript/issues/18091 |
| #18091 | https://github.com/microsoft/TypeScript/issues/18091 |
| #18091 | https://github.com/microsoft/TypeScript/issues/18091 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
|
Sep 6, 2017
| https://github.com/microsoft/TypeScript/pull/18284#pullrequestreview-61060444 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527 |
| src/compiler/emitter.ts | https://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 6, 2017 | https://github.com/microsoft/TypeScript/pull/18284#discussion_r137398685 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| src/compiler/emitter.ts | https://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 6, 2017 | https://github.com/microsoft/TypeScript/pull/18284#discussion_r137399052 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| src/compiler/emitter.ts | https://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 6, 2017 | https://github.com/microsoft/TypeScript/pull/18284#discussion_r137399547 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| src/compiler/emitter.ts | https://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 6, 2017 | https://github.com/microsoft/TypeScript/pull/18284#discussion_r137399630 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| Deleted user (ghost) | https://github.com/ghost |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18284#discussion_r137611034 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| src/compiler/emitter.ts | https://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 6, 2017 | https://github.com/microsoft/TypeScript/pull/18284#discussion_r137400181 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| src/compiler/emitter.ts | https://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 6, 2017 | https://github.com/microsoft/TypeScript/pull/18284#discussion_r137401466 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| src/compiler/utilities.ts | https://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527#diff-1516c8349f7a625a2e4a2aa60f6bbe84e4b1a499128e8705d3087d893e01d367 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 6, 2017 | https://github.com/microsoft/TypeScript/pull/18284#discussion_r137402398 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| Move new parameter to end of parameters | https://github.com/microsoft/TypeScript/pull/18284/commits/7d931bb1cde111aa0e13228189eb488cd9bedca1 |
| 7d931bb | https://github.com/microsoft/TypeScript/pull/18284/commits/7d931bb1cde111aa0e13228189eb488cd9bedca1 |
| force-pushed | https://github.com/microsoft/TypeScript/compare/495f1a252da8cc952aab9c9e6a8afdbcad8bff10..7d931bb1cde111aa0e13228189eb488cd9bedca1 |
| 495f1a2 | https://github.com/microsoft/TypeScript/commit/495f1a252da8cc952aab9c9e6a8afdbcad8bff10 |
| 7d931bb | https://github.com/microsoft/TypeScript/commit/7d931bb1cde111aa0e13228189eb488cd9bedca1 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/495f1a252da8cc952aab9c9e6a8afdbcad8bff10..7d931bb1cde111aa0e13228189eb488cd9bedca1 |
| September 7, 2017 18:14 | https://github.com/microsoft/TypeScript/pull/18284#event-1239321647 |
| September 7, 2017 11:14 | https://github.com/microsoft/TypeScript/pull/18284#commits-pushed-7d56deb |
| Merge branch 'master' into extract-method-format | https://github.com/microsoft/TypeScript/pull/18284/commits/7d56deb12ea959860997e6face7ae6dfd198d9cc |
| 7d56deb | https://github.com/microsoft/TypeScript/pull/18284/commits/7d56deb12ea959860997e6face7ae6dfd198d9cc |
| Fix for ConditionalExpression | https://github.com/microsoft/TypeScript/pull/18284/commits/5b44de1f1502216dd4901069e15bd8490d2ca221 |
| 5b44de1 | https://github.com/microsoft/TypeScript/pull/18284/commits/5b44de1f1502216dd4901069e15bd8490d2ca221 |
| force-pushed | https://github.com/microsoft/TypeScript/compare/49e21b1ad64f998f4063be5e4633b1381da02506..5b44de1f1502216dd4901069e15bd8490d2ca221 |
| 49e21b1 | https://github.com/microsoft/TypeScript/commit/49e21b1ad64f998f4063be5e4633b1381da02506 |
| 5b44de1 | https://github.com/microsoft/TypeScript/commit/5b44de1f1502216dd4901069e15bd8490d2ca221 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/49e21b1ad64f998f4063be5e4633b1381da02506..5b44de1f1502216dd4901069e15bd8490d2ca221 |
| September 7, 2017 18:44 | https://github.com/microsoft/TypeScript/pull/18284#event-1239370825 |
| Make suggested changes to emitter | https://github.com/microsoft/TypeScript/pull/18284/commits/aae877d6fb5881a5977d8a00002bd529e02bc8b3 |
| aae877d | https://github.com/microsoft/TypeScript/pull/18284/commits/aae877d6fb5881a5977d8a00002bd529e02bc8b3 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
|
Sep 7, 2017
| https://github.com/microsoft/TypeScript/pull/18284#pullrequestreview-61323851 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/18284/files/aae877d6fb5881a5977d8a00002bd529e02bc8b3 |
| src/compiler/factory.ts | https://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527..aae877d6fb5881a5977d8a00002bd529e02bc8b3#diff-aa7be70e4da2f4c99dd3bdfeda6e99ea1e8270cf51643ab462aa8a640d8c5c3a |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18284#discussion_r137630915 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| src/compiler/factory.ts | https://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527#diff-aa7be70e4da2f4c99dd3bdfeda6e99ea1e8270cf51643ab462aa8a640d8c5c3a |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18284#discussion_r137631063 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
|
Sep 7, 2017
| https://github.com/microsoft/TypeScript/pull/18284#pullrequestreview-61324253 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/18284/files/aae877d6fb5881a5977d8a00002bd529e02bc8b3 |
| src/compiler/factory.ts | https://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527..aae877d6fb5881a5977d8a00002bd529e02bc8b3#diff-aa7be70e4da2f4c99dd3bdfeda6e99ea1e8270cf51643ab462aa8a640d8c5c3a |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18284#discussion_r137631235 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| src/compiler/types.ts | https://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527..aae877d6fb5881a5977d8a00002bd529e02bc8b3#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18284#discussion_r137631439 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| src/compiler/visitor.ts | https://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527..aae877d6fb5881a5977d8a00002bd529e02bc8b3#diff-64a8e8375642131c99e3999316e14d2ad3839d25972934d69aa87b51d5076386 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18284#discussion_r137631856 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| src/compiler/visitor.ts | https://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527..aae877d6fb5881a5977d8a00002bd529e02bc8b3#diff-64a8e8375642131c99e3999316e14d2ad3839d25972934d69aa87b51d5076386 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18284#discussion_r137631882 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| src/compiler/visitor.ts | https://github.com/microsoft/TypeScript/pull/18284/files/98153599f76cf58beef4df916acfcaf9a9ab1527..aae877d6fb5881a5977d8a00002bd529e02bc8b3#diff-64a8e8375642131c99e3999316e14d2ad3839d25972934d69aa87b51d5076386 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18284#discussion_r137631912 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| September 7, 2017 12:57 | https://github.com/microsoft/TypeScript/pull/18284#commits-pushed-8f775dc |
| Fix parameter ordering | https://github.com/microsoft/TypeScript/pull/18284/commits/8f775dc117645461ff26ccc2d726c1ad535aebc4 |
| 8f775dc | https://github.com/microsoft/TypeScript/pull/18284/commits/8f775dc117645461ff26ccc2d726c1ad535aebc4 |
| Respond to minor comments | https://github.com/microsoft/TypeScript/pull/18284/commits/bca3b097004a784aa2bafff1d280aa55b2ade602 |
| bca3b09 | https://github.com/microsoft/TypeScript/pull/18284/commits/bca3b097004a784aa2bafff1d280aa55b2ade602 |
| Remove potentially expensive assertion | https://github.com/microsoft/TypeScript/pull/18284/commits/15e26635e93fa5d6bdf0ac16223cbed15d2705ec |
| 15e2663 | https://github.com/microsoft/TypeScript/pull/18284/commits/15e26635e93fa5d6bdf0ac16223cbed15d2705ec |
| https://github.com/ghost |
| Deleted user (ghost) | https://github.com/ghost |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18284#issuecomment-327926843 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
|
Sep 7, 2017
| https://github.com/microsoft/TypeScript/pull/18284#pullrequestreview-61352218 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/18284/files/15e26635e93fa5d6bdf0ac16223cbed15d2705ec |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| https://github.com/microsoft/TypeScript/pull/18284#pullrequestreview-61352218 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| src/compiler/emitter.ts | https://github.com/microsoft/TypeScript/pull/18284/files/15e26635e93fa5d6bdf0ac16223cbed15d2705ec#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8 |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18284#discussion_r137655328 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| More emitter cleanup | https://github.com/microsoft/TypeScript/pull/18284/commits/b33dbecfd60b6665e744b0e3219012a73eda2222 |
| b33dbec | https://github.com/microsoft/TypeScript/pull/18284/commits/b33dbecfd60b6665e744b0e3219012a73eda2222 |
| ed4e2e6 | https://github.com/microsoft/TypeScript/commit/ed4e2e6e3b66e43ce3e4807be342f3b235e0bb73 |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18284#event-1239783230 |
| September 7, 2017 21:30 | https://github.com/microsoft/TypeScript/pull/18284#event-1239783342 |
|
Sep 7, 2017
| https://github.com/microsoft/TypeScript/pull/18284#ref-commit-80166c5 |
| Ensure that emitter calls callbacks ( | https://github.com/microsoft/TypeScript/commit/80166c5f047f7dad5a505b1f7efaa1e2adb64319 |
| #18284 | https://github.com/microsoft/TypeScript/pull/18284 |
| ) | https://github.com/microsoft/TypeScript/commit/80166c5f047f7dad5a505b1f7efaa1e2adb64319 |
| 80166c5 | https://github.com/microsoft/TypeScript/commit/80166c5f047f7dad5a505b1f7efaa1e2adb64319 |
|
Sep 7, 2017
| https://github.com/microsoft/TypeScript/pull/18284#ref-pullrequest-256079809 |
|
Ensure that emitter calls callbacks ()
#18325
| https://github.com/microsoft/TypeScript/pull/18325 |
| https://github.com/mhegazy |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18284#issuecomment-327941643 |
| Andy (Andrewkraft) (@Andy-MS) | https://github.com/Andy-MS |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
|
Sep 7, 2017
| https://github.com/microsoft/TypeScript/pull/18284#ref-commit-f5b9e30 |
|
| https://github.com/mhegazy |
| Ensure that emitter calls callbacks ( | https://github.com/microsoft/TypeScript/commit/f5b9e30986d2195b286c6a9b71a1de6ce89d8e9c |
| #18284 | https://github.com/microsoft/TypeScript/pull/18284 |
| ) ( | https://github.com/microsoft/TypeScript/commit/f5b9e30986d2195b286c6a9b71a1de6ce89d8e9c |
| #18325 | https://github.com/microsoft/TypeScript/pull/18325 |
| ) | https://github.com/microsoft/TypeScript/commit/f5b9e30986d2195b286c6a9b71a1de6ce89d8e9c |
| f5b9e30 | https://github.com/microsoft/TypeScript/commit/f5b9e30986d2195b286c6a9b71a1de6ce89d8e9c |
|
Fixes to emit / format for codeFix
#18484
| https://github.com/microsoft/TypeScript/pull/18484 |
|
Ensure that emitter calls callbacks for empty blocks
#18547
| https://github.com/microsoft/TypeScript/pull/18547 |
|
Sep 22, 2017
| https://github.com/microsoft/TypeScript/pull/18284#ref-issue-259654067 |
|
getEditsForRefactor debug failure in js file
#18671
| https://github.com/microsoft/TypeScript/issues/18671 |
|
Should this just be emit?
imdone/TypeScript#90
| https://github.com/imdone/TypeScript/issues/90 |
|
Should this just be emit?
imdone/TypeScript#127
| https://github.com/imdone/TypeScript/issues/127 |
|
Should this just be emit?
imdone/TypeScript#192
| https://github.com/imdone/TypeScript/issues/192 |
|
Should this just be emit?
imdone/TypeScript#714
| https://github.com/imdone/TypeScript/issues/714 |
|
Feb 8, 2018
| https://github.com/microsoft/TypeScript/pull/18284#ref-pullrequest-295692725 |
|
Fix bug: Don't skip emitting JSX attributes
#21777
| https://github.com/microsoft/TypeScript/pull/21777 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Jun 14, 2018 | https://github.com/microsoft/TypeScript/pull/18284#event-1682130242 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18284 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18284 |
|
| https://github.com/rbuckton |
|
| https://github.com/mhegazy |
|
| https://github.com/msftclas |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |