| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:73971207-9e88-2c74-92d5-8c525775eba5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D5D6:28815B:11A36E8:177ED68:6B011B91 |
| html-safe-nonce | 5279a0aca6c64bddd6e88aa674173e24add8e6a7f0592de26dc1f11ff640e974 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUQ2OjI4ODE1QjoxMUEzNkU4OjE3N0VENjg6NkIwMTFCOTEiLCJ2aXNpdG9yX2lkIjoiMzY4MTg3Njc2NjU4NDAxOTg1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a41a8bd6d51328d35bfad2b5b1ddf8c1ef4de0f8a24c6af1a0ed27a3598d8d38 |
| hovercard-subject-tag | pull_request:138739000 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/18185/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5a696d1ff263458e99fec16d6fe8049a83e364d1e67d475bdde6fa46b9f3df30/microsoft/TypeScript/pull/18185 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5a696d1ff263458e99fec16d6fe8049a83e364d1e67d475bdde6fa46b9f3df30/microsoft/TypeScript/pull/18185 |
| og:image:alt | Fixes #6496 (comment)
When loading a module like rxjs/Observer.d.ts, we need to remember to check package.json anyway so we can get the packageId.
Update: Now fixes #17716 (the deduplication side) ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/18185#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18185 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18185 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/18185 |
| Reload | https://github.com/microsoft/TypeScript/pull/18185 |
| Reload | https://github.com/microsoft/TypeScript/pull/18185 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests310 (310) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| master | https://github.com/microsoft/TypeScript/tree/master |
| duplicatePackage_subModule | https://github.com/microsoft/TypeScript/tree/duplicatePackage_subModule |
| Conversation | https://github.com/microsoft/TypeScript/pull/18185 |
| Commits2 (2) | https://github.com/microsoft/TypeScript/pull/18185/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/18185/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/18185/files |
| When loading a module from node_modules, get packageId even in the loadModuleFromFile case | https://github.com/microsoft/TypeScript/pull/18185#top |
| master | https://github.com/microsoft/TypeScript/tree/master |
| duplicatePackage_subModule | https://github.com/microsoft/TypeScript/tree/duplicatePackage_subModule |
|
| https://github.com/ghost |
| Deleted user (ghost) | https://github.com/ghost |
| Aug 31, 2017 | https://github.com/microsoft/TypeScript/pull/18185#issue-254431616 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18185 |
| #6496 (comment) | https://github.com/microsoft/TypeScript/issues/6496#issuecomment-325231491 |
| #17716 | https://github.com/microsoft/TypeScript/issues/17716 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18185 |
| When loading a module from node_modules, get packageId even in the `l… | https://github.com/microsoft/TypeScript/pull/18185/commits/052bb694f57968a700261cec7999efbe3b9dca61 |
| 052bb69 | https://github.com/microsoft/TypeScript/pull/18185/commits/052bb694f57968a700261cec7999efbe3b9dca61 |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Arthur Ozga (aozgaa) | https://github.com/aozgaa |
| August 31, 2017 18:45 | https://github.com/microsoft/TypeScript/pull/18185#event-1230144002 |
| https://github.com/msftclas |
| Microsoft Contribution License Agreements (msftclas) | https://github.com/msftclas |
|
cla-not-required
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required |
| Aug 31, 2017 | https://github.com/microsoft/TypeScript/pull/18185#event-1230144026 |
| Aug 31, 2017 | https://github.com/microsoft/TypeScript/pull/18185#event-1230144641 |
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
|
Aug 31, 2017
| https://github.com/microsoft/TypeScript/pull/18185#pullrequestreview-60013403 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/18185/files/052bb694f57968a700261cec7999efbe3b9dca61 |
| src/compiler/program.ts | https://github.com/microsoft/TypeScript/pull/18185/files/052bb694f57968a700261cec7999efbe3b9dca61#diff-dbfa0e7f632eca196a5ee0e08e00743c46c03799e2704206cfccc065bb6f9e3a |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Aug 31, 2017 | https://github.com/microsoft/TypeScript/pull/18185#discussion_r136468729 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18185 |
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Aug 31, 2017 | https://github.com/microsoft/TypeScript/pull/18185#issuecomment-326443600 |
| Mine Starks (@minestarks) | https://github.com/minestarks |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18185 |
| Mine Starks (minestarks) | https://github.com/minestarks |
| September 1, 2017 15:35 | https://github.com/microsoft/TypeScript/pull/18185#event-1231577223 |
| Support packageId for too | https://github.com/microsoft/TypeScript/pull/18185/commits/104a52b6054608149f4f2f97d473f239715d529f |
| 104a52b | https://github.com/microsoft/TypeScript/pull/18185/commits/104a52b6054608149f4f2f97d473f239715d529f |
| force-pushed | https://github.com/microsoft/TypeScript/compare/ecb72594f1eef78514120c380936671220ea7c0e..104a52b6054608149f4f2f97d473f239715d529f |
| ecb7259 | https://github.com/microsoft/TypeScript/commit/ecb72594f1eef78514120c380936671220ea7c0e |
| 104a52b | https://github.com/microsoft/TypeScript/commit/104a52b6054608149f4f2f97d473f239715d529f |
|
Compare
| https://github.com/microsoft/TypeScript/compare/ecb72594f1eef78514120c380936671220ea7c0e..104a52b6054608149f4f2f97d473f239715d529f |
| September 5, 2017 17:31 | https://github.com/microsoft/TypeScript/pull/18185#event-1235352784 |
| https://github.com/minestarks |
| Mine Starks (minestarks) | https://github.com/minestarks |
|
Sep 7, 2017
| https://github.com/microsoft/TypeScript/pull/18185#pullrequestreview-61357755 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/18185/files/104a52b6054608149f4f2f97d473f239715d529f |
| 2e02778 | https://github.com/microsoft/TypeScript/commit/2e027789606a7b5bcd015cf1173823ed8f83023b |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18185#event-1239784774 |
| September 7, 2017 21:31 | https://github.com/microsoft/TypeScript/pull/18185#event-1239784879 |
|
Sep 7, 2017
| https://github.com/microsoft/TypeScript/pull/18185#ref-commit-4384f48 |
| When loading a module from node_modules, get packageId even in the `l… | https://github.com/microsoft/TypeScript/commit/4384f48f6f36c907ae82c6ed2f175f6c3791475c |
| 4384f48 | https://github.com/microsoft/TypeScript/commit/4384f48f6f36c907ae82c6ed2f175f6c3791475c |
| #18185 | https://github.com/microsoft/TypeScript/pull/18185 |
|
When loading a module from node_modules, get packageId even in the loadModuleFromFile case
#18326
| https://github.com/microsoft/TypeScript/pull/18326 |
|
Duplicate type declarations with npm link
#6496
| https://github.com/microsoft/TypeScript/issues/6496 |
| https://github.com/intellix |
| D (intellix) | https://github.com/intellix |
|
Sep 12, 2017
| https://github.com/microsoft/TypeScript/pull/18185#ref-issue-232346649 |
|
[RFC] Library Support and Boilerplate Comment Thread
angular/angular-cli#6510
| https://github.com/angular/angular-cli/issues/6510 |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
|
Sep 14, 2017
| https://github.com/microsoft/TypeScript/pull/18185#ref-commit-39ecfc0 |
|
| https://github.com/mhegazy |
| When loading a module from node_modules, get packageId even in the `l… | https://github.com/microsoft/TypeScript/commit/39ecfc0db24d82b6df8196e44a3157f8dd648ac5 |
| 39ecfc0 | https://github.com/microsoft/TypeScript/commit/39ecfc0db24d82b6df8196e44a3157f8dd648ac5 |
| #18185 | https://github.com/microsoft/TypeScript/pull/18185 |
| #18326 | https://github.com/microsoft/TypeScript/pull/18326 |
|
Sep 19, 2017
| https://github.com/microsoft/TypeScript/pull/18185#ref-pullrequest-258974261 |
|
Look at correct 'package.json' location for a scoped package
#18580
| https://github.com/microsoft/TypeScript/pull/18580 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Jun 14, 2018 | https://github.com/microsoft/TypeScript/pull/18185#event-1682131133 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18185 |
|
| https://github.com/aozgaa |
|
Arthur Ozga (aozgaa)
| https://github.com/aozgaa |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18185 |
|
Compilation hangs when using Bluebird promise library
| https://github.com/microsoft/TypeScript/issues/17716 |
|
Duplicate type declarations with npm link
| https://github.com/microsoft/TypeScript/issues/6496 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18185 |
|
| https://github.com/amcasey |
|
| https://github.com/minestarks |
|
| https://github.com/msftclas |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |