René's URL Explorer Experiment


Title: When loading a module from node_modules, get packageId even in the `loadModuleFromFile` case · Pull Request #18185 · microsoft/TypeScript · GitHub

Open Graph Title: When loading a module from node_modules, get packageId even in the `loadModuleFromFile` case · Pull Request #18185 · microsoft/TypeScript

X Title: When loading a module from node_modules, get packageId even in the `loadModuleFromFile` case · Pull Request #18185 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - When loading a module from node_modules, get packageId even in the `loadModuleFromFile` case · Pull Request #18185 · microsoft/TypeScript

Open Graph Description: Fixes #6496 (comment) When loading a module like rxjs/Observer.d.ts, we need to remember to check package.json anyway so we can get the packageId. Update: Now fixes #17716 (the deduplication side) ...

X Description: Fixes #6496 (comment) When loading a module like rxjs/Observer.d.ts, we need to remember to check package.json anyway so we can get the packageId. Update: Now fixes #17716 (the deduplication side) ...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/18185

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:73971207-9e88-2c74-92d5-8c525775eba5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD5D6:28815B:11A36E8:177ED68:6B011B91
html-safe-nonce5279a0aca6c64bddd6e88aa674173e24add8e6a7f0592de26dc1f11ff640e974
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUQ2OjI4ODE1QjoxMUEzNkU4OjE3N0VENjg6NkIwMTFCOTEiLCJ2aXNpdG9yX2lkIjoiMzY4MTg3Njc2NjU4NDAxOTg1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca41a8bd6d51328d35bfad2b5b1ddf8c1ef4de0f8a24c6af1a0ed27a3598d8d38
hovercard-subject-tagpull_request:138739000
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/18185/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5a696d1ff263458e99fec16d6fe8049a83e364d1e67d475bdde6fa46b9f3df30/microsoft/TypeScript/pull/18185
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5a696d1ff263458e99fec16d6fe8049a83e364d1e67d475bdde6fa46b9f3df30/microsoft/TypeScript/pull/18185
og:image:altFixes #6496 (comment) When loading a module like rxjs/Observer.d.ts, we need to remember to check package.json anyway so we can get the packageId. Update: Now fixes #17716 (the deduplication side) ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/18185#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18185
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18185
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/18185
Reloadhttps://github.com/microsoft/TypeScript/pull/18185
Reloadhttps://github.com/microsoft/TypeScript/pull/18185
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests310 (310)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
masterhttps://github.com/microsoft/TypeScript/tree/master
duplicatePackage_subModulehttps://github.com/microsoft/TypeScript/tree/duplicatePackage_subModule
Conversationhttps://github.com/microsoft/TypeScript/pull/18185
Commits2 (2)https://github.com/microsoft/TypeScript/pull/18185/commits
Checkshttps://github.com/microsoft/TypeScript/pull/18185/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/18185/files
When loading a module from node_modules, get packageId even in the loadModuleFromFile casehttps://github.com/microsoft/TypeScript/pull/18185#top
masterhttps://github.com/microsoft/TypeScript/tree/master
duplicatePackage_subModulehttps://github.com/microsoft/TypeScript/tree/duplicatePackage_subModule
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Aug 31, 2017https://github.com/microsoft/TypeScript/pull/18185#issue-254431616
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18185
#6496 (comment)https://github.com/microsoft/TypeScript/issues/6496#issuecomment-325231491
#17716https://github.com/microsoft/TypeScript/issues/17716
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18185
When loading a module from node_modules, get packageId even in the `l…https://github.com/microsoft/TypeScript/pull/18185/commits/052bb694f57968a700261cec7999efbe3b9dca61
052bb69https://github.com/microsoft/TypeScript/pull/18185/commits/052bb694f57968a700261cec7999efbe3b9dca61
Andrew Casey (amcasey)https://github.com/amcasey
Arthur Ozga (aozgaa)https://github.com/aozgaa
August 31, 2017 18:45https://github.com/microsoft/TypeScript/pull/18185#event-1230144002
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Aug 31, 2017https://github.com/microsoft/TypeScript/pull/18185#event-1230144026
Aug 31, 2017https://github.com/microsoft/TypeScript/pull/18185#event-1230144641
https://github.com/amcasey
Andrew Casey (amcasey)https://github.com/amcasey
Aug 31, 2017 https://github.com/microsoft/TypeScript/pull/18185#pullrequestreview-60013403
View reviewed changes https://github.com/microsoft/TypeScript/pull/18185/files/052bb694f57968a700261cec7999efbe3b9dca61
src/compiler/program.tshttps://github.com/microsoft/TypeScript/pull/18185/files/052bb694f57968a700261cec7999efbe3b9dca61#diff-dbfa0e7f632eca196a5ee0e08e00743c46c03799e2704206cfccc065bb6f9e3a
Andrew Casey (amcasey)https://github.com/amcasey
Aug 31, 2017https://github.com/microsoft/TypeScript/pull/18185#discussion_r136468729
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18185
https://github.com/amcasey
Andrew Casey (amcasey)https://github.com/amcasey
Aug 31, 2017https://github.com/microsoft/TypeScript/pull/18185#issuecomment-326443600
Mine Starks (@minestarks)https://github.com/minestarks
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18185
Mine Starks (minestarks)https://github.com/minestarks
September 1, 2017 15:35https://github.com/microsoft/TypeScript/pull/18185#event-1231577223
Support packageId for toohttps://github.com/microsoft/TypeScript/pull/18185/commits/104a52b6054608149f4f2f97d473f239715d529f
104a52bhttps://github.com/microsoft/TypeScript/pull/18185/commits/104a52b6054608149f4f2f97d473f239715d529f
force-pushedhttps://github.com/microsoft/TypeScript/compare/ecb72594f1eef78514120c380936671220ea7c0e..104a52b6054608149f4f2f97d473f239715d529f
ecb7259https://github.com/microsoft/TypeScript/commit/ecb72594f1eef78514120c380936671220ea7c0e
104a52bhttps://github.com/microsoft/TypeScript/commit/104a52b6054608149f4f2f97d473f239715d529f
Compare https://github.com/microsoft/TypeScript/compare/ecb72594f1eef78514120c380936671220ea7c0e..104a52b6054608149f4f2f97d473f239715d529f
September 5, 2017 17:31https://github.com/microsoft/TypeScript/pull/18185#event-1235352784
https://github.com/minestarks
Mine Starks (minestarks)https://github.com/minestarks
Sep 7, 2017 https://github.com/microsoft/TypeScript/pull/18185#pullrequestreview-61357755
View reviewed changes https://github.com/microsoft/TypeScript/pull/18185/files/104a52b6054608149f4f2f97d473f239715d529f
2e02778https://github.com/microsoft/TypeScript/commit/2e027789606a7b5bcd015cf1173823ed8f83023b
Sep 7, 2017https://github.com/microsoft/TypeScript/pull/18185#event-1239784774
September 7, 2017 21:31https://github.com/microsoft/TypeScript/pull/18185#event-1239784879
Sep 7, 2017 https://github.com/microsoft/TypeScript/pull/18185#ref-commit-4384f48
When loading a module from node_modules, get packageId even in the `l…https://github.com/microsoft/TypeScript/commit/4384f48f6f36c907ae82c6ed2f175f6c3791475c
4384f48https://github.com/microsoft/TypeScript/commit/4384f48f6f36c907ae82c6ed2f175f6c3791475c
#18185https://github.com/microsoft/TypeScript/pull/18185
When loading a module from node_modules, get packageId even in the loadModuleFromFile case #18326 https://github.com/microsoft/TypeScript/pull/18326
Duplicate type declarations with npm link #6496 https://github.com/microsoft/TypeScript/issues/6496
https://github.com/intellix
D (intellix)https://github.com/intellix
Sep 12, 2017 https://github.com/microsoft/TypeScript/pull/18185#ref-issue-232346649
[RFC] Library Support and Boilerplate Comment Thread angular/angular-cli#6510 https://github.com/angular/angular-cli/issues/6510
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Sep 14, 2017 https://github.com/microsoft/TypeScript/pull/18185#ref-commit-39ecfc0
https://github.com/mhegazy
When loading a module from node_modules, get packageId even in the `l…https://github.com/microsoft/TypeScript/commit/39ecfc0db24d82b6df8196e44a3157f8dd648ac5
39ecfc0https://github.com/microsoft/TypeScript/commit/39ecfc0db24d82b6df8196e44a3157f8dd648ac5
#18185https://github.com/microsoft/TypeScript/pull/18185
#18326https://github.com/microsoft/TypeScript/pull/18326
Sep 19, 2017 https://github.com/microsoft/TypeScript/pull/18185#ref-pullrequest-258974261
Look at correct 'package.json' location for a scoped package #18580 https://github.com/microsoft/TypeScript/pull/18580
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 14, 2018https://github.com/microsoft/TypeScript/pull/18185#event-1682131133
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18185
https://github.com/aozgaa
Arthur Ozga (aozgaa) https://github.com/aozgaa
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18185
Compilation hangs when using Bluebird promise library https://github.com/microsoft/TypeScript/issues/17716
Duplicate type declarations with npm link https://github.com/microsoft/TypeScript/issues/6496
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18185
https://github.com/amcasey
https://github.com/minestarks
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.