| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:594b3771-b9d7-694c-1b30-437f3af1fd70 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9160:EA06E:16AD7B1:1CF7A5C:6B012129 |
| html-safe-nonce | 599936fbc33fbf15d436c1aaa625893db32e2aecd708fe1aaeb4d6c4896026af |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTYwOkVBMDZFOjE2QUQ3QjE6MUNGN0E1Qzo2QjAxMjEyOSIsInZpc2l0b3JfaWQiOiIyOTUzMDYxNTQ5OTIyNjU2NTUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 57967cbcc3fe5499bce1b4c06c62761127b34124feb0f8d17bf0ef991a20fb4c |
| hovercard-subject-tag | pull_request:138550053 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/18172/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c4260c51dd449ed0a22e722f5b51111aa5cf335d28c19de8266d0455bca363f8/microsoft/TypeScript/pull/18172 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c4260c51dd449ed0a22e722f5b51111aa5cf335d28c19de8266d0455bca363f8/microsoft/TypeScript/pull/18172 |
| og:image:alt | And strengthen errorUnusedLocal to no longer error when a declaration name cannot be found.
Fixes #18097
There were actually two separate but related crashes in that issue - one because getDeclarat... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | weswigham |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/18172#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18172 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18172 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/18172 |
| Reload | https://github.com/microsoft/TypeScript/pull/18172 |
| Reload | https://github.com/microsoft/TypeScript/pull/18172 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests310 (310) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| microsoft:master | https://github.com/microsoft/TypeScript/tree/master |
| weswigham:fix-typedef-crash | https://github.com/weswigham/TypeScript/tree/fix-typedef-crash |
| Conversation | https://github.com/microsoft/TypeScript/pull/18172 |
| Commits9 (9) | https://github.com/microsoft/TypeScript/pull/18172/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/18172/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/18172/files |
| Add typedef declaration space, unify typedef name gathering | https://github.com/microsoft/TypeScript/pull/18172#top |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| microsoft:master | https://github.com/microsoft/TypeScript/tree/master |
| weswigham:fix-typedef-crash | https://github.com/weswigham/TypeScript/tree/fix-typedef-crash |
|
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Aug 30, 2017 | https://github.com/microsoft/TypeScript/pull/18172#issue-254163997 |
| #18097 | https://github.com/microsoft/TypeScript/issues/18097 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18172 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| August 30, 2017 23:21 | https://github.com/microsoft/TypeScript/pull/18172#event-1228593126 |
| https://github.com/msftclas |
| Microsoft Contribution License Agreements (msftclas) | https://github.com/msftclas |
|
cla-already-signed
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-already-signed |
| Aug 30, 2017 | https://github.com/microsoft/TypeScript/pull/18172#event-1228593149 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Aug 31, 2017
| https://github.com/microsoft/TypeScript/pull/18172#pullrequestreview-59755726 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/18172/files |
| src/compiler/core.ts | https://github.com/microsoft/TypeScript/pull/18172/files#diff-8eee8edc4cdf82aaa3b0c0ba3c8c74fa80ac6d5214540a460c49fb2ee1031b25 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Aug 31, 2017 | https://github.com/microsoft/TypeScript/pull/18172#discussion_r136245889 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18172 |
| Deleted user (ghost) | https://github.com/ghost |
| Aug 31, 2017 | https://github.com/microsoft/TypeScript/pull/18172#discussion_r136344619 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18172 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18172 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Aug 31, 2017 | https://github.com/microsoft/TypeScript/pull/18172#discussion_r136444859 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18172 |
| https://github.com/mhegazy |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
|
Sep 7, 2017
| https://github.com/microsoft/TypeScript/pull/18172#pullrequestreview-61083631 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/18172/files |
| src/compiler/types.ts | https://github.com/microsoft/TypeScript/pull/18172/files#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560 |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18172#discussion_r137419512 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18172 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18172#discussion_r137446822 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18172 |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18172#discussion_r137584938 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18172 |
| https://github.com/mhegazy |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
|
Sep 7, 2017
| https://github.com/microsoft/TypeScript/pull/18172#pullrequestreview-61083714 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/18172/files |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| September 7, 2017 10:10 | https://github.com/microsoft/TypeScript/pull/18172#commits-pushed-e589d00 |
|
| https://github.com/weswigham |
| Add typedef declaration space, unify typedef name gathering, strength… | https://github.com/microsoft/TypeScript/pull/18172/commits/e589d00c8f324a9125e513a422d13d6c77726a1f |
| e589d00 | https://github.com/microsoft/TypeScript/pull/18172/commits/e589d00c8f324a9125e513a422d13d6c77726a1f |
|
| https://github.com/weswigham |
| Bonus round: make jsdoc presence way mroe typesafe | https://github.com/microsoft/TypeScript/pull/18172/commits/649ca2e2988bb17e46a7bc1ebace6dc031e423be |
| 649ca2e | https://github.com/microsoft/TypeScript/pull/18172/commits/649ca2e2988bb17e46a7bc1ebace6dc031e423be |
|
| https://github.com/weswigham |
| Be exhaustive in nameForNamelessJSDocTypedef | https://github.com/microsoft/TypeScript/pull/18172/commits/5fe751588c7aa35ffa10605b8fea6cae56fd3e15 |
| 5fe7515 | https://github.com/microsoft/TypeScript/pull/18172/commits/5fe751588c7aa35ffa10605b8fea6cae56fd3e15 |
|
| https://github.com/weswigham |
| Remove nonrequired casts | https://github.com/microsoft/TypeScript/pull/18172/commits/256b34414174022276e6fb591869d6528492e415 |
| 256b344 | https://github.com/microsoft/TypeScript/pull/18172/commits/256b34414174022276e6fb591869d6528492e415 |
|
| https://github.com/weswigham |
| Replace more casts with guards | https://github.com/microsoft/TypeScript/pull/18172/commits/b1be2eb6b817c79ea46550f3b21aba038f1301d9 |
| b1be2eb | https://github.com/microsoft/TypeScript/pull/18172/commits/b1be2eb6b817c79ea46550f3b21aba038f1301d9 |
|
| https://github.com/weswigham |
| Cannot be internal | https://github.com/microsoft/TypeScript/pull/18172/commits/b3fdf0d2fbcc9de0bf8107c3539b102dd5ce2489 |
| b3fdf0d | https://github.com/microsoft/TypeScript/pull/18172/commits/b3fdf0d2fbcc9de0bf8107c3539b102dd5ce2489 |
|
| https://github.com/weswigham |
| Debug.fail returns never, assert never no longer needs unreachable th… | https://github.com/microsoft/TypeScript/pull/18172/commits/0ec5d935f8b082f959fa22d8faf9b0bdc1ee502e |
| 0ec5d93 | https://github.com/microsoft/TypeScript/pull/18172/commits/0ec5d935f8b082f959fa22d8faf9b0bdc1ee502e |
|
| https://github.com/weswigham |
| Rename type | https://github.com/microsoft/TypeScript/pull/18172/commits/ca8d2984e6ed9a1099716ff99aa08f6daf5f8034 |
| ca8d298 | https://github.com/microsoft/TypeScript/pull/18172/commits/ca8d2984e6ed9a1099716ff99aa08f6daf5f8034 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| force-pushed | https://github.com/microsoft/TypeScript/compare/01acb14eaf872153b5b8fab99182b3bc723ae362..ca8d2984e6ed9a1099716ff99aa08f6daf5f8034 |
| 01acb14 | https://github.com/microsoft/TypeScript/commit/01acb14eaf872153b5b8fab99182b3bc723ae362 |
| ca8d298 | https://github.com/microsoft/TypeScript/commit/ca8d2984e6ed9a1099716ff99aa08f6daf5f8034 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/01acb14eaf872153b5b8fab99182b3bc723ae362..ca8d2984e6ed9a1099716ff99aa08f6daf5f8034 |
| September 7, 2017 17:12 | https://github.com/microsoft/TypeScript/pull/18172#event-1239220526 |
|
| https://github.com/weswigham |
| Add replacement message as in 18287 | https://github.com/microsoft/TypeScript/pull/18172/commits/dfccaf4b01e5da690b8a0f22f9787632010a449f |
| dfccaf4 | https://github.com/microsoft/TypeScript/pull/18172/commits/dfccaf4b01e5da690b8a0f22f9787632010a449f |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| c1f2afd | https://github.com/microsoft/TypeScript/commit/c1f2afd64587042dc8094bb12ecdbde9d1731523 |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18172#event-1239246227 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| September 7, 2017 17:29 | https://github.com/microsoft/TypeScript/pull/18172#event-1239246310 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Jun 14, 2018 | https://github.com/microsoft/TypeScript/pull/18172#event-1682131272 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18172 |
|
| https://github.com/DanielRosenwasser |
|
Daniel Rosenwasser (DanielRosenwasser)
| https://github.com/DanielRosenwasser |
|
| https://github.com/microsoft/TypeScript/pull/18172/files/4c8b3c9c2280eb6a46f2b9baf4e5b00859f1d7ec |
|
| https://github.com/rbuckton |
|
Ron Buckton (rbuckton)
| https://github.com/rbuckton |
|
| https://github.com/sheetalkamat |
|
Sheetal Nandi (sheetalkamat)
| https://github.com/sheetalkamat |
|
| https://github.com/mhegazy |
|
Mohamed Hegazy (mhegazy)
| https://github.com/mhegazy |
|
| https://github.com/microsoft/TypeScript/pull/18172/files/01acb14eaf872153b5b8fab99182b3bc723ae362 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18172 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18172 |
|
| https://github.com/weswigham |
|
| https://github.com/DanielRosenwasser |
|
| https://github.com/mhegazy |
|
| https://github.com/msftclas |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |