| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:534082c4-ac81-a3dc-9512-ffe212882eda |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A3F0:24ACB9:13FD349:1A4FA73:6B011BB8 |
| html-safe-nonce | db702fc3bfea6b234e86938e1f49b4567a538cd78ccc47f6af7dbbf8a0356fa4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBM0YwOjI0QUNCOToxM0ZEMzQ5OjFBNEZBNzM6NkIwMTFCQjgiLCJ2aXNpdG9yX2lkIjoiMjk3MTUzMDE3OTg3ODM5NDgwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e290f53fbf4ba4a48c88079aa68f84eac5a4353326f1f77dc82a643cb949089a |
| hovercard-subject-tag | pull_request:138532939 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/18165/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/baaa3322405d7db7cd1761a71e1e052c10ad965fa303fe64e093c86083c67886/microsoft/TypeScript/pull/18165 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/baaa3322405d7db7cd1761a71e1e052c10ad965fa303fe64e093c86083c67886/microsoft/TypeScript/pull/18165 |
| og:image:alt | It was looking at the parent which wasn't guaranteed to be in the extracted range.
It was checking direct, rather than indirect containment - apparently to avoid applying the rules to certain e... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | amcasey |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/18165#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18165 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18165 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/18165 |
| Reload | https://github.com/microsoft/TypeScript/pull/18165 |
| Reload | https://github.com/microsoft/TypeScript/pull/18165 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests310 (310) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| microsoft:master | https://github.com/microsoft/TypeScript/tree/master |
| amcasey:GH18144 | https://github.com/amcasey/TypeScript/tree/GH18144 |
| Conversation | https://github.com/microsoft/TypeScript/pull/18165 |
| Commits6 (6) | https://github.com/microsoft/TypeScript/pull/18165/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/18165/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/18165/files |
| Simplify and correct PermittedJumps computation | https://github.com/microsoft/TypeScript/pull/18165#top |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| microsoft:master | https://github.com/microsoft/TypeScript/tree/master |
| amcasey:GH18144 | https://github.com/amcasey/TypeScript/tree/GH18144 |
|
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Aug 30, 2017 | https://github.com/microsoft/TypeScript/pull/18165#issue-254141514 |
| #18144 | https://github.com/microsoft/TypeScript/issues/18144 |
| #18164 | https://github.com/microsoft/TypeScript/pull/18164 |
| amcasey@e8ff205 | https://github.com/amcasey/TypeScript/commit/e8ff2052eb35d4228e82bf91dc55907ea396d21e |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18165 |
| https://github.com/msftclas |
| Microsoft Contribution License Agreements (msftclas) | https://github.com/msftclas |
| Aug 30, 2017 | https://github.com/microsoft/TypeScript/pull/18165#issuecomment-326124780 |
| Andrew Casey (@amcasey) | https://github.com/amcasey |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18165 |
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| August 30, 2017 21:29 | https://github.com/microsoft/TypeScript/pull/18165#event-1228465567 |
| https://github.com/msftclas |
| Microsoft Contribution License Agreements (msftclas) | https://github.com/msftclas |
|
cla-not-required
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required |
| Aug 30, 2017 | https://github.com/microsoft/TypeScript/pull/18165#event-1228465597 |
| https://github.com/mhegazy |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
|
Sep 6, 2017
| https://github.com/microsoft/TypeScript/pull/18165#pullrequestreview-61034049 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/18165/files |
| src/services/refactors/extractMethod.ts | https://github.com/microsoft/TypeScript/pull/18165/files#diff-5022387c72e7ecdc8a5ffc303f5361856cdb9c3deb7b532b1f13f0e3eee4d3cc |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
| Sep 6, 2017 | https://github.com/microsoft/TypeScript/pull/18165#discussion_r137374994 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18165 |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18165#discussion_r137660823 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18165 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18165 |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Sep 7, 2017 | https://github.com/microsoft/TypeScript/pull/18165#discussion_r137675205 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 57906fe | https://github.com/microsoft/TypeScript/commit/57906fe90e8efd2fb285fcb67f018c0438ba06dd |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18165 |
| https://github.com/mhegazy |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
|
Sep 6, 2017
| https://github.com/microsoft/TypeScript/pull/18165#pullrequestreview-61034081 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/18165/files |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| September 7, 2017 14:43 | https://github.com/microsoft/TypeScript/pull/18165#commits-pushed-0e50da6 |
|
| https://github.com/amcasey |
| Handle the combination of a write and a void return | https://github.com/microsoft/TypeScript/pull/18165/commits/0e50da62c47368e7141301d0cf4e9cc105497ef2 |
| 0e50da6 | https://github.com/microsoft/TypeScript/pull/18165/commits/0e50da62c47368e7141301d0cf4e9cc105497ef2 |
| microsoft#18140 | https://github.com/microsoft/TypeScript/issues/18140 |
|
| https://github.com/amcasey |
| Correct permitted jumps check | https://github.com/microsoft/TypeScript/pull/18165/commits/9d11fbb9b9c4e7fbbc4a54d1b95d41e28e13ea42 |
| 9d11fbb | https://github.com/microsoft/TypeScript/pull/18165/commits/9d11fbb9b9c4e7fbbc4a54d1b95d41e28e13ea42 |
|
| https://github.com/amcasey |
| Make permittedJumps a parameter to eliminate save-restore pattern | https://github.com/microsoft/TypeScript/pull/18165/commits/a81fa7a801c7eff1865bcc2cd451bfc618ce832b |
| a81fa7a | https://github.com/microsoft/TypeScript/pull/18165/commits/a81fa7a801c7eff1865bcc2cd451bfc618ce832b |
|
| https://github.com/amcasey |
| Simplify and correct PermittedJumps computation | https://github.com/microsoft/TypeScript/pull/18165/commits/e3808b65d4291c982cba374d336d65b1be87fae2 |
| e3808b6 | https://github.com/microsoft/TypeScript/pull/18165/commits/e3808b65d4291c982cba374d336d65b1be87fae2 |
| microsoft#18144 | https://github.com/microsoft/TypeScript/issues/18144 |
|
| https://github.com/amcasey |
| Correct copied comment | https://github.com/microsoft/TypeScript/pull/18165/commits/73bc0c9796ce2e294e8b0fa1a1dec46da1268187 |
| 73bc0c9 | https://github.com/microsoft/TypeScript/pull/18165/commits/73bc0c9796ce2e294e8b0fa1a1dec46da1268187 |
|
| https://github.com/amcasey |
| Revert "Make permittedJumps a parameter to eliminate save-restore pat… | https://github.com/microsoft/TypeScript/pull/18165/commits/baefdd2ccb21542b7aeab8b6f825e45c516566da |
| baefdd2 | https://github.com/microsoft/TypeScript/pull/18165/commits/baefdd2ccb21542b7aeab8b6f825e45c516566da |
| 57906fe | https://github.com/amcasey/TypeScript/commit/57906fe90e8efd2fb285fcb67f018c0438ba06dd |
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| force-pushed | https://github.com/microsoft/TypeScript/compare/389212c65d7f4ece67aebbbc1aae6abfe4f4d99a..baefdd2ccb21542b7aeab8b6f825e45c516566da |
| 389212c | https://github.com/microsoft/TypeScript/commit/389212c65d7f4ece67aebbbc1aae6abfe4f4d99a |
| baefdd2 | https://github.com/microsoft/TypeScript/commit/baefdd2ccb21542b7aeab8b6f825e45c516566da |
|
Compare
| https://github.com/microsoft/TypeScript/compare/389212c65d7f4ece67aebbbc1aae6abfe4f4d99a..baefdd2ccb21542b7aeab8b6f825e45c516566da |
| September 7, 2017 23:25 | https://github.com/microsoft/TypeScript/pull/18165#event-1239910703 |
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| deefb01 | https://github.com/microsoft/TypeScript/commit/deefb01c9d53020a46a1692bf73b34696dad5c0c |
| Sep 8, 2017 | https://github.com/microsoft/TypeScript/pull/18165#event-1241231330 |
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| September 8, 2017 17:50 | https://github.com/microsoft/TypeScript/pull/18165#event-1241231390 |
| Andrew Casey (amcasey) | https://github.com/amcasey |
|
Sep 16, 2017
| https://github.com/microsoft/TypeScript/pull/18165#ref-commit-17dc8c8 |
|
| https://github.com/amcasey |
| Merge pull request | https://github.com/amcasey/TypeScript/commit/17dc8c82a770215c87fbb3ad2efc8deac33e39dc |
| microsoft#18165 | https://github.com/microsoft/TypeScript/pull/18165 |
| from amcasey/GH18144 | https://github.com/amcasey/TypeScript/commit/17dc8c82a770215c87fbb3ad2efc8deac33e39dc |
| 17dc8c8 | https://github.com/amcasey/TypeScript/commit/17dc8c82a770215c87fbb3ad2efc8deac33e39dc |
| deefb01 | https://github.com/amcasey/TypeScript/commit/deefb01c9d53020a46a1692bf73b34696dad5c0c |
| Andrew Casey (amcasey) | https://github.com/amcasey |
|
Sep 18, 2017
| https://github.com/microsoft/TypeScript/pull/18165#ref-commit-dd0ec42 |
|
| https://github.com/amcasey |
| Merge pull request | https://github.com/amcasey/TypeScript/commit/dd0ec4257464e08915d87cdea66ef78f23d7b355 |
| microsoft#18165 | https://github.com/microsoft/TypeScript/pull/18165 |
| from amcasey/GH18144 | https://github.com/amcasey/TypeScript/commit/dd0ec4257464e08915d87cdea66ef78f23d7b355 |
| dd0ec42 | https://github.com/amcasey/TypeScript/commit/dd0ec4257464e08915d87cdea66ef78f23d7b355 |
| deefb01 | https://github.com/amcasey/TypeScript/commit/deefb01c9d53020a46a1692bf73b34696dad5c0c |
| https://github.com/ghost |
| Deleted user (ghost) | https://github.com/ghost |
|
Sep 18, 2017
| https://github.com/microsoft/TypeScript/pull/18165#pullrequestreview-63463032 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/18165/files/baefdd2ccb21542b7aeab8b6f825e45c516566da |
| src/services/refactors/extractMethod.ts | https://github.com/microsoft/TypeScript/pull/18165/files/baefdd2ccb21542b7aeab8b6f825e45c516566da#diff-5022387c72e7ecdc8a5ffc303f5361856cdb9c3deb7b532b1f13f0e3eee4d3cc |
| Deleted user (ghost) | https://github.com/ghost |
| Sep 18, 2017 | https://github.com/microsoft/TypeScript/pull/18165#discussion_r139519066 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18165 |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Sep 18, 2017 | https://github.com/microsoft/TypeScript/pull/18165#discussion_r139523598 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18165 |
| Andrew Casey (amcasey) | https://github.com/amcasey |
|
Sep 20, 2017
| https://github.com/microsoft/TypeScript/pull/18165#ref-commit-12d1ea5 |
|
| https://github.com/amcasey |
| Merge pull request | https://github.com/amcasey/TypeScript/commit/12d1ea50ca55bb724d3cef40ecd88f8dbacfd3e1 |
| microsoft#18165 | https://github.com/microsoft/TypeScript/pull/18165 |
| from amcasey/GH18144 | https://github.com/amcasey/TypeScript/commit/12d1ea50ca55bb724d3cef40ecd88f8dbacfd3e1 |
| 12d1ea5 | https://github.com/amcasey/TypeScript/commit/12d1ea50ca55bb724d3cef40ecd88f8dbacfd3e1 |
| deefb01 | https://github.com/amcasey/TypeScript/commit/deefb01c9d53020a46a1692bf73b34696dad5c0c |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Jun 14, 2018 | https://github.com/microsoft/TypeScript/pull/18165#event-1682131373 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18165 |
|
| https://github.com/RyanCavanaugh |
|
Ryan Cavanaugh (RyanCavanaugh)
| https://github.com/RyanCavanaugh |
|
| https://github.com/mhegazy |
|
Mohamed Hegazy (mhegazy)
| https://github.com/mhegazy |
|
| https://github.com/microsoft/TypeScript/pull/18165/files/389212c65d7f4ece67aebbbc1aae6abfe4f4d99a |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18165 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/18165 |
|
| https://github.com/amcasey |
|
| https://github.com/msftclas |
|
| https://github.com/mhegazy |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |