René's URL Explorer Experiment


Title: Use isPartOfExpression in extractMethod, not isExpression · Pull Request #18047 · microsoft/TypeScript · GitHub

Open Graph Title: Use isPartOfExpression in extractMethod, not isExpression · Pull Request #18047 · microsoft/TypeScript

X Title: Use isPartOfExpression in extractMethod, not isExpression · Pull Request #18047 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Use isPartOfExpression in extractMethod, not isExpression · Pull Request #18047 · microsoft/TypeScript

Open Graph Description: This reverts the changes to isExpression from #18025. Ron Buckton (@rbuckton) pointed out that we should be using isPartOfExpression outside of transforms, not isExpression, since isExpression shou...

X Description: This reverts the changes to isExpression from #18025. Ron Buckton (@rbuckton) pointed out that we should be using isPartOfExpression outside of transforms, not isExpression, since isExpression shou...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/18047

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:e5db5de8-9f48-743e-c91f-7fd7467f5bf1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBF7C:B1B84:1F4FFD:27D24A:6B00FD6A
html-safe-nonce7c0bdcd5508fec348b62b99d983943ad8e11944877afd446fc1fa8f8c67027c2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjdDOkIxQjg0OjFGNEZGRDoyN0QyNEE6NkIwMEZENkEiLCJ2aXNpdG9yX2lkIjoiNzg0OTY3NzIzMjA2OTk5OTk3OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac60762fc64760fb6ec20dd1ef02cd326f8d3c631de279aa2008effd6cbaf358b2
hovercard-subject-tagpull_request:137750226
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/microsoft/TypeScript/pull/18047
twitter:imagehttps://opengraph.githubassets.com/c8e13d59e9075b67eb1ec78d95ad1ee9a0c78642e2859a801c5d9fa72eb84d1a/microsoft/TypeScript/pull/18047
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c8e13d59e9075b67eb1ec78d95ad1ee9a0c78642e2859a801c5d9fa72eb84d1a/microsoft/TypeScript/pull/18047
og:image:altThis reverts the changes to isExpression from #18025. Ron Buckton (@rbuckton) pointed out that we should be using isPartOfExpression outside of transforms, not isExpression, since isExpression shou...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/18047#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18047
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18047
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/18047
Reloadhttps://github.com/microsoft/TypeScript/pull/18047
Reloadhttps://github.com/microsoft/TypeScript/pull/18047
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
masterhttps://github.com/microsoft/TypeScript/tree/master
isPartOfExpressionhttps://github.com/microsoft/TypeScript/tree/isPartOfExpression
Conversationhttps://github.com/microsoft/TypeScript/pull/18047
Commits2 (2)https://github.com/microsoft/TypeScript/pull/18047/commits
Checkshttps://github.com/microsoft/TypeScript/pull/18047/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/18047/files
Use isPartOfExpression in extractMethod, not isExpressionhttps://github.com/microsoft/TypeScript/pull/18047#top
masterhttps://github.com/microsoft/TypeScript/tree/master
isPartOfExpressionhttps://github.com/microsoft/TypeScript/tree/isPartOfExpression
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Aug 25, 2017https://github.com/microsoft/TypeScript/pull/18047#issue-253008818
#18025https://github.com/microsoft/TypeScript/pull/18025
Ron Buckton (@rbuckton)https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18047
Use isPartOfExpression in extractMethod, not isExpressionhttps://github.com/microsoft/TypeScript/pull/18047/commits/b3ca45f7162f563e5b645b5122523549cc33cb5a
b3ca45fhttps://github.com/microsoft/TypeScript/pull/18047/commits/b3ca45f7162f563e5b645b5122523549cc33cb5a
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Aug 25, 2017https://github.com/microsoft/TypeScript/pull/18047#event-1222098398
Ron Buckton (rbuckton)https://github.com/rbuckton
August 25, 2017 20:24https://github.com/microsoft/TypeScript/pull/18047#event-1222098458
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 25, 2017 https://github.com/microsoft/TypeScript/pull/18047#pullrequestreview-58767316
View reviewed changes https://github.com/microsoft/TypeScript/pull/18047/files/b3ca45f7162f563e5b645b5122523549cc33cb5a
Ron Buckton (rbuckton)https://github.com/rbuckton
https://github.com/microsoft/TypeScript/pull/18047#pullrequestreview-58767316
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18047
src/compiler/utilities.tshttps://github.com/microsoft/TypeScript/pull/18047/files/b3ca45f7162f563e5b645b5122523549cc33cb5a#diff-1516c8349f7a625a2e4a2aa60f6bbe84e4b1a499128e8705d3087d893e01d367
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 25, 2017https://github.com/microsoft/TypeScript/pull/18047#discussion_r135356604
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18047
src/compiler/utilities.tshttps://github.com/microsoft/TypeScript/pull/18047/files/b3ca45f7162f563e5b645b5122523549cc33cb5a#diff-1516c8349f7a625a2e4a2aa60f6bbe84e4b1a499128e8705d3087d893e01d367
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 25, 2017https://github.com/microsoft/TypeScript/pull/18047#discussion_r135356639
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18047
src/compiler/utilities.tshttps://github.com/microsoft/TypeScript/pull/18047/files/b3ca45f7162f563e5b645b5122523549cc33cb5a#diff-1516c8349f7a625a2e4a2aa60f6bbe84e4b1a499128e8705d3087d893e01d367
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 25, 2017https://github.com/microsoft/TypeScript/pull/18047#discussion_r135356675
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18047
Add whitespacehttps://github.com/microsoft/TypeScript/pull/18047/commits/c62047102410af925d246ce7e3c746adf8482732
c620471https://github.com/microsoft/TypeScript/pull/18047/commits/c62047102410af925d246ce7e3c746adf8482732
Don't try to extract import to a method: simpler fix #18054 https://github.com/microsoft/TypeScript/pull/18054
Don't try to extract import to a method #18045 https://github.com/microsoft/TypeScript/pull/18045
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 25, 2017 https://github.com/microsoft/TypeScript/pull/18047#pullrequestreview-58771298
View reviewed changes https://github.com/microsoft/TypeScript/pull/18047/files/c62047102410af925d246ce7e3c746adf8482732
e73b10ahttps://github.com/microsoft/TypeScript/commit/e73b10a304430d7022aca26623e1a286d69f7afe
Aug 25, 2017https://github.com/microsoft/TypeScript/pull/18047#event-1222223822
August 25, 2017 22:15https://github.com/microsoft/TypeScript/pull/18047#event-1222223874
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 14, 2018https://github.com/microsoft/TypeScript/pull/18047#event-1682132568
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18047
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18047
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18047
https://github.com/rbuckton
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.