René's URL Explorer Experiment


Title: Don't try to extract `import` to a method · Pull Request #18025 · microsoft/TypeScript · GitHub

Open Graph Title: Don't try to extract `import` to a method · Pull Request #18025 · microsoft/TypeScript

X Title: Don't try to extract `import` to a method · Pull Request #18025 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Don't try to extract `import` to a method · Pull Request #18025 · microsoft/TypeScript

Open Graph Description: Fixes #17997 Replaced an invalid as Expression cast with a check for isExpression. I had to refactor isExpression to take a Node and not a SyntaxKind because an ImportKeyword is an expression only ...

X Description: Fixes #17997 Replaced an invalid as Expression cast with a check for isExpression. I had to refactor isExpression to take a Node and not a SyntaxKind because an ImportKeyword is an expression only ...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/18025

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:12bd1775-536c-7a9d-4128-63a93365837b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD956:358871:C38B22:103870F:6B00F299
html-safe-noncede49c0cf131f2677713e4117714995490a258884ae165ca491dddaa3d9cf4bf0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTU2OjM1ODg3MTpDMzhCMjI6MTAzODcwRjo2QjAwRjI5OSIsInZpc2l0b3JfaWQiOiIxODUzNDYyMTgwMjU5NzU0NjQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb4bdf04f2ea5e7db17970eb56d47061df924efb8e30b1406757f27ea79e039a1
hovercard-subject-tagpull_request:137542475
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/18025/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0bc316489226934c36c32e0908afc7b0ce7b9741bdd8ae13747efb3df8e3e2be/microsoft/TypeScript/pull/18025
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0bc316489226934c36c32e0908afc7b0ce7b9741bdd8ae13747efb3df8e3e2be/microsoft/TypeScript/pull/18025
og:image:altFixes #17997 Replaced an invalid as Expression cast with a check for isExpression. I had to refactor isExpression to take a Node and not a SyntaxKind because an ImportKeyword is an expression only ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/18025#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18025
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18025
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/18025
Reloadhttps://github.com/microsoft/TypeScript/pull/18025
Reloadhttps://github.com/microsoft/TypeScript/pull/18025
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
masterhttps://github.com/microsoft/TypeScript/tree/master
extract-method-not-for-importhttps://github.com/microsoft/TypeScript/tree/extract-method-not-for-import
Conversationhttps://github.com/microsoft/TypeScript/pull/18025
Commits1 (1)https://github.com/microsoft/TypeScript/pull/18025/commits
Checkshttps://github.com/microsoft/TypeScript/pull/18025/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/18025/files
Don't try to extract import to a methodhttps://github.com/microsoft/TypeScript/pull/18025#top
masterhttps://github.com/microsoft/TypeScript/tree/master
extract-method-not-for-importhttps://github.com/microsoft/TypeScript/tree/extract-method-not-for-import
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Aug 24, 2017https://github.com/microsoft/TypeScript/pull/18025#issue-252719332
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18025
#17997https://github.com/microsoft/TypeScript/issues/17997
Ron Buckton (@rbuckton)https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18025
Don't try to extract import to a methodhttps://github.com/microsoft/TypeScript/pull/18025/commits/631a7aa8860c2fde2255cdae514168e038f8aaec
631a7aahttps://github.com/microsoft/TypeScript/pull/18025/commits/631a7aa8860c2fde2255cdae514168e038f8aaec
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Ron Buckton (rbuckton)https://github.com/rbuckton
August 24, 2017 20:19https://github.com/microsoft/TypeScript/pull/18025#event-1220430633
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Aug 24, 2017https://github.com/microsoft/TypeScript/pull/18025#event-1220430671
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Aug 25, 2017 https://github.com/microsoft/TypeScript/pull/18025#pullrequestreview-58706791
View reviewed changes https://github.com/microsoft/TypeScript/pull/18025/files/631a7aa8860c2fde2255cdae514168e038f8aaec
fe1242chttps://github.com/microsoft/TypeScript/commit/fe1242c8a902a2f530e5fb91b8f8f3e90bd4f4a6
Aug 25, 2017https://github.com/microsoft/TypeScript/pull/18025#event-1221809892
August 25, 2017 16:54https://github.com/microsoft/TypeScript/pull/18025#event-1221809960
Aug 25, 2017 https://github.com/microsoft/TypeScript/pull/18025#ref-commit-ccfbb45
Don't try to extracthttps://github.com/microsoft/TypeScript/commit/ccfbb457734dd9652cc91a67f227b2dc44a8aedb
importhttps://github.com/microsoft/TypeScript/commit/ccfbb457734dd9652cc91a67f227b2dc44a8aedb
to a method (https://github.com/microsoft/TypeScript/commit/ccfbb457734dd9652cc91a67f227b2dc44a8aedb
#18025https://github.com/microsoft/TypeScript/pull/18025
)https://github.com/microsoft/TypeScript/commit/ccfbb457734dd9652cc91a67f227b2dc44a8aedb
ccfbb45https://github.com/microsoft/TypeScript/commit/ccfbb457734dd9652cc91a67f227b2dc44a8aedb
Don't try to extract import to a method #18045 https://github.com/microsoft/TypeScript/pull/18045
Use isPartOfExpression in extractMethod, not isExpression #18047 https://github.com/microsoft/TypeScript/pull/18047
Don't try to extract import to a method: simpler fix #18054 https://github.com/microsoft/TypeScript/pull/18054
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 14, 2018https://github.com/microsoft/TypeScript/pull/18025#event-1682132802
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F18025
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18025
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/18025
https://github.com/RyanCavanaugh
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.