René's URL Explorer Experiment


Title: Add a leading space on binary operator token trailing comments by weswigham · Pull Request #17691 · microsoft/TypeScript · GitHub

Open Graph Title: Add a leading space on binary operator token trailing comments by weswigham · Pull Request #17691 · microsoft/TypeScript

X Title: Add a leading space on binary operator token trailing comments by weswigham · Pull Request #17691 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Add a leading space on binary operator token trailing comments by weswigham · Pull Request #17691 · microsoft/TypeScript

Open Graph Description: Looking through our RWC results, I realized that we could be a bit better in how we emitted comments on binary expressions (from #16584), thanks to work done in #17557.

X Description: Looking through our RWC results, I realized that we could be a bit better in how we emitted comments on binary expressions (from #16584), thanks to work done in #17557.

Opengraph URL: https://github.com/microsoft/TypeScript/pull/17691

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0cc14a3d-c26a-b1c4-ea54-2a186234fa24
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB55C:38E318:1456AF2:19A1028:6B01634F
html-safe-nonce5e075ddb38884289f17202ed38cf4863a4a7af57ef9a6352e5a9890e13bea06e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTVDOjM4RTMxODoxNDU2QUYyOjE5QTEwMjg6NkIwMTYzNEYiLCJ2aXNpdG9yX2lkIjoiNTIzNDc0MjEzODI4MDk2MDg0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac307c660d8b1e303d75a2843d25f5564a838231153b496e2c15dfdb66308e6729
hovercard-subject-tagpull_request:134812680
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/17691/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/44f7e3efc019a7e6f6487be9883bf4d6bac52cba5039d257a8708c57274ea59a/microsoft/TypeScript/pull/17691
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/44f7e3efc019a7e6f6487be9883bf4d6bac52cba5039d257a8708c57274ea59a/microsoft/TypeScript/pull/17691
og:image:altLooking through our RWC results, I realized that we could be a bit better in how we emitted comments on binary expressions (from #16584), thanks to work done in #17557.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/17691#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F17691
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F17691
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/17691
Reloadhttps://github.com/microsoft/TypeScript/pull/17691
Reloadhttps://github.com/microsoft/TypeScript/pull/17691
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:add-space-before-commenthttps://github.com/weswigham/TypeScript/tree/add-space-before-comment
Conversationhttps://github.com/microsoft/TypeScript/pull/17691
Commits2 (2)https://github.com/microsoft/TypeScript/pull/17691/commits
Checkshttps://github.com/microsoft/TypeScript/pull/17691/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/17691/files
Add a leading space on binary operator token trailing commentshttps://github.com/microsoft/TypeScript/pull/17691#top
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:add-space-before-commenthttps://github.com/weswigham/TypeScript/tree/add-space-before-comment
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 9, 2017https://github.com/microsoft/TypeScript/pull/17691#issue-248920954
#16584https://github.com/microsoft/TypeScript/pull/16584
#17557https://github.com/microsoft/TypeScript/pull/17557
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17691
https://github.com/weswigham
Add a leading space on token trailing commentshttps://github.com/microsoft/TypeScript/pull/17691/commits/43ac25a413031e0db97641c7c12794b83513403c
43ac25ahttps://github.com/microsoft/TypeScript/pull/17691/commits/43ac25a413031e0db97641c7c12794b83513403c
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Ron Buckton (rbuckton)https://github.com/rbuckton
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
August 9, 2017 05:30https://github.com/microsoft/TypeScript/pull/17691#event-1198444354
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-already-signed https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-already-signed
Aug 9, 2017https://github.com/microsoft/TypeScript/pull/17691#event-1198444398
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 9, 2017 https://github.com/microsoft/TypeScript/pull/17691#pullrequestreview-55270046
View reviewed changes https://github.com/microsoft/TypeScript/pull/17691/files/43ac25a413031e0db97641c7c12794b83513403c
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/17691#pullrequestreview-55270046
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17691
src/compiler/emitter.tshttps://github.com/microsoft/TypeScript/pull/17691/files/43ac25a413031e0db97641c7c12794b83513403c#diff-537414476d7c7a690310c5e1e5d6a0bbbfba37c5b05126edee32fdea7e3a09d8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 9, 2017https://github.com/microsoft/TypeScript/pull/17691#discussion_r132213861
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17691
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 9, 2017https://github.com/microsoft/TypeScript/pull/17691#discussion_r132233181
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17691
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 9, 2017 https://github.com/microsoft/TypeScript/pull/17691#pullrequestreview-55274247
View reviewed changes https://github.com/microsoft/TypeScript/pull/17691/files/43ac25a413031e0db97641c7c12794b83513403c
tests/baselines/reference/commentOnBinaryOperator1.jshttps://github.com/microsoft/TypeScript/pull/17691/files/43ac25a413031e0db97641c7c12794b83513403c#diff-b8acbff0066331504796da743bb244e95cf1ae7db49b0f72a0a8c6fbb2b656b0
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 9, 2017https://github.com/microsoft/TypeScript/pull/17691#discussion_r132217599
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17691
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 9, 2017https://github.com/microsoft/TypeScript/pull/17691#discussion_r132232642
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17691
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 9, 2017https://github.com/microsoft/TypeScript/pull/17691#discussion_r132233021
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17691
tests/baselines/reference/parserGreaterThanTokenAmbiguity10.jshttps://github.com/microsoft/TypeScript/pull/17691/files/43ac25a413031e0db97641c7c12794b83513403c#diff-43dca24c1857638135992d13c88ee2e5fb975e9553ce477ff31bb5ca478fcfc0
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 9, 2017https://github.com/microsoft/TypeScript/pull/17691#discussion_r132217895
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17691
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 9, 2017https://github.com/microsoft/TypeScript/pull/17691#discussion_r132234003
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17691
https://github.com/weswigham
Demystify commenthttps://github.com/microsoft/TypeScript/pull/17691/commits/04bbb035241d4e01319a4525f05905448acfc6aa
04bbb03https://github.com/microsoft/TypeScript/pull/17691/commits/04bbb035241d4e01319a4525f05905448acfc6aa
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 9, 2017https://github.com/microsoft/TypeScript/pull/17691#issuecomment-321339454
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17691
Ron Buckton (@rbuckton)https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17691
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 9, 2017 https://github.com/microsoft/TypeScript/pull/17691#pullrequestreview-55376966
View reviewed changes https://github.com/microsoft/TypeScript/pull/17691/files/04bbb035241d4e01319a4525f05905448acfc6aa
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 9, 2017https://github.com/microsoft/TypeScript/pull/17691#issuecomment-321384535
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17691
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
a6f37f5https://github.com/microsoft/TypeScript/commit/a6f37f55e495c76874ef4c79a55e103f16be85f1
Aug 9, 2017https://github.com/microsoft/TypeScript/pull/17691#event-1199903223
Ben Lichtman (uniqueiniquity)https://github.com/uniqueiniquity
Aug 9, 2017 https://github.com/microsoft/TypeScript/pull/17691#ref-commit-b329e09
https://github.com/weswigham
https://github.com/uniqueiniquity
Add a leading space on binary operator token trailing comments (https://github.com/uniqueiniquity/TypeScript/commit/b329e0991788278979b0a609701c7257f1a15344
micro…https://github.com/microsoft/TypeScript/pull/17691
b329e09https://github.com/uniqueiniquity/TypeScript/commit/b329e0991788278979b0a609701c7257f1a15344
…soft#17691https://github.com/microsoft/TypeScript/pull/17691
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
August 17, 2017 23:05https://github.com/microsoft/TypeScript/pull/17691#event-1211045292
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 14, 2018https://github.com/microsoft/TypeScript/pull/17691#event-1682135863
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F17691
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/17691/files/43ac25a413031e0db97641c7c12794b83513403c
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
https://github.com/microsoft/TypeScript/pull/17691/files/04bbb035241d4e01319a4525f05905448acfc6aa
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17691
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17691
https://github.com/weswigham
https://github.com/rbuckton
https://github.com/sandersn
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.