René's URL Explorer Experiment


Title: Fix emit for leading 'var' declarations for synthesized namespaces by DanielRosenwasser · Pull Request #17631 · microsoft/TypeScript · GitHub

Open Graph Title: Fix emit for leading 'var' declarations for synthesized namespaces by DanielRosenwasser · Pull Request #17631 · microsoft/TypeScript

X Title: Fix emit for leading 'var' declarations for synthesized namespaces by DanielRosenwasser · Pull Request #17631 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix emit for leading 'var' declarations for synthesized namespaces by DanielRosenwasser · Pull Request #17631 · microsoft/TypeScript

Open Graph Description: Down-leveling a namespace to ES involved an optimization within individual files to avoid emitting multiple var declarations by grabbing the namespace's symbol's name and checking whether a...

X Description: Down-leveling a namespace to ES involved an optimization within individual files to avoid emitting multiple var declarations by grabbing the namespace's symbol's name and checking w...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/17631

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:031b2424-ce2f-9af2-165c-df27adbb54ee
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA074:95C88:995C82:CD4B6C:6B00E502
html-safe-nonce5f245e396f57ff5788d5e552c7df829d640d14101c84e88a7012a557df39a233
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDc0Ojk1Qzg4Ojk5NUM4MjpDRDRCNkM6NkIwMEU1MDIiLCJ2aXNpdG9yX2lkIjoiMTI2MTQxODY4NTMxMTAxODI0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacadf0914ae67b6400e8d7884174932e5e2a83286bb0d95e60b06ce32612f615de
hovercard-subject-tagpull_request:134288627
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/17631/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/518bfeb5f43441f40642e0d455253f79ff416646949291c1f42c2929cf9ac999/microsoft/TypeScript/pull/17631
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/518bfeb5f43441f40642e0d455253f79ff416646949291c1f42c2929cf9ac999/microsoft/TypeScript/pull/17631
og:image:altDown-leveling a namespace to ES involved an optimization within individual files to avoid emitting multiple var declarations by grabbing the namespace's symbol's name and checking whether a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDanielRosenwasser
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/17631#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F17631
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F17631
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/17631
Reloadhttps://github.com/microsoft/TypeScript/pull/17631
Reloadhttps://github.com/microsoft/TypeScript/pull/17631
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
masterhttps://github.com/microsoft/TypeScript/tree/master
synthesizedNamespaceshttps://github.com/microsoft/TypeScript/tree/synthesizedNamespaces
Conversationhttps://github.com/microsoft/TypeScript/pull/17631
Commits12 (12)https://github.com/microsoft/TypeScript/pull/17631/commits
Checkshttps://github.com/microsoft/TypeScript/pull/17631/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/17631/files
Fix emit for leading 'var' declarations for synthesized namespaceshttps://github.com/microsoft/TypeScript/pull/17631#top
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
masterhttps://github.com/microsoft/TypeScript/tree/master
synthesizedNamespaceshttps://github.com/microsoft/TypeScript/tree/synthesizedNamespaces
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Aug 5, 2017https://github.com/microsoft/TypeScript/pull/17631#issue-248179305
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17631
#17596https://github.com/microsoft/TypeScript/issues/17596
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17631
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
August 4, 2017 23:48https://github.com/microsoft/TypeScript/pull/17631#commits-pushed-b44ac91
https://github.com/DanielRosenwasser
Added failing test for a before-transform that indirectly replaces a …https://github.com/microsoft/TypeScript/pull/17631/commits/b44ac91de932012d54b576e9ae343aac7ce8c940
b44ac91https://github.com/microsoft/TypeScript/pull/17631/commits/b44ac91de932012d54b576e9ae343aac7ce8c940
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/17631/commits/5cb5cf14de2cc46613214b258eb5c5e52881c632
5cb5cf1https://github.com/microsoft/TypeScript/pull/17631/commits/5cb5cf14de2cc46613214b258eb5c5e52881c632
https://github.com/DanielRosenwasser
Made the first-declaration check conservative in the TypeScript trans…https://github.com/microsoft/TypeScript/pull/17631/commits/9f1b7471139f3ed91b2b987dcb2cacb66b9de0cb
9f1b747https://github.com/microsoft/TypeScript/pull/17631/commits/9f1b7471139f3ed91b2b987dcb2cacb66b9de0cb
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/17631/commits/22e0d9f7911124f23ee7cfd6e67dc1cf063a4e75
22e0d9fhttps://github.com/microsoft/TypeScript/pull/17631/commits/22e0d9f7911124f23ee7cfd6e67dc1cf063a4e75
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Aug 5, 2017https://github.com/microsoft/TypeScript/pull/17631#event-1194166524
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Aug 5, 2017 https://github.com/microsoft/TypeScript/pull/17631#ref-issue-247835945
Synthesized ModuleDeclarations are missing the top level variable declaration in the emit #17596 https://github.com/microsoft/TypeScript/issues/17596
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 9, 2017 https://github.com/microsoft/TypeScript/pull/17631#pullrequestreview-55107933
View reviewed changes https://github.com/microsoft/TypeScript/pull/17631/files/22e0d9f7911124f23ee7cfd6e67dc1cf063a4e75
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 9, 2017 https://github.com/microsoft/TypeScript/pull/17631#pullrequestreview-55379875
View reviewed changes https://github.com/microsoft/TypeScript/pull/17631/files/22e0d9f7911124f23ee7cfd6e67dc1cf063a4e75
Ron Buckton (rbuckton)https://github.com/rbuckton
https://github.com/microsoft/TypeScript/pull/17631#pullrequestreview-55379875
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17631
src/compiler/transformers/ts.tshttps://github.com/microsoft/TypeScript/pull/17631/files/22e0d9f7911124f23ee7cfd6e67dc1cf063a4e75#diff-434a48997b788187774ea0573dd60688d07638fc89e809acf9bb3f455c816027
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 9, 2017https://github.com/microsoft/TypeScript/pull/17631#discussion_r132312024
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17631
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
August 10, 2017 08:28https://github.com/microsoft/TypeScript/pull/17631#commits-pushed-6ef27a4
https://github.com/DanielRosenwasser
Added test for class/namespace merging with an ESNext target.https://github.com/microsoft/TypeScript/pull/17631/commits/6ef27a4e1e2d7daf77c21bdd2148ee4459be1420
6ef27a4https://github.com/microsoft/TypeScript/pull/17631/commits/6ef27a4e1e2d7daf77c21bdd2148ee4459be1420
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/17631/commits/66e2a0bb943538f3496e41f55a80899f0cfd78e1
66e2a0bhttps://github.com/microsoft/TypeScript/pull/17631/commits/66e2a0bb943538f3496e41f55a80899f0cfd78e1
https://github.com/DanielRosenwasser
Added test.https://github.com/microsoft/TypeScript/pull/17631/commits/18cced9abd97005b5c139bd97ac41e892f0c3b9d
18cced9https://github.com/microsoft/TypeScript/pull/17631/commits/18cced9abd97005b5c139bd97ac41e892f0c3b9d
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/17631/commits/33a036b6799f297fcf7b913c3a56385e47026cd6
33a036bhttps://github.com/microsoft/TypeScript/pull/17631/commits/33a036b6799f297fcf7b913c3a56385e47026cd6
https://github.com/DanielRosenwasser
Just track the local names of identifiers instead of ever using symbols.https://github.com/microsoft/TypeScript/pull/17631/commits/a51397e339c35cf8466460ee014c7100ea266c95
a51397ehttps://github.com/microsoft/TypeScript/pull/17631/commits/a51397e339c35cf8466460ee014c7100ea266c95
https://github.com/DanielRosenwasser
Accepted baselines.https://github.com/microsoft/TypeScript/pull/17631/commits/6e60a017bbc187d10c76ca7c392623f8b4060dd9
6e60a01https://github.com/microsoft/TypeScript/pull/17631/commits/6e60a017bbc187d10c76ca7c392623f8b4060dd9
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Aug 15, 2017https://github.com/microsoft/TypeScript/pull/17631#issuecomment-322363538
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17631
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17631
https://github.com/DanielRosenwasser
Fix lint errors.https://github.com/microsoft/TypeScript/pull/17631/commits/281d821fe812f171ae94fa77503514ec0edb8521
281d821https://github.com/microsoft/TypeScript/pull/17631/commits/281d821fe812f171ae94fa77503514ec0edb8521
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 16, 2017 https://github.com/microsoft/TypeScript/pull/17631#pullrequestreview-56772552
View reviewed changes https://github.com/microsoft/TypeScript/pull/17631/files/281d821fe812f171ae94fa77503514ec0edb8521
Ron Buckton (rbuckton)https://github.com/rbuckton
https://github.com/microsoft/TypeScript/pull/17631#pullrequestreview-56772552
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17631
src/compiler/transformers/ts.tshttps://github.com/microsoft/TypeScript/pull/17631/files/281d821fe812f171ae94fa77503514ec0edb8521#diff-434a48997b788187774ea0573dd60688d07638fc89e809acf9bb3f455c816027
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 16, 2017https://github.com/microsoft/TypeScript/pull/17631#discussion_r133574117
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17631
src/compiler/transformers/ts.tshttps://github.com/microsoft/TypeScript/pull/17631/files/281d821fe812f171ae94fa77503514ec0edb8521#diff-434a48997b788187774ea0573dd60688d07638fc89e809acf9bb3f455c816027
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 16, 2017https://github.com/microsoft/TypeScript/pull/17631#discussion_r133574601
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17631
src/compiler/transformers/ts.tshttps://github.com/microsoft/TypeScript/pull/17631/files/281d821fe812f171ae94fa77503514ec0edb8521#diff-434a48997b788187774ea0573dd60688d07638fc89e809acf9bb3f455c816027
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 16, 2017https://github.com/microsoft/TypeScript/pull/17631#discussion_r133574771
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17631
https://github.com/DanielRosenwasser
Addressed code review feedback.https://github.com/microsoft/TypeScript/pull/17631/commits/b7020628c14284dfcb1df8525ac61a22f945c0ab
b702062https://github.com/microsoft/TypeScript/pull/17631/commits/b7020628c14284dfcb1df8525ac61a22f945c0ab
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
2729281https://github.com/microsoft/TypeScript/commit/2729281a14b582c0e19248728e905449da886eb8
Aug 17, 2017https://github.com/microsoft/TypeScript/pull/17631#event-1209568337
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Aug 17, 2017https://github.com/microsoft/TypeScript/pull/17631#event-1209570103
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Aug 17, 2017 https://github.com/microsoft/TypeScript/pull/17631#ref-pullrequest-250846988
[release-2.5] Fix emit for leading 'var' declarations for synthesized namespaces #17856 https://github.com/microsoft/TypeScript/pull/17856
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 14, 2018https://github.com/microsoft/TypeScript/pull/17631#event-1682136393
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F17631
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
https://github.com/microsoft/TypeScript/pull/17631/files/281d821fe812f171ae94fa77503514ec0edb8521
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17631
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17631
https://github.com/DanielRosenwasser
https://github.com/rbuckton
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.