| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8572f746-9da5-8aa0-a424-b0d3ab1d11bd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 984E:38DA3:1C55C9:27E291:6AFC5C5E |
| html-safe-nonce | 1b27a82397eef52c3f3f09b0e894ccf9d1c5221341616a8845a850b8d38ee1d0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODRFOjM4REEzOjFDNTVDOToyN0UyOTE6NkFGQzVDNUUiLCJ2aXNpdG9yX2lkIjoiODM2MTU1NTg0NTMzODM4OTU5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4e4f19c763c4a717f97f832405e3802b8d6579c5ab48cb7934c6abc3a5314b28 |
| hovercard-subject-tag | pull_request:132799881 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/17455/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7d1f874b250461c89b829405f391ddd0126bf59e5088eb391f6239d83abe4135/microsoft/TypeScript/pull/17455 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7d1f874b250461c89b829405f391ddd0126bf59e5088eb391f6239d83abe4135/microsoft/TypeScript/pull/17455 |
| og:image:alt | This PR adds some missing checks related to indexed access types and mapped types. In particular, for an indexed access T[K] the PR ensures that we always check that K is assignable to keyof T. Thi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ahejlsberg |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4f3b2b289515382e47edd25c65b136bf38bf579bf087f67ba6bcdcef5db540ad |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c0012cfe4370eb5aa24887f80677be13de4df94d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/17455#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F17455 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F17455 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/17455 |
| Reload | https://github.com/microsoft/TypeScript/pull/17455 |
| Reload | https://github.com/microsoft/TypeScript/pull/17455 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests338 (338) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/pulse |
| https://github.com/microsoft/TypeScript |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| master | https://github.com/microsoft/TypeScript/tree/master |
| mappedTypeFixes | https://github.com/microsoft/TypeScript/tree/mappedTypeFixes |
| Conversation | https://github.com/microsoft/TypeScript/pull/17455 |
| Commits4 (4) | https://github.com/microsoft/TypeScript/pull/17455/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/17455/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/17455/files |
| Mapped and indexed access type fixes | https://github.com/microsoft/TypeScript/pull/17455#top |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| master | https://github.com/microsoft/TypeScript/tree/master |
| mappedTypeFixes | https://github.com/microsoft/TypeScript/tree/mappedTypeFixes |
|
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Jul 27, 2017 | https://github.com/microsoft/TypeScript/pull/17455#issue-246108629 |
| #17238 | https://github.com/microsoft/TypeScript/issues/17238 |
| #17336 | https://github.com/microsoft/TypeScript/pull/17336 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/17455 |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| July 26, 2017 15:19 | https://github.com/microsoft/TypeScript/pull/17455#commits-pushed-5a85fca |
|
| https://github.com/ahejlsberg |
| Properly check mapped type constituents / Fix generic mapped type dis… | https://github.com/microsoft/TypeScript/pull/17455/commits/5a85fca0cd9db17b95e80068f17467b0c7f04fe5 |
| 5a85fca | https://github.com/microsoft/TypeScript/pull/17455/commits/5a85fca0cd9db17b95e80068f17467b0c7f04fe5 |
|
| https://github.com/ahejlsberg |
| Accept new baselines | https://github.com/microsoft/TypeScript/pull/17455/commits/62ddc99a4948d81a713bb9997dd6ddef4c460dea |
| 62ddc99 | https://github.com/microsoft/TypeScript/pull/17455/commits/62ddc99a4948d81a713bb9997dd6ddef4c460dea |
|
| https://github.com/ahejlsberg |
| Add missing check in getIndexedAccessForMappedType | https://github.com/microsoft/TypeScript/pull/17455/commits/b6ec9512076a30f2c635cb58e59282ea6df6ca5b |
| b6ec951 | https://github.com/microsoft/TypeScript/pull/17455/commits/b6ec9512076a30f2c635cb58e59282ea6df6ca5b |
|
| https://github.com/ahejlsberg |
| Add regression tests | https://github.com/microsoft/TypeScript/pull/17455/commits/9e900942b5080d61bbd23e3dd09d60d922a781a1 |
| 9e90094 | https://github.com/microsoft/TypeScript/pull/17455/commits/9e900942b5080d61bbd23e3dd09d60d922a781a1 |
| https://github.com/msftclas |
| Microsoft Contribution License Agreements (msftclas) | https://github.com/msftclas |
|
cla-not-required
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required |
| Jul 27, 2017 | https://github.com/microsoft/TypeScript/pull/17455#event-1182168720 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Jul 27, 2017 | https://github.com/microsoft/TypeScript/pull/17455#event-1182169471 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| July 27, 2017 23:47 | https://github.com/microsoft/TypeScript/pull/17455#event-1182716379 |
| https://github.com/SimonMeskens |
| Simon Meskens (SimonMeskens) | https://github.com/SimonMeskens |
|
Jul 30, 2017
| https://github.com/microsoft/TypeScript/pull/17455#ref-issue-245624541 |
|
suggestion: dynamic function type
gcanti/typelevel-ts#8
| https://github.com/gcanti/typelevel-ts/issues/8 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
|
Aug 2, 2017
| https://github.com/microsoft/TypeScript/pull/17455#pullrequestreview-53890356 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/17455/files/9e900942b5080d61bbd23e3dd09d60d922a781a1 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| 4672457 | https://github.com/microsoft/TypeScript/commit/467245780d8ff7ae5b45dd05ac9f7a3a801c3d87 |
| Aug 2, 2017 | https://github.com/microsoft/TypeScript/pull/17455#event-1190288954 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| August 2, 2017 20:36 | https://github.com/microsoft/TypeScript/pull/17455#event-1190289041 |
| https://github.com/gcnew |
| Marin Marinov (gcnew) | https://github.com/gcnew |
|
Aug 2, 2017
| https://github.com/microsoft/TypeScript/pull/17455#ref-pullrequest-244538186 |
|
Mapped types fixes
#17336
| https://github.com/microsoft/TypeScript/pull/17336 |
| https://github.com/SimonMeskens |
| Simon Meskens (SimonMeskens) | https://github.com/SimonMeskens |
|
Aug 7, 2017
| https://github.com/microsoft/TypeScript/pull/17455#ref-issue-234779139 |
|
fleshing out type operators (discussion)
#16392
| https://github.com/microsoft/TypeScript/issues/16392 |
| https://github.com/KiaraGrouwstra |
| kiara (KiaraGrouwstra) | https://github.com/KiaraGrouwstra |
|
Aug 11, 2017
| https://github.com/microsoft/TypeScript/pull/17455#ref-issue-228061170 |
|
Type cannot be used to index type
#15768
| https://github.com/microsoft/TypeScript/issues/15768 |
| https://github.com/KiaraGrouwstra |
| kiara (KiaraGrouwstra) | https://github.com/KiaraGrouwstra |
| Aug 11, 2017 | https://github.com/microsoft/TypeScript/pull/17455#issuecomment-321749422 |
| Anders Hejlsberg (@ahejlsberg) | https://github.com/ahejlsberg |
| #15768 | https://github.com/microsoft/TypeScript/issues/15768 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/17455 |
|
TS 2.5 regression
gcanti/typelevel-ts#9
| https://github.com/gcanti/typelevel-ts/issues/9 |
|
Why path isn't curried?
typed-typings/npm-ramda#185
| https://github.com/typed-typings/npm-ramda/issues/185 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Jun 14, 2018 | https://github.com/microsoft/TypeScript/pull/17455#event-1682138082 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F17455 |
|
| https://github.com/DanielRosenwasser |
|
Daniel Rosenwasser (DanielRosenwasser)
| https://github.com/DanielRosenwasser |
|
| https://github.com/rbuckton |
|
Ron Buckton (rbuckton)
| https://github.com/rbuckton |
|
| https://github.com/microsoft/TypeScript/pull/17455/files/9e900942b5080d61bbd23e3dd09d60d922a781a1 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/17455 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/17455 |
|
| https://github.com/ahejlsberg |
|
| https://github.com/KiaraGrouwstra |
|
| https://github.com/rbuckton |
|
| https://github.com/msftclas |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |