René's URL Explorer Experiment


Title: Session: don't return undefined if a response is required · Pull Request #17165 · microsoft/TypeScript · GitHub

Open Graph Title: Session: don't return undefined if a response is required · Pull Request #17165 · microsoft/TypeScript

X Title: Session: don't return undefined if a response is required · Pull Request #17165 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Session: don't return undefined if a response is required · Pull Request #17165 · microsoft/TypeScript

Open Graph Description: Sequel to #16773 This doesn't yet fix SignatureHelp, since that doesn't return an array. I'm not sure if VSCode is depending on us sending back an "error" response if the user...

X Description: Sequel to #16773 This doesn't yet fix SignatureHelp, since that doesn't return an array. I'm not sure if VSCode is depending on us sending back an "error" ...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/17165

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fc8668e9-f674-f5e2-8ac8-71811812eb3f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCFAC:10531B:1E4581:26AFE2:6B00FD80
html-safe-nonced6594e505f626a78c536fe1c65e31010a085517f21ffc1e4550bacab71998eef
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRkFDOjEwNTMxQjoxRTQ1ODE6MjZBRkUyOjZCMDBGRDgwIiwidmlzaXRvcl9pZCI6Ijg3NjIwMDg2ODMyMzMyMTM4MjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac46e18f12ac89f2ed63d81b97a6f9c0e8142640406cae0493aeda0ad9edccac1e
hovercard-subject-tagpull_request:130401227
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/17165/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b005c2e02b2efd4687c3b7e91f5aa137dd7bc5303d8f7d1f2502898a1627c30c/microsoft/TypeScript/pull/17165
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b005c2e02b2efd4687c3b7e91f5aa137dd7bc5303d8f7d1f2502898a1627c30c/microsoft/TypeScript/pull/17165
og:image:altSequel to #16773 This doesn't yet fix SignatureHelp, since that doesn't return an array. I'm not sure if VSCode is depending on us sending back an "error" response if the user...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/17165#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F17165
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F17165
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/17165
Reloadhttps://github.com/microsoft/TypeScript/pull/17165
Reloadhttps://github.com/microsoft/TypeScript/pull/17165
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
masterhttps://github.com/microsoft/TypeScript/tree/master
requiredResponsehttps://github.com/microsoft/TypeScript/tree/requiredResponse
Conversationhttps://github.com/microsoft/TypeScript/pull/17165
Commits6 (6)https://github.com/microsoft/TypeScript/pull/17165/commits
Checkshttps://github.com/microsoft/TypeScript/pull/17165/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/17165/files
Session: don't return undefined if a response is requiredhttps://github.com/microsoft/TypeScript/pull/17165#top
masterhttps://github.com/microsoft/TypeScript/tree/master
requiredResponsehttps://github.com/microsoft/TypeScript/tree/requiredResponse
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Jul 13, 2017https://github.com/microsoft/TypeScript/pull/17165#issue-242741887
#16773https://github.com/microsoft/TypeScript/pull/16773
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17165
Session: don't return undefined if a response is requiredhttps://github.com/microsoft/TypeScript/pull/17165/commits/c533b0ea2987bcfc503d478250d467be56828c31
c533b0ehttps://github.com/microsoft/TypeScript/pull/17165/commits/c533b0ea2987bcfc503d478250d467be56828c31
Matt Bierner (mjbvz)https://github.com/mjbvz
July 13, 2017 15:33https://github.com/microsoft/TypeScript/pull/17165#event-1162809977
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Jul 13, 2017https://github.com/microsoft/TypeScript/pull/17165#event-1162810026
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 8, 2017 https://github.com/microsoft/TypeScript/pull/17165#pullrequestreview-54813704
View reviewed changes https://github.com/microsoft/TypeScript/pull/17165/files/c533b0ea2987bcfc503d478250d467be56828c31
src/server/session.tshttps://github.com/microsoft/TypeScript/pull/17165/files/c533b0ea2987bcfc503d478250d467be56828c31#diff-c9fde3d99427a4b56c409a7dec15c227b21119d0d56bcfab4dbfad23f83118b0
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 8, 2017https://github.com/microsoft/TypeScript/pull/17165#discussion_r131800826
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17165
src/server/session.tshttps://github.com/microsoft/TypeScript/pull/17165/files/c533b0ea2987bcfc503d478250d467be56828c31#diff-c9fde3d99427a4b56c409a7dec15c227b21119d0d56bcfab4dbfad23f83118b0
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 8, 2017https://github.com/microsoft/TypeScript/pull/17165#discussion_r131800991
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17165
August 8, 2017 07:41https://github.com/microsoft/TypeScript/pull/17165#commits-pushed-848bcf6
Merge branch 'master' into requiredResponsehttps://github.com/microsoft/TypeScript/pull/17165/commits/848bcf66596cf4d0920aa0b67c412c60e7f2797d
848bcf6https://github.com/microsoft/TypeScript/pull/17165/commits/848bcf66596cf4d0920aa0b67c412c60e7f2797d
Use ReadonlyArray and emptyArrayhttps://github.com/microsoft/TypeScript/pull/17165/commits/a31ad7843653dd15e868a355d3e1d3706b90ef6f
a31ad78https://github.com/microsoft/TypeScript/pull/17165/commits/a31ad7843653dd15e868a355d3e1d3706b90ef6f
Remove inferred return typehttps://github.com/microsoft/TypeScript/pull/17165/commits/8931ddc77082c14f4f5b074dfdae3d14063b641e
8931ddchttps://github.com/microsoft/TypeScript/pull/17165/commits/8931ddc77082c14f4f5b074dfdae3d14063b641e
Merge branch 'master' into requiredResponsehttps://github.com/microsoft/TypeScript/pull/17165/commits/38b7afac6713672b47199ff581b9a432ee754d94
38b7afahttps://github.com/microsoft/TypeScript/pull/17165/commits/38b7afac6713672b47199ff581b9a432ee754d94
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 8, 2017https://github.com/microsoft/TypeScript/pull/17165#issuecomment-321031782
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17165
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Aug 8, 2017https://github.com/microsoft/TypeScript/pull/17165#issuecomment-321032372
#17685https://github.com/microsoft/TypeScript/pull/17685
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17165
Merge branch 'master' into requiredResponsehttps://github.com/microsoft/TypeScript/pull/17165/commits/9bf8ef74e5d00744c99cc051d29366da4ac8801f
9bf8ef7https://github.com/microsoft/TypeScript/pull/17165/commits/9bf8ef74e5d00744c99cc051d29366da4ac8801f
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Aug 8, 2017https://github.com/microsoft/TypeScript/pull/17165#issuecomment-321036763
Ron Buckton (@rbuckton)https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17165
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Aug 9, 2017 https://github.com/microsoft/TypeScript/pull/17165#pullrequestreview-55368394
View reviewed changes https://github.com/microsoft/TypeScript/pull/17165/files/9bf8ef74e5d00744c99cc051d29366da4ac8801f
f124e19https://github.com/microsoft/TypeScript/commit/f124e199718b9cda06654af2ce487f1d6a332b34
Aug 9, 2017https://github.com/microsoft/TypeScript/pull/17165#event-1199840646
August 9, 2017 20:46https://github.com/microsoft/TypeScript/pull/17165#event-1199840704
Ben Lichtman (uniqueiniquity)https://github.com/uniqueiniquity
Aug 9, 2017 https://github.com/microsoft/TypeScript/pull/17165#ref-commit-24d376b
https://github.com/uniqueiniquity
Session: don't return undefined if a response is required (https://github.com/uniqueiniquity/TypeScript/commit/24d376b4c5a2726764b22520f78362861c4c1f5c
microsoft#…https://github.com/microsoft/TypeScript/pull/17165
24d376bhttps://github.com/uniqueiniquity/TypeScript/commit/24d376b4c5a2726764b22520f78362861c4c1f5c
…17165https://github.com/microsoft/TypeScript/pull/17165
https://github.com/amcasey
Andrew Casey (amcasey)https://github.com/amcasey
Aug 10, 2017 https://github.com/microsoft/TypeScript/pull/17165#pullrequestreview-55640610
View reviewed changes https://github.com/microsoft/TypeScript/pull/17165/files/9bf8ef74e5d00744c99cc051d29366da4ac8801f
src/server/session.tshttps://github.com/microsoft/TypeScript/pull/17165/files/9bf8ef74e5d00744c99cc051d29366da4ac8801f#diff-c9fde3d99427a4b56c409a7dec15c227b21119d0d56bcfab4dbfad23f83118b0
Andrew Casey (amcasey)https://github.com/amcasey
Aug 10, 2017https://github.com/microsoft/TypeScript/pull/17165#discussion_r132546768
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17165
https://github.com/amcasey
Andrew Casey (amcasey)https://github.com/amcasey
Aug 10, 2017 https://github.com/microsoft/TypeScript/pull/17165#pullrequestreview-55640720
View reviewed changes https://github.com/microsoft/TypeScript/pull/17165/files/9bf8ef74e5d00744c99cc051d29366da4ac8801f
src/server/session.tshttps://github.com/microsoft/TypeScript/pull/17165/files/9bf8ef74e5d00744c99cc051d29366da4ac8801f#diff-c9fde3d99427a4b56c409a7dec15c227b21119d0d56bcfab4dbfad23f83118b0
Andrew Casey (amcasey)https://github.com/amcasey
Aug 10, 2017https://github.com/microsoft/TypeScript/pull/17165#discussion_r132546867
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17165
https://github.com/amcasey
Andrew Casey (amcasey)https://github.com/amcasey
Aug 10, 2017 https://github.com/microsoft/TypeScript/pull/17165#pullrequestreview-55640751
View reviewed changes https://github.com/microsoft/TypeScript/pull/17165/files/9bf8ef74e5d00744c99cc051d29366da4ac8801f
src/server/session.tshttps://github.com/microsoft/TypeScript/pull/17165/files/9bf8ef74e5d00744c99cc051d29366da4ac8801f#diff-c9fde3d99427a4b56c409a7dec15c227b21119d0d56bcfab4dbfad23f83118b0
Andrew Casey (amcasey)https://github.com/amcasey
Aug 10, 2017https://github.com/microsoft/TypeScript/pull/17165#discussion_r132546891
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17165
https://github.com/amcasey
Andrew Casey (amcasey)https://github.com/amcasey
Aug 10, 2017 https://github.com/microsoft/TypeScript/pull/17165#pullrequestreview-55640962
View reviewed changes https://github.com/microsoft/TypeScript/pull/17165/files/9bf8ef74e5d00744c99cc051d29366da4ac8801f
src/server/session.tshttps://github.com/microsoft/TypeScript/pull/17165/files/9bf8ef74e5d00744c99cc051d29366da4ac8801f#diff-c9fde3d99427a4b56c409a7dec15c227b21119d0d56bcfab4dbfad23f83118b0
Andrew Casey (amcasey)https://github.com/amcasey
Aug 10, 2017https://github.com/microsoft/TypeScript/pull/17165#discussion_r132547062
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17165
https://github.com/amcasey
Andrew Casey (amcasey)https://github.com/amcasey
Aug 10, 2017 https://github.com/microsoft/TypeScript/pull/17165#pullrequestreview-55641065
View reviewed changes https://github.com/microsoft/TypeScript/pull/17165/files/9bf8ef74e5d00744c99cc051d29366da4ac8801f
src/server/session.tshttps://github.com/microsoft/TypeScript/pull/17165/files/9bf8ef74e5d00744c99cc051d29366da4ac8801f#diff-c9fde3d99427a4b56c409a7dec15c227b21119d0d56bcfab4dbfad23f83118b0
Andrew Casey (amcasey)https://github.com/amcasey
Aug 10, 2017https://github.com/microsoft/TypeScript/pull/17165#discussion_r132547157
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17165
Aug 10, 2017 https://github.com/microsoft/TypeScript/pull/17165#ref-pullrequest-249455380
Fixes to session's handling of empty results #17728 https://github.com/microsoft/TypeScript/pull/17728
https://github.com/amcasey
Andrew Casey (amcasey)https://github.com/amcasey
Aug 10, 2017https://github.com/microsoft/TypeScript/pull/17165#issuecomment-321654505
Andy (Andrewkraft) (@Andy-MS)https://github.com/Andy-MS
#17727https://github.com/microsoft/TypeScript/pull/17727
Mine Starks (@minestarks)https://github.com/minestarks
Ron Buckton (@rbuckton)https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17165
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Aug 10, 2017https://github.com/microsoft/TypeScript/pull/17165#issuecomment-321663005
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17165
https://github.com/amcasey
Andrew Casey (amcasey)https://github.com/amcasey
Aug 11, 2017https://github.com/microsoft/TypeScript/pull/17165#issuecomment-321875593
#17728https://github.com/microsoft/TypeScript/pull/17728
#17727https://github.com/microsoft/TypeScript/pull/17727
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17165
Aug 14, 2017 https://github.com/microsoft/TypeScript/pull/17165#ref-pullrequest-250097340
session.ts: Revert some emptyArray back to undefined #17781 https://github.com/microsoft/TypeScript/pull/17781
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 14, 2018https://github.com/microsoft/TypeScript/pull/17165#event-1682140789
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F17165
https://github.com/mjbvz
Matt Bierner (mjbvz) https://github.com/mjbvz
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17165
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/17165
https://github.com/rbuckton
https://github.com/amcasey
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.