| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3fde11b6-4d98-795e-b363-6ee1a21686fc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 93C4:3C5B89:38F47C:4DFBFC:6B00B5CF |
| html-safe-nonce | f7f5818b91223df97cf93061bac5c15520d5afe46ef00a858e7ca85baa5ac4cf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0M0OjNDNUI4OTozOEY0N0M6NERGQkZDOjZCMDBCNUNGIiwidmlzaXRvcl9pZCI6IjQ0MDA3NjYxMDMzNzA5MDUwMzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 65731287e1b446cd2749acf31e1367891fb9254ac0b0f8e77d898b7e8f690298 |
| hovercard-subject-tag | pull_request:124538777 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/16343/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a2de115ce173a13422f6e5e9041b780654a1207d58a1e7b535b634698ab0947d/microsoft/TypeScript/pull/16343 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a2de115ce173a13422f6e5e9041b780654a1207d58a1e7b535b634698ab0947d/microsoft/TypeScript/pull/16343 |
| og:image:alt | Fixes #16333
Previously, weak type errors didn't occur with primitive sources because the apparent type of primitives all include toString. isKnownProperty reports that toString is known for al... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sandersn |
| hostname | github.com |
| expected-hostname | github.com |
| None | 1d07c25977adfc5ff6acb0a962a9bc168c07afbda6fef765f9761c350c2ae4a2 |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5429cbfc6aca8c7b9a086a3c8f47400346f38cc9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/16343#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F16343 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F16343 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/16343 |
| Reload | https://github.com/microsoft/TypeScript/pull/16343 |
| Reload | https://github.com/microsoft/TypeScript/pull/16343 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests307 (307) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| master | https://github.com/microsoft/TypeScript/tree/master |
| weak-types-for-primitives | https://github.com/microsoft/TypeScript/tree/weak-types-for-primitives |
| Conversation | https://github.com/microsoft/TypeScript/pull/16343 |
| Commits4 (4) | https://github.com/microsoft/TypeScript/pull/16343/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/16343/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/16343/files |
| Weak type errors for primitives | https://github.com/microsoft/TypeScript/pull/16343#top |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| master | https://github.com/microsoft/TypeScript/tree/master |
| weak-types-for-primitives | https://github.com/microsoft/TypeScript/tree/weak-types-for-primitives |
|
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Jun 7, 2017 | https://github.com/microsoft/TypeScript/pull/16343#issue-234370595 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/16343 |
| #16333 | https://github.com/microsoft/TypeScript/issues/16333 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/16343 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| June 7, 2017 16:20 | https://github.com/microsoft/TypeScript/pull/16343#commits-pushed-efa490e |
|
| https://github.com/sandersn |
| Detect weak type errors with primitive sources | https://github.com/microsoft/TypeScript/pull/16343/commits/efa490eb164fbb4addcf774c62eab9d811e9b975 |
| efa490e | https://github.com/microsoft/TypeScript/pull/16343/commits/efa490eb164fbb4addcf774c62eab9d811e9b975 |
|
| https://github.com/sandersn |
| Test weak type errors with primitives | https://github.com/microsoft/TypeScript/pull/16343/commits/b509e681c1d2580c3c73093cbee1fd0a6db4853c |
| b509e68 | https://github.com/microsoft/TypeScript/pull/16343/commits/b509e681c1d2580c3c73093cbee1fd0a6db4853c |
| https://github.com/msftclas |
| Microsoft Contribution License Agreements (msftclas) | https://github.com/msftclas |
|
cla-not-required
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required |
| Jun 7, 2017 | https://github.com/microsoft/TypeScript/pull/16343#event-1114608929 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Jun 7, 2017 | https://github.com/microsoft/TypeScript/pull/16343#event-1114609035 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Jun 7, 2017
| https://github.com/microsoft/TypeScript/pull/16343#ref-issue-234326191 |
|
Primitives are assignable to weak types
#16333
| https://github.com/microsoft/TypeScript/issues/16333 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| June 8, 2017 09:01 | https://github.com/microsoft/TypeScript/pull/16343#commits-pushed-7797b1d |
|
| https://github.com/sandersn |
| Always use getPropertyOfObjectType in isKnownProperty | https://github.com/microsoft/TypeScript/pull/16343/commits/7797b1ddba2db6fa306dc15a56b532e7312d7db5 |
| 7797b1d | https://github.com/microsoft/TypeScript/pull/16343/commits/7797b1ddba2db6fa306dc15a56b532e7312d7db5 |
|
| https://github.com/sandersn |
| Update tests and baselines | https://github.com/microsoft/TypeScript/pull/16343/commits/a5b68c0800e27ac898113b6a84969ee83def2332 |
| a5b68c0 | https://github.com/microsoft/TypeScript/pull/16343/commits/a5b68c0800e27ac898113b6a84969ee83def2332 |
| https://github.com/ikatyang |
| Ika (ikatyang) | https://github.com/ikatyang |
|
Jun 8, 2017
| https://github.com/microsoft/TypeScript/pull/16343#ref-issue-234444475 |
|
Typescript does not work with defaults
#16354
| https://github.com/microsoft/TypeScript/issues/16354 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Yui (yuit) | https://github.com/yuit |
| June 8, 2017 16:20 | https://github.com/microsoft/TypeScript/pull/16343#event-1115827279 |
| https://github.com/yuit |
| Yui (yuit) | https://github.com/yuit |
|
Jun 9, 2017
| https://github.com/microsoft/TypeScript/pull/16343#pullrequestreview-43188737 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/16343/files/a5b68c0800e27ac898113b6a84969ee83def2332 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| cae1286 | https://github.com/microsoft/TypeScript/commit/cae1286b726e7c7e847c046edc4321c069d37cb9 |
| Jun 9, 2017 | https://github.com/microsoft/TypeScript/pull/16343#event-1117518302 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| June 9, 2017 16:03 | https://github.com/microsoft/TypeScript/pull/16343#event-1117518365 |
| https://github.com/ikatyang |
| Ika (ikatyang) | https://github.com/ikatyang |
|
Jun 22, 2017
| https://github.com/microsoft/TypeScript/pull/16343#ref-issue-237802018 |
|
Partial type passes for values that are strings and incorrect objects
#16691
| https://github.com/microsoft/TypeScript/issues/16691 |
|
Jun 23, 2017
| https://github.com/microsoft/TypeScript/pull/16343#ref-pullrequest-238161712 |
|
node: Expand allowed arguments to http(s).get / request
DefinitelyTyped/DefinitelyTyped#17433
| https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17433 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Jul 6, 2017
| https://github.com/microsoft/TypeScript/pull/16343#ref-pullrequest-230855470 |
|
Weak type detection
#16047
| https://github.com/microsoft/TypeScript/pull/16047 |
|
twix: Allow "LT" as a format
DefinitelyTyped/DefinitelyTyped#19065
| https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19065 |
|
sencha_touch: Make type of getScrollable() match interface
DefinitelyTyped/DefinitelyTyped#19068
| https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19068 |
|
jqrangeslider: Fix compile error
DefinitelyTyped/DefinitelyTyped#19086
| https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19086 |
|
gulp-useref: Fix tests
DefinitelyTyped/DefinitelyTyped#19088
| https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19088 |
|
google.visualization: Allow legend: "none"
DefinitelyTyped/DefinitelyTyped#19089
| https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19089 |
|
datatables.net: Allow "search" to be a boolean
DefinitelyTyped/DefinitelyTyped#19092
| https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19092 |
|
mongoose: Fix compile errors
DefinitelyTyped/DefinitelyTyped#19107
| https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19107 |
|
pad: Allow to use a string instead of an options object
DefinitelyTyped/DefinitelyTyped#19208
| https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19208 |
|
react-native-goby: allow updateDialog to be a boolean
DefinitelyTyped/DefinitelyTyped#19212
| https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19212 |
|
webpack: Fix tests
DefinitelyTyped/DefinitelyTyped#19218
| https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19218 |
|
react-router/v3: Fix test
DefinitelyTyped/DefinitelyTyped#19277
| https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19277 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Jun 14, 2018 | https://github.com/microsoft/TypeScript/pull/16343#event-1682149064 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F16343 |
|
| https://github.com/yuit |
|
Yui (yuit)
| https://github.com/yuit |
|
| https://github.com/microsoft/TypeScript/pull/16343/files/a5b68c0800e27ac898113b6a84969ee83def2332 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/16343 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/16343 |
|
| https://github.com/sandersn |
|
| https://github.com/yuit |
|
| https://github.com/msftclas |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |