René's URL Explorer Experiment


Title: Weak type errors for primitives by sandersn · Pull Request #16343 · microsoft/TypeScript · GitHub

Open Graph Title: Weak type errors for primitives by sandersn · Pull Request #16343 · microsoft/TypeScript

X Title: Weak type errors for primitives by sandersn · Pull Request #16343 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Weak type errors for primitives by sandersn · Pull Request #16343 · microsoft/TypeScript

Open Graph Description: Fixes #16333 Previously, weak type errors didn't occur with primitive sources because the apparent type of primitives all include toString. isKnownProperty reports that toString is known for al...

X Description: Fixes #16333 Previously, weak type errors didn't occur with primitive sources because the apparent type of primitives all include toString. isKnownProperty reports that toString is known fo...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/16343

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3fde11b6-4d98-795e-b363-6ee1a21686fc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id93C4:3C5B89:38F47C:4DFBFC:6B00B5CF
html-safe-noncef7f5818b91223df97cf93061bac5c15520d5afe46ef00a858e7ca85baa5ac4cf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0M0OjNDNUI4OTozOEY0N0M6NERGQkZDOjZCMDBCNUNGIiwidmlzaXRvcl9pZCI6IjQ0MDA3NjYxMDMzNzA5MDUwMzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac65731287e1b446cd2749acf31e1367891fb9254ac0b0f8e77d898b7e8f690298
hovercard-subject-tagpull_request:124538777
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/16343/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a2de115ce173a13422f6e5e9041b780654a1207d58a1e7b535b634698ab0947d/microsoft/TypeScript/pull/16343
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a2de115ce173a13422f6e5e9041b780654a1207d58a1e7b535b634698ab0947d/microsoft/TypeScript/pull/16343
og:image:altFixes #16333 Previously, weak type errors didn't occur with primitive sources because the apparent type of primitives all include toString. isKnownProperty reports that toString is known for al...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
None1d07c25977adfc5ff6acb0a962a9bc168c07afbda6fef765f9761c350c2ae4a2
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5429cbfc6aca8c7b9a086a3c8f47400346f38cc9
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/16343#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F16343
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F16343
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/16343
Reloadhttps://github.com/microsoft/TypeScript/pull/16343
Reloadhttps://github.com/microsoft/TypeScript/pull/16343
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests307 (307)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
weak-types-for-primitiveshttps://github.com/microsoft/TypeScript/tree/weak-types-for-primitives
Conversationhttps://github.com/microsoft/TypeScript/pull/16343
Commits4 (4)https://github.com/microsoft/TypeScript/pull/16343/commits
Checkshttps://github.com/microsoft/TypeScript/pull/16343/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/16343/files
Weak type errors for primitiveshttps://github.com/microsoft/TypeScript/pull/16343#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
weak-types-for-primitiveshttps://github.com/microsoft/TypeScript/tree/weak-types-for-primitives
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 7, 2017https://github.com/microsoft/TypeScript/pull/16343#issue-234370595
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/16343
#16333https://github.com/microsoft/TypeScript/issues/16333
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/16343
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
June 7, 2017 16:20https://github.com/microsoft/TypeScript/pull/16343#commits-pushed-efa490e
https://github.com/sandersn
Detect weak type errors with primitive sourceshttps://github.com/microsoft/TypeScript/pull/16343/commits/efa490eb164fbb4addcf774c62eab9d811e9b975
efa490ehttps://github.com/microsoft/TypeScript/pull/16343/commits/efa490eb164fbb4addcf774c62eab9d811e9b975
https://github.com/sandersn
Test weak type errors with primitiveshttps://github.com/microsoft/TypeScript/pull/16343/commits/b509e681c1d2580c3c73093cbee1fd0a6db4853c
b509e68https://github.com/microsoft/TypeScript/pull/16343/commits/b509e681c1d2580c3c73093cbee1fd0a6db4853c
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Jun 7, 2017https://github.com/microsoft/TypeScript/pull/16343#event-1114608929
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 7, 2017https://github.com/microsoft/TypeScript/pull/16343#event-1114609035
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 7, 2017 https://github.com/microsoft/TypeScript/pull/16343#ref-issue-234326191
Primitives are assignable to weak types #16333 https://github.com/microsoft/TypeScript/issues/16333
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
June 8, 2017 09:01https://github.com/microsoft/TypeScript/pull/16343#commits-pushed-7797b1d
https://github.com/sandersn
Always use getPropertyOfObjectType in isKnownPropertyhttps://github.com/microsoft/TypeScript/pull/16343/commits/7797b1ddba2db6fa306dc15a56b532e7312d7db5
7797b1dhttps://github.com/microsoft/TypeScript/pull/16343/commits/7797b1ddba2db6fa306dc15a56b532e7312d7db5
https://github.com/sandersn
Update tests and baselineshttps://github.com/microsoft/TypeScript/pull/16343/commits/a5b68c0800e27ac898113b6a84969ee83def2332
a5b68c0https://github.com/microsoft/TypeScript/pull/16343/commits/a5b68c0800e27ac898113b6a84969ee83def2332
https://github.com/ikatyang
Ika (ikatyang)https://github.com/ikatyang
Jun 8, 2017 https://github.com/microsoft/TypeScript/pull/16343#ref-issue-234444475
Typescript does not work with defaults #16354 https://github.com/microsoft/TypeScript/issues/16354
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Yui (yuit)https://github.com/yuit
June 8, 2017 16:20https://github.com/microsoft/TypeScript/pull/16343#event-1115827279
https://github.com/yuit
Yui (yuit)https://github.com/yuit
Jun 9, 2017 https://github.com/microsoft/TypeScript/pull/16343#pullrequestreview-43188737
View reviewed changes https://github.com/microsoft/TypeScript/pull/16343/files/a5b68c0800e27ac898113b6a84969ee83def2332
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
cae1286https://github.com/microsoft/TypeScript/commit/cae1286b726e7c7e847c046edc4321c069d37cb9
Jun 9, 2017https://github.com/microsoft/TypeScript/pull/16343#event-1117518302
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
June 9, 2017 16:03https://github.com/microsoft/TypeScript/pull/16343#event-1117518365
https://github.com/ikatyang
Ika (ikatyang)https://github.com/ikatyang
Jun 22, 2017 https://github.com/microsoft/TypeScript/pull/16343#ref-issue-237802018
Partial type passes for values that are strings and incorrect objects #16691 https://github.com/microsoft/TypeScript/issues/16691
Jun 23, 2017 https://github.com/microsoft/TypeScript/pull/16343#ref-pullrequest-238161712
node: Expand allowed arguments to http(s).get / request DefinitelyTyped/DefinitelyTyped#17433 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17433
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jul 6, 2017 https://github.com/microsoft/TypeScript/pull/16343#ref-pullrequest-230855470
Weak type detection #16047 https://github.com/microsoft/TypeScript/pull/16047
twix: Allow "LT" as a format DefinitelyTyped/DefinitelyTyped#19065 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19065
sencha_touch: Make type of getScrollable() match interface DefinitelyTyped/DefinitelyTyped#19068 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19068
jqrangeslider: Fix compile error DefinitelyTyped/DefinitelyTyped#19086 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19086
gulp-useref: Fix tests DefinitelyTyped/DefinitelyTyped#19088 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19088
google.visualization: Allow legend: "none" DefinitelyTyped/DefinitelyTyped#19089 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19089
datatables.net: Allow "search" to be a boolean DefinitelyTyped/DefinitelyTyped#19092 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19092
mongoose: Fix compile errors DefinitelyTyped/DefinitelyTyped#19107 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19107
pad: Allow to use a string instead of an options object DefinitelyTyped/DefinitelyTyped#19208 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19208
react-native-goby: allow updateDialog to be a boolean DefinitelyTyped/DefinitelyTyped#19212 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19212
webpack: Fix tests DefinitelyTyped/DefinitelyTyped#19218 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19218
react-router/v3: Fix test DefinitelyTyped/DefinitelyTyped#19277 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19277
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 14, 2018https://github.com/microsoft/TypeScript/pull/16343#event-1682149064
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F16343
https://github.com/yuit
Yui (yuit) https://github.com/yuit
https://github.com/microsoft/TypeScript/pull/16343/files/a5b68c0800e27ac898113b6a84969ee83def2332
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/16343
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/16343
https://github.com/sandersn
https://github.com/yuit
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.