René's URL Explorer Experiment


Title: Make ScriptElementKind and HighlightSpanKind string enums · Pull Request #15966 · microsoft/TypeScript · GitHub

Open Graph Title: Make ScriptElementKind and HighlightSpanKind string enums · Pull Request #15966 · microsoft/TypeScript

X Title: Make ScriptElementKind and HighlightSpanKind string enums · Pull Request #15966 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Make ScriptElementKind and HighlightSpanKind string enums · Pull Request #15966 · microsoft/TypeScript

Open Graph Description: Note: is technically a change to our public API as many strings are now ScriptElementKinds. And anyone using the API must now have ts@next or they will get compile errors on the string enums -- but...

X Description: Note: is technically a change to our public API as many strings are now ScriptElementKinds. And anyone using the API must now have ts@next or they will get compile errors on the string enums -- but...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/15966

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0c816667-c43f-b1ea-5879-befeeac21725
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC34C:25598F:63149C:8563D6:6B00D40A
html-safe-nonce4f323b3d16a2a03cd893a551ed110eb4323054e62e23409416eabe0e23aaa8f7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzRDOjI1NTk4Rjo2MzE0OUM6ODU2M0Q2OjZCMDBENDBBIiwidmlzaXRvcl9pZCI6IjUzMTMwMzU1Mzg0Nzg0MTgwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac81c226b042b0320463a79fb2a4e41fcef4cd6fea19ffe55c1bd0e8b3c7316932
hovercard-subject-tagpull_request:121626277
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/15966/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8a03b8f090092beaefe13f4ee3a44a434414ca4804ab9845bb661178bba7d7bc/microsoft/TypeScript/pull/15966
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8a03b8f090092beaefe13f4ee3a44a434414ca4804ab9845bb661178bba7d7bc/microsoft/TypeScript/pull/15966
og:image:altNote: is technically a change to our public API as many strings are now ScriptElementKinds. And anyone using the API must now have ts@next or they will get compile errors on the string enums -- but...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None85bbdfe2b6ba16e234513bc6ceff5d848ef8449820c900692a2b4e67061931e5
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4943239a6d2c591325dad6e5c313e1cafda877f6
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/15966#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F15966
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F15966
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/15966
Reloadhttps://github.com/microsoft/TypeScript/pull/15966
Reloadhttps://github.com/microsoft/TypeScript/pull/15966
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests307 (307)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
masterhttps://github.com/microsoft/TypeScript/tree/master
kindhttps://github.com/microsoft/TypeScript/tree/kind
Conversationhttps://github.com/microsoft/TypeScript/pull/15966
Commits6 (6)https://github.com/microsoft/TypeScript/pull/15966/commits
Checkshttps://github.com/microsoft/TypeScript/pull/15966/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/15966/files
Make ScriptElementKind and HighlightSpanKind string enumshttps://github.com/microsoft/TypeScript/pull/15966#top
masterhttps://github.com/microsoft/TypeScript/tree/master
kindhttps://github.com/microsoft/TypeScript/tree/kind
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
May 20, 2017https://github.com/microsoft/TypeScript/pull/15966#issue-230158456
#15486https://github.com/microsoft/TypeScript/pull/15486
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15966
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
May 20, 2017https://github.com/microsoft/TypeScript/pull/15966#event-1090561346
Make ScriptElementKind and HighlightSpanKind string enumshttps://github.com/microsoft/TypeScript/pull/15966/commits/b162097c3c7f5e5174eb70124de8888669775dbd
b162097https://github.com/microsoft/TypeScript/pull/15966/commits/b162097c3c7f5e5174eb70124de8888669775dbd
force-pushedhttps://github.com/microsoft/TypeScript/compare/eed650ed66058701e73e1c7a34d8c5df6e903a3a..b162097c3c7f5e5174eb70124de8888669775dbd
eed650ehttps://github.com/microsoft/TypeScript/commit/eed650ed66058701e73e1c7a34d8c5df6e903a3a
b162097https://github.com/microsoft/TypeScript/commit/b162097c3c7f5e5174eb70124de8888669775dbd
Compare https://github.com/microsoft/TypeScript/compare/eed650ed66058701e73e1c7a34d8c5df6e903a3a..b162097c3c7f5e5174eb70124de8888669775dbd
May 20, 2017 14:56https://github.com/microsoft/TypeScript/pull/15966#event-1090561437
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 22, 2017 https://github.com/microsoft/TypeScript/pull/15966#pullrequestreview-39522105
View reviewed changes https://github.com/microsoft/TypeScript/pull/15966/files/b162097c3c7f5e5174eb70124de8888669775dbd
src/services/types.tshttps://github.com/microsoft/TypeScript/pull/15966/files/b162097c3c7f5e5174eb70124de8888669775dbd#diff-9717eb6d935579eea3b5662088dd258d4e1e17e2a405c3f1fa431e981e01b08f
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 22, 2017https://github.com/microsoft/TypeScript/pull/15966#discussion_r117786215
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15966
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 22, 2017https://github.com/microsoft/TypeScript/pull/15966#discussion_r117786305
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15966
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 22, 2017https://github.com/microsoft/TypeScript/pull/15966#discussion_r117786560
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15966
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 22, 2017https://github.com/microsoft/TypeScript/pull/15966#discussion_r117786895
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15966
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 22, 2017 https://github.com/microsoft/TypeScript/pull/15966#pullrequestreview-39522205
View reviewed changes https://github.com/microsoft/TypeScript/pull/15966/files/b162097c3c7f5e5174eb70124de8888669775dbd
src/services/types.tshttps://github.com/microsoft/TypeScript/pull/15966/files/b162097c3c7f5e5174eb70124de8888669775dbd#diff-9717eb6d935579eea3b5662088dd258d4e1e17e2a405c3f1fa431e981e01b08f
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 22, 2017https://github.com/microsoft/TypeScript/pull/15966#discussion_r117786305
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15966
src/services/types.tshttps://github.com/microsoft/TypeScript/pull/15966/files/b162097c3c7f5e5174eb70124de8888669775dbd#diff-9717eb6d935579eea3b5662088dd258d4e1e17e2a405c3f1fa431e981e01b08f
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 22, 2017https://github.com/microsoft/TypeScript/pull/15966#discussion_r117786560
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15966
src/services/types.tshttps://github.com/microsoft/TypeScript/pull/15966/files/b162097c3c7f5e5174eb70124de8888669775dbd#diff-9717eb6d935579eea3b5662088dd258d4e1e17e2a405c3f1fa431e981e01b08f
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 22, 2017https://github.com/microsoft/TypeScript/pull/15966#discussion_r117786895
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15966
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 22, 2017https://github.com/microsoft/TypeScript/pull/15966#issuecomment-303148556
https://github.com/Microsoft/TypeScript/wiki/API-Breaking-Changes#typescript-24https://github.com/Microsoft/TypeScript/wiki/API-Breaking-Changes#typescript-24
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15966
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Breaking Change https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22
Domain: API https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20API%22
May 22, 2017https://github.com/microsoft/TypeScript/pull/15966#event-1092124272
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
TypeScript 2.4https://github.com/microsoft/TypeScript/milestone/43
May 22, 2017https://github.com/microsoft/TypeScript/pull/15966#event-1092124414
May 22, 2017 10:40https://github.com/microsoft/TypeScript/pull/15966#commits-pushed-f94818d
Also convert ClassificationTypeNames and CommandTypes/CommandNameshttps://github.com/microsoft/TypeScript/pull/15966/commits/f94818da36c58f9fc0d6d535677f6500a096f6de
f94818dhttps://github.com/microsoft/TypeScript/pull/15966/commits/f94818da36c58f9fc0d6d535677f6500a096f6de
Convert other namespace + type alias in protocol.ts to const enumshttps://github.com/microsoft/TypeScript/pull/15966/commits/3b56ebeabe424547bcfba2eca77a9d74891901b8
3b56ebehttps://github.com/microsoft/TypeScript/pull/15966/commits/3b56ebeabe424547bcfba2eca77a9d74891901b8
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
May 22, 2017https://github.com/microsoft/TypeScript/pull/15966#issuecomment-303172635
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15966
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 22, 2017 https://github.com/microsoft/TypeScript/pull/15966#pullrequestreview-39545979
View reviewed changes https://github.com/microsoft/TypeScript/pull/15966/files/3b56ebeabe424547bcfba2eca77a9d74891901b8
src/server/protocol.tshttps://github.com/microsoft/TypeScript/pull/15966/files/b162097c3c7f5e5174eb70124de8888669775dbd..3b56ebeabe424547bcfba2eca77a9d74891901b8#diff-eb376d3ed604f5f596e7a34bcd6b1f851af61d3c22393ebf1b48da8f9976a32e
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 22, 2017https://github.com/microsoft/TypeScript/pull/15966#discussion_r117808320
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15966
Deleted user (ghost)https://github.com/ghost
May 22, 2017https://github.com/microsoft/TypeScript/pull/15966#discussion_r117809239
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15966
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 22, 2017 https://github.com/microsoft/TypeScript/pull/15966#pullrequestreview-39546159
View reviewed changes https://github.com/microsoft/TypeScript/pull/15966/files/3b56ebeabe424547bcfba2eca77a9d74891901b8
src/server/protocol.tshttps://github.com/microsoft/TypeScript/pull/15966/files/b162097c3c7f5e5174eb70124de8888669775dbd..3b56ebeabe424547bcfba2eca77a9d74891901b8#diff-eb376d3ed604f5f596e7a34bcd6b1f851af61d3c22393ebf1b48da8f9976a32e
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 22, 2017https://github.com/microsoft/TypeScript/pull/15966#discussion_r117808485
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15966
Fix missing initializershttps://github.com/microsoft/TypeScript/pull/15966/commits/c6e69dd64ba26a29900e7f296d2df3cc8d22767d
c6e69ddhttps://github.com/microsoft/TypeScript/pull/15966/commits/c6e69dd64ba26a29900e7f296d2df3cc8d22767d
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 22, 2017https://github.com/microsoft/TypeScript/pull/15966#issuecomment-303176441
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15966
Make CommandTypes a const enum and use allCommandTypes for unit testhttps://github.com/microsoft/TypeScript/pull/15966/commits/f6240cb6f91fb202c8c0b8fc21d965fd83ea62b7
f6240cbhttps://github.com/microsoft/TypeScript/pull/15966/commits/f6240cb6f91fb202c8c0b8fc21d965fd83ea62b7
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 22, 2017 https://github.com/microsoft/TypeScript/pull/15966#pullrequestreview-39597090
View reviewed changes https://github.com/microsoft/TypeScript/pull/15966/files/f6240cb6f91fb202c8c0b8fc21d965fd83ea62b7
Merge branch 'master' into kindhttps://github.com/microsoft/TypeScript/pull/15966/commits/b1e100e494cee76b352111c54624e36d522c6452
b1e100ehttps://github.com/microsoft/TypeScript/pull/15966/commits/b1e100e494cee76b352111c54624e36d522c6452
73ee2fehttps://github.com/microsoft/TypeScript/commit/73ee2feb51c9b7e24a29eb4cee19d7c14b933065
May 23, 2017https://github.com/microsoft/TypeScript/pull/15966#event-1093767412
May 23, 2017 14:19https://github.com/microsoft/TypeScript/pull/15966#event-1093767540
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 14, 2018https://github.com/microsoft/TypeScript/pull/15966#event-1682152840
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F15966
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15966
Breaking Change https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22
Domain: API https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20API%22
TypeScript 2.4 https://github.com/microsoft/TypeScript/milestone/43
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15966
https://github.com/mhegazy
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.