René's URL Explorer Experiment


Title: Declaration-emit class expressions as type literals by sandersn · Pull Request #15932 · microsoft/TypeScript · GitHub

Open Graph Title: Declaration-emit class expressions as type literals by sandersn · Pull Request #15932 · microsoft/TypeScript

X Title: Declaration-emit class expressions as type literals by sandersn · Pull Request #15932 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Declaration-emit class expressions as type literals by sandersn · Pull Request #15932 · microsoft/TypeScript

Open Graph Description: Fixes #15066, although the resulting d.ts file is a bit ugly. After discussion, Mohamed Hegazy (@mhegazy) and I decided that adding a new "named class expression" type would not be enough...

X Description: Fixes #15066, although the resulting d.ts file is a bit ugly. After discussion, Mohamed Hegazy (@mhegazy) and I decided that adding a new "named class expression" type would not b...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/15932

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:25277f72-14ab-8df2-493d-1d6ab8c50d1f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCE9E:215B92:E457A0:130CEA8:6B010784
html-safe-nonce08f82fc4f1420cf2645d6f6576cdbf7c7df13d61e5e7d69a10d615947c8184f0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTlFOjIxNUI5MjpFNDU3QTA6MTMwQ0VBODo2QjAxMDc4NCIsInZpc2l0b3JfaWQiOiI1NDczODM5NTI3MzgwNDUzMjUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacad0323ddee725204ca2063711ad9a688477a9425b10246131e81a0eef73188d6
hovercard-subject-tagpull_request:121324044
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/15932/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d357dda56b723f5175d27564ed1e5cf9dc83921aa345d4c3eee9282e5a5259b2/microsoft/TypeScript/pull/15932
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d357dda56b723f5175d27564ed1e5cf9dc83921aa345d4c3eee9282e5a5259b2/microsoft/TypeScript/pull/15932
og:image:altFixes #15066, although the resulting d.ts file is a bit ugly. After discussion, Mohamed Hegazy (@mhegazy) and I decided that adding a new "named class expression" type would not be enough...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/15932#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F15932
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F15932
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/15932
Reloadhttps://github.com/microsoft/TypeScript/pull/15932
Reloadhttps://github.com/microsoft/TypeScript/pull/15932
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
decl-emit-class-expr-as-type-literalhttps://github.com/microsoft/TypeScript/tree/decl-emit-class-expr-as-type-literal
Conversationhttps://github.com/microsoft/TypeScript/pull/15932
Commits5 (5)https://github.com/microsoft/TypeScript/pull/15932/commits
Checkshttps://github.com/microsoft/TypeScript/pull/15932/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/15932/files
Declaration-emit class expressions as type literalshttps://github.com/microsoft/TypeScript/pull/15932#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
decl-emit-class-expr-as-type-literalhttps://github.com/microsoft/TypeScript/tree/decl-emit-class-expr-as-type-literal
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 18, 2017https://github.com/microsoft/TypeScript/pull/15932#issue-229730826
#15066https://github.com/microsoft/TypeScript/issues/15066
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15932
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 18, 2017 09:10https://github.com/microsoft/TypeScript/pull/15932#commits-pushed-5a5fee3
https://github.com/sandersn
Declaration-emit class expressions as type literalshttps://github.com/microsoft/TypeScript/pull/15932/commits/5a5fee3bb8c33fc1998ed26924c93db13f1ddd05
5a5fee3https://github.com/microsoft/TypeScript/pull/15932/commits/5a5fee3bb8c33fc1998ed26924c93db13f1ddd05
https://github.com/sandersn
Test:decl emit for class expressions as type litshttps://github.com/microsoft/TypeScript/pull/15932/commits/e77024915e2aa7d50696511575f20d1f88243ec1
e770249https://github.com/microsoft/TypeScript/pull/15932/commits/e77024915e2aa7d50696511575f20d1f88243ec1
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
May 18, 2017https://github.com/microsoft/TypeScript/pull/15932#event-1088126143
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 18, 2017 https://github.com/microsoft/TypeScript/pull/15932#ref-issue-220123937
Using mixins throws TS4093, TS4020 and TS4060 when exporting the class that extends the result of a mixin #15066 https://github.com/microsoft/TypeScript/issues/15066
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 18, 2017 https://github.com/microsoft/TypeScript/pull/15932#pullrequestreview-39025534
View reviewed changes https://github.com/microsoft/TypeScript/pull/15932/files/e77024915e2aa7d50696511575f20d1f88243ec1
tests/baselines/reference/emitClassExpressionInDeclarationFile.jshttps://github.com/microsoft/TypeScript/pull/15932/files/e77024915e2aa7d50696511575f20d1f88243ec1#diff-41679b030b3914b1af80618f4e260afd95c4c3cd6277d6afe66f85e0df08d0a0
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 18, 2017https://github.com/microsoft/TypeScript/pull/15932#discussion_r117325879
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15932
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 22, 2017https://github.com/microsoft/TypeScript/pull/15932#discussion_r117799303
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15932
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
May 18, 2017 https://github.com/microsoft/TypeScript/pull/15932#pullrequestreview-39057219
View reviewed changes https://github.com/microsoft/TypeScript/pull/15932/files/e77024915e2aa7d50696511575f20d1f88243ec1
tests/cases/fourslash/findAllRefsForVariableInExtendsClause01.tshttps://github.com/microsoft/TypeScript/pull/15932/files/e77024915e2aa7d50696511575f20d1f88243ec1#diff-2d57b9615d5ab5b0c6ba70e26076fb39b87214ceed1663e7d83eefedaaeefeea
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
May 18, 2017https://github.com/microsoft/TypeScript/pull/15932#discussion_r117354715
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15932
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 19, 2017https://github.com/microsoft/TypeScript/pull/15932#discussion_r117565576
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15932
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
May 18, 2017 https://github.com/microsoft/TypeScript/pull/15932#pullrequestreview-39057856
View reviewed changes https://github.com/microsoft/TypeScript/pull/15932/files/e77024915e2aa7d50696511575f20d1f88243ec1
tests/cases/compiler/emitClassExpressionInDeclarationFile.tshttps://github.com/microsoft/TypeScript/pull/15932/files/e77024915e2aa7d50696511575f20d1f88243ec1#diff-4d38e80a554ef9e3210e79b1b40473dbced09c7d3e3b10225c1bcec06c0853bd
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
May 18, 2017https://github.com/microsoft/TypeScript/pull/15932#discussion_r117355302
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15932
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 22, 2017https://github.com/microsoft/TypeScript/pull/15932#discussion_r117855156
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15932
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
May 18, 2017 https://github.com/microsoft/TypeScript/pull/15932#pullrequestreview-39058184
View reviewed changes https://github.com/microsoft/TypeScript/pull/15932/files/e77024915e2aa7d50696511575f20d1f88243ec1
tests/cases/compiler/emitClassExpressionInDeclarationFile.tshttps://github.com/microsoft/TypeScript/pull/15932/files/e77024915e2aa7d50696511575f20d1f88243ec1#diff-4d38e80a554ef9e3210e79b1b40473dbced09c7d3e3b10225c1bcec06c0853bd
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
May 18, 2017https://github.com/microsoft/TypeScript/pull/15932#discussion_r117355614
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15932
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 22, 2017https://github.com/microsoft/TypeScript/pull/15932#discussion_r117827786
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15932
https://github.com/sandersn
Address most PR commentshttps://github.com/microsoft/TypeScript/pull/15932/commits/a0fa8ae6c4a19cc893f44036177c18c553b2070d
a0fa8aehttps://github.com/microsoft/TypeScript/pull/15932/commits/a0fa8ae6c4a19cc893f44036177c18c553b2070d
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
May 22, 2017 https://github.com/microsoft/TypeScript/pull/15932#pullrequestreview-39591589
View reviewed changes https://github.com/microsoft/TypeScript/pull/15932/files/a0fa8ae6c4a19cc893f44036177c18c553b2070d
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/15932/files/a0fa8ae6c4a19cc893f44036177c18c553b2070d#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
May 22, 2017https://github.com/microsoft/TypeScript/pull/15932#discussion_r117850706
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15932
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 22, 2017https://github.com/microsoft/TypeScript/pull/15932#discussion_r117854185
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15932
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 22, 2017 14:49https://github.com/microsoft/TypeScript/pull/15932#commits-pushed-860e8e8
https://github.com/sandersn
Add error for class exprs w/private propertieshttps://github.com/microsoft/TypeScript/pull/15932/commits/860e8e88c830eebf44bbdebdb86fadcf995f21bd
860e8e8https://github.com/microsoft/TypeScript/pull/15932/commits/860e8e88c830eebf44bbdebdb86fadcf995f21bd
https://github.com/sandersn
Add more tests and update baselineshttps://github.com/microsoft/TypeScript/pull/15932/commits/ecaf44d47437204f88ef11813665c1c38d32c6c3
ecaf44dhttps://github.com/microsoft/TypeScript/pull/15932/commits/ecaf44d47437204f88ef11813665c1c38d32c6c3
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 22, 2017https://github.com/microsoft/TypeScript/pull/15932#issuecomment-303233463
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15932
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 22, 2017 https://github.com/microsoft/TypeScript/pull/15932#pullrequestreview-39603598
View reviewed changes https://github.com/microsoft/TypeScript/pull/15932/files/ecaf44d47437204f88ef11813665c1c38d32c6c3
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
bc914c0https://github.com/microsoft/TypeScript/commit/bc914c02e6c0f9a5d1845fc97d870dceb949bd7a
May 22, 2017https://github.com/microsoft/TypeScript/pull/15932#event-1092680118
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 22, 2017 22:46https://github.com/microsoft/TypeScript/pull/15932#event-1092680211
Aug 14, 2017 https://github.com/microsoft/TypeScript/pull/15932#ref-pullrequest-250094447
Remove unused UseTypeAliasValue flag #17779 https://github.com/microsoft/TypeScript/pull/17779
https://github.com/jtlapp
Joe Lapp (jtlapp)https://github.com/jtlapp
Jan 29, 2018https://github.com/microsoft/TypeScript/pull/15932#issuecomment-361395938
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15932
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15932
https://github.com/jtlapp
Joe Lapp (jtlapp)https://github.com/jtlapp
Jan 29, 2018https://github.com/microsoft/TypeScript/pull/15932#issuecomment-361417146
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15932
https://github.com/jtlapp
Joe Lapp (jtlapp)https://github.com/jtlapp
Jan 29, 2018 https://github.com/microsoft/TypeScript/pull/15932#ref-issue-292603390
--declaration compiler option breaks exporting mixins #21465 https://github.com/microsoft/TypeScript/issues/21465
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 3, 2018https://github.com/microsoft/TypeScript/pull/15932#event-1712801187
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F15932
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat) https://github.com/sheetalkamat
https://github.com/microsoft/TypeScript/pull/15932/files/a0fa8ae6c4a19cc893f44036177c18c553b2070d
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
https://github.com/microsoft/TypeScript/pull/15932/files/ecaf44d47437204f88ef11813665c1c38d32c6c3
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15932
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15932
https://github.com/sandersn
https://github.com/jtlapp
https://github.com/mhegazy
https://github.com/sheetalkamat
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.