René's URL Explorer Experiment


Title: Add Javascript declarations to index constraint check error reporting by sandersn · Pull Request #15586 · microsoft/TypeScript · GitHub

Open Graph Title: Add Javascript declarations to index constraint check error reporting by sandersn · Pull Request #15586 · microsoft/TypeScript

X Title: Add Javascript declarations to index constraint check error reporting by sandersn · Pull Request #15586 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Add Javascript declarations to index constraint check error reporting by sandersn · Pull Request #15586 · microsoft/TypeScript

Open Graph Description: Now Javascript-style declarations like this.foo = "bar" are handled correctly and errors will be reported on the declaration correctly. Previously the code would check the computed proper...

X Description: Now Javascript-style declarations like this.foo = "bar" are handled correctly and errors will be reported on the declaration correctly. Previously the code would check the compute...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/15586

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:07b813cd-d3e2-4eee-3d05-64f82b02a535
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD956:358871:9C31FD:D0358B:6B00E516
html-safe-nonce4d91a6f2d6a65fdc53a338a41590c3f78f678595abf6cfc072479d182ebc0523
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTU2OjM1ODg3MTo5QzMxRkQ6RDAzNThCOjZCMDBFNTE2IiwidmlzaXRvcl9pZCI6IjI0MTI5OTU1MjE1NTY4MzM1NTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0d0b2bee610dd0819d66d2cef9b3dc2ad87fc9b87693088885a7aa3719252f28
hovercard-subject-tagpull_request:119023337
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/15586/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/798e61a719ae14c0daf97d27ab333fbc4599fd95766a1a5d3ee1b0daab8a8045/microsoft/TypeScript/pull/15586
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/798e61a719ae14c0daf97d27ab333fbc4599fd95766a1a5d3ee1b0daab8a8045/microsoft/TypeScript/pull/15586
og:image:altNow Javascript-style declarations like this.foo = "bar" are handled correctly and errors will be reported on the declaration correctly. Previously the code would check the computed proper...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/15586#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F15586
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F15586
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/15586
Reloadhttps://github.com/microsoft/TypeScript/pull/15586
Reloadhttps://github.com/microsoft/TypeScript/pull/15586
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
fix-index-constraint-check-for-js-class-exprshttps://github.com/microsoft/TypeScript/tree/fix-index-constraint-check-for-js-class-exprs
Conversationhttps://github.com/microsoft/TypeScript/pull/15586
Commits2 (2)https://github.com/microsoft/TypeScript/pull/15586/commits
Checkshttps://github.com/microsoft/TypeScript/pull/15586/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/15586/files
Add Javascript declarations to index constraint check error reportinghttps://github.com/microsoft/TypeScript/pull/15586#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
fix-index-constraint-check-for-js-class-exprshttps://github.com/microsoft/TypeScript/tree/fix-index-constraint-check-for-js-class-exprs
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 4, 2017https://github.com/microsoft/TypeScript/pull/15586#issue-226349661
#15525https://github.com/microsoft/TypeScript/issues/15525
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15586
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 4, 2017 10:11https://github.com/microsoft/TypeScript/pull/15586#commits-pushed-49fd1ad
https://github.com/sandersn
Add JS declaration to index constraint check error reportinghttps://github.com/microsoft/TypeScript/pull/15586/commits/49fd1ad80b19aa2ef1110d6f5255ba4fe4efd15f
49fd1adhttps://github.com/microsoft/TypeScript/pull/15586/commits/49fd1ad80b19aa2ef1110d6f5255ba4fe4efd15f
https://github.com/sandersn
Test:index constraint check on js class expressionhttps://github.com/microsoft/TypeScript/pull/15586/commits/3e85ac062716c06cccd2e9f70a8c8d0e66d1f020
3e85ac0https://github.com/microsoft/TypeScript/pull/15586/commits/3e85ac062716c06cccd2e9f70a8c8d0e66d1f020
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
May 4, 2017https://github.com/microsoft/TypeScript/pull/15586#event-1069327776
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 4, 2017 17:15https://github.com/microsoft/TypeScript/pull/15586#event-1069327861
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 4, 2017 https://github.com/microsoft/TypeScript/pull/15586#ref-issue-225643728
TypeScript 2.3.1 fails to compile this JS and throws TypeError #15525 https://github.com/microsoft/TypeScript/issues/15525
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 4, 2017 https://github.com/microsoft/TypeScript/pull/15586#pullrequestreview-36367041
View reviewed changes https://github.com/microsoft/TypeScript/pull/15586/files/3e85ac062716c06cccd2e9f70a8c8d0e66d1f020
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/15586/files/3e85ac062716c06cccd2e9f70a8c8d0e66d1f020#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 4, 2017https://github.com/microsoft/TypeScript/pull/15586#discussion_r114869404
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15586
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 4, 2017https://github.com/microsoft/TypeScript/pull/15586#discussion_r114871653
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15586
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 4, 2017 https://github.com/microsoft/TypeScript/pull/15586#pullrequestreview-36367049
View reviewed changes https://github.com/microsoft/TypeScript/pull/15586/files/3e85ac062716c06cccd2e9f70a8c8d0e66d1f020
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 4, 2017https://github.com/microsoft/TypeScript/pull/15586#issuecomment-299287949
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15586
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 4, 2017https://github.com/microsoft/TypeScript/pull/15586#issuecomment-299290744
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15586
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
d2bdfbbhttps://github.com/microsoft/TypeScript/commit/d2bdfbbf0ab75415522acad4df2e443c8d7ff741
May 4, 2017https://github.com/microsoft/TypeScript/pull/15586#event-1069577814
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 4, 2017 19:55https://github.com/microsoft/TypeScript/pull/15586#event-1069577885
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 4, 2017https://github.com/microsoft/TypeScript/pull/15586#issuecomment-299295125
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15586
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 4, 2017 https://github.com/microsoft/TypeScript/pull/15586#ref-pullrequest-226434349
Get name of declaration uniformly, even for JS-style assignment declarations. #15594 https://github.com/microsoft/TypeScript/pull/15594
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 5, 2017 https://github.com/microsoft/TypeScript/pull/15586#ref-issue-226677600
Exception in getSpecialPropertyAssignmentKind when handling || in const value #15616 https://github.com/microsoft/TypeScript/issues/15616
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 8, 2017 https://github.com/microsoft/TypeScript/pull/15586#ref-pullrequest-227126080
Simplify js check in index constraint errors #15669 https://github.com/microsoft/TypeScript/pull/15669
https://github.com/TysonAndre
Tyson Andre (TysonAndre)https://github.com/TysonAndre
May 8, 2017 https://github.com/microsoft/TypeScript/pull/15586#pullrequestreview-36892023
View reviewed changes https://github.com/microsoft/TypeScript/pull/15586/files/3e85ac062716c06cccd2e9f70a8c8d0e66d1f020
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/15586/files/3e85ac062716c06cccd2e9f70a8c8d0e66d1f020#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Tyson Andre (TysonAndre)https://github.com/TysonAndre
May 8, 2017https://github.com/microsoft/TypeScript/pull/15586#discussion_r115359347
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#15681https://github.com/microsoft/TypeScript/issues/15681
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15586
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 8, 2017https://github.com/microsoft/TypeScript/pull/15586#discussion_r115359802
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#15594https://github.com/microsoft/TypeScript/pull/15594
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15586
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 14, 2018https://github.com/microsoft/TypeScript/pull/15586#event-1682156812
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F15586
https://github.com/TysonAndre
Tyson Andre (TysonAndre) https://github.com/TysonAndre
https://github.com/microsoft/TypeScript/pull/15586/files/3e85ac062716c06cccd2e9f70a8c8d0e66d1f020
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
https://github.com/microsoft/TypeScript/pull/15586/files/3e85ac062716c06cccd2e9f70a8c8d0e66d1f020
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15586
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15586
https://github.com/sandersn
https://github.com/mhegazy
https://github.com/TysonAndre
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.