René's URL Explorer Experiment


Title: Widen inference candidates for error reporting by sandersn · Pull Request #15221 · microsoft/TypeScript · GitHub

Open Graph Title: Widen inference candidates for error reporting by sandersn · Pull Request #15221 · microsoft/TypeScript

X Title: Widen inference candidates for error reporting by sandersn · Pull Request #15221 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Widen inference candidates for error reporting by sandersn · Pull Request #15221 · microsoft/TypeScript

Open Graph Description: Both type inference and type inference error reporting widen candidates the same way now. Previously error reporting hit an assert when checking for best common supertype: it hit a condition that i...

X Description: Both type inference and type inference error reporting widen candidates the same way now. Previously error reporting hit an assert when checking for best common supertype: it hit a condition that i...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/15221

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:978c59d0-33ba-68a3-73f0-b146990f24d2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A48:1CEA6F:E12C86:12AAF5F:6B00FD68
html-safe-nonce84dd8fcef56b7a59be8936ebfb0a712f4ed059f06850fac1a799fce9cae8bc09
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTQ4OjFDRUE2RjpFMTJDODY6MTJBQUY1Rjo2QjAwRkQ2OCIsInZpc2l0b3JfaWQiOiI4MTcxMzQyNzQ3NTA1MDY1MzIwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac38bd375593311595421943431436102759902b10fc7ed97310157d3159889c56
hovercard-subject-tagpull_request:116152303
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/15221/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ce351427ab4fffda70fbb2ed71b0f4c77dc1a214eb9b311b019043a809ae10f0/microsoft/TypeScript/pull/15221
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ce351427ab4fffda70fbb2ed71b0f4c77dc1a214eb9b311b019043a809ae10f0/microsoft/TypeScript/pull/15221
og:image:altBoth type inference and type inference error reporting widen candidates the same way now. Previously error reporting hit an assert when checking for best common supertype: it hit a condition that i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/15221#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F15221
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F15221
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/15221
Reloadhttps://github.com/microsoft/TypeScript/pull/15221
Reloadhttps://github.com/microsoft/TypeScript/pull/15221
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
widen-inference-candidates-for-error-reportinghttps://github.com/microsoft/TypeScript/tree/widen-inference-candidates-for-error-reporting
Conversationhttps://github.com/microsoft/TypeScript/pull/15221
Commits12 (12)https://github.com/microsoft/TypeScript/pull/15221/commits
Checkshttps://github.com/microsoft/TypeScript/pull/15221/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/15221/files
Widen inference candidates for error reportinghttps://github.com/microsoft/TypeScript/pull/15221#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
widen-inference-candidates-for-error-reportinghttps://github.com/microsoft/TypeScript/tree/widen-inference-candidates-for-error-reporting
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Apr 17, 2017https://github.com/microsoft/TypeScript/pull/15221#issue-222158846
#15116https://github.com/microsoft/TypeScript/issues/15116
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15221
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
April 14, 2017 16:29https://github.com/microsoft/TypeScript/pull/15221#commits-pushed-7bc10c7
https://github.com/sandersn
Widen inference candidates for error reportinghttps://github.com/microsoft/TypeScript/pull/15221/commits/7bc10c7549c8656171de0e2d86c18226b9e368d1
7bc10c7https://github.com/microsoft/TypeScript/pull/15221/commits/7bc10c7549c8656171de0e2d86c18226b9e368d1
https://github.com/sandersn
Test widening inference candidates for err reportshttps://github.com/microsoft/TypeScript/pull/15221/commits/862fa455bfeee02cf280d5fa424ef2f9eaa79b97
862fa45https://github.com/microsoft/TypeScript/pull/15221/commits/862fa455bfeee02cf280d5fa424ef2f9eaa79b97
https://github.com/sandersn
Policheck made-up Romance words and improve typeshttps://github.com/microsoft/TypeScript/pull/15221/commits/8486b612cab212bed3bedcb21fc45396ee5be067
8486b61https://github.com/microsoft/TypeScript/pull/15221/commits/8486b612cab212bed3bedcb21fc45396ee5be067
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Apr 17, 2017https://github.com/microsoft/TypeScript/pull/15221#event-1045131774
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
April 17, 2017 15:45https://github.com/microsoft/TypeScript/pull/15221#event-1045132007
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
April 17, 2017 13:39https://github.com/microsoft/TypeScript/pull/15221#commits-pushed-3541c38
https://github.com/sandersn
getCommonSupertype correctly widens unionshttps://github.com/microsoft/TypeScript/pull/15221/commits/3541c38a750977d22361aa0bb96a797b85f339d2
3541c38https://github.com/microsoft/TypeScript/pull/15221/commits/3541c38a750977d22361aa0bb96a797b85f339d2
https://github.com/sandersn
Update test commentshttps://github.com/microsoft/TypeScript/pull/15221/commits/806739524e351aa68f1946237502df78e41a6eb3
8067395https://github.com/microsoft/TypeScript/pull/15221/commits/806739524e351aa68f1946237502df78e41a6eb3
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Apr 17, 2017https://github.com/microsoft/TypeScript/pull/15221#issuecomment-294588293
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15221
https://github.com/sandersn
Update test too.https://github.com/microsoft/TypeScript/pull/15221/commits/502803ae748ce30c90d38f6ef1e4283c5da52fb3
502803ahttps://github.com/microsoft/TypeScript/pull/15221/commits/502803ae748ce30c90d38f6ef1e4283c5da52fb3
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Apr 19, 2017 https://github.com/microsoft/TypeScript/pull/15221#pullrequestreview-33541882
View reviewed changes https://github.com/microsoft/TypeScript/pull/15221/files/502803ae748ce30c90d38f6ef1e4283c5da52fb3
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/15221/files/502803ae748ce30c90d38f6ef1e4283c5da52fb3#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Apr 19, 2017https://github.com/microsoft/TypeScript/pull/15221#discussion_r112242597
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15221
https://github.com/sandersn
Improve new assert in reportNoCommonSupertypeErrorhttps://github.com/microsoft/TypeScript/pull/15221/commits/f56fe9ebe7ac6f67d29512afe3b96b48f228cac7
f56fe9ehttps://github.com/microsoft/TypeScript/pull/15221/commits/f56fe9ebe7ac6f67d29512afe3b96b48f228cac7
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Jun 8, 2017https://github.com/microsoft/TypeScript/pull/15221#issuecomment-307165624
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15221
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15221
https://github.com/sandersn
Merge branch 'master' into widen-inference-candidates-for-error-repor…https://github.com/microsoft/TypeScript/pull/15221/commits/b0c38e823161d31c0e4ba49c0239f471db7a9b82
b0c38e8https://github.com/microsoft/TypeScript/pull/15221/commits/b0c38e823161d31c0e4ba49c0239f471db7a9b82
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 8, 2017https://github.com/microsoft/TypeScript/pull/15221#issuecomment-307173466
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15221
https://github.com/sandersn
getNullableType supports voidhttps://github.com/microsoft/TypeScript/pull/15221/commits/db3d88ea5f06dd59c1962976963ffdafd9fa2b0b
db3d88ehttps://github.com/microsoft/TypeScript/pull/15221/commits/db3d88ea5f06dd59c1962976963ffdafd9fa2b0b
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 8, 2017https://github.com/microsoft/TypeScript/pull/15221#issuecomment-307177688
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15221
https://github.com/sandersn
Fix semicolon linthttps://github.com/microsoft/TypeScript/pull/15221/commits/637581b46c3f1f585a54095f485af80e514fad14
637581bhttps://github.com/microsoft/TypeScript/pull/15221/commits/637581b46c3f1f585a54095f485af80e514fad14
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 9, 2017 https://github.com/microsoft/TypeScript/pull/15221#pullrequestreview-43269545
View reviewed changes https://github.com/microsoft/TypeScript/pull/15221/files/637581b46c3f1f585a54095f485af80e514fad14
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/15221/files/637581b46c3f1f585a54095f485af80e514fad14#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 9, 2017https://github.com/microsoft/TypeScript/pull/15221#discussion_r121229725
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15221
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
June 9, 2017 15:09https://github.com/microsoft/TypeScript/pull/15221#commits-pushed-ec9e280
https://github.com/sandersn
Restore getNullableType and getCommonSupertypehttps://github.com/microsoft/TypeScript/pull/15221/commits/ec9e2808dacbb2f0aecb1504ec1dfd00e1053b43
ec9e280https://github.com/microsoft/TypeScript/pull/15221/commits/ec9e2808dacbb2f0aecb1504ec1dfd00e1053b43
https://github.com/sandersn
Fix indentationhttps://github.com/microsoft/TypeScript/pull/15221/commits/bf4961ba7a9e0faf4e1f8d9a55ffc6ed97eea09f
bf4961bhttps://github.com/microsoft/TypeScript/pull/15221/commits/bf4961ba7a9e0faf4e1f8d9a55ffc6ed97eea09f
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 12, 2017 https://github.com/microsoft/TypeScript/pull/15221#ref-pullrequest-235031459
Simplify generic function call error reporting #16439 https://github.com/microsoft/TypeScript/pull/16439
https://github.com/jcalz
Joe Calzaretta (jcalz)https://github.com/jcalz
Sep 4, 2017 https://github.com/microsoft/TypeScript/pull/15221#ref-issue-254909830
Stack overflow with circular type parameter default #18234 https://github.com/microsoft/TypeScript/issues/18234
https://github.com/msftgits
Microsoft GitHub User (msftgits)https://github.com/msftgits
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Sep 26, 2017https://github.com/microsoft/TypeScript/pull/15221#event-1265655638
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 13, 2018https://github.com/microsoft/TypeScript/pull/15221#issuecomment-397015022
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15221
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 13, 2018https://github.com/microsoft/TypeScript/pull/15221#event-1679273428
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
June 16, 2022 21:42https://github.com/microsoft/TypeScript/pull/15221#event-6824230710
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/15221#event-20415421958
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F15221
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15221
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/15221
https://github.com/sandersn
https://github.com/ahejlsberg
https://github.com/typescript-bot
https://github.com/msftclas
https://github.com/msftgits
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.