René's URL Explorer Experiment


Title: [Master] Fix resolve entity name to not dive inside property access expression when the expression is not entity name by yuit · Pull Request #14692 · microsoft/TypeScript · GitHub

Open Graph Title: [Master] Fix resolve entity name to not dive inside property access expression when the expression is not entity name by yuit · Pull Request #14692 · microsoft/TypeScript

X Title: [Master] Fix resolve entity name to not dive inside property access expression when the expression is not entity name by yuit · Pull Request #14692 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - [Master] Fix resolve entity name to not dive inside property access expression when the expression is not entity name by yuit · Pull Request #14692 · microsoft/TypeScript

Open Graph Description: While writing tests for dynamic import, I ran into Debug.fail("Unknown entity name kind."); inside resolveEntityName function, turned out that it not only causes failure when writing out ...

X Description: While writing tests for dynamic import, I ran into Debug.fail("Unknown entity name kind."); inside resolveEntityName function, turned out that it not only causes failure when writ...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/14692

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:33bdfb31-452d-61c0-cab6-9cb0ba009421
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id89E4:10531B:189FBE:1F8924:6B00FB94
html-safe-noncef39f72d6b7f96e0a92548f8399c64e155618239df79ec9125e0853444253e84b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUU0OjEwNTMxQjoxODlGQkU6MUY4OTI0OjZCMDBGQjk0IiwidmlzaXRvcl9pZCI6IjE4NzU0ODg0NDMyOTU5MjMwOTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfd1f2c52eaec01b3d7f1e3cc16a61990b889ce1733852627214fb866b72612e5
hovercard-subject-tagpull_request:111160697
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/14692/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1706ceca9797afb4fd07289dc6a5fbc6bac8fb426ee66547e5f5450307713380/microsoft/TypeScript/pull/14692
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1706ceca9797afb4fd07289dc6a5fbc6bac8fb426ee66547e5f5450307713380/microsoft/TypeScript/pull/14692
og:image:altWhile writing tests for dynamic import, I ran into Debug.fail("Unknown entity name kind."); inside resolveEntityName function, turned out that it not only causes failure when writing out ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameyuit
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/14692#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F14692
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F14692
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/14692
Reloadhttps://github.com/microsoft/TypeScript/pull/14692
Reloadhttps://github.com/microsoft/TypeScript/pull/14692
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Yui (yuit)https://github.com/yuit
masterhttps://github.com/microsoft/TypeScript/tree/master
master-fixResolveEntityNamehttps://github.com/microsoft/TypeScript/tree/master-fixResolveEntityName
Conversationhttps://github.com/microsoft/TypeScript/pull/14692
Commits3 (3)https://github.com/microsoft/TypeScript/pull/14692/commits
Checkshttps://github.com/microsoft/TypeScript/pull/14692/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/14692/files
[Master] Fix resolve entity name to not dive inside property access expression when the expression is not entity namehttps://github.com/microsoft/TypeScript/pull/14692#top
Yui (yuit)https://github.com/yuit
masterhttps://github.com/microsoft/TypeScript/tree/master
master-fixResolveEntityNamehttps://github.com/microsoft/TypeScript/tree/master-fixResolveEntityName
https://github.com/yuit
Yui (yuit)https://github.com/yuit
Mar 16, 2017https://github.com/microsoft/TypeScript/pull/14692#issue-214831875
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14692
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14692
March 15, 2017 19:16https://github.com/microsoft/TypeScript/pull/14692#commits-pushed-1c90ef5
wip-fix resolveEntityName with parenthesizedExpressionhttps://github.com/microsoft/TypeScript/pull/14692/commits/1c90ef5aad15e9b09a3d8be0d87868347566dc37
1c90ef5https://github.com/microsoft/TypeScript/pull/14692/commits/1c90ef5aad15e9b09a3d8be0d87868347566dc37
Update resolveEntityName to check for non entity name in property acc…https://github.com/microsoft/TypeScript/pull/14692/commits/4980fa4d5d7145499f3ebe95b3c06cfe61f451cc
4980fa4https://github.com/microsoft/TypeScript/pull/14692/commits/4980fa4d5d7145499f3ebe95b3c06cfe61f451cc
Update baselines and add fourslashhttps://github.com/microsoft/TypeScript/pull/14692/commits/aace2c358fc3aac041f19aaac9e9e26a666d68ee
aace2c3https://github.com/microsoft/TypeScript/pull/14692/commits/aace2c358fc3aac041f19aaac9e9e26a666d68ee
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Mar 16, 2017https://github.com/microsoft/TypeScript/pull/14692#event-1003471707
https://github.com/yuit
Yui (yuit)https://github.com/yuit
Mar 21, 2017 https://github.com/microsoft/TypeScript/pull/14692#ref-pullrequest-215895296
[Master] wip-dynamic import #14774 https://github.com/microsoft/TypeScript/pull/14774
https://github.com/yuit
Yui (yuit)https://github.com/yuit
0cb490ehttps://github.com/microsoft/TypeScript/commit/0cb490e2c28ee73ce103c71c26b35cc34a99b826
Mar 29, 2017https://github.com/microsoft/TypeScript/pull/14692#event-1020812790
https://github.com/yuit
Yui (yuit)https://github.com/yuit
March 29, 2017 16:55https://github.com/microsoft/TypeScript/pull/14692#event-1020812865
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 29, 2017 https://github.com/microsoft/TypeScript/pull/14692#pullrequestreview-29796585
View reviewed changes https://github.com/microsoft/TypeScript/pull/14692/files/aace2c358fc3aac041f19aaac9e9e26a666d68ee
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/14692#pullrequestreview-29796585
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14692
tests/cases/fourslash/renamePropertyAccessExpressionHeritageClause.tshttps://github.com/microsoft/TypeScript/pull/14692/files/aace2c358fc3aac041f19aaac9e9e26a666d68ee#diff-081dfd81131dd0d946822f6583724db28854ee7aeb2630c3cda9796f213381eb
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 29, 2017https://github.com/microsoft/TypeScript/pull/14692#discussion_r108744612
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14692
tests/cases/fourslash/gotoDefinitionPropertyAccessExpressionHeritageClause.tshttps://github.com/microsoft/TypeScript/pull/14692/files/aace2c358fc3aac041f19aaac9e9e26a666d68ee#diff-e76f2a3b600eaf81b3e89c84ef7baa62d8e838450183d383108b6b5f9ad73a8e
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 29, 2017https://github.com/microsoft/TypeScript/pull/14692#discussion_r108744782
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14692
tests/cases/fourslash/findAllReferPropertyAccessExpressionHeritageClause.tshttps://github.com/microsoft/TypeScript/pull/14692/files/aace2c358fc3aac041f19aaac9e9e26a666d68ee#diff-c229a57629036cae0f686cccef94f7cb68e1f9da30ca41a2252cd5fe817648ca
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 29, 2017https://github.com/microsoft/TypeScript/pull/14692#discussion_r108745090
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14692
tests/cases/fourslash/findAllReferPropertyAccessExpressionHeritageClause.tshttps://github.com/microsoft/TypeScript/pull/14692/files/aace2c358fc3aac041f19aaac9e9e26a666d68ee#diff-c229a57629036cae0f686cccef94f7cb68e1f9da30ca41a2252cd5fe817648ca
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 29, 2017https://github.com/microsoft/TypeScript/pull/14692#discussion_r108745526
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14692
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/14692/files/aace2c358fc3aac041f19aaac9e9e26a666d68ee#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 29, 2017https://github.com/microsoft/TypeScript/pull/14692#discussion_r108747467
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14692
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/14692/files/aace2c358fc3aac041f19aaac9e9e26a666d68ee#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 29, 2017https://github.com/microsoft/TypeScript/pull/14692#discussion_r108747720
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14692
Yui (yuit)https://github.com/yuit
Mar 29, 2017https://github.com/microsoft/TypeScript/pull/14692#discussion_r108785754
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14692
.../conformance/es6/classDeclaration/emitClassDeclarationWithPropertyAccessInHeritageClause1.tshttps://github.com/microsoft/TypeScript/pull/14692/files/aace2c358fc3aac041f19aaac9e9e26a666d68ee#diff-85845f23c8bc0c17926b57d488acdc92d95bb7692dbdea7282e56b65e445a98e
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mar 29, 2017https://github.com/microsoft/TypeScript/pull/14692#discussion_r108750895
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14692
https://github.com/yuit
Yui (yuit)https://github.com/yuit
Mar 29, 2017 https://github.com/microsoft/TypeScript/pull/14692#ref-pullrequest-218008231
[Master] Address code review of PR 14692 #14916 https://github.com/microsoft/TypeScript/pull/14916
Feb 2, 2018 https://github.com/microsoft/TypeScript/pull/14692#ref-pullrequest-294034029
EntityNameExpression doesn't need to include ParenthesizedExpression #21588 https://github.com/microsoft/TypeScript/pull/21588
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 21, 2018https://github.com/microsoft/TypeScript/pull/14692#event-1694509989
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F14692
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/14692/files/aace2c358fc3aac041f19aaac9e9e26a666d68ee
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14692
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14692
https://github.com/yuit
https://github.com/sandersn
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.