René's URL Explorer Experiment


Title: Improve discriminated union error messages by sandersn · Pull Request #14006 · microsoft/TypeScript · GitHub

Open Graph Title: Improve discriminated union error messages by sandersn · Pull Request #14006 · microsoft/TypeScript

X Title: Improve discriminated union error messages by sandersn · Pull Request #14006 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Improve discriminated union error messages by sandersn · Pull Request #14006 · microsoft/TypeScript

Open Graph Description: Assignability errors for discriminated unions now check the value of the discriminant to decide which member of the union to check for assignability. Previously, assignability didn't know about...

X Description: Assignability errors for discriminated unions now check the value of the discriminant to decide which member of the union to check for assignability. Previously, assignability didn't know a...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/14006

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f97f0d78-8d1b-bc4b-16b4-d2b8d056a28a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC9DA:2978F1:82D3DB:AA9C87:6B00DAEC
html-safe-nonce34a0fbbade7ee1a322c8f25ae31317556da0cbc900d61a65e262de8d3fedc098
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOURBOjI5NzhGMTo4MkQzREI6QUE5Qzg3OjZCMDBEQUVDIiwidmlzaXRvcl9pZCI6Ijc0NzUxNzE4MzM1MDM4NjU1ODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac191eb6dbaa8a35a1d91797fadc01835fa0fd06a8ec2867dc19667285a77d5883
hovercard-subject-tagpull_request:105717294
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/14006/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fb3ca5bf582177d1170ddcfea138d1eb51f452c53992ebd5a8100be99673b9a1/microsoft/TypeScript/pull/14006
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fb3ca5bf582177d1170ddcfea138d1eb51f452c53992ebd5a8100be99673b9a1/microsoft/TypeScript/pull/14006
og:image:altAssignability errors for discriminated unions now check the value of the discriminant to decide which member of the union to check for assignability. Previously, assignability didn't know about...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonea481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84c8c5cc25e2fb7f2308428458538436baecc6d2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/14006#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F14006
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F14006
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/14006
Reloadhttps://github.com/microsoft/TypeScript/pull/14006
Reloadhttps://github.com/microsoft/TypeScript/pull/14006
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
better-discriminated-union-errorshttps://github.com/microsoft/TypeScript/tree/better-discriminated-union-errors
Conversationhttps://github.com/microsoft/TypeScript/pull/14006
Commits3 (3)https://github.com/microsoft/TypeScript/pull/14006/commits
Checkshttps://github.com/microsoft/TypeScript/pull/14006/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/14006/files
Improve discriminated union error messageshttps://github.com/microsoft/TypeScript/pull/14006#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
better-discriminated-union-errorshttps://github.com/microsoft/TypeScript/tree/better-discriminated-union-errors
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Feb 10, 2017https://github.com/microsoft/TypeScript/pull/14006#issue-206922258
#10867https://github.com/microsoft/TypeScript/issues/10867
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14006
https://github.com/sandersn
Improve discriminated union error messageshttps://github.com/microsoft/TypeScript/pull/14006/commits/1c7628e6534cda58de2f29eaf5a51ef9aac33ce2
1c7628ehttps://github.com/microsoft/TypeScript/pull/14006/commits/1c7628e6534cda58de2f29eaf5a51ef9aac33ce2
#10867https://github.com/microsoft/TypeScript/issues/10867
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Feb 10, 2017https://github.com/microsoft/TypeScript/pull/14006#event-958036692
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Feb 10, 2017 https://github.com/microsoft/TypeScript/pull/14006#ref-issue-176428780
Discriminated union types better error reporting #10867 https://github.com/microsoft/TypeScript/issues/10867
https://github.com/yuit
Yui (yuit)https://github.com/yuit
Feb 10, 2017 https://github.com/microsoft/TypeScript/pull/14006#pullrequestreview-21365089
View reviewed changes https://github.com/microsoft/TypeScript/pull/14006/files/1c7628e6534cda58de2f29eaf5a51ef9aac33ce2
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Feb 10, 2017https://github.com/microsoft/TypeScript/pull/14006#issuecomment-279096746
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14006
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Feb 13, 2017 https://github.com/microsoft/TypeScript/pull/14006#pullrequestreview-21527357
View reviewed changes https://github.com/microsoft/TypeScript/pull/14006/files/1c7628e6534cda58de2f29eaf5a51ef9aac33ce2
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/14006/files/1c7628e6534cda58de2f29eaf5a51ef9aac33ce2#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Feb 13, 2017https://github.com/microsoft/TypeScript/pull/14006#discussion_r100812227
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14006
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Feb 13, 2017https://github.com/microsoft/TypeScript/pull/14006#discussion_r100840072
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14006
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Feb 13, 2017https://github.com/microsoft/TypeScript/pull/14006#discussion_r100850282
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14006
https://github.com/sandersn
Address PR commentshttps://github.com/microsoft/TypeScript/pull/14006/commits/11929e33ed3514e2dc09a29ff065e4525d331587
11929e3https://github.com/microsoft/TypeScript/pull/14006/commits/11929e33ed3514e2dc09a29ff065e4525d331587
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Feb 13, 2017 https://github.com/microsoft/TypeScript/pull/14006#pullrequestreview-21619459
View reviewed changes https://github.com/microsoft/TypeScript/pull/14006/files/11929e33ed3514e2dc09a29ff065e4525d331587
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
https://github.com/microsoft/TypeScript/pull/14006#pullrequestreview-21619459
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14006
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/14006/files/11929e33ed3514e2dc09a29ff065e4525d331587#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Feb 13, 2017https://github.com/microsoft/TypeScript/pull/14006#discussion_r100902745
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14006
https://github.com/sandersn
Address PR commentshttps://github.com/microsoft/TypeScript/pull/14006/commits/271ca80c75e30132cc2549a79f562a2abbb432a3
271ca80https://github.com/microsoft/TypeScript/pull/14006/commits/271ca80c75e30132cc2549a79f562a2abbb432a3
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
ba8330chttps://github.com/microsoft/TypeScript/commit/ba8330cba6e64bdee8962a0ab6dd34469ce0cc69
Feb 13, 2017https://github.com/microsoft/TypeScript/pull/14006#event-960431962
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
February 13, 2017 22:14https://github.com/microsoft/TypeScript/pull/14006#event-960432019
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 8, 2017 https://github.com/microsoft/TypeScript/pull/14006#ref-commit-595cb11
https://github.com/sandersn
Excess property checks for discriminated unionshttps://github.com/microsoft/TypeScript/commit/595cb11f22d4bb3fe4bbf3e4d0366c6b5903c57a
595cb11https://github.com/microsoft/TypeScript/commit/595cb11f22d4bb3fe4bbf3e4d0366c6b5903c57a
#14006https://github.com/microsoft/TypeScript/pull/14006
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 8, 2017 https://github.com/microsoft/TypeScript/pull/14006#ref-pullrequest-234612435
Excess property checks for discriminated unions #16363 https://github.com/microsoft/TypeScript/pull/16363
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 19, 2018https://github.com/microsoft/TypeScript/pull/14006#event-1689929539
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F14006
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
https://github.com/microsoft/TypeScript/pull/14006/files/11929e33ed3514e2dc09a29ff065e4525d331587
https://github.com/yuit
Yui (yuit) https://github.com/yuit
https://github.com/microsoft/TypeScript/pull/14006/files/1c7628e6534cda58de2f29eaf5a51ef9aac33ce2
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14006
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/14006
https://github.com/sandersn
https://github.com/yuit
https://github.com/ahejlsberg
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.