| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:55392a0b-d4c1-0b46-ae65-bea06b69a1c5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BC00:1D86C4:293DA4E:3463584:6B01A28E |
| html-safe-nonce | 8047e8b935c4588c7f6af96b3b0330635d79c29fb67bff8632e7f2d9e2ef6a31 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzAwOjFEODZDNDoyOTNEQTRFOjM0NjM1ODQ6NkIwMUEyOEUiLCJ2aXNpdG9yX2lkIjoiNzIyNjA2ODUxNDkyOTQ4NDQzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 41a63e81bbc4b2afd0fe0acf85955cca6b3a607cde4c45394df68ea432218d4b |
| hovercard-subject-tag | pull_request:103025536 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/13665/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/91ec303967305743871b1a94dccd0fae2502bd9d10d4abe6c58decc6230b97d3/microsoft/TypeScript/pull/13665 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/91ec303967305743871b1a94dccd0fae2502bd9d10d4abe6c58decc6230b97d3/microsoft/TypeScript/pull/13665 |
| og:image:alt | This PR is on top of #12336 to add support for json files lookup and use as a module.
Fixes #7071
This supports resolving module with json file extension when using node resolution
Open things:
[... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sheetalkamat |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/13665#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F13665 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F13665 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/13665 |
| Reload | https://github.com/microsoft/TypeScript/pull/13665 |
| Reload | https://github.com/microsoft/TypeScript/pull/13665 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests312 (312) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| master | https://github.com/microsoft/TypeScript/tree/master |
| supportJsonFileModule | https://github.com/microsoft/TypeScript/tree/supportJsonFileModule |
| Conversation | https://github.com/microsoft/TypeScript/pull/13665 |
| Commits11 (11) | https://github.com/microsoft/TypeScript/pull/13665/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/13665/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/13665/files |
| Support importing json files as modules with commonjs or node module resolution | https://github.com/microsoft/TypeScript/pull/13665#top |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| master | https://github.com/microsoft/TypeScript/tree/master |
| supportJsonFileModule | https://github.com/microsoft/TypeScript/tree/supportJsonFileModule |
|
| https://github.com/sheetalkamat |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| Jan 24, 2017 | https://github.com/microsoft/TypeScript/pull/13665#issue-202970057 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/13665 |
| #12336 | https://github.com/microsoft/TypeScript/pull/12336 |
| #7071 | https://github.com/microsoft/TypeScript/issues/7071 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/13665 |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| January 24, 2017 15:11 | https://github.com/microsoft/TypeScript/pull/13665#commits-pushed-8f8ed2c |
|
| https://github.com/sheetalkamat |
| Resolve Json file when module resolution strategy is node | https://github.com/microsoft/TypeScript/pull/13665/commits/8f8ed2c2e111cd16212c4f5785293ed933ac1741 |
| 8f8ed2c | https://github.com/microsoft/TypeScript/pull/13665/commits/8f8ed2c2e111cd16212c4f5785293ed933ac1741 |
|
| https://github.com/sheetalkamat |
| Bind and resolve the module for json file | https://github.com/microsoft/TypeScript/pull/13665/commits/10560af6f5d36d214d4b30bdcb4e5322f11ffb53 |
| 10560af | https://github.com/microsoft/TypeScript/pull/13665/commits/10560af6f5d36d214d4b30bdcb4e5322f11ffb53 |
|
| https://github.com/sheetalkamat |
| Emit the symbol information for declaration names (could be string li… | https://github.com/microsoft/TypeScript/pull/13665/commits/1f349221fb291baf2c60ad5a43e25befaab1fecd |
| 1f34922 | https://github.com/microsoft/TypeScript/pull/13665/commits/1f349221fb291baf2c60ad5a43e25befaab1fecd |
|
| https://github.com/sheetalkamat |
| Fix emit for json file | https://github.com/microsoft/TypeScript/pull/13665/commits/f1fae6a9422c6f07507a495b34c000a06dd2887c |
| f1fae6a | https://github.com/microsoft/TypeScript/pull/13665/commits/f1fae6a9422c6f07507a495b34c000a06dd2887c |
|
| https://github.com/sheetalkamat |
| More tests | https://github.com/microsoft/TypeScript/pull/13665/commits/4ebf2d96744654a6dcff98db39442e7b268dad50 |
| 4ebf2d9 | https://github.com/microsoft/TypeScript/pull/13665/commits/4ebf2d96744654a6dcff98db39442e7b268dad50 |
| https://github.com/msftclas |
| Microsoft Contribution License Agreements (msftclas) | https://github.com/msftclas |
|
cla-not-required
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required |
| Jan 24, 2017 | https://github.com/microsoft/TypeScript/pull/13665#event-935373496 |
| https://github.com/sheetalkamat |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
| Vladimir Matveev (vladima) | https://github.com/vladima |
| January 24, 2017 23:29 | https://github.com/microsoft/TypeScript/pull/13665#event-935380650 |
| https://github.com/mightyiam |
| Shahar "Dawn" Or (mightyiam) | https://github.com/mightyiam |
| Mar 3, 2017 | https://github.com/microsoft/TypeScript/pull/13665#issuecomment-284027668 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/13665 |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| April 18, 2017 09:46 | https://github.com/microsoft/TypeScript/pull/13665#commits-pushed-b52e45d |
|
| https://github.com/sheetalkamat |
| Merge branch 'ownJsonParsing' into supportJsonFileModule | https://github.com/microsoft/TypeScript/pull/13665/commits/b52e45d6bcf9785125915e529272c17bd094dc1f |
| b52e45d | https://github.com/microsoft/TypeScript/pull/13665/commits/b52e45d6bcf9785125915e529272c17bd094dc1f |
|
| https://github.com/sheetalkamat |
| Merge branch 'ownJsonParsing' into supportJsonFileModule | https://github.com/microsoft/TypeScript/pull/13665/commits/c8e31e440ab196c6457a3824cb0d7cb03e3490da |
| c8e31e4 | https://github.com/microsoft/TypeScript/pull/13665/commits/c8e31e440ab196c6457a3824cb0d7cb03e3490da |
|
| https://github.com/sheetalkamat |
| Merge branch 'ownJsonParsing' into supportJsonFileModule | https://github.com/microsoft/TypeScript/pull/13665/commits/20d79f3bc6621c5bf7e36f215875eb3193b3b689 |
| 20d79f3 | https://github.com/microsoft/TypeScript/pull/13665/commits/20d79f3bc6621c5bf7e36f215875eb3193b3b689 |
|
require('file.json') in JS causes error TS2307.
#15987
| https://github.com/microsoft/TypeScript/issues/15987 |
|
Completion list for JSON files imported using CommonJS require
#9221
| https://github.com/microsoft/TypeScript/pull/9221 |
|
| https://github.com/sheetalkamat |
| Merge branch 'master' into supportJsonFileModule | https://github.com/microsoft/TypeScript/pull/13665/commits/50bc3dd07b225de047b83ed08ae2579c1812a345 |
| 50bc3dd | https://github.com/microsoft/TypeScript/pull/13665/commits/50bc3dd07b225de047b83ed08ae2579c1812a345 |
| https://github.com/sheetalkamat |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| September 14, 2017 21:13 | https://github.com/microsoft/TypeScript/pull/13665#event-1250037135 |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| September 14, 2017 14:25 | https://github.com/microsoft/TypeScript/pull/13665#commits-pushed-2b06729 |
|
| https://github.com/sheetalkamat |
| Merge branch 'master' into supportJsonFileModule | https://github.com/microsoft/TypeScript/pull/13665/commits/2b0672939719451603b98624f2885083b61e1014 |
| 2b06729 | https://github.com/microsoft/TypeScript/pull/13665/commits/2b0672939719451603b98624f2885083b61e1014 |
|
| https://github.com/sheetalkamat |
| Remove unnecessary function | https://github.com/microsoft/TypeScript/pull/13665/commits/d243eb0107110d4fa172504978031063b99f85de |
| d243eb0 | https://github.com/microsoft/TypeScript/pull/13665/commits/d243eb0107110d4fa172504978031063b99f85de |
| https://github.com/msftgits |
| Microsoft GitHub User (msftgits) | https://github.com/msftgits |
|
cla-not-required
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required |
| Sep 26, 2017 | https://github.com/microsoft/TypeScript/pull/13665#event-1265655630 |
| https://github.com/mhegazy |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
|
Jan 18, 2018
| https://github.com/microsoft/TypeScript/pull/13665#ref-issue-289566290 |
|
@ts-check complains about a require of a JSON file.
#21262
| https://github.com/microsoft/TypeScript/issues/21262 |
| https://github.com/sheetalkamat |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| Feb 24, 2018 | https://github.com/microsoft/TypeScript/pull/13665#issuecomment-368248443 |
| #22167 | https://github.com/microsoft/TypeScript/pull/22167 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/13665 |
| https://github.com/sheetalkamat |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| Feb 24, 2018 | https://github.com/microsoft/TypeScript/pull/13665#event-1490526456 |
| https://github.com/sheetalkamat |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| February 24, 2018 18:22 | https://github.com/microsoft/TypeScript/pull/13665#event-1490526503 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Jul 3, 2018 | https://github.com/microsoft/TypeScript/pull/13665#event-1712799811 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F13665 |
|
| https://github.com/mhegazy |
|
Mohamed Hegazy (mhegazy)
| https://github.com/mhegazy |
|
| https://github.com/vladima |
|
Vladimir Matveev (vladima)
| https://github.com/vladima |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/13665 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/13665 |
|
| https://github.com/sheetalkamat |
|
| https://github.com/mightyiam |
|
| https://github.com/msftclas |
|
| https://github.com/msftgits |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |