René's URL Explorer Experiment


Title: Instanceof requires callable or constructable right-hand side by sandersn · Pull Request #12728 · microsoft/TypeScript · GitHub

Open Graph Title: Instanceof requires callable or constructable right-hand side by sandersn · Pull Request #12728 · microsoft/TypeScript

X Title: Instanceof requires callable or constructable right-hand side by sandersn · Pull Request #12728 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Instanceof requires callable or constructable right-hand side by sandersn · Pull Request #12728 · microsoft/TypeScript

Open Graph Description: Fixes #12709 The check for the right-hand side of instanceof previously required that the type be any or a subtype of Function. This is too strict, and breaks if a class has some otherwise-unrelate...

X Description: Fixes #12709 The check for the right-hand side of instanceof previously required that the type be any or a subtype of Function. This is too strict, and breaks if a class has some otherwise-unrelate...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/12728

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:544c5cc7-b38b-90f4-232e-139b74b19515
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD588:1F68:1A8934:2897CF:6B01AEDD
html-safe-nonce0fba0bec01a4676e3e9903b77559bdf25edcd4adb321ff37be525e0d90be6ad4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTg4OjFGNjg6MUE4OTM0OjI4OTdDRjo2QjAxQUVERCIsInZpc2l0b3JfaWQiOiIzMzgwNTY3Mjc0NDE4MTg3OTk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbb5323e5b7bcba6bf8e55f4ab806ded4cebafd503aad9d05155e513dd0521257
hovercard-subject-tagpull_request:97010056
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/12728/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/280d4d296bcbc6c3d2e2b72c3852ee97c5006b54a0bd2e32081122496a639afb/microsoft/TypeScript/pull/12728
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/280d4d296bcbc6c3d2e2b72c3852ee97c5006b54a0bd2e32081122496a639afb/microsoft/TypeScript/pull/12728
og:image:altFixes #12709 The check for the right-hand side of instanceof previously required that the type be any or a subtype of Function. This is too strict, and breaks if a class has some otherwise-unrelate...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/12728#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F12728
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F12728
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/12728
Reloadhttps://github.com/microsoft/TypeScript/pull/12728
Reloadhttps://github.com/microsoft/TypeScript/pull/12728
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
instanceof-requires-callable-rhshttps://github.com/microsoft/TypeScript/tree/instanceof-requires-callable-rhs
Conversationhttps://github.com/microsoft/TypeScript/pull/12728
Commits2 (2)https://github.com/microsoft/TypeScript/pull/12728/commits
Checkshttps://github.com/microsoft/TypeScript/pull/12728/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/12728/files
Instanceof requires callable or constructable right-hand sidehttps://github.com/microsoft/TypeScript/pull/12728#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
instanceof-requires-callable-rhshttps://github.com/microsoft/TypeScript/tree/instanceof-requires-callable-rhs
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Dec 7, 2016https://github.com/microsoft/TypeScript/pull/12728#issue-194174042
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12728
#12709https://github.com/microsoft/TypeScript/issues/12709
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12728
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
December 7, 2016 13:14https://github.com/microsoft/TypeScript/pull/12728#commits-pushed-06b3ea9
https://github.com/sandersn
instanceof RHS must be any, callable/constructable or Function subtypehttps://github.com/microsoft/TypeScript/pull/12728/commits/06b3ea98386a3650faf96f196c2081ae40e43bf7
06b3ea9https://github.com/microsoft/TypeScript/pull/12728/commits/06b3ea98386a3650faf96f196c2081ae40e43bf7
https://github.com/sandersn
Test:instanceof allows callable/constructable RHShttps://github.com/microsoft/TypeScript/pull/12728/commits/f15a7a3bacb765b100062fb9c261116ef12ed2af
f15a7a3https://github.com/microsoft/TypeScript/pull/12728/commits/f15a7a3bacb765b100062fb9c261116ef12ed2af
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Dec 7, 2016https://github.com/microsoft/TypeScript/pull/12728#event-885942139
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Dec 7, 2016https://github.com/microsoft/TypeScript/pull/12728#issuecomment-265577799
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12728
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Dec 7, 2016 https://github.com/microsoft/TypeScript/pull/12728#ref-issue-194107648
static toString with incorrect type breaks instanceof #12709 https://github.com/microsoft/TypeScript/issues/12709
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Dec 21, 2016https://github.com/microsoft/TypeScript/pull/12728#issuecomment-268672246
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12728
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Dec 30, 2016https://github.com/microsoft/TypeScript/pull/12728#issuecomment-269801217
the relevant section of the spec itselfhttps://tc39.github.io/ecma262/#sec-instanceofoperator
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12728
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Dec 30, 2016https://github.com/microsoft/TypeScript/pull/12728#issuecomment-269801430
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12728
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Dec 30, 2016https://github.com/microsoft/TypeScript/pull/12728#issuecomment-269833407
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12728
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Jan 6, 2017 https://github.com/microsoft/TypeScript/pull/12728#ref-issue-199296179
Design Meeting Notes, 1/6/2017 #13331 https://github.com/microsoft/TypeScript/issues/13331
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Jan 6, 2017https://github.com/microsoft/TypeScript/pull/12728#issuecomment-271015658
#13331https://github.com/microsoft/TypeScript/issues/13331
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12728
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
5b075ffhttps://github.com/microsoft/TypeScript/commit/5b075ff924083d3891e3d34bfe2b4a8b4949665c
Jan 6, 2017https://github.com/microsoft/TypeScript/pull/12728#event-914630465
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
January 6, 2017 21:49https://github.com/microsoft/TypeScript/pull/12728#event-914630575
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 19, 2018https://github.com/microsoft/TypeScript/pull/12728#event-1689923956
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F12728
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12728
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12728
https://github.com/sandersn
https://github.com/mhegazy
https://github.com/DanielRosenwasser
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.