| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9cc8cddc-73fa-9711-a43b-3bb7aaeee34b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EDDE:227D53:1D4F1:2AF5F:6AFC136F |
| html-safe-nonce | b7d1798f15adf3066ef0f6f84d0115c0fb48c7609c34dd43929eadd51f21e518 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRERFOjIyN0Q1MzoxRDRGMToyQUY1Rjo2QUZDMTM2RiIsInZpc2l0b3JfaWQiOiI2NTg0MDEzODYyNDQwMDE0NzAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a639e7187cbd8aec721e3dd61f453f5aacd810447da22ace7fcab0db0df4b3e1 |
| hovercard-subject-tag | pull_request:94699846 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/12425/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c2504646a98874d5e39abb9363c16ac2e5c4ffe80e5d659920c2878a6620216d/microsoft/TypeScript/pull/12425 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c2504646a98874d5e39abb9363c16ac2e5c4ffe80e5d659920c2878a6620216d/microsoft/TypeScript/pull/12425 |
| og:image:alt | This PR revises keyof T to always be a subtype of string vs. a subtype of string | number. This more accurately reflects how properties work in JavaScript and allows us to use keyof T as the inferr... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ahejlsberg |
| hostname | github.com |
| expected-hostname | github.com |
| None | c1baf9c4a94b084908b3fdb1f1bc7f5edf84e815f3a48805d893b9c4b193a6ea |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4793ba72a5c086087d41bf4ace563734448a7b73 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/12425#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F12425 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F12425 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/12425 |
| Reload | https://github.com/microsoft/TypeScript/pull/12425 |
| Reload | https://github.com/microsoft/TypeScript/pull/12425 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests337 (337) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/pulse |
| https://github.com/microsoft/TypeScript |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| master | https://github.com/microsoft/TypeScript/tree/master |
| keyofOnlyStrings | https://github.com/microsoft/TypeScript/tree/keyofOnlyStrings |
| Conversation | https://github.com/microsoft/TypeScript/pull/12425 |
| Commits7 (7) | https://github.com/microsoft/TypeScript/pull/12425/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/12425/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/12425/files |
| Change 'keyof T' to always be string-like | https://github.com/microsoft/TypeScript/pull/12425#top |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| master | https://github.com/microsoft/TypeScript/tree/master |
| keyofOnlyStrings | https://github.com/microsoft/TypeScript/tree/keyofOnlyStrings |
|
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Nov 21, 2016 | https://github.com/microsoft/TypeScript/pull/12425#issue-190840187 |
| #12314 | https://github.com/microsoft/TypeScript/issues/12314 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/12425 |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| November 21, 2016 11:41 | https://github.com/microsoft/TypeScript/pull/12425#commits-pushed-76ceab9 |
|
| https://github.com/ahejlsberg |
| Make keyof T a string-like type | https://github.com/microsoft/TypeScript/pull/12425/commits/76ceab97dd744de160f28e2ec7412a6de4ca73dd |
| 76ceab9 | https://github.com/microsoft/TypeScript/pull/12425/commits/76ceab97dd744de160f28e2ec7412a6de4ca73dd |
|
| https://github.com/ahejlsberg |
| Update Record type | https://github.com/microsoft/TypeScript/pull/12425/commits/854a20f1febb50bfa4d814572adc777e8609b226 |
| 854a20f | https://github.com/microsoft/TypeScript/pull/12425/commits/854a20f1febb50bfa4d814572adc777e8609b226 |
|
| https://github.com/ahejlsberg |
| Update tests | https://github.com/microsoft/TypeScript/pull/12425/commits/5498a95245183dab4e0d6be25de6912361101017 |
| 5498a95 | https://github.com/microsoft/TypeScript/pull/12425/commits/5498a95245183dab4e0d6be25de6912361101017 |
|
| https://github.com/ahejlsberg |
| Accept new baselines | https://github.com/microsoft/TypeScript/pull/12425/commits/c5558482b7f2e3a8bc7b99ae1540c089b3e4d142 |
| c555848 | https://github.com/microsoft/TypeScript/pull/12425/commits/c5558482b7f2e3a8bc7b99ae1540c089b3e4d142 |
|
| https://github.com/ahejlsberg |
| Type of for-in variable is keyof T when object type is a type parameter | https://github.com/microsoft/TypeScript/pull/12425/commits/1710df5f28fed8dfa7630978c873ed1bf6ee3983 |
| 1710df5 | https://github.com/microsoft/TypeScript/pull/12425/commits/1710df5f28fed8dfa7630978c873ed1bf6ee3983 |
|
| https://github.com/ahejlsberg |
| Accept new baselines | https://github.com/microsoft/TypeScript/pull/12425/commits/dbc661f88e62ce06c44a6b67b13da40dbf668d10 |
| dbc661f | https://github.com/microsoft/TypeScript/pull/12425/commits/dbc661f88e62ce06c44a6b67b13da40dbf668d10 |
|
| https://github.com/ahejlsberg |
| Add test case | https://github.com/microsoft/TypeScript/pull/12425/commits/b662a8b31906558ec1bd90d8668e78042d2e567c |
| b662a8b | https://github.com/microsoft/TypeScript/pull/12425/commits/b662a8b31906558ec1bd90d8668e78042d2e567c |
| https://github.com/msftclas |
| Microsoft Contribution License Agreements (msftclas) | https://github.com/msftclas |
|
cla-not-required
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required |
| Nov 21, 2016 | https://github.com/microsoft/TypeScript/pull/12425#event-867258731 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Nov 21, 2016 | https://github.com/microsoft/TypeScript/pull/12425#issuecomment-262075007 |
| Mohamed Hegazy (@mhegazy) | https://github.com/mhegazy |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/12425 |
| https://github.com/mhegazy |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
|
Nov 21, 2016
| https://github.com/microsoft/TypeScript/pull/12425#pullrequestreview-9568245 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/12425/files/b662a8b31906558ec1bd90d8668e78042d2e567c |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| 77c0540 | https://github.com/microsoft/TypeScript/commit/77c05404337068d702a0e368ecc2d43b2b5cc6a1 |
| Nov 21, 2016 | https://github.com/microsoft/TypeScript/pull/12425#event-867431945 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| November 21, 2016 23:51 | https://github.com/microsoft/TypeScript/pull/12425#event-867432122 |
| https://github.com/mhegazy |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
|
Nov 22, 2016
| https://github.com/microsoft/TypeScript/pull/12425#ref-pullrequest-191092171 |
|
Merge master into release-2.1
#12440
| https://github.com/microsoft/TypeScript/pull/12440 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
|
Nov 24, 2016
| https://github.com/microsoft/TypeScript/pull/12425#ref-pullrequest-186041340 |
|
Static types for dynamically named properties
#11929
| https://github.com/microsoft/TypeScript/pull/11929 |
| Ethan Resnick (ethanresnick) | https://github.com/ethanresnick |
|
Nov 27, 2016
| https://github.com/microsoft/TypeScript/pull/12425#ref-commit-29105a6 |
|
| https://github.com/ethanresnick |
| Object.keys/entries: remove keyof & string intersections | https://github.com/ethanresnick/TypeScript/commit/29105a68f5ab3a818e9ecd794b090a64524c121f |
| 29105a6 | https://github.com/ethanresnick/TypeScript/commit/29105a68f5ab3a818e9ecd794b090a64524c121f |
| microsoft#12425 | https://github.com/microsoft/TypeScript/pull/12425 |
| https://github.com/ethanresnick |
| Ethan Resnick (ethanresnick) | https://github.com/ethanresnick |
|
Nov 27, 2016
| https://github.com/microsoft/TypeScript/pull/12425#ref-pullrequest-189281733 |
|
Object.keys() types refinement, and Object.entries() types bugfix
#12253
| https://github.com/microsoft/TypeScript/pull/12253 |
| Ethan Resnick (ethanresnick) | https://github.com/ethanresnick |
|
Nov 28, 2016
| https://github.com/microsoft/TypeScript/pull/12425#ref-commit-8b7252c |
|
| https://github.com/ethanresnick |
| Update keyof tests to reflect | https://github.com/ethanresnick/TypeScript/commit/8b7252c4b0faad318a37dd609bfcf7db71154236 |
| microsoft#12425 | https://github.com/microsoft/TypeScript/pull/12425 |
| 8b7252c | https://github.com/ethanresnick/TypeScript/commit/8b7252c4b0faad318a37dd609bfcf7db71154236 |
| https://github.com/ethanresnick |
| Ethan Resnick (ethanresnick) | https://github.com/ethanresnick |
|
Nov 28, 2016
| https://github.com/microsoft/TypeScript/pull/12425#ref-pullrequest-191993697 |
|
Update keyof tests to reflect #12425
#12533
| https://github.com/microsoft/TypeScript/pull/12533 |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
|
Nov 28, 2016
| https://github.com/microsoft/TypeScript/pull/12425#ref-commit-9cac35b |
|
| https://github.com/mhegazy |
| Merge pull request | https://github.com/microsoft/TypeScript/commit/9cac35be25a022ba2775c50023fb3b7746266751 |
| #12533 | https://github.com/microsoft/TypeScript/pull/12533 |
| from ethanresnick/keyof-tests | https://github.com/microsoft/TypeScript/commit/9cac35be25a022ba2775c50023fb3b7746266751 |
| 9cac35b | https://github.com/microsoft/TypeScript/commit/9cac35be25a022ba2775c50023fb3b7746266751 |
| #12425 | https://github.com/microsoft/TypeScript/pull/12425 |
| https://github.com/mhegazy |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
|
Dec 19, 2016
| https://github.com/microsoft/TypeScript/pull/12425#ref-issue-64326798 |
|
Index signature parameter type should allow for enums
#2491
| https://github.com/microsoft/TypeScript/issues/2491 |
| https://github.com/ChiriVulpes |
| Chiri Vulpes (ChiriVulpes) | https://github.com/ChiriVulpes |
|
Dec 20, 2016
| https://github.com/microsoft/TypeScript/pull/12425#ref-issue-196567550 |
|
Enums can not be used for index signature types
#13042
| https://github.com/microsoft/TypeScript/issues/13042 |
| https://github.com/mhegazy |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
|
May 5, 2017
| https://github.com/microsoft/TypeScript/pull/12425#ref-issue-203578730 |
|
number should be subtype of keyof T[]
#13715
| https://github.com/microsoft/TypeScript/issues/13715 |
| https://github.com/nevir |
| Ian MacLeod (nevir) | https://github.com/nevir |
|
Jun 29, 2017
| https://github.com/microsoft/TypeScript/pull/12425#ref-issue-239636400 |
|
Unable to use numeric enums as keys of a map
#16842
| https://github.com/microsoft/TypeScript/issues/16842 |
| https://github.com/yortus |
| Troy Gerwien (yortus) | https://github.com/yortus |
|
Jan 15, 2018
| https://github.com/microsoft/TypeScript/pull/12425#ref-issue-288402281 |
|
Index which's key's type is number can accept string keys
#21179
| https://github.com/microsoft/TypeScript/issues/21179 |
| https://github.com/kpdonn |
| Kevin Donnelly (kpdonn) | https://github.com/kpdonn |
|
Mar 30, 2018
| https://github.com/microsoft/TypeScript/pull/12425#ref-issue-282420038 |
|
Consider adding symbolof type operator, like keyof but for unique symbol properties
#20721
| https://github.com/microsoft/TypeScript/issues/20721 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Jun 19, 2018 | https://github.com/microsoft/TypeScript/pull/12425#event-1689922262 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F12425 |
|
| https://github.com/mhegazy |
|
Mohamed Hegazy (mhegazy)
| https://github.com/mhegazy |
|
| https://github.com/microsoft/TypeScript/pull/12425/files/b662a8b31906558ec1bd90d8668e78042d2e567c |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/12425 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/12425 |
|
| https://github.com/ahejlsberg |
|
| https://github.com/mhegazy |
|
| https://github.com/msftclas |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |